Uh oh!
There was an error while loading. Please reload this page.
refactor: remove PM fallback from vp run, always delegate to vite-plus - #1179
Merged
Conversation
MemberAuthor
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 28, 2026
fengmk2force-pushed
the
vp-run-no-fallback
branch
2 times, most recently
from
March 28, 2026 08:40
f0fe3df to
3af4839Compare
This was referenced Mar 28, 2026
fengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 29, 2026 11:36
3af4839 to
3048c0dComparefengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 29, 2026 14:52
3048c0d to
ad0a0c7Comparegraphite-appBotforce-pushed
the
vp-run-alias-vpr
branch
2 times, most recently
from
March 29, 2026 15:43
959f493 to
cf48911Comparegraphite-appBotforce-pushed
the
vp-run-no-fallback
branch
from
March 29, 2026 15:44
ad0a0c7 to
6c24f5aComparefengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 02:39
6c24f5a to
707c56aComparefengmk2
marked this pull request as ready for review
March 30, 2026 02:43
cpojer
approved these changes
Mar 30, 2026
fengmk2force-pushed
the
vp-run-no-fallback
branch
2 times, most recently
from
March 30, 2026 06:49
9a5c382 to
e4862b2Comparefengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 07:25
e4862b2 to
f898075Comparefengmk2force-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 07:40
f898075 to
0e5b9c2CompareMerge activity
|
…lus (#1179) The `run_or_delegate` module previously fell back to `<pm> run <script>` when vite-plus was not a project dependency. This is no longer needed because the global CLI ships with its own vite-plus installation, and `delegate::execute()` already resolves local vite-plus first then falls back to the global one. Now `vp run` and `vpr` always delegate through the vite-plus task runner, regardless of whether the project has vite-plus as a dependency. Closes#1132
graphite-appBotforce-pushed
the
vp-run-alias-vpr
branch
from
March 30, 2026 08:20
834d8e5 to
acee8b6Comparegraphite-appBotforce-pushed
the
vp-run-no-fallback
branch
from
March 30, 2026 08:21
0e5b9c2 to
c682cb1CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
run_or_delegatemodule previously fell back to<pm> run <script>when vite-plus was not a project dependency. This is no longer needed
because the global CLI ships with its own vite-plus installation, and
delegate::execute()already resolves local vite-plus first then fallsback to the global one.
Now
vp runandvpralways delegate through the vite-plus task runner,regardless of whether the project has vite-plus as a dependency.
Closes#1132