Uh oh!
There was an error while loading. Please reload this page.
fix(cache): add Package-scoped negative globs to prevent cache miss in monorepos - #1198
Merged
Conversation
This was referenced Mar 29, 2026
MemberAuthor
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
fengmk2
commented
Mar 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
fengmk2
commented
Mar 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
fengmk2
commented
Mar 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
graphite-appBotforce-pushed
the
fix-issue-1176
branch
from
March 29, 2026 15:44
3fcad86 to
756e54fComparegraphite-appBotforce-pushed
the
fix-cache-missing
branch
from
March 29, 2026 15:45
485d4ea to
9e18cefComparefengmk2
marked this pull request as ready for review
March 30, 2026 02:43
fengmk2force-pushed
the
fix-issue-1176
branch
2 times, most recently
from
March 30, 2026 07:24
538ff45 to
ffbfc0cComparegraphite-appBotforce-pushed
the
fix-issue-1176
branch
from
March 30, 2026 08:37
82e412a to
110f3c9Comparegraphite-appBotforce-pushed
the
fix-cache-missing
branch
from
March 30, 2026 08:38
04abde5 to
f8066fdComparefengmk2force-pushed
the
fix-cache-missing
branch
2 times, most recently
from
March 30, 2026 09:50
ea53d50 to
854d4c2Comparegraphite-appBot
changed the base branch from
fix-issue-1176
to
graphite-base/1198March 30, 2026 13:15
fengmk2force-pushed
the
graphite-base/1198
branch
from
March 30, 2026 13:16
e60358a to
cf7593eCompare✅ Deploy Preview for viteplus-preview canceled.
|
wan9chi
approved these changes
Mar 30, 2026
Merge activity
|
…n monorepos (#1198) In monorepos, each package has its own node_modules/. When vp build/test/pack run, Vite creates .vite-temp/ config files and dist/ outputs that are both read and written during execution. The existing !node_modules/.vite-temp/** glob at Workspace scope only matched the workspace root, not package-level paths, causing perpetual cache misses due to read-write overlap detection. - Build: add Package-scoped !node_modules/.vite-temp/** and !dist/** - Test: add Package-scoped !node_modules/.vite-temp/** and !node_modules/.vite/**/results.json - Pack: add Package-scoped !node_modules/.vite-temp/** and !dist/**
graphite-appBotforce-pushed
the
fix-cache-missing
branch
from
March 30, 2026 15:03
6cd75f4 to
3fc8005CompareUh oh!
There was an error while loading. Please reload this page.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In monorepos, each package has its own node_modules/. When vp build/test/pack
run, Vite creates .vite-temp/ config files and dist/ outputs that are both read
and written during execution. The existing !node_modules/.vite-temp/** glob at
Workspace scope only matched the workspace root, not package-level paths,
causing perpetual cache misses due to read-write overlap detection.