Uh oh!
There was an error while loading. Please reload this page.
fix(ci): harden some workflows in packages - #12178
Merged
Merged
Conversation
fixes #189098 ``` ~/.local/bin/zizmor --gh-token=$(gh auth token) .github/workflow INFO zizmor: 🌈 zizmor v1.25.2 INFO audit: zizmor: 🌈 completed .github/workflows/batch_release_pr.yml INFO audit: zizmor: 🌈 completed .github/workflows/go_router_batch.yml INFO audit: zizmor: 🌈 completed .github/workflows/internals/install_flutter/action.yml INFO audit: zizmor: 🌈 completed .github/workflows/pull_request_label.yml INFO audit: zizmor: 🌈 completed .github/workflows/release.yml INFO audit: zizmor: 🌈 completed .github/workflows/release_from_branches.yml INFO audit: zizmor: 🌈 completed .github/workflows/remove_cicd.yml INFO audit: zizmor: 🌈 completed .github/workflows/reusable_release.yml INFO audit: zizmor: 🌈 completed .github/workflows/sync_release_pr.yml No findings to report. Good job! (2 ignored, 56 suppressed) ```
Contributor
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stuartmorgan-g
approved these changes
Jul 14, 2026
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with one more comment.
| persist-credentials: false | ||
| - name: Create batch release PR | ||
| run: | | ||
| gh pr create \ |
Collaborator
There was a problem hiding this comment.
Hm, I missed this before: don't we need to call gh auth setup-git here before doing other gh commands in this structure?
MemberAuthor
There was a problem hiding this comment.
That's easy to confuse: gh auth setup-git modifies the ~/.gitconfig by default and that was done on line 35.
Collaborator
There was a problem hiding this comment.
I see, I didn't realize things would carry across tasks.
MemberAuthor
There was a problem hiding this comment.
Wait, its different jobs isn't it?
MemberAuthor
There was a problem hiding this comment.
It is different jobs - since those run in different VMs, it requires auth setup twice. Done.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 16, 2026
pullBot
pushed a commit
to ZainCheung/flutter
that referenced
this pull request
Jul 17, 2026
…er#189659) flutter/packages@9f95026...4fdc766 2026-07-17 tarrinneal@gmail.com [pigeon] allow empty class (flutter/packages#12181) 2026-07-16 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Rename l10n macros (flutter/packages#12211) 2026-07-16 stuartmorgan@google.com [ci] Remove manual SwiftPM enabling step (flutter/packages#12204) 2026-07-16 stuartmorgan@google.com [google_maps_flutter] Fix XCUITest on stable (flutter/packages#12214) 2026-07-16 stuartmorgan@google.com [google_maps_flutter] Convert XCUITests to Swift (flutter/packages#12208) 2026-07-16 dkwingsmt@users.noreply.github.com [material_ui] Rename the remaining templates (flutter/packages#12210) 2026-07-15 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Rename macro names to package names (flutter/packages#12198) 2026-07-15 katelovett@google.com [material_ui] Fix upstream localization test (flutter/packages#12207) 2026-07-15 stuartmorgan@google.com [material_ui, cupertino_ui] Localizations (flutter/packages#12119) 2026-07-15 codefu@google.com fix(ci): harden some workflows in packages (flutter/packages#12178) 2026-07-15 engine-flutter-autoroll@skia.org Roll Flutter from 846664b to fc1ad95 (18 revisions) (flutter/packages#12203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixesflutter/flutter#189098