Skip to content

[material_ui, cupertino_ui] Rename l10n macros - #12211

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
dkwingsmt:rename-l10n-macro
Jul 16, 2026
Merged

[material_ui, cupertino_ui] Rename l10n macros#12211
auto-submit[bot] merged 1 commit into
flutter:mainfrom
dkwingsmt:rename-l10n-macro

Conversation

@dkwingsmt

Copy link
Copy Markdown
Contributor

This PR renames macros used by l10n.

For why the rename is needed, see #12198.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Jul 16, 2026
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actionsgithub-actionsBot added triage-framework Should be looked at in framework triage p: cupertino_ui p: material_ui labels Jul 16, 2026

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation macro names for Cupertino and Material localizations from 'flutter.localizations.' to 'cupertino_ui.localizations.' and 'material_ui.localizations.*'. However, the generated Material localizations file is missing the corresponding macro rename, which should be updated to prevent out-of-sync documentation templates.

Comment threadscript/l10n/lib/gen_material_localizations.dart

@QuncCcccccQuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmtdkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2026
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2026
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12211, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dkwingsmtdkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2026
@auto-submit
auto-submitBot merged commit 99cd385 into flutter:mainJul 16, 2026
12 checks passed
pullBot pushed a commit to safarmer/flutter that referenced this pull request Jul 17, 2026
…er#189659)
flutter/packages@9f95026...4fdc766
2026-07-17 tarrinneal@gmail.com [pigeon] allow empty class
(flutter/packages#12181)
2026-07-16 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Rename l10n macros (flutter/packages#12211)
2026-07-16 stuartmorgan@google.com [ci] Remove manual SwiftPM enabling
step (flutter/packages#12204)
2026-07-16 stuartmorgan@google.com [google_maps_flutter] Fix XCUITest on
stable (flutter/packages#12214)
2026-07-16 stuartmorgan@google.com [google_maps_flutter] Convert
XCUITests to Swift (flutter/packages#12208)
2026-07-16 dkwingsmt@users.noreply.github.com [material_ui] Rename the
remaining templates (flutter/packages#12210)
2026-07-15 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Rename macro names to package names
(flutter/packages#12198)
2026-07-15 katelovett@google.com [material_ui] Fix upstream localization
test (flutter/packages#12207)
2026-07-15 stuartmorgan@google.com [material_ui, cupertino_ui]
Localizations (flutter/packages#12119)
2026-07-15 codefu@google.com fix(ci): harden some workflows in packages
(flutter/packages#12178)
2026-07-15 engine-flutter-autoroll@skia.org Roll Flutter from
846664b to fc1ad95 (18 revisions) (flutter/packages#12203)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Zubii12 pushed a commit to Zubii12/packages that referenced this pull request Jul 23, 2026
This PR renames macros used by l10n.
For why the rename is needed, see flutter#12198.
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: cupertino_uip: material_uitriage-frameworkShould be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dkwingsmt@QuncCccccc