Skip to content

[pigeon] allow empty class - #12181

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
tarrinneal:allow-empty-class
Jul 17, 2026
Merged

[pigeon] allow empty class#12181
auto-submit[bot] merged 4 commits into
flutter:mainfrom
tarrinneal:allow-empty-class

Conversation

@tarrinneal

@tarrinnealtarrinneal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

instead of preventing it from being defined, I just made it work

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Jul 11, 2026
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jul 11, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for empty data classes in Pigeon across Dart, Java, Kotlin, and Objective-C generators, and bumps the package version to 27.2.0. Feedback on the changes suggests adding a blank line between the constructor and the serialization method in the generated Dart code for empty classes to improve readability.

Comment threadpackages/pigeon/lib/src/dart/dart_generator.dart
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Jul 14, 2026
@stuartmorgan-g

stuartmorgan-g commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Looks like Linux, Windows, and Obj-C tests are all sad.

stuartmorgan-g
stuartmorgan-g reviewed Jul 15, 2026
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of small tweaks.

Some of the output is a little silly (like the string concatenation of Foo( and ) as separate steps with nothing in between for to-string methods), but nothing that's worth adding complexity to the generators for other than the one case noted below where it's creating an unused variable.

Comment thread...ources/alternate_language_test_plugin/include/alternate_language_test_plugin/CoreTests.gen.h
Comment thread...darwin/alternate_language_test_plugin/Sources/alternate_language_test_plugin/CoreTests.gen.m Outdated
Comment threadpackages/pigeon/pigeons/core_tests.dart Outdated
stuartmorgan-g
stuartmorgan-g approved these changes Jul 15, 2026
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Now with the right radio button selected.)

@tarrinnealtarrinneal added the CICD Run CI/CD label Jul 17, 2026
@flutter-dashboard

flutter-dashboardBot commented Jul 17, 2026

Copy link
Copy Markdown

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

@tarrinnealtarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2026
@auto-submit
auto-submitBot merged commit 4fdc766 into flutter:mainJul 17, 2026
13 checks passed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 17, 2026
Merged
pullBot pushed a commit to safarmer/flutter that referenced this pull request Jul 17, 2026
@engine-flutter-autoroll
Roll Packages from 9f950268cf0f to 4fdc7666cb80 (11 revisions) (flutt…
7cf475a
…er#189659)
flutter/packages@9f95026...4fdc766
2026-07-17 tarrinneal@gmail.com [pigeon] allow empty class
(flutter/packages#12181)
2026-07-16 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Rename l10n macros (flutter/packages#12211)
2026-07-16 stuartmorgan@google.com [ci] Remove manual SwiftPM enabling
step (flutter/packages#12204)
2026-07-16 stuartmorgan@google.com [google_maps_flutter] Fix XCUITest on
stable (flutter/packages#12214)
2026-07-16 stuartmorgan@google.com [google_maps_flutter] Convert
XCUITests to Swift (flutter/packages#12208)
2026-07-16 dkwingsmt@users.noreply.github.com [material_ui] Rename the
remaining templates (flutter/packages#12210)
2026-07-15 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Rename macro names to package names
(flutter/packages#12198)
2026-07-15 katelovett@google.com [material_ui] Fix upstream localization
test (flutter/packages#12207)
2026-07-15 stuartmorgan@google.com [material_ui, cupertino_ui]
Localizations (flutter/packages#12119)
2026-07-15 codefu@google.com fix(ci): harden some workflows in packages
(flutter/packages#12178)
2026-07-15 engine-flutter-autoroll@skia.org Roll Flutter from
846664b to fc1ad95 (18 revisions) (flutter/packages#12203)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Zubii12 pushed a commit to Zubii12/packages that referenced this pull request Jul 23, 2026
@tarrinneal@Zubii12
[pigeon] allow empty class (flutter#12181)
c1848c7
instead of preventing it from being defined, I just made it work
@tarrinnealtarrinneal mentioned this pull request Aug 14, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: pigeonplatform-androidplatform-iosplatform-linuxplatform-macosplatform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarrinneal@stuartmorgan-g