Skip to content

[material_ui] Fix upstream localization test - #12207

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
Piinks:debugLocalBug
Jul 15, 2026
Merged

[material_ui] Fix upstream localization test#12207
auto-submit[bot] merged 2 commits into
flutter:mainfrom
Piinks:debugLocalBug

Conversation

@Piinks

@PiinksPiinks commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Fixes the tree. flutter_localizations contains a patch from flutter/flutter#188473 that has not reached stable yet. This means this test needs to accommodate a different result when tested on stable versus master. Refactored to green the tree.
@justinmc is filing a follow up issue and looking into extending the code freeze that did not originally apply to localizations.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Jul 15, 2026
@github-actionsgithub-actionsBot added triage-framework Should be looked at in framework triage p: material_ui labels Jul 15, 2026
@Piinks

Piinks commented Jul 15, 2026

Copy link
Copy Markdown
ContributorAuthor

FYI @stuartmorgan-g this will fix the tree

gemini-code-assist[bot]
gemini-code-assistBot reviewed Jul 15, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates date_picker_test.dart to support multiple expected month-year headers as a list of strings. The reviewer suggests replacing the use of find.byWidgetPredicate with a loop over find.text to make the test more robust against potential changes in the underlying text widget implementation.

Comment threadpackages/material_ui/test/l10n/date_picker_test.dart
Piinks
Piinks commented Jul 15, 2026
View reviewed changes
Comment threadpackages/material_ui/test/l10n/date_picker_test.dart Outdated
Piinks
Piinks commented Jul 15, 2026
View reviewed changes
Comment threadpackages/material_ui/test/l10n/date_picker_test.dart Outdated
justinmc
justinmc approved these changes Jul 15, 2026
View reviewed changes

@justinmcjustinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@justinmcjustinmc mentioned this pull request Jul 15, 2026
Open
@PiinksPiinks added the emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. label Jul 15, 2026
@flutter-dashboard

flutter-dashboardBot commented Jul 15, 2026

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2026
QuncCccccc
QuncCccccc approved these changes Jul 15, 2026
View reviewed changes

@QuncCcccccQuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit
auto-submitBot merged commit 499f1b3 into flutter:mainJul 15, 2026
11 of 13 checks passed
This was referenced Jul 16, 2026
Closed
Closed
Merged
pullBot pushed a commit to safarmer/flutter that referenced this pull request Jul 17, 2026
@engine-flutter-autoroll
Roll Packages from 9f950268cf0f to 4fdc7666cb80 (11 revisions) (flutt…
7cf475a
…er#189659)
flutter/packages@9f95026...4fdc766
2026-07-17 tarrinneal@gmail.com [pigeon] allow empty class
(flutter/packages#12181)
2026-07-16 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Rename l10n macros (flutter/packages#12211)
2026-07-16 stuartmorgan@google.com [ci] Remove manual SwiftPM enabling
step (flutter/packages#12204)
2026-07-16 stuartmorgan@google.com [google_maps_flutter] Fix XCUITest on
stable (flutter/packages#12214)
2026-07-16 stuartmorgan@google.com [google_maps_flutter] Convert
XCUITests to Swift (flutter/packages#12208)
2026-07-16 dkwingsmt@users.noreply.github.com [material_ui] Rename the
remaining templates (flutter/packages#12210)
2026-07-15 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Rename macro names to package names
(flutter/packages#12198)
2026-07-15 katelovett@google.com [material_ui] Fix upstream localization
test (flutter/packages#12207)
2026-07-15 stuartmorgan@google.com [material_ui, cupertino_ui]
Localizations (flutter/packages#12119)
2026-07-15 codefu@google.com fix(ci): harden some workflows in packages
(flutter/packages#12178)
2026-07-15 engine-flutter-autoroll@skia.org Roll Flutter from
846664b to fc1ad95 (18 revisions) (flutter/packages#12203)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@PiinksPiinks mentioned this pull request Jul 20, 2026
Closed
4 tasks
Zubii12 pushed a commit to Zubii12/packages that referenced this pull request Jul 23, 2026
@Piinks@Zubii12
[material_ui] Fix upstream localization test (flutter#12207)
49d7322
Fixes the tree. `flutter_localizations` contains a patch from flutter/flutter#188473 that has not reached stable yet. This means this test needs to accommodate a different result when tested on stable versus master. Refactored to green the tree. @justinmc is filing a follow up issue and looking into extending the code freeze that did not originally apply to localizations.
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmcjustinmcjustinmc approved these changes
@QuncCcccccQuncCcccccQuncCccccc approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDemergencyOverride tree-status signal (land even with closed tree), combine with the autosubmit label.p: material_uitriage-frameworkShould be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks@justinmc@QuncCccccc