Uh oh!
There was an error while loading. Please reload this page.
[material_ui] Rename the remaining templates - #12210
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates documentation macros and templates across several Material UI components—including DropdownMenu, ProgressIndicator, RefreshIndicator, SearchAnchor, SearchBar, and TextField—to reference material_ui instead of flutter or flutter.widgets. There are no review comments, and I have no feedback to provide.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 16, 2026
pullBot
pushed a commit
to safarmer/flutter
that referenced
this pull request
Jul 17, 2026
…er#189659) flutter/packages@9f95026...4fdc766 2026-07-17 tarrinneal@gmail.com [pigeon] allow empty class (flutter/packages#12181) 2026-07-16 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Rename l10n macros (flutter/packages#12211) 2026-07-16 stuartmorgan@google.com [ci] Remove manual SwiftPM enabling step (flutter/packages#12204) 2026-07-16 stuartmorgan@google.com [google_maps_flutter] Fix XCUITest on stable (flutter/packages#12214) 2026-07-16 stuartmorgan@google.com [google_maps_flutter] Convert XCUITests to Swift (flutter/packages#12208) 2026-07-16 dkwingsmt@users.noreply.github.com [material_ui] Rename the remaining templates (flutter/packages#12210) 2026-07-15 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Rename macro names to package names (flutter/packages#12198) 2026-07-15 katelovett@google.com [material_ui] Fix upstream localization test (flutter/packages#12207) 2026-07-15 stuartmorgan@google.com [material_ui, cupertino_ui] Localizations (flutter/packages#12119) 2026-07-15 codefu@google.com fix(ci): harden some workflows in packages (flutter/packages#12178) 2026-07-15 engine-flutter-autoroll@skia.org Roll Flutter from 846664b to fc1ad95 (18 revisions) (flutter/packages#12203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Zubii12 pushed a commit
to Zubii12/packages
that referenced
this pull request
Jul 23, 2026
This PR follows up the comment under flutter#12198, and renames all remaining `@template`s so that no templates conflict with the framework. Note: The templates in `generated_cupertino_localizations.dart` and `generated_material_localizations.dart` have been left as-is for now, as these files are auto-generated. A separate migration of the generation script will be required to address those specific instances. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up the comment under #12198, and renames all remaining
@templates so that no templates conflict with the framework.Note: The templates in
generated_cupertino_localizations.dartandgenerated_material_localizations.darthave been left as-is for now, as these files are auto-generated. A separate migration of the generation script will be required to address those specific instances.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2