test: Remove unneeded orchestrion test apps - #23349

Merged
mydea merged 2 commits into
developfrom
fn/remove-e2e-apps
Aug 13, 2026
Merged

test: Remove unneeded orchestrion test apps#23349
mydea merged 2 commits into
developfrom
fn/remove-e2e-apps

Conversation

@mydea

@mydeamydea commented Aug 12, 2026

Copy link
Copy Markdown
Member

Removing e2e test apps that are orchestrion variants, as this should now be covered generally.

Remaining test apps with orchestrion in the name to verify for followup:

  • node-orchestrion-webpack
  • cloudflare-orchestiron-mysql

@github-actions

github-actionsBot commented Aug 12, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser30.31 kB-0.08%-23 B 🔽
@sentry/browser - with treeshaking flags28.49 kB-0.09%-24 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing26.83 kB-0.1%-25 B 🔽
@sentry/browser (incl. Tracing)48.56 kB-0.04%-15 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)48.57 kB-0.03%-14 B 🔽
@sentry/browser (incl. Tracing, Profiling)51.44 kB-0.04%-17 B 🔽
@sentry/browser (incl. Tracing, Replay)87.96 kB-0.04%-29 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.33 kB-0.04%-25 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)92.68 kB-0.03%-20 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)105.36 kB-0.03%-25 B 🔽
@sentry/browser (incl. Feedback)47.64 kB-0.04%-18 B 🔽
@sentry/browser (incl. sendFeedback)35.14 kB-0.07%-22 B 🔽
@sentry/browser (incl. FeedbackAsync)40.29 kB-0.06%-21 B 🔽
@sentry/browser (incl. Metrics)31.29 kB-0.07%-21 B 🔽
@sentry/browser (incl. Logs)31.53 kB-0.14%-44 B 🔽
@sentry/browser (incl. Metrics & Logs)32.2 kB-0.17%-53 B 🔽
@sentry/react32.11 kB-0.09%-27 B 🔽
@sentry/react (incl. Tracing)50.75 kB-0.07%-34 B 🔽
@sentry/vue35.33 kB-0.1%-33 B 🔽
@sentry/vue (incl. Tracing)50.51 kB-0.04%-19 B 🔽
@sentry/svelte30.34 kB-0.08%-24 B 🔽
CDN Bundle31.62 kB-0.07%-21 B 🔽
CDN Bundle (incl. Tracing)48.88 kB-0.04%-18 B 🔽
CDN Bundle (incl. Logs, Metrics)33.82 kB-0.13%-42 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics)50.81 kB-0.1%-48 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)74.32 kB-0.08%-53 B 🔽
CDN Bundle (incl. Tracing, Replay)86.47 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.31 kB-0.06%-47 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)92.18 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.13 kB-0.05%-47 B 🔽
CDN Bundle - uncompressed93.87 kB-0.08%-66 B 🔽
CDN Bundle (incl. Tracing) - uncompressed146.75 kB-0.05%-68 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed100.21 kB-0.14%-132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.47 kB-0.09%-134 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed229.14 kB-0.06%-134 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed266.01 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed271.72 kB-0.05%-134 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.7 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.41 kB-0.05%-134 B 🔽
@sentry/nextjs (client)53.27 kB-0.06%-27 B 🔽
@sentry/sveltekit (client)48.97 kB-0.04%-19 B 🔽
@sentry/core/server65.39 kB-0.11%-70 B 🔽
@sentry/core/browser51.73 kB-0.16%-78 B 🔽
@sentry/node117.95 kB-0.03%-29 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)0 Baddedadded
@sentry/node - without tracing82.07 kB-0.04%-29 B 🔽
@sentry/aws-serverless91.48 kB-0.04%-31 B 🔽
@sentry/cloudflare (withSentry) - minified214.04 kB-0.04%-80 B 🔽
@sentry/cloudflare (withSentry)528.91 kB-0.03%-119 B 🔽

View base workflow run

@mydea
mydea marked this pull request as ready for review August 12, 2026 12:55
chargome
chargome reviewed Aug 12, 2026
View reviewed changes

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is

@mydea

mydea commented Aug 12, 2026

Copy link
Copy Markdown
MemberAuthor

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is

hmm maybe we should merge them then I guess?

@chargome

chargome commented Aug 12, 2026

Copy link
Copy Markdown
Member

Yes, I'd merge them 👍

github-advanced-security[bot]
github-advanced-securityBot found potential problems Aug 12, 2026
View reviewed changes
Comment threaddev-packages/e2e-tests/test-applications/node-express-esm-loader/src/app.mjs Dismissed
Comment threaddev-packages/e2e-tests/test-applications/node-express-v5/src/app.ts Dismissed
@mydea

mydea commented Aug 12, 2026

Copy link
Copy Markdown
MemberAuthor

Yes, I'd merge them 👍

I folded them back into the existing tests!

chargome
chargome approved these changes Aug 12, 2026
View reviewed changes

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging 🙏

@mydea
mydea merged commit 1f3125e into developAug 13, 2026
269 of 271 checks passed
@mydea
mydea deleted the fn/remove-e2e-apps branch August 13, 2026 07:14
s1gr1d added a commit that referenced this pull request Aug 24, 2026
@s1gr1d@claude
Merge branch 'develop' into sig/network-attributes
01a888e
Develop landed the same `net.*` -> `server.*`/`network.*` rename for db and
messaging spans (#23422), plus a `db.*` rename (#23408) and a restructure of
the redis/mysql2/mongoose integrations, so that half of this branch is
superseded. Conflicts in `packages/server-utils` and the db/messaging test
assertions resolve to develop's version; the orchestrion e2e test apps develop
deleted in #23349 stay deleted. `docs/migration/v11-end-state.md` keeps this
branch's sectioned layout and `net.*` mapping table with develop's added
entries folded in.
The branch's own work - the HTTP server and client network attributes in
core, node, cloudflare and deno - is unaffected.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit that referenced this pull request Aug 24, 2026
@s1gr1d
Merge branch 'develop' into sig/messaging-attributes
4d6db2e
Develop landed overlapping semantic-convention work (#23408, #23422,
#23353, #23405) and restructured the redis integration into
`integrations/redis/`. Conflicts were resolved by keeping develop's
file layout and layering this branch's attribute changes on top:
- ioredis/node-redis spans emit `db.operation.name` and drop
`db.connection_string`; `server.address`/`server.port` are only set
when known.
- The ioredis orchestrion span op moves from `db` to `db.query`, and the
connect span to `db` via `SENTRY_OP`, matching the native
diagnostics-channel subscriber develop added.
- AMQP keeps this branch's removal of the legacy `messaging.*`
attributes and adds `messaging.operation.name`.
- Test conditionals on the deleted `isOrchestrionEnabled()` helper
(#23435) collapse to their channel branch.
- `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis
coverage now lives in `nextjs-16/tests/db-page.test.ts`.
The v11 migration doc keeps develop's subsection structure with this
branch's AMQP and Redis specifics folded in.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JPeer264JPeer264JPeer264 approved these changes
@chargomechargomechargome approved these changes
@nicohrubecnicohrubecnicohrubec approved these changes
+1 more reviewer
@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mydea@chargome@JPeer264@nicohrubec@github-advanced-security
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test: Remove unneeded orchestrion test apps - #23349
Merged
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Aug 13, 2026
Merged
test: Remove unneeded orchestrion test apps#23349
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Conversation
@mydea
@mydeamydea
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Removing e2e test apps that are orchestrion variants, as this should now be covered generally.
Remaining test apps with orchestrion in the name to verify for followup:
  • node-orchestrion-webpack
  • cloudflare-orchestiron-mysql
@github-actions
github-actionsBot
commented
Aug 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser30.31 kB-0.08%-23 B 🔽
@sentry/browser - with treeshaking flags28.49 kB-0.09%-24 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing26.83 kB-0.1%-25 B 🔽
@sentry/browser (incl. Tracing)48.56 kB-0.04%-15 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)48.57 kB-0.03%-14 B 🔽
@sentry/browser (incl. Tracing, Profiling)51.44 kB-0.04%-17 B 🔽
@sentry/browser (incl. Tracing, Replay)87.96 kB-0.04%-29 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.33 kB-0.04%-25 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)92.68 kB-0.03%-20 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)105.36 kB-0.03%-25 B 🔽
@sentry/browser (incl. Feedback)47.64 kB-0.04%-18 B 🔽
@sentry/browser (incl. sendFeedback)35.14 kB-0.07%-22 B 🔽
@sentry/browser (incl. FeedbackAsync)40.29 kB-0.06%-21 B 🔽
@sentry/browser (incl. Metrics)31.29 kB-0.07%-21 B 🔽
@sentry/browser (incl. Logs)31.53 kB-0.14%-44 B 🔽
@sentry/browser (incl. Metrics & Logs)32.2 kB-0.17%-53 B 🔽
@sentry/react32.11 kB-0.09%-27 B 🔽
@sentry/react (incl. Tracing)50.75 kB-0.07%-34 B 🔽
@sentry/vue35.33 kB-0.1%-33 B 🔽
@sentry/vue (incl. Tracing)50.51 kB-0.04%-19 B 🔽
@sentry/svelte30.34 kB-0.08%-24 B 🔽
CDN Bundle31.62 kB-0.07%-21 B 🔽
CDN Bundle (incl. Tracing)48.88 kB-0.04%-18 B 🔽
CDN Bundle (incl. Logs, Metrics)33.82 kB-0.13%-42 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics)50.81 kB-0.1%-48 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)74.32 kB-0.08%-53 B 🔽
CDN Bundle (incl. Tracing, Replay)86.47 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.31 kB-0.06%-47 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)92.18 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.13 kB-0.05%-47 B 🔽
CDN Bundle - uncompressed93.87 kB-0.08%-66 B 🔽
CDN Bundle (incl. Tracing) - uncompressed146.75 kB-0.05%-68 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed100.21 kB-0.14%-132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.47 kB-0.09%-134 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed229.14 kB-0.06%-134 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed266.01 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed271.72 kB-0.05%-134 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.7 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.41 kB-0.05%-134 B 🔽
@sentry/nextjs (client)53.27 kB-0.06%-27 B 🔽
@sentry/sveltekit (client)48.97 kB-0.04%-19 B 🔽
@sentry/core/server65.39 kB-0.11%-70 B 🔽
@sentry/core/browser51.73 kB-0.16%-78 B 🔽
@sentry/node117.95 kB-0.03%-29 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)0 Baddedadded
@sentry/node - without tracing82.07 kB-0.04%-29 B 🔽
@sentry/aws-serverless91.48 kB-0.04%-31 B 🔽
@sentry/cloudflare (withSentry) - minified214.04 kB-0.04%-80 B 🔽
@sentry/cloudflare (withSentry)528.91 kB-0.03%-119 B 🔽
View base workflow run
@mydea
mydea
marked this pull request as ready for review
August 12, 2026 12:55
chargome
chargome
reviewed
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
hmm maybe we should merge them then I guess?
@chargome
chargome
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Yes, I'd merge them 👍
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Aug 12, 2026
View reviewed changes
Comment threaddev-packages/e2e-tests/test-applications/node-express-esm-loader/src/app.mjs
Dismissed

Comment threaddev-packages/e2e-tests/test-applications/node-express-v5/src/app.ts
Dismissed

@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
Yes, I'd merge them 👍
I folded them back into the existing tests!
chargome
chargome
approved these changes
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging 🙏
@mydea
mydea
merged commit 1f3125e
into
developAug 13, 2026

269 of 271 checks passed

@mydea
mydea
deleted the

fn/remove-e2e-apps

branch
August 13, 2026 07:14
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d@claude
Merge branch 'develop' into sig/network-attributes
01a888e
Develop landed the same `net.*` -> `server.*`/`network.*` rename for db and
messaging spans (#23422), plus a `db.*` rename (#23408) and a restructure of
the redis/mysql2/mongoose integrations, so that half of this branch is
superseded. Conflicts in `packages/server-utils` and the db/messaging test
assertions resolve to develop's version; the orchestrion e2e test apps develop
deleted in #23349 stay deleted. `docs/migration/v11-end-state.md` keeps this
branch's sectioned layout and `net.*` mapping table with develop's added
entries folded in.
The branch's own work - the HTTP server and client network attributes in
core, node, cloudflare and deno - is unaffected.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d
Merge branch 'develop' into sig/messaging-attributes
4d6db2e
Develop landed overlapping semantic-convention work (#23408, #23422,
#23353, #23405) and restructured the redis integration into
`integrations/redis/`. Conflicts were resolved by keeping develop's
file layout and layering this branch's attribute changes on top:
- ioredis/node-redis spans emit `db.operation.name` and drop
`db.connection_string`; `server.address`/`server.port` are only set
when known.
- The ioredis orchestrion span op moves from `db` to `db.query`, and the
connect span to `db` via `SENTRY_OP`, matching the native
diagnostics-channel subscriber develop added.
- AMQP keeps this branch's removal of the legacy `messaging.*`
attributes and adds `messaging.operation.name`.
- Test conditionals on the deleted `isOrchestrionEnabled()` helper
(#23435) collapse to their channel branch.
- `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis
coverage now lives in `nextjs-16/tests/db-page.test.ts`.
The v11 migration doc keeps develop's subsection structure with this
branch's AMQP and Redis specifics folded in.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JPeer264JPeer264JPeer264 approved these changes
@chargomechargomechargome approved these changes
@nicohrubecnicohrubecnicohrubec approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mydea@chargome@JPeer264@nicohrubec@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: Remove unneeded orchestrion test apps - #23349
Merged
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Aug 13, 2026
Merged
test: Remove unneeded orchestrion test apps#23349
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Conversation
@mydea
@mydeamydea
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Removing e2e test apps that are orchestrion variants, as this should now be covered generally.
Remaining test apps with orchestrion in the name to verify for followup:
  • node-orchestrion-webpack
  • cloudflare-orchestiron-mysql
@github-actions
github-actionsBot
commented
Aug 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser30.31 kB-0.08%-23 B 🔽
@sentry/browser - with treeshaking flags28.49 kB-0.09%-24 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing26.83 kB-0.1%-25 B 🔽
@sentry/browser (incl. Tracing)48.56 kB-0.04%-15 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)48.57 kB-0.03%-14 B 🔽
@sentry/browser (incl. Tracing, Profiling)51.44 kB-0.04%-17 B 🔽
@sentry/browser (incl. Tracing, Replay)87.96 kB-0.04%-29 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.33 kB-0.04%-25 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)92.68 kB-0.03%-20 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)105.36 kB-0.03%-25 B 🔽
@sentry/browser (incl. Feedback)47.64 kB-0.04%-18 B 🔽
@sentry/browser (incl. sendFeedback)35.14 kB-0.07%-22 B 🔽
@sentry/browser (incl. FeedbackAsync)40.29 kB-0.06%-21 B 🔽
@sentry/browser (incl. Metrics)31.29 kB-0.07%-21 B 🔽
@sentry/browser (incl. Logs)31.53 kB-0.14%-44 B 🔽
@sentry/browser (incl. Metrics & Logs)32.2 kB-0.17%-53 B 🔽
@sentry/react32.11 kB-0.09%-27 B 🔽
@sentry/react (incl. Tracing)50.75 kB-0.07%-34 B 🔽
@sentry/vue35.33 kB-0.1%-33 B 🔽
@sentry/vue (incl. Tracing)50.51 kB-0.04%-19 B 🔽
@sentry/svelte30.34 kB-0.08%-24 B 🔽
CDN Bundle31.62 kB-0.07%-21 B 🔽
CDN Bundle (incl. Tracing)48.88 kB-0.04%-18 B 🔽
CDN Bundle (incl. Logs, Metrics)33.82 kB-0.13%-42 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics)50.81 kB-0.1%-48 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)74.32 kB-0.08%-53 B 🔽
CDN Bundle (incl. Tracing, Replay)86.47 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.31 kB-0.06%-47 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)92.18 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.13 kB-0.05%-47 B 🔽
CDN Bundle - uncompressed93.87 kB-0.08%-66 B 🔽
CDN Bundle (incl. Tracing) - uncompressed146.75 kB-0.05%-68 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed100.21 kB-0.14%-132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.47 kB-0.09%-134 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed229.14 kB-0.06%-134 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed266.01 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed271.72 kB-0.05%-134 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.7 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.41 kB-0.05%-134 B 🔽
@sentry/nextjs (client)53.27 kB-0.06%-27 B 🔽
@sentry/sveltekit (client)48.97 kB-0.04%-19 B 🔽
@sentry/core/server65.39 kB-0.11%-70 B 🔽
@sentry/core/browser51.73 kB-0.16%-78 B 🔽
@sentry/node117.95 kB-0.03%-29 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)0 Baddedadded
@sentry/node - without tracing82.07 kB-0.04%-29 B 🔽
@sentry/aws-serverless91.48 kB-0.04%-31 B 🔽
@sentry/cloudflare (withSentry) - minified214.04 kB-0.04%-80 B 🔽
@sentry/cloudflare (withSentry)528.91 kB-0.03%-119 B 🔽
View base workflow run
@mydea
mydea
marked this pull request as ready for review
August 12, 2026 12:55
chargome
chargome
reviewed
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
hmm maybe we should merge them then I guess?
@chargome
chargome
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Yes, I'd merge them 👍
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Aug 12, 2026
View reviewed changes
Comment threaddev-packages/e2e-tests/test-applications/node-express-esm-loader/src/app.mjs
Dismissed

Comment threaddev-packages/e2e-tests/test-applications/node-express-v5/src/app.ts
Dismissed

@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
Yes, I'd merge them 👍
I folded them back into the existing tests!
chargome
chargome
approved these changes
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging 🙏
@mydea
mydea
merged commit 1f3125e
into
developAug 13, 2026

269 of 271 checks passed

@mydea
mydea
deleted the

fn/remove-e2e-apps

branch
August 13, 2026 07:14
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d@claude
Merge branch 'develop' into sig/network-attributes
01a888e
Develop landed the same `net.*` -> `server.*`/`network.*` rename for db and
messaging spans (#23422), plus a `db.*` rename (#23408) and a restructure of
the redis/mysql2/mongoose integrations, so that half of this branch is
superseded. Conflicts in `packages/server-utils` and the db/messaging test
assertions resolve to develop's version; the orchestrion e2e test apps develop
deleted in #23349 stay deleted. `docs/migration/v11-end-state.md` keeps this
branch's sectioned layout and `net.*` mapping table with develop's added
entries folded in.
The branch's own work - the HTTP server and client network attributes in
core, node, cloudflare and deno - is unaffected.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d
Merge branch 'develop' into sig/messaging-attributes
4d6db2e
Develop landed overlapping semantic-convention work (#23408, #23422,
#23353, #23405) and restructured the redis integration into
`integrations/redis/`. Conflicts were resolved by keeping develop's
file layout and layering this branch's attribute changes on top:
- ioredis/node-redis spans emit `db.operation.name` and drop
`db.connection_string`; `server.address`/`server.port` are only set
when known.
- The ioredis orchestrion span op moves from `db` to `db.query`, and the
connect span to `db` via `SENTRY_OP`, matching the native
diagnostics-channel subscriber develop added.
- AMQP keeps this branch's removal of the legacy `messaging.*`
attributes and adds `messaging.operation.name`.
- Test conditionals on the deleted `isOrchestrionEnabled()` helper
(#23435) collapse to their channel branch.
- `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis
coverage now lives in `nextjs-16/tests/db-page.test.ts`.
The v11 migration doc keeps develop's subsection structure with this
branch's AMQP and Redis specifics folded in.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JPeer264JPeer264JPeer264 approved these changes
@chargomechargomechargome approved these changes
@nicohrubecnicohrubecnicohrubec approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mydea@chargome@JPeer264@nicohrubec@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: Remove unneeded orchestrion test apps - #23349
Merged
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Aug 13, 2026
Merged
test: Remove unneeded orchestrion test apps#23349
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Conversation
@mydea
@mydeamydea
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Removing e2e test apps that are orchestrion variants, as this should now be covered generally.
Remaining test apps with orchestrion in the name to verify for followup:
  • node-orchestrion-webpack
  • cloudflare-orchestiron-mysql
@github-actions
github-actionsBot
commented
Aug 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser30.31 kB-0.08%-23 B 🔽
@sentry/browser - with treeshaking flags28.49 kB-0.09%-24 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing26.83 kB-0.1%-25 B 🔽
@sentry/browser (incl. Tracing)48.56 kB-0.04%-15 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)48.57 kB-0.03%-14 B 🔽
@sentry/browser (incl. Tracing, Profiling)51.44 kB-0.04%-17 B 🔽
@sentry/browser (incl. Tracing, Replay)87.96 kB-0.04%-29 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.33 kB-0.04%-25 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)92.68 kB-0.03%-20 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)105.36 kB-0.03%-25 B 🔽
@sentry/browser (incl. Feedback)47.64 kB-0.04%-18 B 🔽
@sentry/browser (incl. sendFeedback)35.14 kB-0.07%-22 B 🔽
@sentry/browser (incl. FeedbackAsync)40.29 kB-0.06%-21 B 🔽
@sentry/browser (incl. Metrics)31.29 kB-0.07%-21 B 🔽
@sentry/browser (incl. Logs)31.53 kB-0.14%-44 B 🔽
@sentry/browser (incl. Metrics & Logs)32.2 kB-0.17%-53 B 🔽
@sentry/react32.11 kB-0.09%-27 B 🔽
@sentry/react (incl. Tracing)50.75 kB-0.07%-34 B 🔽
@sentry/vue35.33 kB-0.1%-33 B 🔽
@sentry/vue (incl. Tracing)50.51 kB-0.04%-19 B 🔽
@sentry/svelte30.34 kB-0.08%-24 B 🔽
CDN Bundle31.62 kB-0.07%-21 B 🔽
CDN Bundle (incl. Tracing)48.88 kB-0.04%-18 B 🔽
CDN Bundle (incl. Logs, Metrics)33.82 kB-0.13%-42 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics)50.81 kB-0.1%-48 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)74.32 kB-0.08%-53 B 🔽
CDN Bundle (incl. Tracing, Replay)86.47 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.31 kB-0.06%-47 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)92.18 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.13 kB-0.05%-47 B 🔽
CDN Bundle - uncompressed93.87 kB-0.08%-66 B 🔽
CDN Bundle (incl. Tracing) - uncompressed146.75 kB-0.05%-68 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed100.21 kB-0.14%-132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.47 kB-0.09%-134 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed229.14 kB-0.06%-134 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed266.01 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed271.72 kB-0.05%-134 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.7 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.41 kB-0.05%-134 B 🔽
@sentry/nextjs (client)53.27 kB-0.06%-27 B 🔽
@sentry/sveltekit (client)48.97 kB-0.04%-19 B 🔽
@sentry/core/server65.39 kB-0.11%-70 B 🔽
@sentry/core/browser51.73 kB-0.16%-78 B 🔽
@sentry/node117.95 kB-0.03%-29 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)0 Baddedadded
@sentry/node - without tracing82.07 kB-0.04%-29 B 🔽
@sentry/aws-serverless91.48 kB-0.04%-31 B 🔽
@sentry/cloudflare (withSentry) - minified214.04 kB-0.04%-80 B 🔽
@sentry/cloudflare (withSentry)528.91 kB-0.03%-119 B 🔽
View base workflow run
@mydea
mydea
marked this pull request as ready for review
August 12, 2026 12:55
chargome
chargome
reviewed
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
hmm maybe we should merge them then I guess?
@chargome
chargome
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Yes, I'd merge them 👍
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Aug 12, 2026
View reviewed changes
Comment threaddev-packages/e2e-tests/test-applications/node-express-esm-loader/src/app.mjs
Dismissed

Comment threaddev-packages/e2e-tests/test-applications/node-express-v5/src/app.ts
Dismissed

@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
Yes, I'd merge them 👍
I folded them back into the existing tests!
chargome
chargome
approved these changes
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging 🙏
@mydea
mydea
merged commit 1f3125e
into
developAug 13, 2026

269 of 271 checks passed

@mydea
mydea
deleted the

fn/remove-e2e-apps

branch
August 13, 2026 07:14
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d@claude
Merge branch 'develop' into sig/network-attributes
01a888e
Develop landed the same `net.*` -> `server.*`/`network.*` rename for db and
messaging spans (#23422), plus a `db.*` rename (#23408) and a restructure of
the redis/mysql2/mongoose integrations, so that half of this branch is
superseded. Conflicts in `packages/server-utils` and the db/messaging test
assertions resolve to develop's version; the orchestrion e2e test apps develop
deleted in #23349 stay deleted. `docs/migration/v11-end-state.md` keeps this
branch's sectioned layout and `net.*` mapping table with develop's added
entries folded in.
The branch's own work - the HTTP server and client network attributes in
core, node, cloudflare and deno - is unaffected.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d
Merge branch 'develop' into sig/messaging-attributes
4d6db2e
Develop landed overlapping semantic-convention work (#23408, #23422,
#23353, #23405) and restructured the redis integration into
`integrations/redis/`. Conflicts were resolved by keeping develop's
file layout and layering this branch's attribute changes on top:
- ioredis/node-redis spans emit `db.operation.name` and drop
`db.connection_string`; `server.address`/`server.port` are only set
when known.
- The ioredis orchestrion span op moves from `db` to `db.query`, and the
connect span to `db` via `SENTRY_OP`, matching the native
diagnostics-channel subscriber develop added.
- AMQP keeps this branch's removal of the legacy `messaging.*`
attributes and adds `messaging.operation.name`.
- Test conditionals on the deleted `isOrchestrionEnabled()` helper
(#23435) collapse to their channel branch.
- `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis
coverage now lives in `nextjs-16/tests/db-page.test.ts`.
The v11 migration doc keeps develop's subsection structure with this
branch's AMQP and Redis specifics folded in.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JPeer264JPeer264JPeer264 approved these changes
@chargomechargomechargome approved these changes
@nicohrubecnicohrubecnicohrubec approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mydea@chargome@JPeer264@nicohrubec@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test: Remove unneeded orchestrion test apps - #23349
Merged
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Aug 13, 2026
Merged
test: Remove unneeded orchestrion test apps#23349
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Conversation
@mydea
@mydeamydea
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Removing e2e test apps that are orchestrion variants, as this should now be covered generally.
Remaining test apps with orchestrion in the name to verify for followup:
  • node-orchestrion-webpack
  • cloudflare-orchestiron-mysql
@github-actions
github-actionsBot
commented
Aug 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser30.31 kB-0.08%-23 B 🔽
@sentry/browser - with treeshaking flags28.49 kB-0.09%-24 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing26.83 kB-0.1%-25 B 🔽
@sentry/browser (incl. Tracing)48.56 kB-0.04%-15 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)48.57 kB-0.03%-14 B 🔽
@sentry/browser (incl. Tracing, Profiling)51.44 kB-0.04%-17 B 🔽
@sentry/browser (incl. Tracing, Replay)87.96 kB-0.04%-29 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.33 kB-0.04%-25 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)92.68 kB-0.03%-20 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)105.36 kB-0.03%-25 B 🔽
@sentry/browser (incl. Feedback)47.64 kB-0.04%-18 B 🔽
@sentry/browser (incl. sendFeedback)35.14 kB-0.07%-22 B 🔽
@sentry/browser (incl. FeedbackAsync)40.29 kB-0.06%-21 B 🔽
@sentry/browser (incl. Metrics)31.29 kB-0.07%-21 B 🔽
@sentry/browser (incl. Logs)31.53 kB-0.14%-44 B 🔽
@sentry/browser (incl. Metrics & Logs)32.2 kB-0.17%-53 B 🔽
@sentry/react32.11 kB-0.09%-27 B 🔽
@sentry/react (incl. Tracing)50.75 kB-0.07%-34 B 🔽
@sentry/vue35.33 kB-0.1%-33 B 🔽
@sentry/vue (incl. Tracing)50.51 kB-0.04%-19 B 🔽
@sentry/svelte30.34 kB-0.08%-24 B 🔽
CDN Bundle31.62 kB-0.07%-21 B 🔽
CDN Bundle (incl. Tracing)48.88 kB-0.04%-18 B 🔽
CDN Bundle (incl. Logs, Metrics)33.82 kB-0.13%-42 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics)50.81 kB-0.1%-48 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)74.32 kB-0.08%-53 B 🔽
CDN Bundle (incl. Tracing, Replay)86.47 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.31 kB-0.06%-47 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)92.18 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.13 kB-0.05%-47 B 🔽
CDN Bundle - uncompressed93.87 kB-0.08%-66 B 🔽
CDN Bundle (incl. Tracing) - uncompressed146.75 kB-0.05%-68 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed100.21 kB-0.14%-132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.47 kB-0.09%-134 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed229.14 kB-0.06%-134 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed266.01 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed271.72 kB-0.05%-134 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.7 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.41 kB-0.05%-134 B 🔽
@sentry/nextjs (client)53.27 kB-0.06%-27 B 🔽
@sentry/sveltekit (client)48.97 kB-0.04%-19 B 🔽
@sentry/core/server65.39 kB-0.11%-70 B 🔽
@sentry/core/browser51.73 kB-0.16%-78 B 🔽
@sentry/node117.95 kB-0.03%-29 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)0 Baddedadded
@sentry/node - without tracing82.07 kB-0.04%-29 B 🔽
@sentry/aws-serverless91.48 kB-0.04%-31 B 🔽
@sentry/cloudflare (withSentry) - minified214.04 kB-0.04%-80 B 🔽
@sentry/cloudflare (withSentry)528.91 kB-0.03%-119 B 🔽
View base workflow run
@mydea
mydea
marked this pull request as ready for review
August 12, 2026 12:55
chargome
chargome
reviewed
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
hmm maybe we should merge them then I guess?
@chargome
chargome
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Yes, I'd merge them 👍
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Aug 12, 2026
View reviewed changes
Comment threaddev-packages/e2e-tests/test-applications/node-express-esm-loader/src/app.mjs
Dismissed

Comment threaddev-packages/e2e-tests/test-applications/node-express-v5/src/app.ts
Dismissed

@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
Yes, I'd merge them 👍
I folded them back into the existing tests!
chargome
chargome
approved these changes
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging 🙏
@mydea
mydea
merged commit 1f3125e
into
developAug 13, 2026

269 of 271 checks passed

@mydea
mydea
deleted the

fn/remove-e2e-apps

branch
August 13, 2026 07:14
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d@claude
Merge branch 'develop' into sig/network-attributes
01a888e
Develop landed the same `net.*` -> `server.*`/`network.*` rename for db and
messaging spans (#23422), plus a `db.*` rename (#23408) and a restructure of
the redis/mysql2/mongoose integrations, so that half of this branch is
superseded. Conflicts in `packages/server-utils` and the db/messaging test
assertions resolve to develop's version; the orchestrion e2e test apps develop
deleted in #23349 stay deleted. `docs/migration/v11-end-state.md` keeps this
branch's sectioned layout and `net.*` mapping table with develop's added
entries folded in.
The branch's own work - the HTTP server and client network attributes in
core, node, cloudflare and deno - is unaffected.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d
Merge branch 'develop' into sig/messaging-attributes
4d6db2e
Develop landed overlapping semantic-convention work (#23408, #23422,
#23353, #23405) and restructured the redis integration into
`integrations/redis/`. Conflicts were resolved by keeping develop's
file layout and layering this branch's attribute changes on top:
- ioredis/node-redis spans emit `db.operation.name` and drop
`db.connection_string`; `server.address`/`server.port` are only set
when known.
- The ioredis orchestrion span op moves from `db` to `db.query`, and the
connect span to `db` via `SENTRY_OP`, matching the native
diagnostics-channel subscriber develop added.
- AMQP keeps this branch's removal of the legacy `messaging.*`
attributes and adds `messaging.operation.name`.
- Test conditionals on the deleted `isOrchestrionEnabled()` helper
(#23435) collapse to their channel branch.
- `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis
coverage now lives in `nextjs-16/tests/db-page.test.ts`.
The v11 migration doc keeps develop's subsection structure with this
branch's AMQP and Redis specifics folded in.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JPeer264JPeer264JPeer264 approved these changes
@chargomechargomechargome approved these changes
@nicohrubecnicohrubecnicohrubec approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mydea@chargome@JPeer264@nicohrubec@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: Remove unneeded orchestrion test apps - #23349
Merged
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Aug 13, 2026
Merged
test: Remove unneeded orchestrion test apps#23349
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Conversation
@mydea
@mydeamydea
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Removing e2e test apps that are orchestrion variants, as this should now be covered generally.
Remaining test apps with orchestrion in the name to verify for followup:
  • node-orchestrion-webpack
  • cloudflare-orchestiron-mysql
@github-actions
github-actionsBot
commented
Aug 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser30.31 kB-0.08%-23 B 🔽
@sentry/browser - with treeshaking flags28.49 kB-0.09%-24 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing26.83 kB-0.1%-25 B 🔽
@sentry/browser (incl. Tracing)48.56 kB-0.04%-15 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)48.57 kB-0.03%-14 B 🔽
@sentry/browser (incl. Tracing, Profiling)51.44 kB-0.04%-17 B 🔽
@sentry/browser (incl. Tracing, Replay)87.96 kB-0.04%-29 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.33 kB-0.04%-25 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)92.68 kB-0.03%-20 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)105.36 kB-0.03%-25 B 🔽
@sentry/browser (incl. Feedback)47.64 kB-0.04%-18 B 🔽
@sentry/browser (incl. sendFeedback)35.14 kB-0.07%-22 B 🔽
@sentry/browser (incl. FeedbackAsync)40.29 kB-0.06%-21 B 🔽
@sentry/browser (incl. Metrics)31.29 kB-0.07%-21 B 🔽
@sentry/browser (incl. Logs)31.53 kB-0.14%-44 B 🔽
@sentry/browser (incl. Metrics & Logs)32.2 kB-0.17%-53 B 🔽
@sentry/react32.11 kB-0.09%-27 B 🔽
@sentry/react (incl. Tracing)50.75 kB-0.07%-34 B 🔽
@sentry/vue35.33 kB-0.1%-33 B 🔽
@sentry/vue (incl. Tracing)50.51 kB-0.04%-19 B 🔽
@sentry/svelte30.34 kB-0.08%-24 B 🔽
CDN Bundle31.62 kB-0.07%-21 B 🔽
CDN Bundle (incl. Tracing)48.88 kB-0.04%-18 B 🔽
CDN Bundle (incl. Logs, Metrics)33.82 kB-0.13%-42 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics)50.81 kB-0.1%-48 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)74.32 kB-0.08%-53 B 🔽
CDN Bundle (incl. Tracing, Replay)86.47 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.31 kB-0.06%-47 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)92.18 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.13 kB-0.05%-47 B 🔽
CDN Bundle - uncompressed93.87 kB-0.08%-66 B 🔽
CDN Bundle (incl. Tracing) - uncompressed146.75 kB-0.05%-68 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed100.21 kB-0.14%-132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.47 kB-0.09%-134 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed229.14 kB-0.06%-134 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed266.01 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed271.72 kB-0.05%-134 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.7 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.41 kB-0.05%-134 B 🔽
@sentry/nextjs (client)53.27 kB-0.06%-27 B 🔽
@sentry/sveltekit (client)48.97 kB-0.04%-19 B 🔽
@sentry/core/server65.39 kB-0.11%-70 B 🔽
@sentry/core/browser51.73 kB-0.16%-78 B 🔽
@sentry/node117.95 kB-0.03%-29 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)0 Baddedadded
@sentry/node - without tracing82.07 kB-0.04%-29 B 🔽
@sentry/aws-serverless91.48 kB-0.04%-31 B 🔽
@sentry/cloudflare (withSentry) - minified214.04 kB-0.04%-80 B 🔽
@sentry/cloudflare (withSentry)528.91 kB-0.03%-119 B 🔽
View base workflow run
@mydea
mydea
marked this pull request as ready for review
August 12, 2026 12:55
chargome
chargome
reviewed
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
hmm maybe we should merge them then I guess?
@chargome
chargome
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Yes, I'd merge them 👍
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Aug 12, 2026
View reviewed changes
Comment threaddev-packages/e2e-tests/test-applications/node-express-esm-loader/src/app.mjs
Dismissed

Comment threaddev-packages/e2e-tests/test-applications/node-express-v5/src/app.ts
Dismissed

@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
Yes, I'd merge them 👍
I folded them back into the existing tests!
chargome
chargome
approved these changes
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging 🙏
@mydea
mydea
merged commit 1f3125e
into
developAug 13, 2026

269 of 271 checks passed

@mydea
mydea
deleted the

fn/remove-e2e-apps

branch
August 13, 2026 07:14
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d@claude
Merge branch 'develop' into sig/network-attributes
01a888e
Develop landed the same `net.*` -> `server.*`/`network.*` rename for db and
messaging spans (#23422), plus a `db.*` rename (#23408) and a restructure of
the redis/mysql2/mongoose integrations, so that half of this branch is
superseded. Conflicts in `packages/server-utils` and the db/messaging test
assertions resolve to develop's version; the orchestrion e2e test apps develop
deleted in #23349 stay deleted. `docs/migration/v11-end-state.md` keeps this
branch's sectioned layout and `net.*` mapping table with develop's added
entries folded in.
The branch's own work - the HTTP server and client network attributes in
core, node, cloudflare and deno - is unaffected.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d
Merge branch 'develop' into sig/messaging-attributes
4d6db2e
Develop landed overlapping semantic-convention work (#23408, #23422,
#23353, #23405) and restructured the redis integration into
`integrations/redis/`. Conflicts were resolved by keeping develop's
file layout and layering this branch's attribute changes on top:
- ioredis/node-redis spans emit `db.operation.name` and drop
`db.connection_string`; `server.address`/`server.port` are only set
when known.
- The ioredis orchestrion span op moves from `db` to `db.query`, and the
connect span to `db` via `SENTRY_OP`, matching the native
diagnostics-channel subscriber develop added.
- AMQP keeps this branch's removal of the legacy `messaging.*`
attributes and adds `messaging.operation.name`.
- Test conditionals on the deleted `isOrchestrionEnabled()` helper
(#23435) collapse to their channel branch.
- `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis
coverage now lives in `nextjs-16/tests/db-page.test.ts`.
The v11 migration doc keeps develop's subsection structure with this
branch's AMQP and Redis specifics folded in.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JPeer264JPeer264JPeer264 approved these changes
@chargomechargomechargome approved these changes
@nicohrubecnicohrubecnicohrubec approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mydea@chargome@JPeer264@nicohrubec@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: Remove unneeded orchestrion test apps - #23349
Merged
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Aug 13, 2026
Merged
test: Remove unneeded orchestrion test apps#23349
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Conversation
@mydea
@mydeamydea
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Removing e2e test apps that are orchestrion variants, as this should now be covered generally.
Remaining test apps with orchestrion in the name to verify for followup:
  • node-orchestrion-webpack
  • cloudflare-orchestiron-mysql
@github-actions
github-actionsBot
commented
Aug 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser30.31 kB-0.08%-23 B 🔽
@sentry/browser - with treeshaking flags28.49 kB-0.09%-24 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing26.83 kB-0.1%-25 B 🔽
@sentry/browser (incl. Tracing)48.56 kB-0.04%-15 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)48.57 kB-0.03%-14 B 🔽
@sentry/browser (incl. Tracing, Profiling)51.44 kB-0.04%-17 B 🔽
@sentry/browser (incl. Tracing, Replay)87.96 kB-0.04%-29 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.33 kB-0.04%-25 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)92.68 kB-0.03%-20 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)105.36 kB-0.03%-25 B 🔽
@sentry/browser (incl. Feedback)47.64 kB-0.04%-18 B 🔽
@sentry/browser (incl. sendFeedback)35.14 kB-0.07%-22 B 🔽
@sentry/browser (incl. FeedbackAsync)40.29 kB-0.06%-21 B 🔽
@sentry/browser (incl. Metrics)31.29 kB-0.07%-21 B 🔽
@sentry/browser (incl. Logs)31.53 kB-0.14%-44 B 🔽
@sentry/browser (incl. Metrics & Logs)32.2 kB-0.17%-53 B 🔽
@sentry/react32.11 kB-0.09%-27 B 🔽
@sentry/react (incl. Tracing)50.75 kB-0.07%-34 B 🔽
@sentry/vue35.33 kB-0.1%-33 B 🔽
@sentry/vue (incl. Tracing)50.51 kB-0.04%-19 B 🔽
@sentry/svelte30.34 kB-0.08%-24 B 🔽
CDN Bundle31.62 kB-0.07%-21 B 🔽
CDN Bundle (incl. Tracing)48.88 kB-0.04%-18 B 🔽
CDN Bundle (incl. Logs, Metrics)33.82 kB-0.13%-42 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics)50.81 kB-0.1%-48 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)74.32 kB-0.08%-53 B 🔽
CDN Bundle (incl. Tracing, Replay)86.47 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.31 kB-0.06%-47 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)92.18 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.13 kB-0.05%-47 B 🔽
CDN Bundle - uncompressed93.87 kB-0.08%-66 B 🔽
CDN Bundle (incl. Tracing) - uncompressed146.75 kB-0.05%-68 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed100.21 kB-0.14%-132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.47 kB-0.09%-134 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed229.14 kB-0.06%-134 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed266.01 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed271.72 kB-0.05%-134 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.7 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.41 kB-0.05%-134 B 🔽
@sentry/nextjs (client)53.27 kB-0.06%-27 B 🔽
@sentry/sveltekit (client)48.97 kB-0.04%-19 B 🔽
@sentry/core/server65.39 kB-0.11%-70 B 🔽
@sentry/core/browser51.73 kB-0.16%-78 B 🔽
@sentry/node117.95 kB-0.03%-29 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)0 Baddedadded
@sentry/node - without tracing82.07 kB-0.04%-29 B 🔽
@sentry/aws-serverless91.48 kB-0.04%-31 B 🔽
@sentry/cloudflare (withSentry) - minified214.04 kB-0.04%-80 B 🔽
@sentry/cloudflare (withSentry)528.91 kB-0.03%-119 B 🔽
View base workflow run
@mydea
mydea
marked this pull request as ready for review
August 12, 2026 12:55
chargome
chargome
reviewed
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
hmm maybe we should merge them then I guess?
@chargome
chargome
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Yes, I'd merge them 👍
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Aug 12, 2026
View reviewed changes
Comment threaddev-packages/e2e-tests/test-applications/node-express-esm-loader/src/app.mjs
Dismissed

Comment threaddev-packages/e2e-tests/test-applications/node-express-v5/src/app.ts
Dismissed

@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
Yes, I'd merge them 👍
I folded them back into the existing tests!
chargome
chargome
approved these changes
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging 🙏
@mydea
mydea
merged commit 1f3125e
into
developAug 13, 2026

269 of 271 checks passed

@mydea
mydea
deleted the

fn/remove-e2e-apps

branch
August 13, 2026 07:14
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d@claude
Merge branch 'develop' into sig/network-attributes
01a888e
Develop landed the same `net.*` -> `server.*`/`network.*` rename for db and
messaging spans (#23422), plus a `db.*` rename (#23408) and a restructure of
the redis/mysql2/mongoose integrations, so that half of this branch is
superseded. Conflicts in `packages/server-utils` and the db/messaging test
assertions resolve to develop's version; the orchestrion e2e test apps develop
deleted in #23349 stay deleted. `docs/migration/v11-end-state.md` keeps this
branch's sectioned layout and `net.*` mapping table with develop's added
entries folded in.
The branch's own work - the HTTP server and client network attributes in
core, node, cloudflare and deno - is unaffected.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d
Merge branch 'develop' into sig/messaging-attributes
4d6db2e
Develop landed overlapping semantic-convention work (#23408, #23422,
#23353, #23405) and restructured the redis integration into
`integrations/redis/`. Conflicts were resolved by keeping develop's
file layout and layering this branch's attribute changes on top:
- ioredis/node-redis spans emit `db.operation.name` and drop
`db.connection_string`; `server.address`/`server.port` are only set
when known.
- The ioredis orchestrion span op moves from `db` to `db.query`, and the
connect span to `db` via `SENTRY_OP`, matching the native
diagnostics-channel subscriber develop added.
- AMQP keeps this branch's removal of the legacy `messaging.*`
attributes and adds `messaging.operation.name`.
- Test conditionals on the deleted `isOrchestrionEnabled()` helper
(#23435) collapse to their channel branch.
- `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis
coverage now lives in `nextjs-16/tests/db-page.test.ts`.
The v11 migration doc keeps develop's subsection structure with this
branch's AMQP and Redis specifics folded in.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JPeer264JPeer264JPeer264 approved these changes
@chargomechargomechargome approved these changes
@nicohrubecnicohrubecnicohrubec approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mydea@chargome@JPeer264@nicohrubec@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test: Remove unneeded orchestrion test apps - #23349
Merged
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Aug 13, 2026
Merged
test: Remove unneeded orchestrion test apps#23349
mydea merged 2 commits into
developfrom 
fn/remove-e2e-apps
Conversation
@mydea
@mydeamydea
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Removing e2e test apps that are orchestrion variants, as this should now be covered generally.
Remaining test apps with orchestrion in the name to verify for followup:
  • node-orchestrion-webpack
  • cloudflare-orchestiron-mysql
@github-actions
github-actionsBot
commented
Aug 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
PathSize% ChangeChange
@sentry/browser30.31 kB-0.08%-23 B 🔽
@sentry/browser - with treeshaking flags28.49 kB-0.09%-24 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing26.83 kB-0.1%-25 B 🔽
@sentry/browser (incl. Tracing)48.56 kB-0.04%-15 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)48.57 kB-0.03%-14 B 🔽
@sentry/browser (incl. Tracing, Profiling)51.44 kB-0.04%-17 B 🔽
@sentry/browser (incl. Tracing, Replay)87.96 kB-0.04%-29 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.33 kB-0.04%-25 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)92.68 kB-0.03%-20 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)105.36 kB-0.03%-25 B 🔽
@sentry/browser (incl. Feedback)47.64 kB-0.04%-18 B 🔽
@sentry/browser (incl. sendFeedback)35.14 kB-0.07%-22 B 🔽
@sentry/browser (incl. FeedbackAsync)40.29 kB-0.06%-21 B 🔽
@sentry/browser (incl. Metrics)31.29 kB-0.07%-21 B 🔽
@sentry/browser (incl. Logs)31.53 kB-0.14%-44 B 🔽
@sentry/browser (incl. Metrics & Logs)32.2 kB-0.17%-53 B 🔽
@sentry/react32.11 kB-0.09%-27 B 🔽
@sentry/react (incl. Tracing)50.75 kB-0.07%-34 B 🔽
@sentry/vue35.33 kB-0.1%-33 B 🔽
@sentry/vue (incl. Tracing)50.51 kB-0.04%-19 B 🔽
@sentry/svelte30.34 kB-0.08%-24 B 🔽
CDN Bundle31.62 kB-0.07%-21 B 🔽
CDN Bundle (incl. Tracing)48.88 kB-0.04%-18 B 🔽
CDN Bundle (incl. Logs, Metrics)33.82 kB-0.13%-42 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics)50.81 kB-0.1%-48 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)74.32 kB-0.08%-53 B 🔽
CDN Bundle (incl. Tracing, Replay)86.47 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.31 kB-0.06%-47 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)92.18 kB-0.03%-21 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.13 kB-0.05%-47 B 🔽
CDN Bundle - uncompressed93.87 kB-0.08%-66 B 🔽
CDN Bundle (incl. Tracing) - uncompressed146.75 kB-0.05%-68 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed100.21 kB-0.14%-132 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed152.47 kB-0.09%-134 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed229.14 kB-0.06%-134 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed266.01 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed271.72 kB-0.05%-134 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed279.7 kB-0.03%-68 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed285.41 kB-0.05%-134 B 🔽
@sentry/nextjs (client)53.27 kB-0.06%-27 B 🔽
@sentry/sveltekit (client)48.97 kB-0.04%-19 B 🔽
@sentry/core/server65.39 kB-0.11%-70 B 🔽
@sentry/core/browser51.73 kB-0.16%-78 B 🔽
@sentry/node117.95 kB-0.03%-29 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)0 Baddedadded
@sentry/node - without tracing82.07 kB-0.04%-29 B 🔽
@sentry/aws-serverless91.48 kB-0.04%-31 B 🔽
@sentry/cloudflare (withSentry) - minified214.04 kB-0.04%-80 B 🔽
@sentry/cloudflare (withSentry)528.91 kB-0.03%-119 B 🔽
View base workflow run
@mydea
mydea
marked this pull request as ready for review
August 12, 2026 12:55
chargome
chargome
reviewed
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
We do lose tests for the db instrumentations with this change, e.g. astro-7 is not covered the same way astro-7-orchestrion is
hmm maybe we should merge them then I guess?
@chargome
chargome
commented
Aug 12, 2026

Copy link


Copy Markdown

Member
Yes, I'd merge them 👍
github-advanced-security[bot]
github-advanced-securityBot
found potential problems
Aug 12, 2026
View reviewed changes
Comment threaddev-packages/e2e-tests/test-applications/node-express-esm-loader/src/app.mjs
Dismissed

Comment threaddev-packages/e2e-tests/test-applications/node-express-v5/src/app.ts
Dismissed

@mydea
mydea
commented
Aug 12, 2026

Copy link


Copy Markdown

MemberAuthor
Yes, I'd merge them 👍
I folded them back into the existing tests!
chargome
chargome
approved these changes
Aug 12, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging 🙏
@mydea
mydea
merged commit 1f3125e
into
developAug 13, 2026

269 of 271 checks passed

@mydea
mydea
deleted the

fn/remove-e2e-apps

branch
August 13, 2026 07:14
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d@claude
Merge branch 'develop' into sig/network-attributes
01a888e
Develop landed the same `net.*` -> `server.*`/`network.*` rename for db and
messaging spans (#23422), plus a `db.*` rename (#23408) and a restructure of
the redis/mysql2/mongoose integrations, so that half of this branch is
superseded. Conflicts in `packages/server-utils` and the db/messaging test
assertions resolve to develop's version; the orchestrion e2e test apps develop
deleted in #23349 stay deleted. `docs/migration/v11-end-state.md` keeps this
branch's sectioned layout and `net.*` mapping table with develop's added
entries folded in.
The branch's own work - the HTTP server and client network attributes in
core, node, cloudflare and deno - is unaffected.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
@s1gr1d
Merge branch 'develop' into sig/messaging-attributes
4d6db2e
Develop landed overlapping semantic-convention work (#23408, #23422,
#23353, #23405) and restructured the redis integration into
`integrations/redis/`. Conflicts were resolved by keeping develop's
file layout and layering this branch's attribute changes on top:
- ioredis/node-redis spans emit `db.operation.name` and drop
`db.connection_string`; `server.address`/`server.port` are only set
when known.
- The ioredis orchestrion span op moves from `db` to `db.query`, and the
connect span to `db` via `SENTRY_OP`, matching the native
diagnostics-channel subscriber develop added.
- AMQP keeps this branch's removal of the legacy `messaging.*`
attributes and adds `messaging.operation.name`.
- Test conditionals on the deleted `isOrchestrionEnabled()` helper
(#23435) collapse to their channel branch.
- `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis
coverage now lives in `nextjs-16/tests/db-page.test.ts`.
The v11 migration doc keeps develop's subsection structure with this
branch's AMQP and Redis specifics folded in.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JPeer264JPeer264JPeer264 approved these changes
@chargomechargomechargome approved these changes
@nicohrubecnicohrubecnicohrubec approved these changes

+1 more reviewer

@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@mydea@chargome@JPeer264@nicohrubec@github-advanced-security