Uh oh!
There was an error while loading. Please reload this page.
test(node-integration): Remove isOrchestrionEnabled helper - #23435
Merged
Conversation
… helper Channel-based instrumentation is the v11 default, so the test helper was hardcoded to `true`. Collapse every call site to its channel branch, drop the dead OTel branches, and delete the helper (unblocked by JS-3074). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
isOrchestrionEnabled helperisOrchestrionEnabled helperContributor
size-limit report 📦
|
isOrchestrionEnabled helperisOrchestrionEnabled helpernicohrubec
marked this pull request as ready for review
August 20, 2026 11:39
nicohrubec
requested review from
andreiborza, isaacs and mydea
and removed request for
a teamAugust 20, 2026 11:39
# Conflicts: # dev-packages/node-integration-tests/suites/tracing/mongodb-v7/test.ts # dev-packages/node-integration-tests/suites/tracing/mongoose-tracing-channel/test.ts # dev-packages/node-integration-tests/suites/tracing/mongoose-v9/test.ts
nicohrubec
enabled auto-merge (squash)
August 20, 2026 13:27
Uh oh!
There was an error while loading. Please reload this page.
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
Develop landed overlapping semantic-convention work (#23408, #23422, #23353, #23405) and restructured the redis integration into `integrations/redis/`. Conflicts were resolved by keeping develop's file layout and layering this branch's attribute changes on top: - ioredis/node-redis spans emit `db.operation.name` and drop `db.connection_string`; `server.address`/`server.port` are only set when known. - The ioredis orchestrion span op moves from `db` to `db.query`, and the connect span to `db` via `SENTRY_OP`, matching the native diagnostics-channel subscriber develop added. - AMQP keeps this branch's removal of the legacy `messaging.*` attributes and adds `messaging.operation.name`. - Test conditionals on the deleted `isOrchestrionEnabled()` helper (#23435) collapse to their channel branch. - `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis coverage now lives in `nextjs-16/tests/db-page.test.ts`. The v11 migration doc keeps develop's subsection structure with this branch's AMQP and Redis specifics folded in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel-based instrumentation is the v11 default so the
isOrchestrionEnabled()test helper was hardcoded totrue. This collapses every call site to its channel branch, drops the dead OTel branches, and deletes the helper.