Uh oh!
There was an error while loading. Please reload this page.
fix(server-utils)!: Register channel integrations on versions with native channels - #23405
Merged
Conversation
Contributor
size-limit report 📦
|
JPeer264force-pushed
the
jp/orchestrion-channel-native
branch
2 times, most recently
from
August 14, 2026 09:17
c35446b to
3d8f160Comparemydea
reviewed
Aug 20, 2026
| { exportName: 'postgresJsIntegration', modules: ['postgres'] }, | ||
| { exportName: 'mysqlIntegration', modules: ['mysql'] }, | ||
| { exportName: 'mysql2Integration', modules: ['mysql2'] }, | ||
| { exportName: 'mongooseIntegration', modules: ['mongoose'] }, |
Member
There was a problem hiding this comment.
also needs to add: prisma, fastify, I suppose?
MemberAuthor
There was a problem hiding this comment.
Yes that is a separate commit (and PR). There are way more missing
JPeer264force-pushed
the
jp/orchestrion-channel-native
branch
from
August 21, 2026 06:40
b3c6e1e to
f0bb82fComparemydea
reviewed
Aug 21, 2026
| { exportName: 'postgresJsIntegration', modules: ['postgres'] }, | ||
| { exportName: 'mysqlIntegration', modules: ['mysql'] }, | ||
| { exportName: 'mysql2Integration', modules: ['mysql2'] }, | ||
| { exportName: 'mongooseIntegration', modules: ['mongoose'] }, |
Member
There was a problem hiding this comment.
do we need to add the other things that are native here? I think these are missing here:
Missing exportName │ module(s) │
├──────────────────────┼─────────────────────────────────────────────────────────────┤
│ awsIntegration │ @smithy/core, @smithy/smithy-client, @aws-sdk/smithy-client │
├──────────────────────┼─────────────────────────────────────────────────────────────┤
│ koaIntegration │ koa │
├──────────────────────┼─────────────────────────────────────────────────────────────┤
│ knexIntegration │ knex │
├──────────────────────┼─────────────────────────────────────────────────────────────┤
│ langChainIntegration │ @langchain/core, @langchain/openai, … │
├──────────────────────┼─────────────────────────────────────────────────────────────┤
│ langGraphIntegration │ @langchain/langgraph │
├──────────────────────┼─────────────────────────────────────────────────────────────┤
│ mongoIntegration │ mongodb │
├──────────────────────┼─────────────────────────────────────────────────────────────┤
│ mongooseIntegration │ mongoose │
├──────────────────────┼─────────────────────────────────────────────────────────────┤
│ tediousIntegration │ tedious │
├──────────────────────┼─────────────────────────────────────────────────────────────┤
│ firebaseIntegration │ @firebase/firestore, firebase-functions
MemberAuthor
There was a problem hiding this comment.
Yes they are missing. I tried to split it up in another PR to keep it small. mongoose is only in this PR since it has native channels already.
That is the follow up: #23477
JPeer264
marked this pull request as ready for review
August 21, 2026 10:04
JPeer264
requested review from
andreiborza and isaacs
and removed request for
a teamAugust 21, 2026 10:04
mydea
approved these changes
Aug 21, 2026
nicohrubec
approved these changes
Aug 22, 2026
Uh oh!
There was an error while loading. Please reload this page.
JPeer264 added a commit
that referenced
this pull request
Aug 22, 2026
This adds the missing integrations based on top of #23405 --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
Develop landed overlapping semantic-convention work (#23408, #23422, #23353, #23405) and restructured the redis integration into `integrations/redis/`. Conflicts were resolved by keeping develop's file layout and layering this branch's attribute changes on top: - ioredis/node-redis spans emit `db.operation.name` and drop `db.connection_string`; `server.address`/`server.port` are only set when known. - The ioredis orchestrion span op moves from `db` to `db.query`, and the connect span to `db` via `SENTRY_OP`, matching the native diagnostics-channel subscriber develop added. - AMQP keeps this branch's removal of the legacy `messaging.*` attributes and adds `messaging.operation.name`. - Test conditionals on the deleted `isOrchestrionEnabled()` helper (#23435) collapse to their channel branch. - `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis coverage now lives in `nextjs-16/tests/db-page.test.ts`. The v11 migration doc keeps develop's subsection structure with this branch's AMQP and Redis specifics folded in.
JPeer264 added a commit
that referenced
this pull request
Aug 25, 2026
…tive channels (#23405) ## Problem When injecting tracing channels via Orchestrion we also add the integration on the fly, to save bytes on the SDK itself and only add integrations where we need them. The main problem is that for versions where a library has tracing channels baked in, our matchers don't match, so nothing is injected into the bundle and the integration is never registered. Those versions get no instrumentation at all, even though the native channels are exactly what the subscriber consumes. This already affects some integrations today and will affect more as libraries adopt native channels. ## Solution Registration-only configs. For library versions with native channels, `registrationOnly()` produces a config with `astQuery: 'Program'` and a custom `transform` (`sentryModuleRegistration`). Orchestrion dispatches the named transform instead of its built-in `traceSync` operator, so the only thing injected is the module-registration snippet that registers the subscriber integration when the module is evaluated. No `diagnostics_channel` import, no channel declaration, and no function wrapper are added. Matching the Program node also means the config doesn't depend on any anchor function existing inside the library, so a refactor within the open-ended version range can't trigger orchestrion's "Failed to find injection points" build error. This is only breaking because in Cloudflare we removed the `vercelAIIntegration` by default (`ai` >= 7 is now registered via the bundler plugin). This only affects v11, so I didn't add it to the migration.md. --------- Co-authored-by: Tim Fish <tim@timfish.uk>
JPeer264 added a commit
that referenced
this pull request
Aug 25, 2026
This adds the missing integrations based on top of #23405 --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When injecting tracing channels via Orchestrion we also add the integration on the fly, to save bytes on the SDK itself and only add integrations where we need them. The main problem is that for versions where a library has tracing channels baked in, our matchers don't match, so nothing is injected into the bundle and the integration is never registered. Those versions get no instrumentation at all, even though the native channels are exactly what the subscriber consumes. This already affects some integrations today and will affect more as libraries adopt native channels.
Solution
Registration-only configs. For library versions with native channels,
registrationOnly()produces a config withastQuery: 'Program'and a customtransform(sentryModuleRegistration). Orchestrion dispatches the named transform instead of its built-intraceSyncoperator, so the only thing injected is the module-registration snippet that registers the subscriber integration when the module is evaluated. Nodiagnostics_channelimport, no channel declaration, and no function wrapper are added.Matching the Program node also means the config doesn't depend on any anchor function existing inside the library, so a refactor within the open-ended version range can't trigger orchestrion's "Failed to find injection points" build error.
This is only breaking because in Cloudflare we removed the
vercelAIIntegrationby default (ai>= 7 is now registered via the bundler plugin). This only affects v11, so I didn't add it to the migration.md.