Uh oh!
There was an error while loading. Please reload this page.
ref(server-utils)!: Replace deprecated net.* span attributes on db and messaging spans - #23422
Merged
Merged
Conversation
…and messaging spans Part of the v11 migration away from attributes `@sentry/conventions` marks deprecated, and a direct follow-on to the `db.*` migration (#23408), which touched the same integrations. `net.peer.name` -> `server.address` and `net.peer.port` -> `server.port` on database and messaging client spans, plus `net.transport` -> `network.transport` in Knex. This covers Postgres, MySQL, MySQL2, Knex, MongoDB, Mongoose, Redis, ioredis, Tedious and AMQP. On these spans the socket peer is the server being called, so `server.*` is the right target for the peer attributes. That is not true of HTTP server spans, where the peer is the client — those are migrated separately. AMQP already emitted `server.address`/`server.port` alongside the deprecated pair, so there the deprecated attributes are simply dropped. `redis-cache.ts` still reads `net.peer.name`/`net.peer.port` as a fallback: it also sees spans from a user's own OpenTelemetry instrumentation, which still emits the old conventions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
msonnb
commented
Aug 13, 2026
MemberAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8107e2e. Configure here.
Contributor
size-limit report 📦
|
msonnb
marked this pull request as ready for review
August 13, 2026 16:34
msonnb
requested review from
isaacs, logaretm and mydea
and removed request for
a teamAugust 13, 2026 16:34
logaretm
approved these changes
Aug 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
Develop landed the same `net.*` -> `server.*`/`network.*` rename for db and messaging spans (#23422), plus a `db.*` rename (#23408) and a restructure of the redis/mysql2/mongoose integrations, so that half of this branch is superseded. Conflicts in `packages/server-utils` and the db/messaging test assertions resolve to develop's version; the orchestrion e2e test apps develop deleted in #23349 stay deleted. `docs/migration/v11-end-state.md` keeps this branch's sectioned layout and `net.*` mapping table with develop's added entries folded in. The branch's own work - the HTTP server and client network attributes in core, node, cloudflare and deno - is unaffected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
Develop landed overlapping semantic-convention work (#23408, #23422, #23353, #23405) and restructured the redis integration into `integrations/redis/`. Conflicts were resolved by keeping develop's file layout and layering this branch's attribute changes on top: - ioredis/node-redis spans emit `db.operation.name` and drop `db.connection_string`; `server.address`/`server.port` are only set when known. - The ioredis orchestrion span op moves from `db` to `db.query`, and the connect span to `db` via `SENTRY_OP`, matching the native diagnostics-channel subscriber develop added. - AMQP keeps this branch's removal of the legacy `messaging.*` attributes and adds `messaging.operation.name`. - Test conditionals on the deleted `isOrchestrionEnabled()` helper (#23435) collapse to their channel branch. - `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis coverage now lives in `nextjs-16/tests/db-page.test.ts`. The v11 migration doc keeps develop's subsection structure with this branch's AMQP and Redis specifics folded in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net.peer.name->server.addressnet.peer.port->server.portnet.transport->network.transportAMQP already emitted
server.address/server.portalongside the deprecated pair, so there the deprecated attributes are simply dropped.redis-cache.tsstill readsnet.peer.name/net.peer.portas a fallback: it also sees spans from a user's own OpenTelemetry instrumentation, which still emits the old conventions.part of #18895