Uh oh!
There was an error while loading. Please reload this page.
Fix doc comment: Windows line endings are \r\n not \n\r - #717
Merged
Mark Hildebrand (hildebrandmw) merged 5 commits intoFeb 5, 2026
Conversation
Co-authored-by: hildebrandmw <24898651+hildebrandmw@users.noreply.github.com>
CopilotAI
changed the title
[WIP] WIP addressing review feedback from PR #714 on internal changesFix doc comment: Windows line endings are \r\n not \n\rFeb 4, 2026
Mark Hildebrand (hildebrandmw)
commented
Feb 4, 2026
Contributor
Copilot - Please merge with |
…other-one # Conflicts: # diskann-benchmark-runner/src/ux.rs
ContributorAuthor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #717 +/- ##
=======================================
Coverage 89.01% 89.01% =======================================
Files 428 428 Lines 78151 78151 =======================================
+ Hits 69563 69566 +3 + Misses 8588 8585 -3
🚀 New features to boost your workflow:
|
Mark Hildebrand (hildebrandmw)
marked this pull request as ready for review
February 4, 2026 22:36
Mark Hildebrand (hildebrandmw)
approved these changes
Feb 4, 2026
Copilotstarted reviewing on behalf of Mark Hildebrand (hildebrandmw)February 4, 2026 22:36 View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a documentation error in a comment describing Windows line endings. The comment incorrectly stated that Windows line endings are \n\r when they are actually \r\n. The fix ensures the documentation accurately matches the actual implementation.
Changes:
- Corrected the doc comment in
normalizefunction to state Windows line endings as\r\ninstead of\n\r
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Aditya Krishnan (arkrishn94)
approved these changes
Feb 5, 2026
Mark Hildebrand (hildebrandmw)
approved these changes
Feb 5, 2026
Harsha Simhadri (harsha-simhadri)
approved these changes
Feb 5, 2026
Uh oh!
There was an error while loading. Please reload this page.
Mark Hildebrand (hildebrandmw)
deleted the
copilot/sub-pr-714-another-one
branch
February 5, 2026 19:12
Merged
Mark Hildebrand (hildebrandmw) added a commit
that referenced
this pull request
Feb 13, 2026
## What's Changed ### API Breaking Changes * Remove the `experimental_avx512` feature. by @hildebrandmw in #732 * Use VirtualStorageProvider::new_overlay(test_data_root()) in tests by @Copilot in #726 * save and load max_record_size and leaf_page_size for bftrees by @backurs in #724 * [multi-vector] Verify `Standard` won't overflow in its constructor. by @hildebrandmw in #757 * VirtualStorageProvider: Make new() private, add new_physical by @Copilot in #764 * [minmax] Refactor full query by @arkrishn94 in #770 * Bump diskann-quantization to edition 2024. by @hildebrandmw in #772 ### Additions * [multi-vector] Enable cloning of `Mat` and friends. by @hildebrandmw in #759 * adding bftreepaths in mod.rs by @backurs in #775 * [quantization] Add `as_raw_ptr`. by @hildebrandmw in #774 ### Bug Fixes * Fix `diskann` compilation without default-features and add CI tests. by @hildebrandmw in #722 ### Docs and Comments * Updating the benchmark README to use diskann-benchmark by @bryantower in #709 * Fix doc comment: Windows line endings are \r\n not \n\r by @Copilot in #717 * Fix spelling errors in streaming API documentation by @Copilot in #715 * Add performance diagnostic to `diskann-benchmark` by @hildebrandmw in #744 * Add agents.md onboarding guide for coding agents by @Copilot in #765 * [doc] Fix lots of little typos in `diskann-wide` by @hildebrandmw in #771 ### Performance * [diskann-wide] Optimize `load_simd_first` for 8-bit and 16-bit element types. by @hildebrandmw in #747 ### Dependencies * Bump bytes from 1.11.0 to 1.11.1 by @dependabot[bot] in #723 * [diskann] Add note on the selection of `PruneKind` in `graph::config::Builder`. by @hildebrandmw in #734 * [diskann-providers] Remove the LRU dependency and make `vfs` and `serde_json` optional. by @hildebrandmw in #733 ### Infrastructure * Add initial QEMU tests for `diskann-wide`. by @hildebrandmw in #719 * [CI] Skip coverage for Dependabot. by @hildebrandmw in #725 * Add miri test coverage to CI workflow by @Copilot in #729 * [CI] Add minimal ARM checks by @hildebrandmw in #745 * Enable CodeQL security analysis by @Copilot in #754 ## New Contributors * @backurs made their first contribution in #724 * @arkrishn94 made their first contribution in #770 **Full Changelog**: 0.45.0...0.46.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\r\ninstead of\n\r💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.