Uh oh!
There was an error while loading. Please reload this page.
Remove the experimental_avx512 feature. - #732
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the experimental_avx512 feature from the diskann-vector crate, as AVX-512 support has officially landed and the experimental feature flag is no longer needed. Since diskann-vector now has no features at all, it is also removed from the CI workflow's clippy-no-default-features job, which only tests crates that have features.
Changes:
- Removed the
[features]section containingexperimental_avx512fromdiskann-vector/Cargo.toml - Updated
diskann-benchmark-simdto depend ondiskann-vectorwithout the feature flag - Removed
diskann-vectorfrom the CI workflow'sclippy-no-default-featuresjob matrix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| diskann-vector/Cargo.toml | Removed the entire [features] section containing experimental_avx512 |
| diskann-benchmark-simd/Cargo.toml | Removed the features = ["experimental_avx512"] from the diskann-vector dependency |
| .github/workflows/ci.yml | Removed diskann-vector from the clippy-no-default-features job matrix since it no longer has any features to test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #732 +/- ##
==========================================
- Coverage 89.01% 89.01% -0.01%
==========================================
Files 428 428 Lines 78294 78294 ==========================================
- Hits 69692 69690 -2 - Misses 8602 8604 +2 🚀 New features to boost your workflow:
|
Suhas Jayaram Subramanya (suhasjs)
left a comment
There was a problem hiding this comment.
LGTM
Uh oh!
There was an error while loading. Please reload this page.
## What's Changed ### API Breaking Changes * Remove the `experimental_avx512` feature. by @hildebrandmw in #732 * Use VirtualStorageProvider::new_overlay(test_data_root()) in tests by @Copilot in #726 * save and load max_record_size and leaf_page_size for bftrees by @backurs in #724 * [multi-vector] Verify `Standard` won't overflow in its constructor. by @hildebrandmw in #757 * VirtualStorageProvider: Make new() private, add new_physical by @Copilot in #764 * [minmax] Refactor full query by @arkrishn94 in #770 * Bump diskann-quantization to edition 2024. by @hildebrandmw in #772 ### Additions * [multi-vector] Enable cloning of `Mat` and friends. by @hildebrandmw in #759 * adding bftreepaths in mod.rs by @backurs in #775 * [quantization] Add `as_raw_ptr`. by @hildebrandmw in #774 ### Bug Fixes * Fix `diskann` compilation without default-features and add CI tests. by @hildebrandmw in #722 ### Docs and Comments * Updating the benchmark README to use diskann-benchmark by @bryantower in #709 * Fix doc comment: Windows line endings are \r\n not \n\r by @Copilot in #717 * Fix spelling errors in streaming API documentation by @Copilot in #715 * Add performance diagnostic to `diskann-benchmark` by @hildebrandmw in #744 * Add agents.md onboarding guide for coding agents by @Copilot in #765 * [doc] Fix lots of little typos in `diskann-wide` by @hildebrandmw in #771 ### Performance * [diskann-wide] Optimize `load_simd_first` for 8-bit and 16-bit element types. by @hildebrandmw in #747 ### Dependencies * Bump bytes from 1.11.0 to 1.11.1 by @dependabot[bot] in #723 * [diskann] Add note on the selection of `PruneKind` in `graph::config::Builder`. by @hildebrandmw in #734 * [diskann-providers] Remove the LRU dependency and make `vfs` and `serde_json` optional. by @hildebrandmw in #733 ### Infrastructure * Add initial QEMU tests for `diskann-wide`. by @hildebrandmw in #719 * [CI] Skip coverage for Dependabot. by @hildebrandmw in #725 * Add miri test coverage to CI workflow by @Copilot in #729 * [CI] Add minimal ARM checks by @hildebrandmw in #745 * Enable CodeQL security analysis by @Copilot in #754 ## New Contributors * @backurs made their first contribution in #724 * @arkrishn94 made their first contribution in #770 **Full Changelog**: 0.45.0...0.46.0
This feature is no longer needed as AVX-512 support has officially landed. Since
diskann-vectorno longer has any features, this removes it from the--no-default-featuresas well.