Uh oh!
There was an error while loading. Please reload this page.
Bump diskann-quantization to edition 2024. - #772
Conversation
There was a problem hiding this comment.
Pull request overview
Updates diskann-quantization to Rust edition 2024 and addresses the new warn-by-default unsafe-op-in-unsafe-fn lint by making unsafe operations explicit and suppressing the lint for generated FlatBuffers code.
Changes:
- Bump
diskann-quantizationcrate to Rust edition 2024. - Wrap unsafe operations inside
unsafe fnbodies with explicitunsafe { ... }blocks and add/adjust safety justifications. - Suppress
unsafe_op_in_unsafe_fnwarnings for included/generated FlatBuffers modules.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| diskann-quantization/Cargo.toml | Sets crate edition to Rust 2024. |
| diskann-quantization/src/test_util.rs | Adds explicit unsafe block for allocator deallocation forwarding. |
| diskann-quantization/src/multi_vector/matrix.rs | Adds explicit unsafe blocks and safety comments for pointer arithmetic and slice creation. |
| diskann-quantization/src/minmax/multi/meta.rs | Adds explicit unsafe block for Box::from_raw deallocation. |
| diskann-quantization/src/flatbuffers.rs | Suppresses unsafe_op_in_unsafe_fn for generated FlatBuffers modules. |
| diskann-quantization/src/bits/slice.rs | Adds explicit unsafe block when calling unsafe internal constructor. |
| diskann-quantization/src/alloc/mod.rs | Adds explicit unsafe block for delegating deallocation. |
| diskann-quantization/src/alloc/aligned.rs | Adds explicit unsafe block + justification for deallocation with adjusted layout. |
| diskann-quantization/src/algorithms/kmeans/common.rs | Adds explicit unsafe block around pointer .add(...). |
| diskann-quantization/src/algorithms/heap.rs | Adds explicit unsafe block for unchecked slice access. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #772 +/- ##
=======================================
Coverage 88.99% 88.99% =======================================
Files 428 428 Lines 78415 78401 -14 =======================================
- Hits 69784 69772 -12 + Misses 8631 8629 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
## What's Changed ### API Breaking Changes * Remove the `experimental_avx512` feature. by @hildebrandmw in #732 * Use VirtualStorageProvider::new_overlay(test_data_root()) in tests by @Copilot in #726 * save and load max_record_size and leaf_page_size for bftrees by @backurs in #724 * [multi-vector] Verify `Standard` won't overflow in its constructor. by @hildebrandmw in #757 * VirtualStorageProvider: Make new() private, add new_physical by @Copilot in #764 * [minmax] Refactor full query by @arkrishn94 in #770 * Bump diskann-quantization to edition 2024. by @hildebrandmw in #772 ### Additions * [multi-vector] Enable cloning of `Mat` and friends. by @hildebrandmw in #759 * adding bftreepaths in mod.rs by @backurs in #775 * [quantization] Add `as_raw_ptr`. by @hildebrandmw in #774 ### Bug Fixes * Fix `diskann` compilation without default-features and add CI tests. by @hildebrandmw in #722 ### Docs and Comments * Updating the benchmark README to use diskann-benchmark by @bryantower in #709 * Fix doc comment: Windows line endings are \r\n not \n\r by @Copilot in #717 * Fix spelling errors in streaming API documentation by @Copilot in #715 * Add performance diagnostic to `diskann-benchmark` by @hildebrandmw in #744 * Add agents.md onboarding guide for coding agents by @Copilot in #765 * [doc] Fix lots of little typos in `diskann-wide` by @hildebrandmw in #771 ### Performance * [diskann-wide] Optimize `load_simd_first` for 8-bit and 16-bit element types. by @hildebrandmw in #747 ### Dependencies * Bump bytes from 1.11.0 to 1.11.1 by @dependabot[bot] in #723 * [diskann] Add note on the selection of `PruneKind` in `graph::config::Builder`. by @hildebrandmw in #734 * [diskann-providers] Remove the LRU dependency and make `vfs` and `serde_json` optional. by @hildebrandmw in #733 ### Infrastructure * Add initial QEMU tests for `diskann-wide`. by @hildebrandmw in #719 * [CI] Skip coverage for Dependabot. by @hildebrandmw in #725 * Add miri test coverage to CI workflow by @Copilot in #729 * [CI] Add minimal ARM checks by @hildebrandmw in #745 * Enable CodeQL security analysis by @Copilot in #754 ## New Contributors * @backurs made their first contribution in #724 * @arkrishn94 made their first contribution in #770 **Full Changelog**: 0.45.0...0.46.0
Bump
diskann-quantizationto Rust edition 2024 - addressing instances of the warn-by-defaultunsafe-op-in-unsafe-fnlint.The automatically generated
flatbufferscode is explicitly excluded from the new lint.Note that edition 2024 changes
rustfmt- so there are significant changes to formatting as well.