Skip to content

[quantization] Add as_raw_ptr. - #774

Merged
Mark Hildebrand (hildebrandmw) merged 2 commits into
mainfrom
mhildebr/as_raw_ptr
Feb 13, 2026
Merged

[quantization] Add as_raw_ptr.#774
Mark Hildebrand (hildebrandmw) merged 2 commits into
mainfrom
mhildebr/as_raw_ptr

Conversation

@hildebrandmw

Copy link
Copy Markdown
Contributor

Add publicly exported as_raw_ptr for retrieving the base pointer of Mat, MatRef, and MatMut.

The term "raw" is meant to denote that this is the byte pointer - not necessarily the pointer to the actual element type stored in these containers.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new public method as_raw_ptr() to the Mat, MatRef, and MatMut types in the quantization module. The method provides safe access to the underlying byte-level pointer (*const u8) for these matrix types. The "raw" naming convention clearly distinguishes this byte-pointer accessor from potential typed-pointer accessors, following established codebase patterns.

Changes:

  • Added as_raw_ptr() method to Mat, MatRef, and MatMut that returns the base byte pointer (*const u8)
  • Removed the previous test-only as_ptr() method from Mat and replaced all its usages with the new public as_raw_ptr()
  • Updated all test code to use the new method name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Feb 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.99%. Comparing base (e093583) to head (a84331d).

Files with missing linesPatch %Lines
diskann-quantization/src/multi_vector/matrix.rs91.30%2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## main #774 +/- ##
==========================================
- Coverage 88.99% 88.99% -0.01% 
==========================================
Files 428 428 Lines 78415 78431 +16 ==========================================
+ Hits 69784 69798 +14 - Misses 8631 8633 +2 
FlagCoverage Δ
miri88.99% <91.30%> (-0.01%)⬇️
unittests88.99% <91.30%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
diskann-quantization/src/multi_vector/matrix.rs97.28% <91.30%> (-0.25%)⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment threaddiskann-quantization/src/multi_vector/matrix.rs
@hildebrandmw
Mark Hildebrand (hildebrandmw) merged commit 58be51f into mainFeb 13, 2026
22 checks passed
@hildebrandmw
Mark Hildebrand (hildebrandmw) deleted the mhildebr/as_raw_ptr branch February 13, 2026 18:50
Mark Hildebrand (hildebrandmw) added a commit that referenced this pull request Feb 13, 2026
## What's Changed
### API Breaking Changes
* Remove the `experimental_avx512` feature. by @hildebrandmw in
#732
* Use VirtualStorageProvider::new_overlay(test_data_root()) in tests by
@Copilot in #726
* save and load max_record_size and leaf_page_size for bftrees by
@backurs in #724
* [multi-vector] Verify `Standard` won't overflow in its constructor. by
@hildebrandmw in #757
* VirtualStorageProvider: Make new() private, add new_physical by
@Copilot in #764
* [minmax] Refactor full query by @arkrishn94 in
#770
* Bump diskann-quantization to edition 2024. by @hildebrandmw in
#772
### Additions
* [multi-vector] Enable cloning of `Mat` and friends. by @hildebrandmw
in #759
* adding bftreepaths in mod.rs by @backurs in
#775
* [quantization] Add `as_raw_ptr`. by @hildebrandmw in
#774
### Bug Fixes
* Fix `diskann` compilation without default-features and add CI tests.
by @hildebrandmw in #722
### Docs and Comments
* Updating the benchmark README to use diskann-benchmark by @bryantower
in #709
* Fix doc comment: Windows line endings are \r\n not \n\r by @Copilot in
#717
* Fix spelling errors in streaming API documentation by @Copilot in
#715
* Add performance diagnostic to `diskann-benchmark` by @hildebrandmw in
#744
* Add agents.md onboarding guide for coding agents by @Copilot in
#765
* [doc] Fix lots of little typos in `diskann-wide` by @hildebrandmw in
#771
### Performance
* [diskann-wide] Optimize `load_simd_first` for 8-bit and 16-bit element
types. by @hildebrandmw in #747
### Dependencies
* Bump bytes from 1.11.0 to 1.11.1 by @dependabot[bot] in
#723
* [diskann] Add note on the selection of `PruneKind` in
`graph::config::Builder`. by @hildebrandmw in
#734
* [diskann-providers] Remove the LRU dependency and make `vfs` and
`serde_json` optional. by @hildebrandmw in
#733
### Infrastructure
* Add initial QEMU tests for `diskann-wide`. by @hildebrandmw in
#719
* [CI] Skip coverage for Dependabot. by @hildebrandmw in
#725
* Add miri test coverage to CI workflow by @Copilot in
#729
* [CI] Add minimal ARM checks by @hildebrandmw in
#745
* Enable CodeQL security analysis by @Copilot in
#754
## New Contributors
* @backurs made their first contribution in
#724
* @arkrishn94 made their first contribution in
#770
**Full Changelog**:
0.45.0...0.46.0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@hildebrandmw@codecov-commenter@harsha-simhadri@arkrishn94