Uh oh!
There was an error while loading. Please reload this page.
[multi-vector] Enable cloning of Mat and friends. - #759
Merged
Conversation
Copilotstarted reviewing on behalf of Mark Hildebrand (hildebrandmw)February 11, 2026 00:59 View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables cloning functionality for the multi-vector matrix types in the quantization module. It introduces a new NewCloned trait that representations can implement to support creating owned Mat instances from borrowed views. The PR implements this trait for the Standard<T> representation and uses it to enable Clone for Mat<T>, as well as adding to_owned() methods for MatRef and MatMut.
Changes:
- Introduced
NewClonedtrait for representations that support cloning from a view - Implemented
NewClonedforStandard<T>whereT: Copy - Added
Cloneimplementation forMat<T>whereT: NewCloned - Added
to_owned()inherent methods toMatRefandMatMut - Refactored
NewOwnedimplementation to use a newbox_to_mathelper method - Added comprehensive tests for all three cloning paths
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #759 +/- ##
==========================================
- Coverage 88.99% 88.98% -0.01%
==========================================
Files 428 428 Lines 78291 78420 +129 ==========================================
+ Hits 69677 69785 +108 - Misses 8614 8635 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Aditya Krishnan (arkrishn94)
approved these changes
Feb 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
Jack Moffitt (metajack)
approved these changes
Feb 11, 2026
Aditya Krishnan (arkrishn94)
approved these changes
Feb 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
Merged
Mark Hildebrand (hildebrandmw) added a commit
that referenced
this pull request
Feb 13, 2026
## What's Changed ### API Breaking Changes * Remove the `experimental_avx512` feature. by @hildebrandmw in #732 * Use VirtualStorageProvider::new_overlay(test_data_root()) in tests by @Copilot in #726 * save and load max_record_size and leaf_page_size for bftrees by @backurs in #724 * [multi-vector] Verify `Standard` won't overflow in its constructor. by @hildebrandmw in #757 * VirtualStorageProvider: Make new() private, add new_physical by @Copilot in #764 * [minmax] Refactor full query by @arkrishn94 in #770 * Bump diskann-quantization to edition 2024. by @hildebrandmw in #772 ### Additions * [multi-vector] Enable cloning of `Mat` and friends. by @hildebrandmw in #759 * adding bftreepaths in mod.rs by @backurs in #775 * [quantization] Add `as_raw_ptr`. by @hildebrandmw in #774 ### Bug Fixes * Fix `diskann` compilation without default-features and add CI tests. by @hildebrandmw in #722 ### Docs and Comments * Updating the benchmark README to use diskann-benchmark by @bryantower in #709 * Fix doc comment: Windows line endings are \r\n not \n\r by @Copilot in #717 * Fix spelling errors in streaming API documentation by @Copilot in #715 * Add performance diagnostic to `diskann-benchmark` by @hildebrandmw in #744 * Add agents.md onboarding guide for coding agents by @Copilot in #765 * [doc] Fix lots of little typos in `diskann-wide` by @hildebrandmw in #771 ### Performance * [diskann-wide] Optimize `load_simd_first` for 8-bit and 16-bit element types. by @hildebrandmw in #747 ### Dependencies * Bump bytes from 1.11.0 to 1.11.1 by @dependabot[bot] in #723 * [diskann] Add note on the selection of `PruneKind` in `graph::config::Builder`. by @hildebrandmw in #734 * [diskann-providers] Remove the LRU dependency and make `vfs` and `serde_json` optional. by @hildebrandmw in #733 ### Infrastructure * Add initial QEMU tests for `diskann-wide`. by @hildebrandmw in #719 * [CI] Skip coverage for Dependabot. by @hildebrandmw in #725 * Add miri test coverage to CI workflow by @Copilot in #729 * [CI] Add minimal ARM checks by @hildebrandmw in #745 * Enable CodeQL security analysis by @Copilot in #754 ## New Contributors * @backurs made their first contribution in #724 * @arkrishn94 made their first contribution in #770 **Full Changelog**: 0.45.0...0.46.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable:
MatMatRef::to_owned(as an inherent method)MatMut::to_owned(as an inherent method)All three of these require the underlying representation to implement
NewClonedto perform the actual clone. This PR implementsNewClonedfor theStandardrepresentation.This is turning out necessary for use in multi-vector scenarios.