fs: add fast api for InternalModuleStat

[anonrig]

Adds V8 Fast API to InternalModuleStat

[nodejs-github-bot]

Review requested:

• @nodejs/loaders

[H4ad]

Just thinking about this, if this is true, it will:

• ignore the value -1.
• re-run InternalModuleStat but in the slower version.
• throw error since the permission is not granted.

I don't know if worthy but maybe one test just to ensure this behavior, maybe a loop and then pass a value that is not allowed.

[anonrig]

I added a test (6 months later)

[H4ad]

Error: --- stderr ---
npm WARN cli npm v10.2.4 does not support Node.js v22.0.0-pre. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at [https://nodejs.org/.](https://nodejs.org/)
npm ERR! code MODULE_NOT_FOUND
npm ERR! path /home/runner/work/node/node/deps/npm/node_modules/walk-up-path/package.json
npm ERR! Cannot find module '/home/runner/work/node/node/deps/npm/node_modules/walk-up-path/dist/cjs/index.js'

Failing because of the Node version: https://github.com/nodejs/node/actions/runs/7390448695/job/20105393172?pr=51344#step:6:5719

Who we should ping to solve this kind of issue?

[anonrig]

Error: --- stderr ---
npm WARN cli npm v10.2.4 does not support Node.js v22.0.0-pre. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at [https://nodejs.org/.](https://nodejs.org/)
npm ERR! code MODULE_NOT_FOUND
npm ERR! path /home/runner/work/node/node/deps/npm/node_modules/walk-up-path/package.json
npm ERR! Cannot find module '/home/runner/work/node/node/deps/npm/node_modules/walk-up-path/dist/cjs/index.js'

Failing because of the Node version: https://github.com/nodejs/node/actions/runs/7390448695/job/20105393172?pr=51344#step:6:5719

Who we should ping to solve this kind of issue?

cc @nodejs/build @nodejs/npm Any suggestions on how to fix the error?

[wraithgar]

There are two separate items in that log. First is a warning that will always show up when you're using a prerelease version of node. This is intentional to remind folks that they're in an unsupported prerelease version of node. npm still will install just fine, the part of npm that prevents itself from being installed globally in an unsupported node version throws a different exception and allows prereleases in its semver check against npm's engines field.

The second error has to do with a missing file that is being required. As to why that file is missing, that's another mystery. It's definitely in the tarball of the published module, and in source control.

[targos]

The error must be related to the changes made in this PR. In other words, there's a bug in the implementation.

[aduh95]

This needs a rebase.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59772/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59773/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59775/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59776/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59783/

[mcollina]

lgtm

is this improving startup time in any way?

[anonrig]

is this improving startup time in any way?

I don't know, but better ask our friend "benchmark ci": https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1570/

[anonrig]

@mcollina

misc/startup-cli-version.js count=30 cli='deps/corepack/dist/corepack.js' *** 0.14 % ±0.08% ±0.11% ±0.14%
misc/startup-cli-version.js count=30 cli='deps/npm/bin/npm-cli.js' 0.07 % ±0.19% ±0.25% ±0.33%
misc/startup-cli-version.js count=30 cli='deps/npm/bin/npx-cli.js' *** 0.31 % ±0.17% ±0.23% ±0.30%
misc/startup-cli-version.js count=30 cli='tools/node_modules/eslint/bin/eslint.js' *** -0.12 % ±0.05% ±0.06% ±0.08%
misc/startup-core.js count=30 mode='process' script='benchmark/fixtures/require-builtins' * -0.45 % ±0.36% ±0.48% ±0.62%
misc/startup-core.js count=30 mode='process' script='test/fixtures/semicolon' 2.38 % ±3.17% ±4.22% ±5.50%
misc/startup-core.js count=30 mode='process' script='test/fixtures/snapshot/typescript' *** 0.55 % ±0.05% ±0.06% ±0.08%
misc/startup-core.js count=30 mode='worker' script='benchmark/fixtures/require-builtins' -0.20 % ±0.23% ±0.31% ±0.40%
misc/startup-core.js count=30 mode='worker' script='test/fixtures/semicolon' 0.06 % ±0.37% ±0.49% ±0.65%
misc/startup-core.js count=30 mode='worker' script='test/fixtures/snapshot/typescript' 0.69 % ±0.85% ±1.13% ±1.47%```

[nodejs-github-bot]

Landed in 1aa8a78

[joyeecheung]

This is incorrect: the path should be converted to UTF-16 on windows if it's using std::filesystem::path, otherwise it could crash - this could be the cause of #56670

[joyeecheung]

It seems removing the fast API locally improves performance now (due to the handle scope creation, which would be necessary to get the Environment if this were to be implemented correctly e.g. to name spacing it using env->exec_path)

 confidence improvement accuracy (*) (**) (***)
misc/startup-cli-version.js n=30 cli='deps/corepack/dist/corepack.js' -0.16 % ±1.46% ±1.95% ±2.53%
misc/startup-cli-version.js n=30 cli='deps/npm/bin/npm-cli.js' ** 1.88 % ±1.32% ±1.76% ±2.29%
misc/startup-cli-version.js n=30 cli='deps/npm/bin/npx-cli.js' *** 2.37 % ±1.04% ±1.39% ±1.81%
misc/startup-cli-version.js n=30 cli='tools/eslint/node_modules/eslint/bin/eslint.js' -0.94 % ±1.12% ±1.49% ±1.94%
misc/startup-core.js n=30 mode='process' script='benchmark/fixtures/require-builtins' 0.68 % ±1.69% ±2.25% ±2.92%
misc/startup-core.js n=30 mode='process' script='test/fixtures/semicolon' 0.79 % ±1.08% ±1.44% ±1.88%
misc/startup-core.js n=30 mode='process' script='test/fixtures/snapshot/typescript' -0.21 % ±0.88% ±1.17% ±1.53%
misc/startup-core.js n=30 mode='worker' script='benchmark/fixtures/require-builtins' -0.29 % ±1.04% ±1.39% ±1.80%
misc/startup-core.js n=30 mode='worker' script='test/fixtures/semicolon' 2.43 % ±2.98% ±4.01% ±5.32%
misc/startup-core.js n=30 mode='worker' script='test/fixtures/snapshot/typescript' 0.12 % ±0.70% ±0.93% ±1.21%