Skip to content

esm: remove --no-import-harmony-assertions - #54890

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
syg:rm-import-assertions-flag
Sep 13, 2024
Merged

esm: remove --no-import-harmony-assertions#54890
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
syg:rm-import-assertions-flag

Conversation

@syg

@sygsyg commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

The flag is off by default now.

@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 11, 2024
@syg

syg commented Sep 11, 2024

Copy link
Copy Markdown
ContributorAuthor

cc @nicolo-ribaudo@joyeecheung

@codecov

codecovBot commented Sep 11, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (1d2603b) to head (7897b5e).
Report is 28 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #54890 +/- ##
==========================================
- Coverage 88.06% 88.06% -0.01% 
==========================================
Files 651 651 Lines 183386 183385 -1 Branches 35800 35798 -2 ==========================================
- Hits 161504 161496 -8 + Misses 15159 15157 -2 - Partials 6723 6732 +9
Files with missing linesCoverage Δ
src/node.cc73.71% <ø> (-0.04%)⬇️

... and 36 files with indirect coverage changes

@avivkelleravivkeller added v8 engine Issues and PRs related to the V8 dependency. esm Issues and PRs related to the ECMAScript Modules implementation. labels Sep 11, 2024
@avivkeller

avivkeller commented Sep 11, 2024

Copy link
Copy Markdown
Member

Hey, can you please amend your commit to be all lowercase? Thank you!

@aduh95aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Sep 11, 2024
@syg
sygforce-pushed the rm-import-assertions-flag branch from 71cceb3 to 7897b5eCompareSeptember 11, 2024 20:56
@sygsyg changed the title esm: Remove --no-import-harmony-assertionsesm: remove --no-import-harmony-assertionsSep 11, 2024
@syg

syg commented Sep 11, 2024

Copy link
Copy Markdown
ContributorAuthor

Hey, can you please amend your commit to be all lowercase? Thank you!

Done.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 11, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62339/

@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6188/

@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6188/

@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6188/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 8fd9093 into nodejs:mainSep 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2024

Copy link
Copy Markdown
Collaborator

Landed in 8fd9093

@aduh95aduh95 mentioned this pull request Oct 14, 2024
Merged
jkleinsc added a commit to electron/electron that referenced this pull request Oct 14, 2024
@jkleinsc
esm: remove --no-import-harmony-assertions
16df1dd
nodejs/node#54890
jkleinsc added a commit to electron/electron that referenced this pull request Oct 14, 2024
@jkleinsc
esm: remove --no-import-harmony-assertions
0949fc1
nodejs/node#54890
jkleinsc added a commit to electron/electron that referenced this pull request Oct 15, 2024
@electron-roller@nornagon
@deepak1556@jkleinsc
chore: bump chromium to 131.0.6776.0 (main) (#44137)
36b7cf3
* chore: bump chromium in DEPS to 131.0.6763.0
* chore: bump chromium in DEPS to 131.0.6764.0
* update patches
* chore: bump chromium in DEPS to 131.0.6766.0
* chore: update patches
* Use PathInfo in FileSystemAccess code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5872329
* Modernize image utilities.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905226
* [DevTools] move feature flags to the devtools directory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5913878
* chore: bump chromium in DEPS to 131.0.6768.0
* chore: update patches
* Remove experimental credshelper flags
Refs bazelbuild/reclient@4017a6c
* Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5917286
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905621
* chore: script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6770.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6772.0
* chore: update patches
* [UI] Add alias for mojo version of `MenuSourceType`
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5803393
* Update Background Color for Task Manager Refresh
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5875259
* chore: bump chromium in DEPS to 131.0.6774.0
* chore: bump chromium in DEPS to 131.0.6776.0
* chore: update patches
* chore: update filenames.libcxx.gni
* esm: remove --no-import-harmony-assertions
nodejs/node#54890
* 5507047: [import-attributes] Remove support for import assertions
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fixup: Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
* chore: bump chromium in DEPS to 131.0.6778.0
* Revert "chore: bump chromium in DEPS to 131.0.6778.0"
This reverts commit fb9092f.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024
@codebytere
esm: drop support for import assertions
dc38ada
nodejs/node#54890
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
@codebytere
esm: drop support for import assertions
4288807
nodejs/node#54890
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
@codebytere
esm: drop support for import assertions
6b71a09
nodejs/node#54890
yangannyx pushed a commit to yangannyx/electron that referenced this pull request Oct 21, 2024
@electron-roller@nornagon
@deepak1556@jkleinsc@yangannyx
chore: bump chromium to 131.0.6776.0 (main) (electron#44137)
822e2ab
* chore: bump chromium in DEPS to 131.0.6763.0
* chore: bump chromium in DEPS to 131.0.6764.0
* update patches
* chore: bump chromium in DEPS to 131.0.6766.0
* chore: update patches
* Use PathInfo in FileSystemAccess code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5872329
* Modernize image utilities.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905226
* [DevTools] move feature flags to the devtools directory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5913878
* chore: bump chromium in DEPS to 131.0.6768.0
* chore: update patches
* Remove experimental credshelper flags
Refs bazelbuild/reclient@4017a6c
* Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5917286
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905621
* chore: script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6770.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6772.0
* chore: update patches
* [UI] Add alias for mojo version of `MenuSourceType`
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5803393
* Update Background Color for Task Manager Refresh
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5875259
* chore: bump chromium in DEPS to 131.0.6774.0
* chore: bump chromium in DEPS to 131.0.6776.0
* chore: update patches
* chore: update filenames.libcxx.gni
* esm: remove --no-import-harmony-assertions
nodejs/node#54890
* 5507047: [import-attributes] Remove support for import assertions
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fixup: Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
* chore: bump chromium in DEPS to 131.0.6778.0
* Revert "chore: bump chromium in DEPS to 131.0.6778.0"
This reverts commit fb9092f.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
yangannyx pushed a commit to yangannyx/electron that referenced this pull request Oct 21, 2024
@electron-roller@nornagon
@deepak1556@jkleinsc@yangannyx
chore: bump chromium to 131.0.6776.0 (main) (electron#44137)
6308858
* chore: bump chromium in DEPS to 131.0.6763.0
* chore: bump chromium in DEPS to 131.0.6764.0
* update patches
* chore: bump chromium in DEPS to 131.0.6766.0
* chore: update patches
* Use PathInfo in FileSystemAccess code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5872329
* Modernize image utilities.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905226
* [DevTools] move feature flags to the devtools directory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5913878
* chore: bump chromium in DEPS to 131.0.6768.0
* chore: update patches
* Remove experimental credshelper flags
Refs bazelbuild/reclient@4017a6c
* Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5917286
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905621
* chore: script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6770.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6772.0
* chore: update patches
* [UI] Add alias for mojo version of `MenuSourceType`
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5803393
* Update Background Color for Task Manager Refresh
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5875259
* chore: bump chromium in DEPS to 131.0.6774.0
* chore: bump chromium in DEPS to 131.0.6776.0
* chore: update patches
* chore: update filenames.libcxx.gni
* esm: remove --no-import-harmony-assertions
nodejs/node#54890
* 5507047: [import-attributes] Remove support for import assertions
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fixup: Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
* chore: bump chromium in DEPS to 131.0.6778.0
* Revert "chore: bump chromium in DEPS to 131.0.6778.0"
This reverts commit fb9092f.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
yangannyx pushed a commit to yangannyx/electron that referenced this pull request Oct 21, 2024
@electron-roller@nornagon
@deepak1556@jkleinsc@yangannyx
chore: bump chromium to 131.0.6776.0 (main) (electron#44137)
02af664
* chore: bump chromium in DEPS to 131.0.6763.0
* chore: bump chromium in DEPS to 131.0.6764.0
* update patches
* chore: bump chromium in DEPS to 131.0.6766.0
* chore: update patches
* Use PathInfo in FileSystemAccess code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5872329
* Modernize image utilities.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905226
* [DevTools] move feature flags to the devtools directory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5913878
* chore: bump chromium in DEPS to 131.0.6768.0
* chore: update patches
* Remove experimental credshelper flags
Refs bazelbuild/reclient@4017a6c
* Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5917286
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905621
* chore: script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6770.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6772.0
* chore: update patches
* [UI] Add alias for mojo version of `MenuSourceType`
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5803393
* Update Background Color for Task Manager Refresh
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5875259
* chore: bump chromium in DEPS to 131.0.6774.0
* chore: bump chromium in DEPS to 131.0.6776.0
* chore: update patches
* chore: update filenames.libcxx.gni
* esm: remove --no-import-harmony-assertions
nodejs/node#54890
* 5507047: [import-attributes] Remove support for import assertions
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fixup: Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
* chore: bump chromium in DEPS to 131.0.6778.0
* Revert "chore: bump chromium in DEPS to 131.0.6778.0"
This reverts commit fb9092f.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024
@codebytere
esm: drop support for import assertions
6d6f05a
nodejs/node#54890
codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024
@codebytere
esm: drop support for import assertions
21c3acb
nodejs/node#54890
codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024
@codebytere
esm: drop support for import assertions
d3de7b6
nodejs/node#54890
codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024
@codebytere
esm: drop support for import assertions
92000a2
nodejs/node#54890
jkleinsc pushed a commit to electron/electron that referenced this pull request Nov 4, 2024
@codebytere
chore: bump Node.js to v22.9.0 (#44281)
c63d0d6
* chore: bump Node.js to v22.9.0
* build: drop base64 dep in GN build
nodejs/node#52856
* build,tools: make addons tests work with GN
nodejs/node#50737
* fs: add fast api for InternalModuleStat
nodejs/node#51344
* src: move package_json_reader cache to c++
nodejs/node#50322
* crypto: disable PKCS#1 padding for privateDecrypt
nodejs-private/node-private#525
* src: move more crypto code to ncrypto
nodejs/node#54320
* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey
nodejs/node#50234
* src: shift more crypto impl details to ncrypto
nodejs/node#54028
* src: switch crypto APIs to use Maybe<void>
nodejs/node#54775
* crypto: remove DEFAULT_ENCODING
nodejs/node#47182
* deps: update libuv to 1.47.0
nodejs/node#50650
* build: fix conflict gyp configs
nodejs/node#53605
* lib,src: drop --experimental-network-imports
nodejs/node#53822
* esm: align sync and async load implementations
nodejs/node#49152
* esm: remove unnecessary toNamespacedPath calls
nodejs/node#53656
* module: detect ESM syntax by trying to recompile as SourceTextModule
nodejs/node#52413
* test: adapt debugger tests to V8 11.4
nodejs/node#49639
* lib: update usage of always on Atomics API
nodejs/node#49639
* test: adapt test-fs-write to V8 internal changes
nodejs/node#49639
* test: adapt to new V8 trusted memory spaces
nodejs/node#50115
* deps: update libuv to 1.47.0
nodejs/node#50650
* src: use non-deprecated v8::Uint8Array::kMaxLength
nodejs/node#50115
* src: update default V8 platform to override functions with location
nodejs/node#51362
* src: add missing TryCatch
nodejs/node#51362
* lib,test: handle new Iterator global
nodejs/node#51362
* src: use non-deprecated version of CreateSyntheticModule
nodejs/node#50115
* src: remove calls to recently deprecated V8 APIs
nodejs/node#52996
* src: use new V8 API to define stream accessor
nodejs/node#53084
* src: do not use deprecated V8 API
nodejs/node#53084
* src: do not use soon-to-be-deprecated V8 API
nodejs/node#53174
* src: migrate to new V8 interceptors API
nodejs/node#52745
* src: use supported API to get stalled TLA messages
nodejs/node#51362
* module: print location of unsettled top-level await in entry points
nodejs/node#51999
* test: make snapshot comparison more flexible
nodejs/node#54375
* test: do not set concurrency on parallelized runs
nodejs/node#52177
* src: move FromNamespacedPath to path.cc
nodejs/node#53540
* test: adapt to new V8 trusted memory spaces
nodejs/node#50115
* build: add option to enable clang-cl on Windows
nodejs/node#52870
* chore: fixup patch indices
* chore: add/remove changed files
* esm: drop support for import assertions
nodejs/node#54890
* build: compile with C++20 support
nodejs/node#52838
* deps: update nghttp2 to 1.62.1
nodejs/node#52966
* src: parse inspector profiles with simdjson
nodejs/node#51783
* build: add GN build files
nodejs/node#47637
* deps,lib,src: add experimental web storage
nodejs/node#52435
* build: add missing BoringSSL dep
* src: rewrite task runner in c++
nodejs/node#52609
* fixup! build: add GN build files
* src: stop using deprecated fields of v8::FastApiCallbackOptions
nodejs/node#54077
* fix: shadow variable
* build: add back incorrectly removed SetAccessor patch
* fixup! fixup! build: add GN build files
* crypto: fix integer comparison in crypto for BoringSSL
* src,lib: reducing C++ calls of esm legacy main resolvenodejs/node#48325
* src: move more crypto_dh.cc code to ncrypto
nodejs/node#54459
* chore: fixup GN files for previous commit
* src: move more crypto code to ncrypto
nodejs/node#54320
* Fixup Perfetto ifdef guards
* fix: missing electron_natives dep
* fix: node_use_node_platform = false
* fix: include src/node_snapshot_stub.cc in libnode
* 5507047: [import-attributes] Remove support for import assertions
https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fix: restore v8-sandbox.h in filenames.json
* fix: re-add original-fs generation logic
* fix: ngtcp2 openssl dep
* test: try removing NAPI_VERSION undef
* chore(deps): bump @types/node
* src: move more crypto_dh.cc code to ncrypto
nodejs/node#54459
* esm: remove unnecessary toNamespacedPath calls
nodejs/node#53656
* buffer: fix out of range for toString
nodejs/node#54553
* lib: rewrite AsyncLocalStorage without async_hooks
nodejs/node#48528
* module: print amount of load time of a cjs module
nodejs/node#52213
* test: skip reproducible snapshot test on 32-bit
nodejs/node#53592
* fixup! src: move more crypto_dh.cc code to ncrypto
* test: adjust emittedUntil return type
* chore: remove redundant wpt streams patch
* fixup! chore(deps): bump @types/node
* fix: gn executable name on Windows
* fix: build on Windows
* fix: rename conflicting win32 symbols in //third_party/sqlite
On Windows otherwise we get:
lld-link: error: duplicate symbol: sqlite3_win32_write_debug
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_sleep
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_is_nt
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550
>>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj
* docs: remove unnecessary ts-expect-error after types bump
* src: move package resolver to c++
nodejs/node#50322
* build: set ASAN detect_container_overflow=0
nodejs/node#55584
* chore: fixup rebase
* test: disable failing ASAN test
* win: almost fix race detecting ESRCH in uv_kill
libuv/libuv#4341
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@syg@nodejs-github-bot@avivkeller@jasnell@lpinca@anonrig@aduh95