src: move more crypto_dh.cc code to ncrypto by jasnell · Pull Request #54459 · nodejs/node

jasnell · 2024-08-20T02:31:24Z

Moving more bits and pieces to ncrypto.

Unfortunately this is semver-major because it changes error codes in a couple of places. The change is worth it as it simplifies a few things and eliminates a special case error code that is only used in this one spot. This could be made semver-patch or semver-minor with a bit more work but it makes the API a bit more awkward. I'd rather not but if folks prefer it we can. No longer semver-major

While I'm at it, this makes a number of other cleanups along the way.

nodejs-github-bot · 2024-08-20T02:31:29Z

Review requested:

@nodejs/crypto
@nodejs/gyp
@nodejs/security-wg

mcollina

I fear making it semver-major will make backporting all of the ncrypto PR very hard/impossible.

An option is to mark all of them to not be backported on v22 (unless this ship has already sailed).

jasnell · 2024-08-20T14:20:33Z

Looks like part of the early ncrypto stuff is already in 22... sigh. Ok, let me go back and figure out how to make this non-semver-major.

jasnell · 2024-08-20T17:46:41Z

Ok, backed the error code changes out. Not super ideal but makes it semver-patch instead of major.

nodejs-github-bot · 2024-08-20T23:38:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61306/

mcollina · 2024-08-21T13:44:01Z

@jasnell can you update the PR description?

nodejs-github-bot · 2024-08-21T17:32:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61324/ 💛

Update deps/ncrypto/ncrypto.cc

Update deps/ncrypto/ncrypto.cc PR-URL: #54459 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

jasnell · 2024-08-27T14:27:28Z

Landed in 6bf7b6e

Update deps/ncrypto/ncrypto.cc PR-URL: #54459 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs/node#54459

* chore: bump Node.js to v22.9.0 * build: drop base64 dep in GN build nodejs/node#52856 * build,tools: make addons tests work with GN nodejs/node#50737 * fs: add fast api for InternalModuleStat nodejs/node#51344 * src: move package_json_reader cache to c++ nodejs/node#50322 * crypto: disable PKCS#1 padding for privateDecrypt nodejs-private/node-private#525 * src: move more crypto code to ncrypto nodejs/node#54320 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * src: shift more crypto impl details to ncrypto nodejs/node#54028 * src: switch crypto APIs to use Maybe<void> nodejs/node#54775 * crypto: remove DEFAULT_ENCODING nodejs/node#47182 * deps: update libuv to 1.47.0 nodejs/node#50650 * build: fix conflict gyp configs nodejs/node#53605 * lib,src: drop --experimental-network-imports nodejs/node#53822 * esm: align sync and async load implementations nodejs/node#49152 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * module: detect ESM syntax by trying to recompile as SourceTextModule nodejs/node#52413 * test: adapt debugger tests to V8 11.4 nodejs/node#49639 * lib: update usage of always on Atomics API nodejs/node#49639 * test: adapt test-fs-write to V8 internal changes nodejs/node#49639 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * deps: update libuv to 1.47.0 nodejs/node#50650 * src: use non-deprecated v8::Uint8Array::kMaxLength nodejs/node#50115 * src: update default V8 platform to override functions with location nodejs/node#51362 * src: add missing TryCatch nodejs/node#51362 * lib,test: handle new Iterator global nodejs/node#51362 * src: use non-deprecated version of CreateSyntheticModule nodejs/node#50115 * src: remove calls to recently deprecated V8 APIs nodejs/node#52996 * src: use new V8 API to define stream accessor nodejs/node#53084 * src: do not use deprecated V8 API nodejs/node#53084 * src: do not use soon-to-be-deprecated V8 API nodejs/node#53174 * src: migrate to new V8 interceptors API nodejs/node#52745 * src: use supported API to get stalled TLA messages nodejs/node#51362 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * test: make snapshot comparison more flexible nodejs/node#54375 * test: do not set concurrency on parallelized runs nodejs/node#52177 * src: move FromNamespacedPath to path.cc nodejs/node#53540 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * build: add option to enable clang-cl on Windows nodejs/node#52870 * chore: fixup patch indices * chore: add/remove changed files * esm: drop support for import assertions nodejs/node#54890 * build: compile with C++20 support nodejs/node#52838 * deps: update nghttp2 to 1.62.1 nodejs/node#52966 * src: parse inspector profiles with simdjson nodejs/node#51783 * build: add GN build files nodejs/node#47637 * deps,lib,src: add experimental web storage nodejs/node#52435 * build: add missing BoringSSL dep * src: rewrite task runner in c++ nodejs/node#52609 * fixup! build: add GN build files * src: stop using deprecated fields of v8::FastApiCallbackOptions nodejs/node#54077 * fix: shadow variable * build: add back incorrectly removed SetAccessor patch * fixup! fixup! build: add GN build files * crypto: fix integer comparison in crypto for BoringSSL * src,lib: reducing C++ calls of esm legacy main resolvenodejs/node#48325 * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * chore: fixup GN files for previous commit * src: move more crypto code to ncrypto nodejs/node#54320 * Fixup Perfetto ifdef guards * fix: missing electron_natives dep * fix: node_use_node_platform = false * fix: include src/node_snapshot_stub.cc in libnode * 5507047: [import-attributes] Remove support for import assertions https://chromium-review.googlesource.com/c/v8/v8/+/5507047 * fix: restore v8-sandbox.h in filenames.json * fix: re-add original-fs generation logic * fix: ngtcp2 openssl dep * test: try removing NAPI_VERSION undef * chore(deps): bump @types/node * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * buffer: fix out of range for toString nodejs/node#54553 * lib: rewrite AsyncLocalStorage without async_hooks nodejs/node#48528 * module: print amount of load time of a cjs module nodejs/node#52213 * test: skip reproducible snapshot test on 32-bit nodejs/node#53592 * fixup! src: move more crypto_dh.cc code to ncrypto * test: adjust emittedUntil return type * chore: remove redundant wpt streams patch * fixup! chore(deps): bump @types/node * fix: gn executable name on Windows * fix: build on Windows * fix: rename conflicting win32 symbols in //third_party/sqlite On Windows otherwise we get: lld-link: error: duplicate symbol: sqlite3_win32_write_debug >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_sleep >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_is_nt >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj * docs: remove unnecessary ts-expect-error after types bump * src: move package resolver to c++ nodejs/node#50322 * build: set ASAN detect_container_overflow=0 nodejs/node#55584 * chore: fixup rebase * test: disable failing ASAN test * win: almost fix race detecting ESRCH in uv_kill libuv/libuv#4341

Update ncrypto.cc PR-URL: nodejs/node#54459 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 20, 2024

jasnell requested review from anonrig, mcollina and tniessen August 20, 2024 02:31

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 20, 2024

jasnell commented Aug 20, 2024
View reviewed changes

Comment threaddeps/ncrypto/ncrypto.cc Outdated

This comment was marked as outdated.
Sign in to view

anonrig approved these changes Aug 20, 2024
View reviewed changes

Comment threaddeps/ncrypto/ncrypto.cc Outdated

mcollina reviewed Aug 20, 2024
View reviewed changes

jasnell force-pushed the ncrypto-dh branch from 079ff81 to fe1bfa1Compare August 20, 2024 17:45

jasnell commented Aug 20, 2024
View reviewed changes

Comment threadtest/parallel/test-crypto-dh-errors.js Outdated

jasnell commented Aug 20, 2024
View reviewed changes

Comment threadtest/parallel/test-crypto-dh-errors.js Outdated

jasnell removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 20, 2024

jasnell requested review from anonrig and mcollina August 20, 2024 17:46

This comment was marked as outdated.
Sign in to view

jasnell added the crypto Issues and PRs related to the crypto subsystem. label Aug 20, 2024

This comment was marked as outdated.
Sign in to view

jasnell force-pushed the ncrypto-dh branch from 8547a56 to 5fd8d18Compare August 20, 2024 21:02

This comment was marked as outdated.
Sign in to view

jasnell force-pushed the ncrypto-dh branch from 8daec99 to b8cd634Compare August 20, 2024 23:38

This comment was marked as outdated.
Sign in to view

jasnell removed the needs-ci PRs that need a full CI run. label Aug 21, 2024

anonrig approved these changes Aug 23, 2024
View reviewed changes

jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 23, 2024

src: move more crypto_dh.cc code to ncrypto
fcdb2fd
Update deps/ncrypto/ncrypto.cc

jasnell force-pushed the ncrypto-dh branch from b8cd634 to fcdb2fdCompare August 26, 2024 19:23

anonrig approved these changes Aug 26, 2024
View reviewed changes

jasnell added a commit that referenced this pull request Aug 27, 2024
src: move more crypto_dh.cc code to ncrypto
6bf7b6e
Update deps/ncrypto/ncrypto.cc PR-URL: #54459 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

jasnell closed this Aug 27, 2024

RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
src: move more crypto_dh.cc code to ncrypto
101e299
Update deps/ncrypto/ncrypto.cc PR-URL: #54459 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS mentioned this pull request Aug 30, 2024
v22.8.0 proposal #54560
Merged

targos added the dont-land-on-v20.x label Sep 22, 2024

codebytere added a commit to electron/electron that referenced this pull request Oct 18, 2024
src: move more crypto_dh.cc code to ncrypto
aa4a631
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
src: move more crypto_dh.cc code to ncrypto
57d7455
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
src: move more crypto_dh.cc code to ncrypto
a2a358b
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024
src: move more crypto_dh.cc code to ncrypto
e72192e
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024
src: move more crypto_dh.cc code to ncrypto
d6ca70d
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024
src: move more crypto_dh.cc code to ncrypto
7386e4a
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024
src: move more crypto_dh.cc code to ncrypto
c7ef768
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024
src: move more crypto_dh.cc code to ncrypto
1f5b926
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024
src: move more crypto_dh.cc code to ncrypto
4d7adf0
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024
src: move more crypto_dh.cc code to ncrypto
1ccc3d6
nodejs/node#54459

codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024
src: move more crypto_dh.cc code to ncrypto
e5f6644
nodejs/node#54459

npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 18, 2025
src: move more crypto_dh.cc code to ncrypto
d3c43e3
Update ncrypto.cc PR-URL: nodejs/node#54459 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Uh oh!

Uh oh!

Conversation

jasnell commented Aug 20, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 20, 2024

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Aug 20, 2024

Uh oh!

Uh oh!

Uh oh!

jasnell commented Aug 20, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 20, 2024

Uh oh!

mcollina commented Aug 21, 2024

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Aug 21, 2024• edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Aug 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jasnell commented Aug 20, 2024•
edited
Loading

nodejs-github-bot commented Aug 21, 2024•
edited by jasnell
Loading