node-api: Add node_api_create_object_with_properties method

[miguelmarcondesf]

Attempt to closeIssue

Exposing a new node_api_create_object_with_properties allows the API to be agnostic to a specific engine API while still being optimized.

Benchmark is created with 20 properties:

./node benchmark/napi/create_object_with_properties/index.js method=old
n=100000
napi/create_object_with_properties/index.js method="old" n=100: 537,995.9650302622
napi/create_object_with_properties/index.js method="old" n=1000: 521,048.2657429523
napi/create_object_with_properties/index.js method="old" n=10000: 522,675.38294073264
napi/create_object_with_properties/index.js method="old" n=100000: 406,313.9844216699
napi/create_object_with_properties/index.js method="old" n=1000000: 406,063.06305714406
./node benchmark/napi/create_object_with_properties/index.js method=new
n=100000
napi/create_object_with_properties/index.js method="new" n=100: 2,016,820.281144747
napi/create_object_with_properties/index.js method="new" n=1000: 2,978,042.8897736985
napi/create_object_with_properties/index.js method="new" n=10000: 2,446,408.366716614
napi/create_object_with_properties/index.js method="new" n=100000: 1,496,462.73620729
napi/create_object_with_properties/index.js method="new" n=1000000: 807,987.1416409168

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/node-api
• @nodejs/performance

[codecov]

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.58%. Comparing base (2388088) to head (000bfe7).
⚠️ Report is 740 commits behind head on main.

Files with missing lines	Patch %	Lines
src/js_native_api_v8.cc	79.31%	0 Missing and 6 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #59953 +/- ##
==========================================
+ Coverage 88.44% 88.58% +0.14% 
==========================================
Files 703 704 +1 Lines 207401 208354 +953 Branches 39993 40046 +53 ==========================================
+ Hits 183433 184577 +1144 + Misses 15941 15800 -141 + Partials 8027 7977 -50 

Files with missing lines	Coverage Δ
src/js_native_api_v8.cc	76.54% <79.31%> (+0.04%)	⬆️

... and 150 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[legendecas]

Overall LGTM % nits. Thanks for working on this!

[KevinEady]

Do you need to define a HAS_X macro eg. NODE_API_EXPERIMENTAL_HAS_CREATE_OBJECT_WITH_PROPERTIES? We do it eg. here:

node/src/js_native_api.h

Lines 550 to 559 in 71f5b1c

	#ifdefNAPI_EXPERIMENTAL
	#defineNODE_API_EXPERIMENTAL_HAS_POST_FINALIZER
	NAPI_EXTERNnapi_statusNAPI_CDECL
	node_api_post_finalizer(node_api_basic_envenv,
	napi_finalizefinalize_cb,
	void*finalize_data,
	void*finalize_hint);
	#endif// NAPI_EXPERIMENTAL

and eg. here:

node/src/js_native_api.h

Lines 489 to 495 in 71f5b1c

	#ifdefNAPI_EXPERIMENTAL
	#defineNODE_API_EXPERIMENTAL_HAS_SHAREDARRAYBUFFER
	NAPI_EXTERNnapi_statusNAPI_CDECL
	node_api_is_sharedarraybuffer(napi_envenv, napi_valuevalue, bool*result);
	NAPI_EXTERNnapi_statusNAPI_CDECLnode_api_create_sharedarraybuffer(
	napi_envenv, size_tbyte_length, void**data, napi_value*result);
	#endif// NAPI_EXPERIMENTAL

I believe this is needed in order to add support to node-addon-api while the feature is still in experimental state.

[nodejs-github-bot]

Landed in a556db4

[legendecas]

@vmoroz mentioned that the new name convention is node_api_. Given that this is a new api, this should also follow the new name convention.

@vmoroz is volunteered to submit a PR to fix this.

[legendecas]

This should be blocked on backporting until #61319 landed.