feat(web): add PageUp/PageDown chat navigation - #9315

Merged
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation
Sep 3, 2026
Merged

feat(web): add PageUp/PageDown chat navigation#9315
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Added PageUp/PageDown keyboard navigation for the chat timeline.
  • Added a shared page-scroll controller with focused tests for scroll behavior and boundaries.
  • Updated the composer and chat components to coordinate keyboard navigation with the message timeline.
  • Removed obsolete environment machine icons, settings, contracts, and related legacy code.

Why

Chat users can now move through long conversations one viewport at a time without relying on the mouse or scrollbar. The scrolling logic is isolated and tested so navigation remains predictable at the start and end of the timeline.

UI Changes

  • Added keyboard-driven PageUp/PageDown navigation in the web chat view.
  • No screenshots or video included; the interaction is keyboard-based and does not add animation.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes timeline scroll and live-follow opt-out behavior on PageUp; a noted edge case can disable follow without an actual upward scroll when already at the top of an overflowing anchored view.

Overview
Adds keyboard PageUp/PageDown navigation for the message timeline when the chat composer is focused, so users can move through long threads without the mouse.

A new pageScrollController drives the timeline list: one viewport per tap (with easing), hold-to-repeat scrolling that ramps speed, boundary checks, and bottom padding from the composer overlay height. getTimelinePageScrollKey keeps Page keys on the composer while its textarea can still scroll, then hands off to the timeline at the editor edge (including IME/modifier guards).

ChatView mounts the controller on the timeline scroll node and wires key down/up/release from ChatComposerComposerPromptEditor. Starting a timeline PageUp scroll can cancel timeline live-follow when content overflows the viewport, matching manual navigation elsewhere.

Unit tests cover composer handoff, scroll distance/velocity, tap vs hold, and boundary no-ops.

Reviewed by Cursor Bugbot for commit 9bebc8b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add PageUp/PageDown animated timeline scrolling to chat view

  • Adds createPageScrollController in pageScrollController.ts to animate tap-page scrolls and delayed, accelerating continuous scrolling when PageUp or PageDown is held. Scrolling stops on key-up, blur, direction change, boundary, or disposal.
  • Wires the controller through ChatViewContentChatComposerComposerPromptEditor so that unmodified PageUp/PageDown presses at a composer scroll boundary are delegated to the timeline, while non-boundary presses keep native composer scrolling. An accepted PageUp also cancels timeline live-follow.
  • Page distance is computed from viewport height minus a 36-pixel alignment offset and composer overlay padding. Held scrolling ramps linearly to a 2× multiplier over 400 ms. Boundary requests within a one-pixel tolerance are rejected.
  • Risk: getTimelinePageScrollKey classifies which key presses are delegated; if composer scroll-position detection is inaccurate, PageUp/PageDown may be stolen from or inappropriately handed back to the editor. Verify canScrollInDirection against fractional-pixel scroll positions in the target browsers.

Macroscope summarized 9bebc8b.

- Scroll the chat timeline from the composer
- Support smooth scrolling, key holds, and acceleration
- Add focused controller tests
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.5 KiB13.2 KiB−249 B (−1.8%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−249 B (−3.7%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.5 KiB+174 B (+1.3%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+8 B (+0.1%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.6 KiB+166 B (+2.5%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB57.8 KiB+1.4 KiB (+2.5%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 9409dd2 · PR result: 9bebc8b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadapps/web/src/components/ComposerPromptEditor.tsx
Comment threadapps/web/src/components/chat/pageScrollController.ts
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new default chat interaction spanning the composer and timeline, including custom animated scrolling, held-key acceleration, and live-follow coordination. Its production-path behavior and cross-component integration exceed a small self-contained change and merit human review.

You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/components/chat/pageScrollController.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 99da696. Configure here.

Comment threadapps/web/src/components/chat/pageScrollController.ts
- Ignore PageUp/PageDown when the editor is within 1px of its boundary
- Add regression coverage for fractional scroll positions
Comment threadapps/web/src/components/chat/pageScrollController.ts
@Yash-Singh1
Yash-Singh1 merged commit 5f84efa into mainSep 3, 2026
27 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/chat-page-navigation branch September 3, 2026 04:12
@Yash-Singh1
Yash-Singh1 restored the t3code/chat-page-navigation branch September 3, 2026 04:12
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(web): add PageUp/PageDown chat navigation - #9315

Merged
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation
Sep 3, 2026
Merged

feat(web): add PageUp/PageDown chat navigation#9315
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Added PageUp/PageDown keyboard navigation for the chat timeline.
  • Added a shared page-scroll controller with focused tests for scroll behavior and boundaries.
  • Updated the composer and chat components to coordinate keyboard navigation with the message timeline.
  • Removed obsolete environment machine icons, settings, contracts, and related legacy code.

Why

Chat users can now move through long conversations one viewport at a time without relying on the mouse or scrollbar. The scrolling logic is isolated and tested so navigation remains predictable at the start and end of the timeline.

UI Changes

  • Added keyboard-driven PageUp/PageDown navigation in the web chat view.
  • No screenshots or video included; the interaction is keyboard-based and does not add animation.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes timeline scroll and live-follow opt-out behavior on PageUp; a noted edge case can disable follow without an actual upward scroll when already at the top of an overflowing anchored view.

Overview
Adds keyboard PageUp/PageDown navigation for the message timeline when the chat composer is focused, so users can move through long threads without the mouse.

A new pageScrollController drives the timeline list: one viewport per tap (with easing), hold-to-repeat scrolling that ramps speed, boundary checks, and bottom padding from the composer overlay height. getTimelinePageScrollKey keeps Page keys on the composer while its textarea can still scroll, then hands off to the timeline at the editor edge (including IME/modifier guards).

ChatView mounts the controller on the timeline scroll node and wires key down/up/release from ChatComposerComposerPromptEditor. Starting a timeline PageUp scroll can cancel timeline live-follow when content overflows the viewport, matching manual navigation elsewhere.

Unit tests cover composer handoff, scroll distance/velocity, tap vs hold, and boundary no-ops.

Reviewed by Cursor Bugbot for commit 9bebc8b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add PageUp/PageDown animated timeline scrolling to chat view

  • Adds createPageScrollController in pageScrollController.ts to animate tap-page scrolls and delayed, accelerating continuous scrolling when PageUp or PageDown is held. Scrolling stops on key-up, blur, direction change, boundary, or disposal.
  • Wires the controller through ChatViewContentChatComposerComposerPromptEditor so that unmodified PageUp/PageDown presses at a composer scroll boundary are delegated to the timeline, while non-boundary presses keep native composer scrolling. An accepted PageUp also cancels timeline live-follow.
  • Page distance is computed from viewport height minus a 36-pixel alignment offset and composer overlay padding. Held scrolling ramps linearly to a 2× multiplier over 400 ms. Boundary requests within a one-pixel tolerance are rejected.
  • Risk: getTimelinePageScrollKey classifies which key presses are delegated; if composer scroll-position detection is inaccurate, PageUp/PageDown may be stolen from or inappropriately handed back to the editor. Verify canScrollInDirection against fractional-pixel scroll positions in the target browsers.

Macroscope summarized 9bebc8b.

- Scroll the chat timeline from the composer
- Support smooth scrolling, key holds, and acceleration
- Add focused controller tests
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.5 KiB13.2 KiB−249 B (−1.8%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−249 B (−3.7%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.5 KiB+174 B (+1.3%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+8 B (+0.1%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.6 KiB+166 B (+2.5%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB57.8 KiB+1.4 KiB (+2.5%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 9409dd2 · PR result: 9bebc8b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadapps/web/src/components/ComposerPromptEditor.tsx
Comment threadapps/web/src/components/chat/pageScrollController.ts
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new default chat interaction spanning the composer and timeline, including custom animated scrolling, held-key acceleration, and live-follow coordination. Its production-path behavior and cross-component integration exceed a small self-contained change and merit human review.

You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/components/chat/pageScrollController.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 99da696. Configure here.

Comment threadapps/web/src/components/chat/pageScrollController.ts
- Ignore PageUp/PageDown when the editor is within 1px of its boundary
- Add regression coverage for fractional scroll positions
Comment threadapps/web/src/components/chat/pageScrollController.ts
@Yash-Singh1
Yash-Singh1 merged commit 5f84efa into mainSep 3, 2026
27 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/chat-page-navigation branch September 3, 2026 04:12
@Yash-Singh1
Yash-Singh1 restored the t3code/chat-page-navigation branch September 3, 2026 04:12
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): add PageUp/PageDown chat navigation - #9315

Merged
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation
Sep 3, 2026
Merged

feat(web): add PageUp/PageDown chat navigation#9315
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Added PageUp/PageDown keyboard navigation for the chat timeline.
  • Added a shared page-scroll controller with focused tests for scroll behavior and boundaries.
  • Updated the composer and chat components to coordinate keyboard navigation with the message timeline.
  • Removed obsolete environment machine icons, settings, contracts, and related legacy code.

Why

Chat users can now move through long conversations one viewport at a time without relying on the mouse or scrollbar. The scrolling logic is isolated and tested so navigation remains predictable at the start and end of the timeline.

UI Changes

  • Added keyboard-driven PageUp/PageDown navigation in the web chat view.
  • No screenshots or video included; the interaction is keyboard-based and does not add animation.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes timeline scroll and live-follow opt-out behavior on PageUp; a noted edge case can disable follow without an actual upward scroll when already at the top of an overflowing anchored view.

Overview
Adds keyboard PageUp/PageDown navigation for the message timeline when the chat composer is focused, so users can move through long threads without the mouse.

A new pageScrollController drives the timeline list: one viewport per tap (with easing), hold-to-repeat scrolling that ramps speed, boundary checks, and bottom padding from the composer overlay height. getTimelinePageScrollKey keeps Page keys on the composer while its textarea can still scroll, then hands off to the timeline at the editor edge (including IME/modifier guards).

ChatView mounts the controller on the timeline scroll node and wires key down/up/release from ChatComposerComposerPromptEditor. Starting a timeline PageUp scroll can cancel timeline live-follow when content overflows the viewport, matching manual navigation elsewhere.

Unit tests cover composer handoff, scroll distance/velocity, tap vs hold, and boundary no-ops.

Reviewed by Cursor Bugbot for commit 9bebc8b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add PageUp/PageDown animated timeline scrolling to chat view

  • Adds createPageScrollController in pageScrollController.ts to animate tap-page scrolls and delayed, accelerating continuous scrolling when PageUp or PageDown is held. Scrolling stops on key-up, blur, direction change, boundary, or disposal.
  • Wires the controller through ChatViewContentChatComposerComposerPromptEditor so that unmodified PageUp/PageDown presses at a composer scroll boundary are delegated to the timeline, while non-boundary presses keep native composer scrolling. An accepted PageUp also cancels timeline live-follow.
  • Page distance is computed from viewport height minus a 36-pixel alignment offset and composer overlay padding. Held scrolling ramps linearly to a 2× multiplier over 400 ms. Boundary requests within a one-pixel tolerance are rejected.
  • Risk: getTimelinePageScrollKey classifies which key presses are delegated; if composer scroll-position detection is inaccurate, PageUp/PageDown may be stolen from or inappropriately handed back to the editor. Verify canScrollInDirection against fractional-pixel scroll positions in the target browsers.

Macroscope summarized 9bebc8b.

- Scroll the chat timeline from the composer
- Support smooth scrolling, key holds, and acceleration
- Add focused controller tests
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.5 KiB13.2 KiB−249 B (−1.8%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−249 B (−3.7%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.5 KiB+174 B (+1.3%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+8 B (+0.1%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.6 KiB+166 B (+2.5%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB57.8 KiB+1.4 KiB (+2.5%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 9409dd2 · PR result: 9bebc8b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadapps/web/src/components/ComposerPromptEditor.tsx
Comment threadapps/web/src/components/chat/pageScrollController.ts
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new default chat interaction spanning the composer and timeline, including custom animated scrolling, held-key acceleration, and live-follow coordination. Its production-path behavior and cross-component integration exceed a small self-contained change and merit human review.

You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/components/chat/pageScrollController.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 99da696. Configure here.

Comment threadapps/web/src/components/chat/pageScrollController.ts
- Ignore PageUp/PageDown when the editor is within 1px of its boundary
- Add regression coverage for fractional scroll positions
Comment threadapps/web/src/components/chat/pageScrollController.ts
@Yash-Singh1
Yash-Singh1 merged commit 5f84efa into mainSep 3, 2026
27 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/chat-page-navigation branch September 3, 2026 04:12
@Yash-Singh1
Yash-Singh1 restored the t3code/chat-page-navigation branch September 3, 2026 04:12
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): add PageUp/PageDown chat navigation - #9315

Merged
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation
Sep 3, 2026
Merged

feat(web): add PageUp/PageDown chat navigation#9315
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Added PageUp/PageDown keyboard navigation for the chat timeline.
  • Added a shared page-scroll controller with focused tests for scroll behavior and boundaries.
  • Updated the composer and chat components to coordinate keyboard navigation with the message timeline.
  • Removed obsolete environment machine icons, settings, contracts, and related legacy code.

Why

Chat users can now move through long conversations one viewport at a time without relying on the mouse or scrollbar. The scrolling logic is isolated and tested so navigation remains predictable at the start and end of the timeline.

UI Changes

  • Added keyboard-driven PageUp/PageDown navigation in the web chat view.
  • No screenshots or video included; the interaction is keyboard-based and does not add animation.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes timeline scroll and live-follow opt-out behavior on PageUp; a noted edge case can disable follow without an actual upward scroll when already at the top of an overflowing anchored view.

Overview
Adds keyboard PageUp/PageDown navigation for the message timeline when the chat composer is focused, so users can move through long threads without the mouse.

A new pageScrollController drives the timeline list: one viewport per tap (with easing), hold-to-repeat scrolling that ramps speed, boundary checks, and bottom padding from the composer overlay height. getTimelinePageScrollKey keeps Page keys on the composer while its textarea can still scroll, then hands off to the timeline at the editor edge (including IME/modifier guards).

ChatView mounts the controller on the timeline scroll node and wires key down/up/release from ChatComposerComposerPromptEditor. Starting a timeline PageUp scroll can cancel timeline live-follow when content overflows the viewport, matching manual navigation elsewhere.

Unit tests cover composer handoff, scroll distance/velocity, tap vs hold, and boundary no-ops.

Reviewed by Cursor Bugbot for commit 9bebc8b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add PageUp/PageDown animated timeline scrolling to chat view

  • Adds createPageScrollController in pageScrollController.ts to animate tap-page scrolls and delayed, accelerating continuous scrolling when PageUp or PageDown is held. Scrolling stops on key-up, blur, direction change, boundary, or disposal.
  • Wires the controller through ChatViewContentChatComposerComposerPromptEditor so that unmodified PageUp/PageDown presses at a composer scroll boundary are delegated to the timeline, while non-boundary presses keep native composer scrolling. An accepted PageUp also cancels timeline live-follow.
  • Page distance is computed from viewport height minus a 36-pixel alignment offset and composer overlay padding. Held scrolling ramps linearly to a 2× multiplier over 400 ms. Boundary requests within a one-pixel tolerance are rejected.
  • Risk: getTimelinePageScrollKey classifies which key presses are delegated; if composer scroll-position detection is inaccurate, PageUp/PageDown may be stolen from or inappropriately handed back to the editor. Verify canScrollInDirection against fractional-pixel scroll positions in the target browsers.

Macroscope summarized 9bebc8b.

- Scroll the chat timeline from the composer
- Support smooth scrolling, key holds, and acceleration
- Add focused controller tests
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.5 KiB13.2 KiB−249 B (−1.8%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−249 B (−3.7%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.5 KiB+174 B (+1.3%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+8 B (+0.1%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.6 KiB+166 B (+2.5%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB57.8 KiB+1.4 KiB (+2.5%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 9409dd2 · PR result: 9bebc8b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadapps/web/src/components/ComposerPromptEditor.tsx
Comment threadapps/web/src/components/chat/pageScrollController.ts
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new default chat interaction spanning the composer and timeline, including custom animated scrolling, held-key acceleration, and live-follow coordination. Its production-path behavior and cross-component integration exceed a small self-contained change and merit human review.

You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/components/chat/pageScrollController.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 99da696. Configure here.

Comment threadapps/web/src/components/chat/pageScrollController.ts
- Ignore PageUp/PageDown when the editor is within 1px of its boundary
- Add regression coverage for fractional scroll positions
Comment threadapps/web/src/components/chat/pageScrollController.ts
@Yash-Singh1
Yash-Singh1 merged commit 5f84efa into mainSep 3, 2026
27 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/chat-page-navigation branch September 3, 2026 04:12
@Yash-Singh1
Yash-Singh1 restored the t3code/chat-page-navigation branch September 3, 2026 04:12
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(web): add PageUp/PageDown chat navigation - #9315

Merged
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation
Sep 3, 2026
Merged

feat(web): add PageUp/PageDown chat navigation#9315
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Added PageUp/PageDown keyboard navigation for the chat timeline.
  • Added a shared page-scroll controller with focused tests for scroll behavior and boundaries.
  • Updated the composer and chat components to coordinate keyboard navigation with the message timeline.
  • Removed obsolete environment machine icons, settings, contracts, and related legacy code.

Why

Chat users can now move through long conversations one viewport at a time without relying on the mouse or scrollbar. The scrolling logic is isolated and tested so navigation remains predictable at the start and end of the timeline.

UI Changes

  • Added keyboard-driven PageUp/PageDown navigation in the web chat view.
  • No screenshots or video included; the interaction is keyboard-based and does not add animation.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes timeline scroll and live-follow opt-out behavior on PageUp; a noted edge case can disable follow without an actual upward scroll when already at the top of an overflowing anchored view.

Overview
Adds keyboard PageUp/PageDown navigation for the message timeline when the chat composer is focused, so users can move through long threads without the mouse.

A new pageScrollController drives the timeline list: one viewport per tap (with easing), hold-to-repeat scrolling that ramps speed, boundary checks, and bottom padding from the composer overlay height. getTimelinePageScrollKey keeps Page keys on the composer while its textarea can still scroll, then hands off to the timeline at the editor edge (including IME/modifier guards).

ChatView mounts the controller on the timeline scroll node and wires key down/up/release from ChatComposerComposerPromptEditor. Starting a timeline PageUp scroll can cancel timeline live-follow when content overflows the viewport, matching manual navigation elsewhere.

Unit tests cover composer handoff, scroll distance/velocity, tap vs hold, and boundary no-ops.

Reviewed by Cursor Bugbot for commit 9bebc8b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add PageUp/PageDown animated timeline scrolling to chat view

  • Adds createPageScrollController in pageScrollController.ts to animate tap-page scrolls and delayed, accelerating continuous scrolling when PageUp or PageDown is held. Scrolling stops on key-up, blur, direction change, boundary, or disposal.
  • Wires the controller through ChatViewContentChatComposerComposerPromptEditor so that unmodified PageUp/PageDown presses at a composer scroll boundary are delegated to the timeline, while non-boundary presses keep native composer scrolling. An accepted PageUp also cancels timeline live-follow.
  • Page distance is computed from viewport height minus a 36-pixel alignment offset and composer overlay padding. Held scrolling ramps linearly to a 2× multiplier over 400 ms. Boundary requests within a one-pixel tolerance are rejected.
  • Risk: getTimelinePageScrollKey classifies which key presses are delegated; if composer scroll-position detection is inaccurate, PageUp/PageDown may be stolen from or inappropriately handed back to the editor. Verify canScrollInDirection against fractional-pixel scroll positions in the target browsers.

Macroscope summarized 9bebc8b.

- Scroll the chat timeline from the composer
- Support smooth scrolling, key holds, and acceleration
- Add focused controller tests
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.5 KiB13.2 KiB−249 B (−1.8%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−249 B (−3.7%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.5 KiB+174 B (+1.3%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+8 B (+0.1%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.6 KiB+166 B (+2.5%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB57.8 KiB+1.4 KiB (+2.5%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 9409dd2 · PR result: 9bebc8b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadapps/web/src/components/ComposerPromptEditor.tsx
Comment threadapps/web/src/components/chat/pageScrollController.ts
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new default chat interaction spanning the composer and timeline, including custom animated scrolling, held-key acceleration, and live-follow coordination. Its production-path behavior and cross-component integration exceed a small self-contained change and merit human review.

You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/components/chat/pageScrollController.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 99da696. Configure here.

Comment threadapps/web/src/components/chat/pageScrollController.ts
- Ignore PageUp/PageDown when the editor is within 1px of its boundary
- Add regression coverage for fractional scroll positions
Comment threadapps/web/src/components/chat/pageScrollController.ts
@Yash-Singh1
Yash-Singh1 merged commit 5f84efa into mainSep 3, 2026
27 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/chat-page-navigation branch September 3, 2026 04:12
@Yash-Singh1
Yash-Singh1 restored the t3code/chat-page-navigation branch September 3, 2026 04:12
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): add PageUp/PageDown chat navigation - #9315

Merged
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation
Sep 3, 2026
Merged

feat(web): add PageUp/PageDown chat navigation#9315
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Added PageUp/PageDown keyboard navigation for the chat timeline.
  • Added a shared page-scroll controller with focused tests for scroll behavior and boundaries.
  • Updated the composer and chat components to coordinate keyboard navigation with the message timeline.
  • Removed obsolete environment machine icons, settings, contracts, and related legacy code.

Why

Chat users can now move through long conversations one viewport at a time without relying on the mouse or scrollbar. The scrolling logic is isolated and tested so navigation remains predictable at the start and end of the timeline.

UI Changes

  • Added keyboard-driven PageUp/PageDown navigation in the web chat view.
  • No screenshots or video included; the interaction is keyboard-based and does not add animation.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes timeline scroll and live-follow opt-out behavior on PageUp; a noted edge case can disable follow without an actual upward scroll when already at the top of an overflowing anchored view.

Overview
Adds keyboard PageUp/PageDown navigation for the message timeline when the chat composer is focused, so users can move through long threads without the mouse.

A new pageScrollController drives the timeline list: one viewport per tap (with easing), hold-to-repeat scrolling that ramps speed, boundary checks, and bottom padding from the composer overlay height. getTimelinePageScrollKey keeps Page keys on the composer while its textarea can still scroll, then hands off to the timeline at the editor edge (including IME/modifier guards).

ChatView mounts the controller on the timeline scroll node and wires key down/up/release from ChatComposerComposerPromptEditor. Starting a timeline PageUp scroll can cancel timeline live-follow when content overflows the viewport, matching manual navigation elsewhere.

Unit tests cover composer handoff, scroll distance/velocity, tap vs hold, and boundary no-ops.

Reviewed by Cursor Bugbot for commit 9bebc8b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add PageUp/PageDown animated timeline scrolling to chat view

  • Adds createPageScrollController in pageScrollController.ts to animate tap-page scrolls and delayed, accelerating continuous scrolling when PageUp or PageDown is held. Scrolling stops on key-up, blur, direction change, boundary, or disposal.
  • Wires the controller through ChatViewContentChatComposerComposerPromptEditor so that unmodified PageUp/PageDown presses at a composer scroll boundary are delegated to the timeline, while non-boundary presses keep native composer scrolling. An accepted PageUp also cancels timeline live-follow.
  • Page distance is computed from viewport height minus a 36-pixel alignment offset and composer overlay padding. Held scrolling ramps linearly to a 2× multiplier over 400 ms. Boundary requests within a one-pixel tolerance are rejected.
  • Risk: getTimelinePageScrollKey classifies which key presses are delegated; if composer scroll-position detection is inaccurate, PageUp/PageDown may be stolen from or inappropriately handed back to the editor. Verify canScrollInDirection against fractional-pixel scroll positions in the target browsers.

Macroscope summarized 9bebc8b.

- Scroll the chat timeline from the composer
- Support smooth scrolling, key holds, and acceleration
- Add focused controller tests
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.5 KiB13.2 KiB−249 B (−1.8%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−249 B (−3.7%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.5 KiB+174 B (+1.3%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+8 B (+0.1%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.6 KiB+166 B (+2.5%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB57.8 KiB+1.4 KiB (+2.5%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 9409dd2 · PR result: 9bebc8b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadapps/web/src/components/ComposerPromptEditor.tsx
Comment threadapps/web/src/components/chat/pageScrollController.ts
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new default chat interaction spanning the composer and timeline, including custom animated scrolling, held-key acceleration, and live-follow coordination. Its production-path behavior and cross-component integration exceed a small self-contained change and merit human review.

You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/components/chat/pageScrollController.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 99da696. Configure here.

Comment threadapps/web/src/components/chat/pageScrollController.ts
- Ignore PageUp/PageDown when the editor is within 1px of its boundary
- Add regression coverage for fractional scroll positions
Comment threadapps/web/src/components/chat/pageScrollController.ts
@Yash-Singh1
Yash-Singh1 merged commit 5f84efa into mainSep 3, 2026
27 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/chat-page-navigation branch September 3, 2026 04:12
@Yash-Singh1
Yash-Singh1 restored the t3code/chat-page-navigation branch September 3, 2026 04:12
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): add PageUp/PageDown chat navigation - #9315

Merged
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation
Sep 3, 2026
Merged

feat(web): add PageUp/PageDown chat navigation#9315
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Added PageUp/PageDown keyboard navigation for the chat timeline.
  • Added a shared page-scroll controller with focused tests for scroll behavior and boundaries.
  • Updated the composer and chat components to coordinate keyboard navigation with the message timeline.
  • Removed obsolete environment machine icons, settings, contracts, and related legacy code.

Why

Chat users can now move through long conversations one viewport at a time without relying on the mouse or scrollbar. The scrolling logic is isolated and tested so navigation remains predictable at the start and end of the timeline.

UI Changes

  • Added keyboard-driven PageUp/PageDown navigation in the web chat view.
  • No screenshots or video included; the interaction is keyboard-based and does not add animation.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes timeline scroll and live-follow opt-out behavior on PageUp; a noted edge case can disable follow without an actual upward scroll when already at the top of an overflowing anchored view.

Overview
Adds keyboard PageUp/PageDown navigation for the message timeline when the chat composer is focused, so users can move through long threads without the mouse.

A new pageScrollController drives the timeline list: one viewport per tap (with easing), hold-to-repeat scrolling that ramps speed, boundary checks, and bottom padding from the composer overlay height. getTimelinePageScrollKey keeps Page keys on the composer while its textarea can still scroll, then hands off to the timeline at the editor edge (including IME/modifier guards).

ChatView mounts the controller on the timeline scroll node and wires key down/up/release from ChatComposerComposerPromptEditor. Starting a timeline PageUp scroll can cancel timeline live-follow when content overflows the viewport, matching manual navigation elsewhere.

Unit tests cover composer handoff, scroll distance/velocity, tap vs hold, and boundary no-ops.

Reviewed by Cursor Bugbot for commit 9bebc8b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add PageUp/PageDown animated timeline scrolling to chat view

  • Adds createPageScrollController in pageScrollController.ts to animate tap-page scrolls and delayed, accelerating continuous scrolling when PageUp or PageDown is held. Scrolling stops on key-up, blur, direction change, boundary, or disposal.
  • Wires the controller through ChatViewContentChatComposerComposerPromptEditor so that unmodified PageUp/PageDown presses at a composer scroll boundary are delegated to the timeline, while non-boundary presses keep native composer scrolling. An accepted PageUp also cancels timeline live-follow.
  • Page distance is computed from viewport height minus a 36-pixel alignment offset and composer overlay padding. Held scrolling ramps linearly to a 2× multiplier over 400 ms. Boundary requests within a one-pixel tolerance are rejected.
  • Risk: getTimelinePageScrollKey classifies which key presses are delegated; if composer scroll-position detection is inaccurate, PageUp/PageDown may be stolen from or inappropriately handed back to the editor. Verify canScrollInDirection against fractional-pixel scroll positions in the target browsers.

Macroscope summarized 9bebc8b.

- Scroll the chat timeline from the composer
- Support smooth scrolling, key holds, and acceleration
- Add focused controller tests
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.5 KiB13.2 KiB−249 B (−1.8%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−249 B (−3.7%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.5 KiB+174 B (+1.3%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+8 B (+0.1%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.6 KiB+166 B (+2.5%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB57.8 KiB+1.4 KiB (+2.5%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 9409dd2 · PR result: 9bebc8b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadapps/web/src/components/ComposerPromptEditor.tsx
Comment threadapps/web/src/components/chat/pageScrollController.ts
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new default chat interaction spanning the composer and timeline, including custom animated scrolling, held-key acceleration, and live-follow coordination. Its production-path behavior and cross-component integration exceed a small self-contained change and merit human review.

You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/components/chat/pageScrollController.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 99da696. Configure here.

Comment threadapps/web/src/components/chat/pageScrollController.ts
- Ignore PageUp/PageDown when the editor is within 1px of its boundary
- Add regression coverage for fractional scroll positions
Comment threadapps/web/src/components/chat/pageScrollController.ts
@Yash-Singh1
Yash-Singh1 merged commit 5f84efa into mainSep 3, 2026
27 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/chat-page-navigation branch September 3, 2026 04:12
@Yash-Singh1
Yash-Singh1 restored the t3code/chat-page-navigation branch September 3, 2026 04:12
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(web): add PageUp/PageDown chat navigation - #9315

Merged
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation
Sep 3, 2026
Merged

feat(web): add PageUp/PageDown chat navigation#9315
Yash-Singh1 merged 6 commits into
mainfrom
t3code/chat-page-navigation

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Added PageUp/PageDown keyboard navigation for the chat timeline.
  • Added a shared page-scroll controller with focused tests for scroll behavior and boundaries.
  • Updated the composer and chat components to coordinate keyboard navigation with the message timeline.
  • Removed obsolete environment machine icons, settings, contracts, and related legacy code.

Why

Chat users can now move through long conversations one viewport at a time without relying on the mouse or scrollbar. The scrolling logic is isolated and tested so navigation remains predictable at the start and end of the timeline.

UI Changes

  • Added keyboard-driven PageUp/PageDown navigation in the web chat view.
  • No screenshots or video included; the interaction is keyboard-based and does not add animation.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes timeline scroll and live-follow opt-out behavior on PageUp; a noted edge case can disable follow without an actual upward scroll when already at the top of an overflowing anchored view.

Overview
Adds keyboard PageUp/PageDown navigation for the message timeline when the chat composer is focused, so users can move through long threads without the mouse.

A new pageScrollController drives the timeline list: one viewport per tap (with easing), hold-to-repeat scrolling that ramps speed, boundary checks, and bottom padding from the composer overlay height. getTimelinePageScrollKey keeps Page keys on the composer while its textarea can still scroll, then hands off to the timeline at the editor edge (including IME/modifier guards).

ChatView mounts the controller on the timeline scroll node and wires key down/up/release from ChatComposerComposerPromptEditor. Starting a timeline PageUp scroll can cancel timeline live-follow when content overflows the viewport, matching manual navigation elsewhere.

Unit tests cover composer handoff, scroll distance/velocity, tap vs hold, and boundary no-ops.

Reviewed by Cursor Bugbot for commit 9bebc8b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add PageUp/PageDown animated timeline scrolling to chat view

  • Adds createPageScrollController in pageScrollController.ts to animate tap-page scrolls and delayed, accelerating continuous scrolling when PageUp or PageDown is held. Scrolling stops on key-up, blur, direction change, boundary, or disposal.
  • Wires the controller through ChatViewContentChatComposerComposerPromptEditor so that unmodified PageUp/PageDown presses at a composer scroll boundary are delegated to the timeline, while non-boundary presses keep native composer scrolling. An accepted PageUp also cancels timeline live-follow.
  • Page distance is computed from viewport height minus a 36-pixel alignment offset and composer overlay padding. Held scrolling ramps linearly to a 2× multiplier over 400 ms. Boundary requests within a one-pixel tolerance are rejected.
  • Risk: getTimelinePageScrollKey classifies which key presses are delegated; if composer scroll-position detection is inaccurate, PageUp/PageDown may be stolen from or inappropriately handed back to the editor. Verify canScrollInDirection against fractional-pixel scroll positions in the target browsers.

Macroscope summarized 9bebc8b.

- Scroll the chat timeline from the composer
- Support smooth scrolling, key holds, and acceleration
- Add focused controller tests
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.5 KiB13.2 KiB−249 B (−1.8%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−249 B (−3.7%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.5 KiB+174 B (+1.3%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+8 B (+0.1%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.6 KiB+166 B (+2.5%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB57.8 KiB+1.4 KiB (+2.5%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 9409dd2 · PR result: 9bebc8b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/web/src/components/ChatView.tsx Outdated
Comment threadapps/web/src/components/ComposerPromptEditor.tsx
Comment threadapps/web/src/components/chat/pageScrollController.ts
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new default chat interaction spanning the composer and timeline, including custom animated scrolling, held-key acceleration, and live-follow coordination. Its production-path behavior and cross-component integration exceed a small self-contained change and merit human review.

You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/components/chat/pageScrollController.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 99da696. Configure here.

Comment threadapps/web/src/components/chat/pageScrollController.ts
- Ignore PageUp/PageDown when the editor is within 1px of its boundary
- Add regression coverage for fractional scroll positions
Comment threadapps/web/src/components/chat/pageScrollController.ts
@Yash-Singh1
Yash-Singh1 merged commit 5f84efa into mainSep 3, 2026
27 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/chat-page-navigation branch September 3, 2026 04:12
@Yash-Singh1
Yash-Singh1 restored the t3code/chat-page-navigation branch September 3, 2026 04:12
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1