chore: upgrade vite-plus to 0.3.0 - #9327

Merged
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0
Sep 3, 2026
Merged

chore: upgrade vite-plus to 0.3.0#9327
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

vp run dev --share defaults T3CODE_BUNDLED_DEV=1 (scripts/dev-runner.ts, apps/web/vite.config.tsexperimental.bundledDev) so a remote browser on the tailnet pays a few chunk requests instead of a per-module round trip. On vite-plus 0.2.2, which bundles vite 8.1.2 / rolldown 1.1.4, that bundled dev mode is flaky for the shared origin: the page throws @vitejs/plugin-react can't detect preamble and Cannot read properties of undefined (reading 'Root') in <Collapsible> (a base-ui namespace import resolving to undefined in the bundled chunk), so the app never gets past the splash. Unbundled dev renders fine.

Fix

Bump the pinned toolchain to vite-plus 0.3.0, which bundles vite 8.2.2 / rolldown 1.2.5. The 8.1.2 to 8.2.2 range carries the batch of experimental.bundledDev fixes (vitejs/vite CHANGELOG):

  • bundled-dev: reload once after rebuild instead of via the fallback page (#23106)
  • bundled-dev: support worker file update accepted by HMR (#23068)
  • bundled-dev: print build errors when an HMR update fails (#23024)
  • bundled-dev: avoid stack overflow on import.meta.hot.invalidate() (#22797)
  • bundled-dev: serve assets emitted during HMR / lazy compile (#22745)
  • bundled-dev: skip plugin transform hooks for rolldown-lazy stub modules (#22778)
  • bundled-dev: avoid duplicated buildEnd (#22931)

Plus from vite-plus itself:

What changed

Only the two catalog entries in pnpm-workspace.yaml (vite: npm:@voidzero-dev/vite-plus-core@0.3.0, vite-plus: 0.3.0). Every package consumes them via catalog:, so nothing else needed touching. No other 0.2.2 pin exists in package.json files, workflows, Dockerfiles, or tool-version files; CI uses voidzero-dev/setup-vp@v1 with no version pin, and the local vp reads the project version from the lockfile.

The lockfile delta is limited to the vite-plus toolchain: vite-plus, @voidzero-dev/vite-plus-core and platform binaries, vitest 4.1.9 to 4.1.11, oxlint 1.72.0 to 1.79.0, oxfmt 0.57.0 to 0.64.0, oxlint-tsgolint 0.24.0 to 7.0.2001, @oxc-project/* 0.138.0 to 0.146.0, and new transitive deps of vite-plus-core (lightningcss 1.33.0, yuku-parser / yuku-codegen 0.5.48, @oxlint/plugins 1.79.0). No unrelated major bumps.

experimental.bundledDev is still typed boolean in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts need no change.

0.3.0 caveats

  • XDG install layout for fresh installs only. Existing ~/.vite-plus installs keep their layout and vp upgrade leaves them in place. CI via setup-vp stays on the single-root layout, so the $HOME/.vite-plus/package_manager/pnpm/... paths in the mobile workflows keep working. A maintainer who does a fresh install will get ~/.local/share/vite-plus/bin instead; nothing in this repo hard-codes that path.
  • @vitejs/devtools optional peer range widened to ^0.4.0 || ^0.5.0. We do not depend on it.
  • Upgrade check moved out of process; commands no longer wait on the registry.
  • Newer oxlint/oxfmt may flag new issues; the pre-commit vp fmt on the two changed files was clean.

Verification

  • vp i refreshed the lockfile; vp --version inside apps/web reports vite-plus 0.3.0, vite 8.2.2, rolldown 1.2.5, vitest 4.1.11
  • vp run build in apps/web: built in 12.7s, working tree clean afterward
  • vp run typecheck in apps/web: exit 0
  • vp test run --project unit src/lib/assistantCitationNavigation.test.ts src/lib/attachmentUploadState.test.ts in apps/web: 2 files, 8 tests passed on vitest 4.1.11
  • T3CODE_BUNDLED_DEV=1 vp run dev in the worktree (no --share): after the first rolldown build the real index was served with <script type="module" src="/bundledDevClient.mjs"> and <script type="module" crossorigin src="/assets/index.js">; both returned 200 (text/javascript, 57 kB and 19.5 MB) with no error / ENOENT / preamble lines in the server log. Stopped by the process group of the PID captured at spawn.

Not verified here: the remote-browser --share path itself, which needs a second machine on the tailnet.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
Primarily a dev/build toolchain and auto-format refresh; application logic is unchanged aside from formatting, though a major vite/rolldown bump can still surface new build or lint issues in CI.

Overview
Bumps the workspace vite-plus / vite catalog pins from 0.2.2 to 0.3.0 and refreshes pnpm-lock.yaml, pulling in vite 8.2.2, rolldown 1.2.5, vitest 4.1.11, oxlint 1.79.0, oxfmt 0.64.0, and related native bindings (including new yuku-parser / yuku-codegen transitives).

Alongside the lockfile, many TypeScript files were reformatted only: multi-line .map / Effect.map / Effect.flatMap callbacks and similar patterns were collapsed to match oxfmt 0.64 (desktop, mobile, server, client-runtime, web, shared, generated schema.gen.ts). No intentional runtime or API behavior changes in those edits.

The upgrade targets more reliable experimental.bundledDev (used when shared dev defaults T3CODE_BUNDLED_DEV=1); app config in apps/web/vite.config.ts and scripts/dev-runner.ts is unchanged.

Reviewed by Cursor Bugbot for commit 21611ad. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Upgrade vite-plus to 0.3.0

Bumps the Vite alias and vite-plus catalog versions from 0.2.2 to 0.3.0 in pnpm-workspace.yaml and updates the lockfile. The rest of the PR is formatting-only reformatting across many provider, orchestration, and client modules triggered by the new formatter rules.

Macroscope summarized 21611ad.

Follow-up commit: oxfmt 0.57 → 0.64 reformat

The toolchain bump also moves oxfmt, which now hugs a sole trailing arrow-function argument (Effect.map((x) => ({...})) on one line instead of breaking before the arrow) and breaks long string-literal unions onto leading | lines. vp check failed on 29 pre-existing files for that reason, so a second commit runs vp fmt over the repo. Verified per file that the change is whitespace, trailing commas, and | placement only (stripping those, old and new are byte-identical). Includes packages/effect-codex-app-server/src/_generated/schema.gen.ts, whose generator already runs vp fmt over its output, so it stays consistent from here.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.2 KiB13.4 KiB+234 B (+1.7%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.6 KiB+238 B (+3.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB57.0 KiB+1.5 KiB (+2.7%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−48 B (−0.4%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−51 B (−0.8%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.3 KiB−88 B (−0.2%)66.4 KiB
ClaudeLive turn messages108−2 (−20.0%)21

Baseline: 3b2de9d · PR result: 21611ad · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This updates the shared Vite-plus build, bundling, testing, linting, and formatting toolchain across the monorepo, including the implementation of the existing bundled-development path. Although no application source changes are included, the upgrade can affect generated web/desktop/server artifacts and the unverified remote HMR path.

No code changes detected at 03de157. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

`vp run dev --share` defaults T3CODE_BUNDLED_DEV=1 so a remote browser
on the tailnet pays a few chunk requests instead of a per-module round
trip. On vite-plus 0.2.2 (vite 8.1.2 / rolldown 1.1.4) that bundled dev
mode is flaky for the shared origin: the page throws
"@vitejs/plugin-react can't detect preamble" and a base-ui namespace
import resolves to undefined inside <Collapsible>, so the app never
gets past the splash.
vite-plus 0.3.0 bundles vite 8.2.2 / rolldown 1.2.5, which carry the
batch of experimental.bundledDev fixes landed between 8.1.2 and 8.2.2
(reload once after rebuild, serve assets emitted during HMR/lazy
compile, skip plugin transforms for rolldown-lazy stubs, HMR error
printing, invalidate() stack overflow, duplicated buildEnd), plus the
vp dev ENOENT-at-startup fix from 0.2.9.
Only the two catalog entries in pnpm-workspace.yaml change; every
package consumes them via "catalog:". The lockfile delta is limited to
the vite-plus toolchain (vite-plus-core, vitest 4.1.11, oxlint 1.79,
oxfmt 0.64, oxlint-tsgolint, oxc types) and its new transitive deps
(lightningcss, yuku-parser/codegen). experimental.bundledDev is still
`boolean` in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts
need no change.
Verified: `vp i`, `vp run build` in apps/web, `vp run typecheck` in
apps/web, two unit test files in apps/web, and a T3CODE_BUNDLED_DEV=1
`vp run dev` that served the real index with /assets/index.js at 200
and no server-side errors.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:36
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
The toolchain bump moves oxfmt from 0.57 to 0.64, which hugs a sole
trailing arrow-function argument instead of breaking it. Whitespace only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@juliusmarminge
juliusmarminge merged commit f5fbb1b into mainSep 3, 2026
26 checks passed
@juliusmarminge
juliusmarminge deleted the chore/vite-plus-0.3.0 branch September 3, 2026 03:40
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

chore: upgrade vite-plus to 0.3.0 - #9327

Merged
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0
Sep 3, 2026
Merged

chore: upgrade vite-plus to 0.3.0#9327
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

vp run dev --share defaults T3CODE_BUNDLED_DEV=1 (scripts/dev-runner.ts, apps/web/vite.config.tsexperimental.bundledDev) so a remote browser on the tailnet pays a few chunk requests instead of a per-module round trip. On vite-plus 0.2.2, which bundles vite 8.1.2 / rolldown 1.1.4, that bundled dev mode is flaky for the shared origin: the page throws @vitejs/plugin-react can't detect preamble and Cannot read properties of undefined (reading 'Root') in <Collapsible> (a base-ui namespace import resolving to undefined in the bundled chunk), so the app never gets past the splash. Unbundled dev renders fine.

Fix

Bump the pinned toolchain to vite-plus 0.3.0, which bundles vite 8.2.2 / rolldown 1.2.5. The 8.1.2 to 8.2.2 range carries the batch of experimental.bundledDev fixes (vitejs/vite CHANGELOG):

  • bundled-dev: reload once after rebuild instead of via the fallback page (#23106)
  • bundled-dev: support worker file update accepted by HMR (#23068)
  • bundled-dev: print build errors when an HMR update fails (#23024)
  • bundled-dev: avoid stack overflow on import.meta.hot.invalidate() (#22797)
  • bundled-dev: serve assets emitted during HMR / lazy compile (#22745)
  • bundled-dev: skip plugin transform hooks for rolldown-lazy stub modules (#22778)
  • bundled-dev: avoid duplicated buildEnd (#22931)

Plus from vite-plus itself:

What changed

Only the two catalog entries in pnpm-workspace.yaml (vite: npm:@voidzero-dev/vite-plus-core@0.3.0, vite-plus: 0.3.0). Every package consumes them via catalog:, so nothing else needed touching. No other 0.2.2 pin exists in package.json files, workflows, Dockerfiles, or tool-version files; CI uses voidzero-dev/setup-vp@v1 with no version pin, and the local vp reads the project version from the lockfile.

The lockfile delta is limited to the vite-plus toolchain: vite-plus, @voidzero-dev/vite-plus-core and platform binaries, vitest 4.1.9 to 4.1.11, oxlint 1.72.0 to 1.79.0, oxfmt 0.57.0 to 0.64.0, oxlint-tsgolint 0.24.0 to 7.0.2001, @oxc-project/* 0.138.0 to 0.146.0, and new transitive deps of vite-plus-core (lightningcss 1.33.0, yuku-parser / yuku-codegen 0.5.48, @oxlint/plugins 1.79.0). No unrelated major bumps.

experimental.bundledDev is still typed boolean in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts need no change.

0.3.0 caveats

  • XDG install layout for fresh installs only. Existing ~/.vite-plus installs keep their layout and vp upgrade leaves them in place. CI via setup-vp stays on the single-root layout, so the $HOME/.vite-plus/package_manager/pnpm/... paths in the mobile workflows keep working. A maintainer who does a fresh install will get ~/.local/share/vite-plus/bin instead; nothing in this repo hard-codes that path.
  • @vitejs/devtools optional peer range widened to ^0.4.0 || ^0.5.0. We do not depend on it.
  • Upgrade check moved out of process; commands no longer wait on the registry.
  • Newer oxlint/oxfmt may flag new issues; the pre-commit vp fmt on the two changed files was clean.

Verification

  • vp i refreshed the lockfile; vp --version inside apps/web reports vite-plus 0.3.0, vite 8.2.2, rolldown 1.2.5, vitest 4.1.11
  • vp run build in apps/web: built in 12.7s, working tree clean afterward
  • vp run typecheck in apps/web: exit 0
  • vp test run --project unit src/lib/assistantCitationNavigation.test.ts src/lib/attachmentUploadState.test.ts in apps/web: 2 files, 8 tests passed on vitest 4.1.11
  • T3CODE_BUNDLED_DEV=1 vp run dev in the worktree (no --share): after the first rolldown build the real index was served with <script type="module" src="/bundledDevClient.mjs"> and <script type="module" crossorigin src="/assets/index.js">; both returned 200 (text/javascript, 57 kB and 19.5 MB) with no error / ENOENT / preamble lines in the server log. Stopped by the process group of the PID captured at spawn.

Not verified here: the remote-browser --share path itself, which needs a second machine on the tailnet.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
Primarily a dev/build toolchain and auto-format refresh; application logic is unchanged aside from formatting, though a major vite/rolldown bump can still surface new build or lint issues in CI.

Overview
Bumps the workspace vite-plus / vite catalog pins from 0.2.2 to 0.3.0 and refreshes pnpm-lock.yaml, pulling in vite 8.2.2, rolldown 1.2.5, vitest 4.1.11, oxlint 1.79.0, oxfmt 0.64.0, and related native bindings (including new yuku-parser / yuku-codegen transitives).

Alongside the lockfile, many TypeScript files were reformatted only: multi-line .map / Effect.map / Effect.flatMap callbacks and similar patterns were collapsed to match oxfmt 0.64 (desktop, mobile, server, client-runtime, web, shared, generated schema.gen.ts). No intentional runtime or API behavior changes in those edits.

The upgrade targets more reliable experimental.bundledDev (used when shared dev defaults T3CODE_BUNDLED_DEV=1); app config in apps/web/vite.config.ts and scripts/dev-runner.ts is unchanged.

Reviewed by Cursor Bugbot for commit 21611ad. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Upgrade vite-plus to 0.3.0

Bumps the Vite alias and vite-plus catalog versions from 0.2.2 to 0.3.0 in pnpm-workspace.yaml and updates the lockfile. The rest of the PR is formatting-only reformatting across many provider, orchestration, and client modules triggered by the new formatter rules.

Macroscope summarized 21611ad.

Follow-up commit: oxfmt 0.57 → 0.64 reformat

The toolchain bump also moves oxfmt, which now hugs a sole trailing arrow-function argument (Effect.map((x) => ({...})) on one line instead of breaking before the arrow) and breaks long string-literal unions onto leading | lines. vp check failed on 29 pre-existing files for that reason, so a second commit runs vp fmt over the repo. Verified per file that the change is whitespace, trailing commas, and | placement only (stripping those, old and new are byte-identical). Includes packages/effect-codex-app-server/src/_generated/schema.gen.ts, whose generator already runs vp fmt over its output, so it stays consistent from here.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.2 KiB13.4 KiB+234 B (+1.7%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.6 KiB+238 B (+3.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB57.0 KiB+1.5 KiB (+2.7%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−48 B (−0.4%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−51 B (−0.8%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.3 KiB−88 B (−0.2%)66.4 KiB
ClaudeLive turn messages108−2 (−20.0%)21

Baseline: 3b2de9d · PR result: 21611ad · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This updates the shared Vite-plus build, bundling, testing, linting, and formatting toolchain across the monorepo, including the implementation of the existing bundled-development path. Although no application source changes are included, the upgrade can affect generated web/desktop/server artifacts and the unverified remote HMR path.

No code changes detected at 03de157. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

`vp run dev --share` defaults T3CODE_BUNDLED_DEV=1 so a remote browser
on the tailnet pays a few chunk requests instead of a per-module round
trip. On vite-plus 0.2.2 (vite 8.1.2 / rolldown 1.1.4) that bundled dev
mode is flaky for the shared origin: the page throws
"@vitejs/plugin-react can't detect preamble" and a base-ui namespace
import resolves to undefined inside <Collapsible>, so the app never
gets past the splash.
vite-plus 0.3.0 bundles vite 8.2.2 / rolldown 1.2.5, which carry the
batch of experimental.bundledDev fixes landed between 8.1.2 and 8.2.2
(reload once after rebuild, serve assets emitted during HMR/lazy
compile, skip plugin transforms for rolldown-lazy stubs, HMR error
printing, invalidate() stack overflow, duplicated buildEnd), plus the
vp dev ENOENT-at-startup fix from 0.2.9.
Only the two catalog entries in pnpm-workspace.yaml change; every
package consumes them via "catalog:". The lockfile delta is limited to
the vite-plus toolchain (vite-plus-core, vitest 4.1.11, oxlint 1.79,
oxfmt 0.64, oxlint-tsgolint, oxc types) and its new transitive deps
(lightningcss, yuku-parser/codegen). experimental.bundledDev is still
`boolean` in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts
need no change.
Verified: `vp i`, `vp run build` in apps/web, `vp run typecheck` in
apps/web, two unit test files in apps/web, and a T3CODE_BUNDLED_DEV=1
`vp run dev` that served the real index with /assets/index.js at 200
and no server-side errors.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:36
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
The toolchain bump moves oxfmt from 0.57 to 0.64, which hugs a sole
trailing arrow-function argument instead of breaking it. Whitespace only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@juliusmarminge
juliusmarminge merged commit f5fbb1b into mainSep 3, 2026
26 checks passed
@juliusmarminge
juliusmarminge deleted the chore/vite-plus-0.3.0 branch September 3, 2026 03:40
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore: upgrade vite-plus to 0.3.0 - #9327

Merged
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0
Sep 3, 2026
Merged

chore: upgrade vite-plus to 0.3.0#9327
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

vp run dev --share defaults T3CODE_BUNDLED_DEV=1 (scripts/dev-runner.ts, apps/web/vite.config.tsexperimental.bundledDev) so a remote browser on the tailnet pays a few chunk requests instead of a per-module round trip. On vite-plus 0.2.2, which bundles vite 8.1.2 / rolldown 1.1.4, that bundled dev mode is flaky for the shared origin: the page throws @vitejs/plugin-react can't detect preamble and Cannot read properties of undefined (reading 'Root') in <Collapsible> (a base-ui namespace import resolving to undefined in the bundled chunk), so the app never gets past the splash. Unbundled dev renders fine.

Fix

Bump the pinned toolchain to vite-plus 0.3.0, which bundles vite 8.2.2 / rolldown 1.2.5. The 8.1.2 to 8.2.2 range carries the batch of experimental.bundledDev fixes (vitejs/vite CHANGELOG):

  • bundled-dev: reload once after rebuild instead of via the fallback page (#23106)
  • bundled-dev: support worker file update accepted by HMR (#23068)
  • bundled-dev: print build errors when an HMR update fails (#23024)
  • bundled-dev: avoid stack overflow on import.meta.hot.invalidate() (#22797)
  • bundled-dev: serve assets emitted during HMR / lazy compile (#22745)
  • bundled-dev: skip plugin transform hooks for rolldown-lazy stub modules (#22778)
  • bundled-dev: avoid duplicated buildEnd (#22931)

Plus from vite-plus itself:

What changed

Only the two catalog entries in pnpm-workspace.yaml (vite: npm:@voidzero-dev/vite-plus-core@0.3.0, vite-plus: 0.3.0). Every package consumes them via catalog:, so nothing else needed touching. No other 0.2.2 pin exists in package.json files, workflows, Dockerfiles, or tool-version files; CI uses voidzero-dev/setup-vp@v1 with no version pin, and the local vp reads the project version from the lockfile.

The lockfile delta is limited to the vite-plus toolchain: vite-plus, @voidzero-dev/vite-plus-core and platform binaries, vitest 4.1.9 to 4.1.11, oxlint 1.72.0 to 1.79.0, oxfmt 0.57.0 to 0.64.0, oxlint-tsgolint 0.24.0 to 7.0.2001, @oxc-project/* 0.138.0 to 0.146.0, and new transitive deps of vite-plus-core (lightningcss 1.33.0, yuku-parser / yuku-codegen 0.5.48, @oxlint/plugins 1.79.0). No unrelated major bumps.

experimental.bundledDev is still typed boolean in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts need no change.

0.3.0 caveats

  • XDG install layout for fresh installs only. Existing ~/.vite-plus installs keep their layout and vp upgrade leaves them in place. CI via setup-vp stays on the single-root layout, so the $HOME/.vite-plus/package_manager/pnpm/... paths in the mobile workflows keep working. A maintainer who does a fresh install will get ~/.local/share/vite-plus/bin instead; nothing in this repo hard-codes that path.
  • @vitejs/devtools optional peer range widened to ^0.4.0 || ^0.5.0. We do not depend on it.
  • Upgrade check moved out of process; commands no longer wait on the registry.
  • Newer oxlint/oxfmt may flag new issues; the pre-commit vp fmt on the two changed files was clean.

Verification

  • vp i refreshed the lockfile; vp --version inside apps/web reports vite-plus 0.3.0, vite 8.2.2, rolldown 1.2.5, vitest 4.1.11
  • vp run build in apps/web: built in 12.7s, working tree clean afterward
  • vp run typecheck in apps/web: exit 0
  • vp test run --project unit src/lib/assistantCitationNavigation.test.ts src/lib/attachmentUploadState.test.ts in apps/web: 2 files, 8 tests passed on vitest 4.1.11
  • T3CODE_BUNDLED_DEV=1 vp run dev in the worktree (no --share): after the first rolldown build the real index was served with <script type="module" src="/bundledDevClient.mjs"> and <script type="module" crossorigin src="/assets/index.js">; both returned 200 (text/javascript, 57 kB and 19.5 MB) with no error / ENOENT / preamble lines in the server log. Stopped by the process group of the PID captured at spawn.

Not verified here: the remote-browser --share path itself, which needs a second machine on the tailnet.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
Primarily a dev/build toolchain and auto-format refresh; application logic is unchanged aside from formatting, though a major vite/rolldown bump can still surface new build or lint issues in CI.

Overview
Bumps the workspace vite-plus / vite catalog pins from 0.2.2 to 0.3.0 and refreshes pnpm-lock.yaml, pulling in vite 8.2.2, rolldown 1.2.5, vitest 4.1.11, oxlint 1.79.0, oxfmt 0.64.0, and related native bindings (including new yuku-parser / yuku-codegen transitives).

Alongside the lockfile, many TypeScript files were reformatted only: multi-line .map / Effect.map / Effect.flatMap callbacks and similar patterns were collapsed to match oxfmt 0.64 (desktop, mobile, server, client-runtime, web, shared, generated schema.gen.ts). No intentional runtime or API behavior changes in those edits.

The upgrade targets more reliable experimental.bundledDev (used when shared dev defaults T3CODE_BUNDLED_DEV=1); app config in apps/web/vite.config.ts and scripts/dev-runner.ts is unchanged.

Reviewed by Cursor Bugbot for commit 21611ad. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Upgrade vite-plus to 0.3.0

Bumps the Vite alias and vite-plus catalog versions from 0.2.2 to 0.3.0 in pnpm-workspace.yaml and updates the lockfile. The rest of the PR is formatting-only reformatting across many provider, orchestration, and client modules triggered by the new formatter rules.

Macroscope summarized 21611ad.

Follow-up commit: oxfmt 0.57 → 0.64 reformat

The toolchain bump also moves oxfmt, which now hugs a sole trailing arrow-function argument (Effect.map((x) => ({...})) on one line instead of breaking before the arrow) and breaks long string-literal unions onto leading | lines. vp check failed on 29 pre-existing files for that reason, so a second commit runs vp fmt over the repo. Verified per file that the change is whitespace, trailing commas, and | placement only (stripping those, old and new are byte-identical). Includes packages/effect-codex-app-server/src/_generated/schema.gen.ts, whose generator already runs vp fmt over its output, so it stays consistent from here.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.2 KiB13.4 KiB+234 B (+1.7%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.6 KiB+238 B (+3.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB57.0 KiB+1.5 KiB (+2.7%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−48 B (−0.4%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−51 B (−0.8%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.3 KiB−88 B (−0.2%)66.4 KiB
ClaudeLive turn messages108−2 (−20.0%)21

Baseline: 3b2de9d · PR result: 21611ad · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This updates the shared Vite-plus build, bundling, testing, linting, and formatting toolchain across the monorepo, including the implementation of the existing bundled-development path. Although no application source changes are included, the upgrade can affect generated web/desktop/server artifacts and the unverified remote HMR path.

No code changes detected at 03de157. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

`vp run dev --share` defaults T3CODE_BUNDLED_DEV=1 so a remote browser
on the tailnet pays a few chunk requests instead of a per-module round
trip. On vite-plus 0.2.2 (vite 8.1.2 / rolldown 1.1.4) that bundled dev
mode is flaky for the shared origin: the page throws
"@vitejs/plugin-react can't detect preamble" and a base-ui namespace
import resolves to undefined inside <Collapsible>, so the app never
gets past the splash.
vite-plus 0.3.0 bundles vite 8.2.2 / rolldown 1.2.5, which carry the
batch of experimental.bundledDev fixes landed between 8.1.2 and 8.2.2
(reload once after rebuild, serve assets emitted during HMR/lazy
compile, skip plugin transforms for rolldown-lazy stubs, HMR error
printing, invalidate() stack overflow, duplicated buildEnd), plus the
vp dev ENOENT-at-startup fix from 0.2.9.
Only the two catalog entries in pnpm-workspace.yaml change; every
package consumes them via "catalog:". The lockfile delta is limited to
the vite-plus toolchain (vite-plus-core, vitest 4.1.11, oxlint 1.79,
oxfmt 0.64, oxlint-tsgolint, oxc types) and its new transitive deps
(lightningcss, yuku-parser/codegen). experimental.bundledDev is still
`boolean` in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts
need no change.
Verified: `vp i`, `vp run build` in apps/web, `vp run typecheck` in
apps/web, two unit test files in apps/web, and a T3CODE_BUNDLED_DEV=1
`vp run dev` that served the real index with /assets/index.js at 200
and no server-side errors.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:36
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
The toolchain bump moves oxfmt from 0.57 to 0.64, which hugs a sole
trailing arrow-function argument instead of breaking it. Whitespace only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@juliusmarminge
juliusmarminge merged commit f5fbb1b into mainSep 3, 2026
26 checks passed
@juliusmarminge
juliusmarminge deleted the chore/vite-plus-0.3.0 branch September 3, 2026 03:40
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore: upgrade vite-plus to 0.3.0 - #9327

Merged
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0
Sep 3, 2026
Merged

chore: upgrade vite-plus to 0.3.0#9327
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

vp run dev --share defaults T3CODE_BUNDLED_DEV=1 (scripts/dev-runner.ts, apps/web/vite.config.tsexperimental.bundledDev) so a remote browser on the tailnet pays a few chunk requests instead of a per-module round trip. On vite-plus 0.2.2, which bundles vite 8.1.2 / rolldown 1.1.4, that bundled dev mode is flaky for the shared origin: the page throws @vitejs/plugin-react can't detect preamble and Cannot read properties of undefined (reading 'Root') in <Collapsible> (a base-ui namespace import resolving to undefined in the bundled chunk), so the app never gets past the splash. Unbundled dev renders fine.

Fix

Bump the pinned toolchain to vite-plus 0.3.0, which bundles vite 8.2.2 / rolldown 1.2.5. The 8.1.2 to 8.2.2 range carries the batch of experimental.bundledDev fixes (vitejs/vite CHANGELOG):

  • bundled-dev: reload once after rebuild instead of via the fallback page (#23106)
  • bundled-dev: support worker file update accepted by HMR (#23068)
  • bundled-dev: print build errors when an HMR update fails (#23024)
  • bundled-dev: avoid stack overflow on import.meta.hot.invalidate() (#22797)
  • bundled-dev: serve assets emitted during HMR / lazy compile (#22745)
  • bundled-dev: skip plugin transform hooks for rolldown-lazy stub modules (#22778)
  • bundled-dev: avoid duplicated buildEnd (#22931)

Plus from vite-plus itself:

What changed

Only the two catalog entries in pnpm-workspace.yaml (vite: npm:@voidzero-dev/vite-plus-core@0.3.0, vite-plus: 0.3.0). Every package consumes them via catalog:, so nothing else needed touching. No other 0.2.2 pin exists in package.json files, workflows, Dockerfiles, or tool-version files; CI uses voidzero-dev/setup-vp@v1 with no version pin, and the local vp reads the project version from the lockfile.

The lockfile delta is limited to the vite-plus toolchain: vite-plus, @voidzero-dev/vite-plus-core and platform binaries, vitest 4.1.9 to 4.1.11, oxlint 1.72.0 to 1.79.0, oxfmt 0.57.0 to 0.64.0, oxlint-tsgolint 0.24.0 to 7.0.2001, @oxc-project/* 0.138.0 to 0.146.0, and new transitive deps of vite-plus-core (lightningcss 1.33.0, yuku-parser / yuku-codegen 0.5.48, @oxlint/plugins 1.79.0). No unrelated major bumps.

experimental.bundledDev is still typed boolean in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts need no change.

0.3.0 caveats

  • XDG install layout for fresh installs only. Existing ~/.vite-plus installs keep their layout and vp upgrade leaves them in place. CI via setup-vp stays on the single-root layout, so the $HOME/.vite-plus/package_manager/pnpm/... paths in the mobile workflows keep working. A maintainer who does a fresh install will get ~/.local/share/vite-plus/bin instead; nothing in this repo hard-codes that path.
  • @vitejs/devtools optional peer range widened to ^0.4.0 || ^0.5.0. We do not depend on it.
  • Upgrade check moved out of process; commands no longer wait on the registry.
  • Newer oxlint/oxfmt may flag new issues; the pre-commit vp fmt on the two changed files was clean.

Verification

  • vp i refreshed the lockfile; vp --version inside apps/web reports vite-plus 0.3.0, vite 8.2.2, rolldown 1.2.5, vitest 4.1.11
  • vp run build in apps/web: built in 12.7s, working tree clean afterward
  • vp run typecheck in apps/web: exit 0
  • vp test run --project unit src/lib/assistantCitationNavigation.test.ts src/lib/attachmentUploadState.test.ts in apps/web: 2 files, 8 tests passed on vitest 4.1.11
  • T3CODE_BUNDLED_DEV=1 vp run dev in the worktree (no --share): after the first rolldown build the real index was served with <script type="module" src="/bundledDevClient.mjs"> and <script type="module" crossorigin src="/assets/index.js">; both returned 200 (text/javascript, 57 kB and 19.5 MB) with no error / ENOENT / preamble lines in the server log. Stopped by the process group of the PID captured at spawn.

Not verified here: the remote-browser --share path itself, which needs a second machine on the tailnet.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
Primarily a dev/build toolchain and auto-format refresh; application logic is unchanged aside from formatting, though a major vite/rolldown bump can still surface new build or lint issues in CI.

Overview
Bumps the workspace vite-plus / vite catalog pins from 0.2.2 to 0.3.0 and refreshes pnpm-lock.yaml, pulling in vite 8.2.2, rolldown 1.2.5, vitest 4.1.11, oxlint 1.79.0, oxfmt 0.64.0, and related native bindings (including new yuku-parser / yuku-codegen transitives).

Alongside the lockfile, many TypeScript files were reformatted only: multi-line .map / Effect.map / Effect.flatMap callbacks and similar patterns were collapsed to match oxfmt 0.64 (desktop, mobile, server, client-runtime, web, shared, generated schema.gen.ts). No intentional runtime or API behavior changes in those edits.

The upgrade targets more reliable experimental.bundledDev (used when shared dev defaults T3CODE_BUNDLED_DEV=1); app config in apps/web/vite.config.ts and scripts/dev-runner.ts is unchanged.

Reviewed by Cursor Bugbot for commit 21611ad. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Upgrade vite-plus to 0.3.0

Bumps the Vite alias and vite-plus catalog versions from 0.2.2 to 0.3.0 in pnpm-workspace.yaml and updates the lockfile. The rest of the PR is formatting-only reformatting across many provider, orchestration, and client modules triggered by the new formatter rules.

Macroscope summarized 21611ad.

Follow-up commit: oxfmt 0.57 → 0.64 reformat

The toolchain bump also moves oxfmt, which now hugs a sole trailing arrow-function argument (Effect.map((x) => ({...})) on one line instead of breaking before the arrow) and breaks long string-literal unions onto leading | lines. vp check failed on 29 pre-existing files for that reason, so a second commit runs vp fmt over the repo. Verified per file that the change is whitespace, trailing commas, and | placement only (stripping those, old and new are byte-identical). Includes packages/effect-codex-app-server/src/_generated/schema.gen.ts, whose generator already runs vp fmt over its output, so it stays consistent from here.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.2 KiB13.4 KiB+234 B (+1.7%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.6 KiB+238 B (+3.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB57.0 KiB+1.5 KiB (+2.7%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−48 B (−0.4%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−51 B (−0.8%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.3 KiB−88 B (−0.2%)66.4 KiB
ClaudeLive turn messages108−2 (−20.0%)21

Baseline: 3b2de9d · PR result: 21611ad · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This updates the shared Vite-plus build, bundling, testing, linting, and formatting toolchain across the monorepo, including the implementation of the existing bundled-development path. Although no application source changes are included, the upgrade can affect generated web/desktop/server artifacts and the unverified remote HMR path.

No code changes detected at 03de157. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

`vp run dev --share` defaults T3CODE_BUNDLED_DEV=1 so a remote browser
on the tailnet pays a few chunk requests instead of a per-module round
trip. On vite-plus 0.2.2 (vite 8.1.2 / rolldown 1.1.4) that bundled dev
mode is flaky for the shared origin: the page throws
"@vitejs/plugin-react can't detect preamble" and a base-ui namespace
import resolves to undefined inside <Collapsible>, so the app never
gets past the splash.
vite-plus 0.3.0 bundles vite 8.2.2 / rolldown 1.2.5, which carry the
batch of experimental.bundledDev fixes landed between 8.1.2 and 8.2.2
(reload once after rebuild, serve assets emitted during HMR/lazy
compile, skip plugin transforms for rolldown-lazy stubs, HMR error
printing, invalidate() stack overflow, duplicated buildEnd), plus the
vp dev ENOENT-at-startup fix from 0.2.9.
Only the two catalog entries in pnpm-workspace.yaml change; every
package consumes them via "catalog:". The lockfile delta is limited to
the vite-plus toolchain (vite-plus-core, vitest 4.1.11, oxlint 1.79,
oxfmt 0.64, oxlint-tsgolint, oxc types) and its new transitive deps
(lightningcss, yuku-parser/codegen). experimental.bundledDev is still
`boolean` in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts
need no change.
Verified: `vp i`, `vp run build` in apps/web, `vp run typecheck` in
apps/web, two unit test files in apps/web, and a T3CODE_BUNDLED_DEV=1
`vp run dev` that served the real index with /assets/index.js at 200
and no server-side errors.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:36
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
The toolchain bump moves oxfmt from 0.57 to 0.64, which hugs a sole
trailing arrow-function argument instead of breaking it. Whitespace only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@juliusmarminge
juliusmarminge merged commit f5fbb1b into mainSep 3, 2026
26 checks passed
@juliusmarminge
juliusmarminge deleted the chore/vite-plus-0.3.0 branch September 3, 2026 03:40
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

chore: upgrade vite-plus to 0.3.0 - #9327

Merged
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0
Sep 3, 2026
Merged

chore: upgrade vite-plus to 0.3.0#9327
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

vp run dev --share defaults T3CODE_BUNDLED_DEV=1 (scripts/dev-runner.ts, apps/web/vite.config.tsexperimental.bundledDev) so a remote browser on the tailnet pays a few chunk requests instead of a per-module round trip. On vite-plus 0.2.2, which bundles vite 8.1.2 / rolldown 1.1.4, that bundled dev mode is flaky for the shared origin: the page throws @vitejs/plugin-react can't detect preamble and Cannot read properties of undefined (reading 'Root') in <Collapsible> (a base-ui namespace import resolving to undefined in the bundled chunk), so the app never gets past the splash. Unbundled dev renders fine.

Fix

Bump the pinned toolchain to vite-plus 0.3.0, which bundles vite 8.2.2 / rolldown 1.2.5. The 8.1.2 to 8.2.2 range carries the batch of experimental.bundledDev fixes (vitejs/vite CHANGELOG):

  • bundled-dev: reload once after rebuild instead of via the fallback page (#23106)
  • bundled-dev: support worker file update accepted by HMR (#23068)
  • bundled-dev: print build errors when an HMR update fails (#23024)
  • bundled-dev: avoid stack overflow on import.meta.hot.invalidate() (#22797)
  • bundled-dev: serve assets emitted during HMR / lazy compile (#22745)
  • bundled-dev: skip plugin transform hooks for rolldown-lazy stub modules (#22778)
  • bundled-dev: avoid duplicated buildEnd (#22931)

Plus from vite-plus itself:

What changed

Only the two catalog entries in pnpm-workspace.yaml (vite: npm:@voidzero-dev/vite-plus-core@0.3.0, vite-plus: 0.3.0). Every package consumes them via catalog:, so nothing else needed touching. No other 0.2.2 pin exists in package.json files, workflows, Dockerfiles, or tool-version files; CI uses voidzero-dev/setup-vp@v1 with no version pin, and the local vp reads the project version from the lockfile.

The lockfile delta is limited to the vite-plus toolchain: vite-plus, @voidzero-dev/vite-plus-core and platform binaries, vitest 4.1.9 to 4.1.11, oxlint 1.72.0 to 1.79.0, oxfmt 0.57.0 to 0.64.0, oxlint-tsgolint 0.24.0 to 7.0.2001, @oxc-project/* 0.138.0 to 0.146.0, and new transitive deps of vite-plus-core (lightningcss 1.33.0, yuku-parser / yuku-codegen 0.5.48, @oxlint/plugins 1.79.0). No unrelated major bumps.

experimental.bundledDev is still typed boolean in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts need no change.

0.3.0 caveats

  • XDG install layout for fresh installs only. Existing ~/.vite-plus installs keep their layout and vp upgrade leaves them in place. CI via setup-vp stays on the single-root layout, so the $HOME/.vite-plus/package_manager/pnpm/... paths in the mobile workflows keep working. A maintainer who does a fresh install will get ~/.local/share/vite-plus/bin instead; nothing in this repo hard-codes that path.
  • @vitejs/devtools optional peer range widened to ^0.4.0 || ^0.5.0. We do not depend on it.
  • Upgrade check moved out of process; commands no longer wait on the registry.
  • Newer oxlint/oxfmt may flag new issues; the pre-commit vp fmt on the two changed files was clean.

Verification

  • vp i refreshed the lockfile; vp --version inside apps/web reports vite-plus 0.3.0, vite 8.2.2, rolldown 1.2.5, vitest 4.1.11
  • vp run build in apps/web: built in 12.7s, working tree clean afterward
  • vp run typecheck in apps/web: exit 0
  • vp test run --project unit src/lib/assistantCitationNavigation.test.ts src/lib/attachmentUploadState.test.ts in apps/web: 2 files, 8 tests passed on vitest 4.1.11
  • T3CODE_BUNDLED_DEV=1 vp run dev in the worktree (no --share): after the first rolldown build the real index was served with <script type="module" src="/bundledDevClient.mjs"> and <script type="module" crossorigin src="/assets/index.js">; both returned 200 (text/javascript, 57 kB and 19.5 MB) with no error / ENOENT / preamble lines in the server log. Stopped by the process group of the PID captured at spawn.

Not verified here: the remote-browser --share path itself, which needs a second machine on the tailnet.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
Primarily a dev/build toolchain and auto-format refresh; application logic is unchanged aside from formatting, though a major vite/rolldown bump can still surface new build or lint issues in CI.

Overview
Bumps the workspace vite-plus / vite catalog pins from 0.2.2 to 0.3.0 and refreshes pnpm-lock.yaml, pulling in vite 8.2.2, rolldown 1.2.5, vitest 4.1.11, oxlint 1.79.0, oxfmt 0.64.0, and related native bindings (including new yuku-parser / yuku-codegen transitives).

Alongside the lockfile, many TypeScript files were reformatted only: multi-line .map / Effect.map / Effect.flatMap callbacks and similar patterns were collapsed to match oxfmt 0.64 (desktop, mobile, server, client-runtime, web, shared, generated schema.gen.ts). No intentional runtime or API behavior changes in those edits.

The upgrade targets more reliable experimental.bundledDev (used when shared dev defaults T3CODE_BUNDLED_DEV=1); app config in apps/web/vite.config.ts and scripts/dev-runner.ts is unchanged.

Reviewed by Cursor Bugbot for commit 21611ad. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Upgrade vite-plus to 0.3.0

Bumps the Vite alias and vite-plus catalog versions from 0.2.2 to 0.3.0 in pnpm-workspace.yaml and updates the lockfile. The rest of the PR is formatting-only reformatting across many provider, orchestration, and client modules triggered by the new formatter rules.

Macroscope summarized 21611ad.

Follow-up commit: oxfmt 0.57 → 0.64 reformat

The toolchain bump also moves oxfmt, which now hugs a sole trailing arrow-function argument (Effect.map((x) => ({...})) on one line instead of breaking before the arrow) and breaks long string-literal unions onto leading | lines. vp check failed on 29 pre-existing files for that reason, so a second commit runs vp fmt over the repo. Verified per file that the change is whitespace, trailing commas, and | placement only (stripping those, old and new are byte-identical). Includes packages/effect-codex-app-server/src/_generated/schema.gen.ts, whose generator already runs vp fmt over its output, so it stays consistent from here.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.2 KiB13.4 KiB+234 B (+1.7%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.6 KiB+238 B (+3.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB57.0 KiB+1.5 KiB (+2.7%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−48 B (−0.4%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−51 B (−0.8%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.3 KiB−88 B (−0.2%)66.4 KiB
ClaudeLive turn messages108−2 (−20.0%)21

Baseline: 3b2de9d · PR result: 21611ad · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This updates the shared Vite-plus build, bundling, testing, linting, and formatting toolchain across the monorepo, including the implementation of the existing bundled-development path. Although no application source changes are included, the upgrade can affect generated web/desktop/server artifacts and the unverified remote HMR path.

No code changes detected at 03de157. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

`vp run dev --share` defaults T3CODE_BUNDLED_DEV=1 so a remote browser
on the tailnet pays a few chunk requests instead of a per-module round
trip. On vite-plus 0.2.2 (vite 8.1.2 / rolldown 1.1.4) that bundled dev
mode is flaky for the shared origin: the page throws
"@vitejs/plugin-react can't detect preamble" and a base-ui namespace
import resolves to undefined inside <Collapsible>, so the app never
gets past the splash.
vite-plus 0.3.0 bundles vite 8.2.2 / rolldown 1.2.5, which carry the
batch of experimental.bundledDev fixes landed between 8.1.2 and 8.2.2
(reload once after rebuild, serve assets emitted during HMR/lazy
compile, skip plugin transforms for rolldown-lazy stubs, HMR error
printing, invalidate() stack overflow, duplicated buildEnd), plus the
vp dev ENOENT-at-startup fix from 0.2.9.
Only the two catalog entries in pnpm-workspace.yaml change; every
package consumes them via "catalog:". The lockfile delta is limited to
the vite-plus toolchain (vite-plus-core, vitest 4.1.11, oxlint 1.79,
oxfmt 0.64, oxlint-tsgolint, oxc types) and its new transitive deps
(lightningcss, yuku-parser/codegen). experimental.bundledDev is still
`boolean` in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts
need no change.
Verified: `vp i`, `vp run build` in apps/web, `vp run typecheck` in
apps/web, two unit test files in apps/web, and a T3CODE_BUNDLED_DEV=1
`vp run dev` that served the real index with /assets/index.js at 200
and no server-side errors.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:36
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
The toolchain bump moves oxfmt from 0.57 to 0.64, which hugs a sole
trailing arrow-function argument instead of breaking it. Whitespace only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@juliusmarminge
juliusmarminge merged commit f5fbb1b into mainSep 3, 2026
26 checks passed
@juliusmarminge
juliusmarminge deleted the chore/vite-plus-0.3.0 branch September 3, 2026 03:40
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore: upgrade vite-plus to 0.3.0 - #9327

Merged
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0
Sep 3, 2026
Merged

chore: upgrade vite-plus to 0.3.0#9327
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

vp run dev --share defaults T3CODE_BUNDLED_DEV=1 (scripts/dev-runner.ts, apps/web/vite.config.tsexperimental.bundledDev) so a remote browser on the tailnet pays a few chunk requests instead of a per-module round trip. On vite-plus 0.2.2, which bundles vite 8.1.2 / rolldown 1.1.4, that bundled dev mode is flaky for the shared origin: the page throws @vitejs/plugin-react can't detect preamble and Cannot read properties of undefined (reading 'Root') in <Collapsible> (a base-ui namespace import resolving to undefined in the bundled chunk), so the app never gets past the splash. Unbundled dev renders fine.

Fix

Bump the pinned toolchain to vite-plus 0.3.0, which bundles vite 8.2.2 / rolldown 1.2.5. The 8.1.2 to 8.2.2 range carries the batch of experimental.bundledDev fixes (vitejs/vite CHANGELOG):

  • bundled-dev: reload once after rebuild instead of via the fallback page (#23106)
  • bundled-dev: support worker file update accepted by HMR (#23068)
  • bundled-dev: print build errors when an HMR update fails (#23024)
  • bundled-dev: avoid stack overflow on import.meta.hot.invalidate() (#22797)
  • bundled-dev: serve assets emitted during HMR / lazy compile (#22745)
  • bundled-dev: skip plugin transform hooks for rolldown-lazy stub modules (#22778)
  • bundled-dev: avoid duplicated buildEnd (#22931)

Plus from vite-plus itself:

What changed

Only the two catalog entries in pnpm-workspace.yaml (vite: npm:@voidzero-dev/vite-plus-core@0.3.0, vite-plus: 0.3.0). Every package consumes them via catalog:, so nothing else needed touching. No other 0.2.2 pin exists in package.json files, workflows, Dockerfiles, or tool-version files; CI uses voidzero-dev/setup-vp@v1 with no version pin, and the local vp reads the project version from the lockfile.

The lockfile delta is limited to the vite-plus toolchain: vite-plus, @voidzero-dev/vite-plus-core and platform binaries, vitest 4.1.9 to 4.1.11, oxlint 1.72.0 to 1.79.0, oxfmt 0.57.0 to 0.64.0, oxlint-tsgolint 0.24.0 to 7.0.2001, @oxc-project/* 0.138.0 to 0.146.0, and new transitive deps of vite-plus-core (lightningcss 1.33.0, yuku-parser / yuku-codegen 0.5.48, @oxlint/plugins 1.79.0). No unrelated major bumps.

experimental.bundledDev is still typed boolean in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts need no change.

0.3.0 caveats

  • XDG install layout for fresh installs only. Existing ~/.vite-plus installs keep their layout and vp upgrade leaves them in place. CI via setup-vp stays on the single-root layout, so the $HOME/.vite-plus/package_manager/pnpm/... paths in the mobile workflows keep working. A maintainer who does a fresh install will get ~/.local/share/vite-plus/bin instead; nothing in this repo hard-codes that path.
  • @vitejs/devtools optional peer range widened to ^0.4.0 || ^0.5.0. We do not depend on it.
  • Upgrade check moved out of process; commands no longer wait on the registry.
  • Newer oxlint/oxfmt may flag new issues; the pre-commit vp fmt on the two changed files was clean.

Verification

  • vp i refreshed the lockfile; vp --version inside apps/web reports vite-plus 0.3.0, vite 8.2.2, rolldown 1.2.5, vitest 4.1.11
  • vp run build in apps/web: built in 12.7s, working tree clean afterward
  • vp run typecheck in apps/web: exit 0
  • vp test run --project unit src/lib/assistantCitationNavigation.test.ts src/lib/attachmentUploadState.test.ts in apps/web: 2 files, 8 tests passed on vitest 4.1.11
  • T3CODE_BUNDLED_DEV=1 vp run dev in the worktree (no --share): after the first rolldown build the real index was served with <script type="module" src="/bundledDevClient.mjs"> and <script type="module" crossorigin src="/assets/index.js">; both returned 200 (text/javascript, 57 kB and 19.5 MB) with no error / ENOENT / preamble lines in the server log. Stopped by the process group of the PID captured at spawn.

Not verified here: the remote-browser --share path itself, which needs a second machine on the tailnet.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
Primarily a dev/build toolchain and auto-format refresh; application logic is unchanged aside from formatting, though a major vite/rolldown bump can still surface new build or lint issues in CI.

Overview
Bumps the workspace vite-plus / vite catalog pins from 0.2.2 to 0.3.0 and refreshes pnpm-lock.yaml, pulling in vite 8.2.2, rolldown 1.2.5, vitest 4.1.11, oxlint 1.79.0, oxfmt 0.64.0, and related native bindings (including new yuku-parser / yuku-codegen transitives).

Alongside the lockfile, many TypeScript files were reformatted only: multi-line .map / Effect.map / Effect.flatMap callbacks and similar patterns were collapsed to match oxfmt 0.64 (desktop, mobile, server, client-runtime, web, shared, generated schema.gen.ts). No intentional runtime or API behavior changes in those edits.

The upgrade targets more reliable experimental.bundledDev (used when shared dev defaults T3CODE_BUNDLED_DEV=1); app config in apps/web/vite.config.ts and scripts/dev-runner.ts is unchanged.

Reviewed by Cursor Bugbot for commit 21611ad. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Upgrade vite-plus to 0.3.0

Bumps the Vite alias and vite-plus catalog versions from 0.2.2 to 0.3.0 in pnpm-workspace.yaml and updates the lockfile. The rest of the PR is formatting-only reformatting across many provider, orchestration, and client modules triggered by the new formatter rules.

Macroscope summarized 21611ad.

Follow-up commit: oxfmt 0.57 → 0.64 reformat

The toolchain bump also moves oxfmt, which now hugs a sole trailing arrow-function argument (Effect.map((x) => ({...})) on one line instead of breaking before the arrow) and breaks long string-literal unions onto leading | lines. vp check failed on 29 pre-existing files for that reason, so a second commit runs vp fmt over the repo. Verified per file that the change is whitespace, trailing commas, and | placement only (stripping those, old and new are byte-identical). Includes packages/effect-codex-app-server/src/_generated/schema.gen.ts, whose generator already runs vp fmt over its output, so it stays consistent from here.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.2 KiB13.4 KiB+234 B (+1.7%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.6 KiB+238 B (+3.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB57.0 KiB+1.5 KiB (+2.7%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−48 B (−0.4%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−51 B (−0.8%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.3 KiB−88 B (−0.2%)66.4 KiB
ClaudeLive turn messages108−2 (−20.0%)21

Baseline: 3b2de9d · PR result: 21611ad · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This updates the shared Vite-plus build, bundling, testing, linting, and formatting toolchain across the monorepo, including the implementation of the existing bundled-development path. Although no application source changes are included, the upgrade can affect generated web/desktop/server artifacts and the unverified remote HMR path.

No code changes detected at 03de157. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

`vp run dev --share` defaults T3CODE_BUNDLED_DEV=1 so a remote browser
on the tailnet pays a few chunk requests instead of a per-module round
trip. On vite-plus 0.2.2 (vite 8.1.2 / rolldown 1.1.4) that bundled dev
mode is flaky for the shared origin: the page throws
"@vitejs/plugin-react can't detect preamble" and a base-ui namespace
import resolves to undefined inside <Collapsible>, so the app never
gets past the splash.
vite-plus 0.3.0 bundles vite 8.2.2 / rolldown 1.2.5, which carry the
batch of experimental.bundledDev fixes landed between 8.1.2 and 8.2.2
(reload once after rebuild, serve assets emitted during HMR/lazy
compile, skip plugin transforms for rolldown-lazy stubs, HMR error
printing, invalidate() stack overflow, duplicated buildEnd), plus the
vp dev ENOENT-at-startup fix from 0.2.9.
Only the two catalog entries in pnpm-workspace.yaml change; every
package consumes them via "catalog:". The lockfile delta is limited to
the vite-plus toolchain (vite-plus-core, vitest 4.1.11, oxlint 1.79,
oxfmt 0.64, oxlint-tsgolint, oxc types) and its new transitive deps
(lightningcss, yuku-parser/codegen). experimental.bundledDev is still
`boolean` in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts
need no change.
Verified: `vp i`, `vp run build` in apps/web, `vp run typecheck` in
apps/web, two unit test files in apps/web, and a T3CODE_BUNDLED_DEV=1
`vp run dev` that served the real index with /assets/index.js at 200
and no server-side errors.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:36
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
The toolchain bump moves oxfmt from 0.57 to 0.64, which hugs a sole
trailing arrow-function argument instead of breaking it. Whitespace only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@juliusmarminge
juliusmarminge merged commit f5fbb1b into mainSep 3, 2026
26 checks passed
@juliusmarminge
juliusmarminge deleted the chore/vite-plus-0.3.0 branch September 3, 2026 03:40
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore: upgrade vite-plus to 0.3.0 - #9327

Merged
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0
Sep 3, 2026
Merged

chore: upgrade vite-plus to 0.3.0#9327
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

vp run dev --share defaults T3CODE_BUNDLED_DEV=1 (scripts/dev-runner.ts, apps/web/vite.config.tsexperimental.bundledDev) so a remote browser on the tailnet pays a few chunk requests instead of a per-module round trip. On vite-plus 0.2.2, which bundles vite 8.1.2 / rolldown 1.1.4, that bundled dev mode is flaky for the shared origin: the page throws @vitejs/plugin-react can't detect preamble and Cannot read properties of undefined (reading 'Root') in <Collapsible> (a base-ui namespace import resolving to undefined in the bundled chunk), so the app never gets past the splash. Unbundled dev renders fine.

Fix

Bump the pinned toolchain to vite-plus 0.3.0, which bundles vite 8.2.2 / rolldown 1.2.5. The 8.1.2 to 8.2.2 range carries the batch of experimental.bundledDev fixes (vitejs/vite CHANGELOG):

  • bundled-dev: reload once after rebuild instead of via the fallback page (#23106)
  • bundled-dev: support worker file update accepted by HMR (#23068)
  • bundled-dev: print build errors when an HMR update fails (#23024)
  • bundled-dev: avoid stack overflow on import.meta.hot.invalidate() (#22797)
  • bundled-dev: serve assets emitted during HMR / lazy compile (#22745)
  • bundled-dev: skip plugin transform hooks for rolldown-lazy stub modules (#22778)
  • bundled-dev: avoid duplicated buildEnd (#22931)

Plus from vite-plus itself:

What changed

Only the two catalog entries in pnpm-workspace.yaml (vite: npm:@voidzero-dev/vite-plus-core@0.3.0, vite-plus: 0.3.0). Every package consumes them via catalog:, so nothing else needed touching. No other 0.2.2 pin exists in package.json files, workflows, Dockerfiles, or tool-version files; CI uses voidzero-dev/setup-vp@v1 with no version pin, and the local vp reads the project version from the lockfile.

The lockfile delta is limited to the vite-plus toolchain: vite-plus, @voidzero-dev/vite-plus-core and platform binaries, vitest 4.1.9 to 4.1.11, oxlint 1.72.0 to 1.79.0, oxfmt 0.57.0 to 0.64.0, oxlint-tsgolint 0.24.0 to 7.0.2001, @oxc-project/* 0.138.0 to 0.146.0, and new transitive deps of vite-plus-core (lightningcss 1.33.0, yuku-parser / yuku-codegen 0.5.48, @oxlint/plugins 1.79.0). No unrelated major bumps.

experimental.bundledDev is still typed boolean in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts need no change.

0.3.0 caveats

  • XDG install layout for fresh installs only. Existing ~/.vite-plus installs keep their layout and vp upgrade leaves them in place. CI via setup-vp stays on the single-root layout, so the $HOME/.vite-plus/package_manager/pnpm/... paths in the mobile workflows keep working. A maintainer who does a fresh install will get ~/.local/share/vite-plus/bin instead; nothing in this repo hard-codes that path.
  • @vitejs/devtools optional peer range widened to ^0.4.0 || ^0.5.0. We do not depend on it.
  • Upgrade check moved out of process; commands no longer wait on the registry.
  • Newer oxlint/oxfmt may flag new issues; the pre-commit vp fmt on the two changed files was clean.

Verification

  • vp i refreshed the lockfile; vp --version inside apps/web reports vite-plus 0.3.0, vite 8.2.2, rolldown 1.2.5, vitest 4.1.11
  • vp run build in apps/web: built in 12.7s, working tree clean afterward
  • vp run typecheck in apps/web: exit 0
  • vp test run --project unit src/lib/assistantCitationNavigation.test.ts src/lib/attachmentUploadState.test.ts in apps/web: 2 files, 8 tests passed on vitest 4.1.11
  • T3CODE_BUNDLED_DEV=1 vp run dev in the worktree (no --share): after the first rolldown build the real index was served with <script type="module" src="/bundledDevClient.mjs"> and <script type="module" crossorigin src="/assets/index.js">; both returned 200 (text/javascript, 57 kB and 19.5 MB) with no error / ENOENT / preamble lines in the server log. Stopped by the process group of the PID captured at spawn.

Not verified here: the remote-browser --share path itself, which needs a second machine on the tailnet.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
Primarily a dev/build toolchain and auto-format refresh; application logic is unchanged aside from formatting, though a major vite/rolldown bump can still surface new build or lint issues in CI.

Overview
Bumps the workspace vite-plus / vite catalog pins from 0.2.2 to 0.3.0 and refreshes pnpm-lock.yaml, pulling in vite 8.2.2, rolldown 1.2.5, vitest 4.1.11, oxlint 1.79.0, oxfmt 0.64.0, and related native bindings (including new yuku-parser / yuku-codegen transitives).

Alongside the lockfile, many TypeScript files were reformatted only: multi-line .map / Effect.map / Effect.flatMap callbacks and similar patterns were collapsed to match oxfmt 0.64 (desktop, mobile, server, client-runtime, web, shared, generated schema.gen.ts). No intentional runtime or API behavior changes in those edits.

The upgrade targets more reliable experimental.bundledDev (used when shared dev defaults T3CODE_BUNDLED_DEV=1); app config in apps/web/vite.config.ts and scripts/dev-runner.ts is unchanged.

Reviewed by Cursor Bugbot for commit 21611ad. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Upgrade vite-plus to 0.3.0

Bumps the Vite alias and vite-plus catalog versions from 0.2.2 to 0.3.0 in pnpm-workspace.yaml and updates the lockfile. The rest of the PR is formatting-only reformatting across many provider, orchestration, and client modules triggered by the new formatter rules.

Macroscope summarized 21611ad.

Follow-up commit: oxfmt 0.57 → 0.64 reformat

The toolchain bump also moves oxfmt, which now hugs a sole trailing arrow-function argument (Effect.map((x) => ({...})) on one line instead of breaking before the arrow) and breaks long string-literal unions onto leading | lines. vp check failed on 29 pre-existing files for that reason, so a second commit runs vp fmt over the repo. Verified per file that the change is whitespace, trailing commas, and | placement only (stripping those, old and new are byte-identical). Includes packages/effect-codex-app-server/src/_generated/schema.gen.ts, whose generator already runs vp fmt over its output, so it stays consistent from here.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.2 KiB13.4 KiB+234 B (+1.7%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.6 KiB+238 B (+3.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB57.0 KiB+1.5 KiB (+2.7%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−48 B (−0.4%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−51 B (−0.8%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.3 KiB−88 B (−0.2%)66.4 KiB
ClaudeLive turn messages108−2 (−20.0%)21

Baseline: 3b2de9d · PR result: 21611ad · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This updates the shared Vite-plus build, bundling, testing, linting, and formatting toolchain across the monorepo, including the implementation of the existing bundled-development path. Although no application source changes are included, the upgrade can affect generated web/desktop/server artifacts and the unverified remote HMR path.

No code changes detected at 03de157. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

`vp run dev --share` defaults T3CODE_BUNDLED_DEV=1 so a remote browser
on the tailnet pays a few chunk requests instead of a per-module round
trip. On vite-plus 0.2.2 (vite 8.1.2 / rolldown 1.1.4) that bundled dev
mode is flaky for the shared origin: the page throws
"@vitejs/plugin-react can't detect preamble" and a base-ui namespace
import resolves to undefined inside <Collapsible>, so the app never
gets past the splash.
vite-plus 0.3.0 bundles vite 8.2.2 / rolldown 1.2.5, which carry the
batch of experimental.bundledDev fixes landed between 8.1.2 and 8.2.2
(reload once after rebuild, serve assets emitted during HMR/lazy
compile, skip plugin transforms for rolldown-lazy stubs, HMR error
printing, invalidate() stack overflow, duplicated buildEnd), plus the
vp dev ENOENT-at-startup fix from 0.2.9.
Only the two catalog entries in pnpm-workspace.yaml change; every
package consumes them via "catalog:". The lockfile delta is limited to
the vite-plus toolchain (vite-plus-core, vitest 4.1.11, oxlint 1.79,
oxfmt 0.64, oxlint-tsgolint, oxc types) and its new transitive deps
(lightningcss, yuku-parser/codegen). experimental.bundledDev is still
`boolean` in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts
need no change.
Verified: `vp i`, `vp run build` in apps/web, `vp run typecheck` in
apps/web, two unit test files in apps/web, and a T3CODE_BUNDLED_DEV=1
`vp run dev` that served the real index with /assets/index.js at 200
and no server-side errors.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:36
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
The toolchain bump moves oxfmt from 0.57 to 0.64, which hugs a sole
trailing arrow-function argument instead of breaking it. Whitespace only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@juliusmarminge
juliusmarminge merged commit f5fbb1b into mainSep 3, 2026
26 checks passed
@juliusmarminge
juliusmarminge deleted the chore/vite-plus-0.3.0 branch September 3, 2026 03:40
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

chore: upgrade vite-plus to 0.3.0 - #9327

Merged
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0
Sep 3, 2026
Merged

chore: upgrade vite-plus to 0.3.0#9327
juliusmarminge merged 2 commits into
mainfrom
chore/vite-plus-0.3.0

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

vp run dev --share defaults T3CODE_BUNDLED_DEV=1 (scripts/dev-runner.ts, apps/web/vite.config.tsexperimental.bundledDev) so a remote browser on the tailnet pays a few chunk requests instead of a per-module round trip. On vite-plus 0.2.2, which bundles vite 8.1.2 / rolldown 1.1.4, that bundled dev mode is flaky for the shared origin: the page throws @vitejs/plugin-react can't detect preamble and Cannot read properties of undefined (reading 'Root') in <Collapsible> (a base-ui namespace import resolving to undefined in the bundled chunk), so the app never gets past the splash. Unbundled dev renders fine.

Fix

Bump the pinned toolchain to vite-plus 0.3.0, which bundles vite 8.2.2 / rolldown 1.2.5. The 8.1.2 to 8.2.2 range carries the batch of experimental.bundledDev fixes (vitejs/vite CHANGELOG):

  • bundled-dev: reload once after rebuild instead of via the fallback page (#23106)
  • bundled-dev: support worker file update accepted by HMR (#23068)
  • bundled-dev: print build errors when an HMR update fails (#23024)
  • bundled-dev: avoid stack overflow on import.meta.hot.invalidate() (#22797)
  • bundled-dev: serve assets emitted during HMR / lazy compile (#22745)
  • bundled-dev: skip plugin transform hooks for rolldown-lazy stub modules (#22778)
  • bundled-dev: avoid duplicated buildEnd (#22931)

Plus from vite-plus itself:

What changed

Only the two catalog entries in pnpm-workspace.yaml (vite: npm:@voidzero-dev/vite-plus-core@0.3.0, vite-plus: 0.3.0). Every package consumes them via catalog:, so nothing else needed touching. No other 0.2.2 pin exists in package.json files, workflows, Dockerfiles, or tool-version files; CI uses voidzero-dev/setup-vp@v1 with no version pin, and the local vp reads the project version from the lockfile.

The lockfile delta is limited to the vite-plus toolchain: vite-plus, @voidzero-dev/vite-plus-core and platform binaries, vitest 4.1.9 to 4.1.11, oxlint 1.72.0 to 1.79.0, oxfmt 0.57.0 to 0.64.0, oxlint-tsgolint 0.24.0 to 7.0.2001, @oxc-project/* 0.138.0 to 0.146.0, and new transitive deps of vite-plus-core (lightningcss 1.33.0, yuku-parser / yuku-codegen 0.5.48, @oxlint/plugins 1.79.0). No unrelated major bumps.

experimental.bundledDev is still typed boolean in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts need no change.

0.3.0 caveats

  • XDG install layout for fresh installs only. Existing ~/.vite-plus installs keep their layout and vp upgrade leaves them in place. CI via setup-vp stays on the single-root layout, so the $HOME/.vite-plus/package_manager/pnpm/... paths in the mobile workflows keep working. A maintainer who does a fresh install will get ~/.local/share/vite-plus/bin instead; nothing in this repo hard-codes that path.
  • @vitejs/devtools optional peer range widened to ^0.4.0 || ^0.5.0. We do not depend on it.
  • Upgrade check moved out of process; commands no longer wait on the registry.
  • Newer oxlint/oxfmt may flag new issues; the pre-commit vp fmt on the two changed files was clean.

Verification

  • vp i refreshed the lockfile; vp --version inside apps/web reports vite-plus 0.3.0, vite 8.2.2, rolldown 1.2.5, vitest 4.1.11
  • vp run build in apps/web: built in 12.7s, working tree clean afterward
  • vp run typecheck in apps/web: exit 0
  • vp test run --project unit src/lib/assistantCitationNavigation.test.ts src/lib/attachmentUploadState.test.ts in apps/web: 2 files, 8 tests passed on vitest 4.1.11
  • T3CODE_BUNDLED_DEV=1 vp run dev in the worktree (no --share): after the first rolldown build the real index was served with <script type="module" src="/bundledDevClient.mjs"> and <script type="module" crossorigin src="/assets/index.js">; both returned 200 (text/javascript, 57 kB and 19.5 MB) with no error / ENOENT / preamble lines in the server log. Stopped by the process group of the PID captured at spawn.

Not verified here: the remote-browser --share path itself, which needs a second machine on the tailnet.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
Primarily a dev/build toolchain and auto-format refresh; application logic is unchanged aside from formatting, though a major vite/rolldown bump can still surface new build or lint issues in CI.

Overview
Bumps the workspace vite-plus / vite catalog pins from 0.2.2 to 0.3.0 and refreshes pnpm-lock.yaml, pulling in vite 8.2.2, rolldown 1.2.5, vitest 4.1.11, oxlint 1.79.0, oxfmt 0.64.0, and related native bindings (including new yuku-parser / yuku-codegen transitives).

Alongside the lockfile, many TypeScript files were reformatted only: multi-line .map / Effect.map / Effect.flatMap callbacks and similar patterns were collapsed to match oxfmt 0.64 (desktop, mobile, server, client-runtime, web, shared, generated schema.gen.ts). No intentional runtime or API behavior changes in those edits.

The upgrade targets more reliable experimental.bundledDev (used when shared dev defaults T3CODE_BUNDLED_DEV=1); app config in apps/web/vite.config.ts and scripts/dev-runner.ts is unchanged.

Reviewed by Cursor Bugbot for commit 21611ad. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Upgrade vite-plus to 0.3.0

Bumps the Vite alias and vite-plus catalog versions from 0.2.2 to 0.3.0 in pnpm-workspace.yaml and updates the lockfile. The rest of the PR is formatting-only reformatting across many provider, orchestration, and client modules triggered by the new formatter rules.

Macroscope summarized 21611ad.

Follow-up commit: oxfmt 0.57 → 0.64 reformat

The toolchain bump also moves oxfmt, which now hugs a sole trailing arrow-function argument (Effect.map((x) => ({...})) on one line instead of breaking before the arrow) and breaks long string-literal unions onto leading | lines. vp check failed on 29 pre-existing files for that reason, so a second commit runs vp fmt over the repo. Verified per file that the change is whitespace, trailing commas, and | placement only (stripping those, old and new are byte-identical). Includes packages/effect-codex-app-server/src/_generated/schema.gen.ts, whose generator already runs vp fmt over its output, so it stays consistent from here.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.2 KiB13.4 KiB+234 B (+1.7%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−4 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.3 KiB6.6 KiB+238 B (+3.7%)7.8 KiB
CodexLive turn WebSocket decoded55.5 KiB57.0 KiB+1.5 KiB (+2.7%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−48 B (−0.4%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−51 B (−0.8%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.3 KiB−88 B (−0.2%)66.4 KiB
ClaudeLive turn messages108−2 (−20.0%)21

Baseline: 3b2de9d · PR result: 21611ad · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This updates the shared Vite-plus build, bundling, testing, linting, and formatting toolchain across the monorepo, including the implementation of the existing bundled-development path. Although no application source changes are included, the upgrade can affect generated web/desktop/server artifacts and the unverified remote HMR path.

No code changes detected at 03de157. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

`vp run dev --share` defaults T3CODE_BUNDLED_DEV=1 so a remote browser
on the tailnet pays a few chunk requests instead of a per-module round
trip. On vite-plus 0.2.2 (vite 8.1.2 / rolldown 1.1.4) that bundled dev
mode is flaky for the shared origin: the page throws
"@vitejs/plugin-react can't detect preamble" and a base-ui namespace
import resolves to undefined inside <Collapsible>, so the app never
gets past the splash.
vite-plus 0.3.0 bundles vite 8.2.2 / rolldown 1.2.5, which carry the
batch of experimental.bundledDev fixes landed between 8.1.2 and 8.2.2
(reload once after rebuild, serve assets emitted during HMR/lazy
compile, skip plugin transforms for rolldown-lazy stubs, HMR error
printing, invalidate() stack overflow, duplicated buildEnd), plus the
vp dev ENOENT-at-startup fix from 0.2.9.
Only the two catalog entries in pnpm-workspace.yaml change; every
package consumes them via "catalog:". The lockfile delta is limited to
the vite-plus toolchain (vite-plus-core, vitest 4.1.11, oxlint 1.79,
oxfmt 0.64, oxlint-tsgolint, oxc types) and its new transitive deps
(lightningcss, yuku-parser/codegen). experimental.bundledDev is still
`boolean` in 8.2.2, so apps/web/vite.config.ts and scripts/dev-runner.ts
need no change.
Verified: `vp i`, `vp run build` in apps/web, `vp run typecheck` in
apps/web, two unit test files in apps/web, and a T3CODE_BUNDLED_DEV=1
`vp run dev` that served the real index with /assets/index.js at 200
and no server-side errors.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:36
@github-actionsgithub-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 3, 2026
The toolchain bump moves oxfmt from 0.57 to 0.64, which hugs a sole
trailing arrow-function argument instead of breaking it. Whitespace only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@juliusmarminge
juliusmarminge merged commit f5fbb1b into mainSep 3, 2026
26 checks passed
@juliusmarminge
juliusmarminge deleted the chore/vite-plus-0.3.0 branch September 3, 2026 03:40
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge