feat(web): add a file tree to the diff panel and pull request code tab

[juliusmarminge]

Problem

Reading a diff with many files means scrolling through all of them to find the one you want. Neither the thread Diff panel nor the pull request Code tab had any way to see the changed files as a structure or jump straight to one.

Fix

One shared DiffFileTree component (apps/web/src/components/diffs/), mounted in both places behind a folder-tree toggle at the end of each toolbar (same spot and icon as the Files tab). The toggle persists per view in localStorage, off by default.

• Pierre file tree of the changed files with git status marks (A/M/D/R), directories open by default, plus an expand/collapse-all-folders control in the tree header.
• Clicking a file expands it if it was folded and scrolls the code view to it.
• The tree diffs the path list into add/remove batch ops instead of rebuilding, so a refresh after an agent edit or a later PR slice keeps whatever folders the reader has opened or closed.
• Thread diff panel: the file selected from the chat's changed-files list is mirrored into the tree (select + reveal).
• PR code tab: a Load more files footer while the diff is still paging (also acts as Retry on failure). The existing scroll sentinel and this button share one loadNextSlice.
• The Files tab's Pierre theme CSS moves to pierre-tree-theme.ts so all three trees share it.

Based on the approach in #6373 by @ShpetimA; that PR predates #9174 (expanded-by-default) and had drifted, so this is a fresh cut with him as co-author. Deliberately not coupling "expand all files" to "expand all folders" — the tree has its own button, matching the Files tab.

Surfaces

• Web + desktop (shared apps/web). Mobile has its own diff UI and is unchanged.
• Docs: docs/user/source-control.md.
• Providers/contracts: untouched.

Verification

vp test run apps/web/src/components/diffs/diffFileTree.logic.test.ts (6 tests), tsgo --noEmit in apps/web, targeted vp lint on the touched files. Manually verified in a real browser against a snapshot of real data.

Thread diff panel

Before	After

Switching scope to Branch changes rebuilds the tree for that scope:

Walkthrough (toggle on, jump to two files, collapse/expand folders, switch scope, jump again, toggle off):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/ec08e7f59a261fe0/diff-panel.mp4

Pull request Code tab (PR #9253, 52 files)

Walkthrough (toggle on, jump, collapse all folders, drill into apps/web/src, collapse all files from the toolbar, then pick a file in the tree so it expands just that one and scrolls to it):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/28416528c557fe77/pr-code-tab.mp4

Not exercised: the Load more files footer, since every open PR I tried fits in GitHub's 100-file page so nextCursor is never set. It drives the same code path as the existing scroll sentinel.

---

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
UI-only navigation and layout in shared web diff views; no auth, API, or data-model changes.

Overview
Adds a folder-tree sidebar to the thread Diff panel and pull request Code tab so reviewers can browse changed files by path and jump to any file without scrolling the full patch.

A shared DiffFileTree (Pierre file tree + git status badges) sits beside the diff viewer when a toolbar Show file tree toggle is on. Visibility is persisted in localStorage per surface (off by default). Picking a file unfolds a collapsed diff and scrolls the code view to it; the thread panel also syncs selection from chat changed-files links into the tree.

Tree paths update incrementally via buildDiffFileTreeUpdates so refreshes and paged PR slices keep folder expand/collapse state. On large PRs, the tree footer exposes Load more files / Retry, sharing the same loadNextSlice path as the scroll sentinel. Pierre tree styling is centralized in pierre-tree-theme.ts (also used by the Files tab). User docs in source-control.md describe the feature.

^{Reviewed by Cursor Bugbot for commit 5ea691d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add file tree toggle and navigation to DiffPanel

• Adds a toolbar toggle in DiffPanel.tsx that shows a side-by-side DiffFileTree listing all changed files
• The toggle state is persisted across sessions
• Selecting a file in the tree reopens its diff if collapsed and scrolls the viewer to it
• Risk: new layout adds a conditional sidebar next to the diff viewer; verify rendering on narrow viewports

^{Macroscope summarized 5ea691d.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.4 KiB	13.4 KiB	+4 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+3 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+1 B (+0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−29 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−9 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−20 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: f5fbb1b · PR result: 5ea691d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new persisted file-tree workflow across two production diff surfaces, including dynamic folder updates, selection synchronization, scrolling, and pull-request paging controls. The supplied unresolved comments identify medium-severity risks in incremental folder expansion and flattened-directory handling, while the new product defaults require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

New folders stay collapsed after updates

Medium Severity

initialExpansion: "open" only applies to the first resetPaths. Later path changes use batch adds and never expand the new directories. A scope switch, agent refresh, or PR slice that introduces a new folder can hide those files behind collapsed rows, even though directories are supposed to start open.

Additional Locations (2)

• apps/web/src/components/diffs/DiffFileTree.tsx#L73-L77
• apps/web/src/components/DiffPanel.tsx#L1032-L1041

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

Checked against the Pierre source and this does not happen. initialExpansion: "open" sets state.defaultExpansion = "open", and isDirectoryExpanded falls through to isDirectoryExpandedByDefault, which returns true for any directory not explicitly collapsed — including ones added later via batch. The only path that marks new directories collapsed on add is collapseNewDirectoriesByDefault, which is set only when initialExpansion is "closed" and every directory was listed in initialExpandedPaths (the approach #6373 used, which is exactly why it needed a reset-and-recompute effect). Verified in the recording: switching the scope to Branch changes swaps in a whole new set of folders and they all arrive open.

[cursor]

Ancestor expand misses unsuffixed folders

Low Severity

The reveal effect expands ancestors only via model.getItem with a trailing slash. The Files tab looks up both the slashed and unsuffixed ids because Pierre can register a flattened directory under either form. If the slashed lookup misses, a collapsed parent stays closed and the selected file is not revealed.

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

FileTreeController.getItem documents that it "accepts both canonical directory paths (src/) and bare directory lookup paths (src)", so the trailing-slash form already resolves flattened directories; the double lookup in FileBrowserPanel is belt-and-braces, not a requirement. Leaving as is.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[cursor]

Flattened folders break expand-all

Medium Severity

DiffFileTree turns on flattenEmptyDirectories and seeds Pierre with file paths only, then treats every ancestor from collectDirectoryPaths as a real item. Flattened single-child chains often have no apps/ or apps/web/ node, so areAllDirectoriesExpanded stays false and the header control keeps offering Expand instead of Collapse. The same lookups drive chat reveal, so collapsed ancestors may never reopen.

Additional Locations (2)

• apps/web/src/components/diffs/diffFileTree.logic.ts#L36-L48
• apps/web/src/components/diffs/DiffFileTree.tsx#L147-L160

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[juliusmarminge]

Tested this against @pierre/trees directly rather than assume: a FileTree with flattenEmptyDirectories: true, initialExpansion: "open", seeded only with apps/mobile/src/a.ts, apps/mobile/src/b.ts, docs/x.md. getItem resolves every ancestor from collectDirectoryPaths (apps/, apps/mobile/, apps/mobile/src/) — flattening is a render-time projection over the canonical path store, the nodes still exist. areAllDirectoriesExpanded is true on load and flips to false after collapsing apps/mobile/src/, so the header control toggles correctly. This is also the same helper and the same flattenEmptyDirectories setting the Files tab has shipped with. The recordings in the description show both the collapse/expand-all toggle and chat-driven reveal working over flattened chains (mobile / src, server / src / environment).

[juliusmarminge]

Problem

Reading a diff with many files means scrolling through all of them to find the one you want. Neither the thread Diff panel nor the pull request Code tab had any way to see the changed files as a structure or jump straight to one.

Fix

One shared DiffFileTree component (apps/web/src/components/diffs/), mounted in both places behind a folder-tree toggle at the end of each toolbar (same spot and icon as the Files tab). The toggle persists per view in localStorage, off by default.

• Pierre file tree of the changed files with git status marks (A/M/D/R), directories open by default, plus an expand/collapse-all-folders control in the tree header.
• Clicking a file expands it if it was folded and scrolls the code view to it.
• The tree diffs the path list into add/remove batch ops instead of rebuilding, so a refresh after an agent edit or a later PR slice keeps whatever folders the reader has opened or closed.
• Thread diff panel: the file selected from the chat's changed-files list is mirrored into the tree (select + reveal).
• PR code tab: a Load more files footer while the diff is still paging (also acts as Retry on failure). The existing scroll sentinel and this button share one loadNextSlice.
• The Files tab's Pierre theme CSS moves to pierre-tree-theme.ts so all three trees share it.

Based on the approach in #6373 by @ShpetimA; that PR predates #9174 (expanded-by-default) and had drifted, so this is a fresh cut with him as co-author. Deliberately not coupling "expand all files" to "expand all folders" — the tree has its own button, matching the Files tab.

Surfaces

• Web + desktop (shared apps/web). Mobile has its own diff UI and is unchanged.
• Docs: docs/user/source-control.md.
• Providers/contracts: untouched.

Verification

vp test run apps/web/src/components/diffs/diffFileTree.logic.test.ts (6 tests), tsgo --noEmit in apps/web, targeted vp lint on the touched files. Manually verified in a real browser against a snapshot of real data.

Thread diff panel

Before	After

Switching scope to Branch changes rebuilds the tree for that scope:

Walkthrough (toggle on, jump to two files, collapse/expand folders, switch scope, jump again, toggle off):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/ec08e7f59a261fe0/diff-panel.mp4

Pull request Code tab (PR #9253, 52 files)

Walkthrough (toggle on, jump, collapse all folders, drill into apps/web/src, collapse all files from the toolbar, then pick a file in the tree so it expands just that one and scrolls to it):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/28416528c557fe77/pr-code-tab.mp4

Not exercised: the Load more files footer, since every open PR I tried fits in GitHub's 100-file page so nextCursor is never set. It drives the same code path as the existing scroll sentinel.

---

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
UI-only navigation and layout in shared web diff views; no auth, API, or data-model changes.

Overview
Adds a folder-tree sidebar to the thread Diff panel and pull request Code tab so reviewers can browse changed files by path and jump to any file without scrolling the full patch.

A shared DiffFileTree (Pierre file tree + git status badges) sits beside the diff viewer when a toolbar Show file tree toggle is on. Visibility is persisted in localStorage per surface (off by default). Picking a file unfolds a collapsed diff and scrolls the code view to it; the thread panel also syncs selection from chat changed-files links into the tree.

Tree paths update incrementally via buildDiffFileTreeUpdates so refreshes and paged PR slices keep folder expand/collapse state. On large PRs, the tree footer exposes Load more files / Retry, sharing the same loadNextSlice path as the scroll sentinel. Pierre tree styling is centralized in pierre-tree-theme.ts (also used by the Files tab). User docs in source-control.md describe the feature.

^{Reviewed by Cursor Bugbot for commit 5ea691d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add file tree toggle and navigation to DiffPanel

• Adds a toolbar toggle in DiffPanel.tsx that shows a side-by-side DiffFileTree listing all changed files
• The toggle state is persisted across sessions
• Selecting a file in the tree reopens its diff if collapsed and scrolls the viewer to it
• Risk: new layout adds a conditional sidebar next to the diff viewer; verify rendering on narrow viewports

^{Macroscope summarized 5ea691d.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.4 KiB	13.4 KiB	+4 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+3 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+1 B (+0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−29 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−9 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−20 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: f5fbb1b · PR result: 5ea691d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new persisted file-tree workflow across two production diff surfaces, including dynamic folder updates, selection synchronization, scrolling, and pull-request paging controls. The supplied unresolved comments identify medium-severity risks in incremental folder expansion and flattened-directory handling, while the new product defaults require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

New folders stay collapsed after updates

Medium Severity

initialExpansion: "open" only applies to the first resetPaths. Later path changes use batch adds and never expand the new directories. A scope switch, agent refresh, or PR slice that introduces a new folder can hide those files behind collapsed rows, even though directories are supposed to start open.

Additional Locations (2)

• apps/web/src/components/diffs/DiffFileTree.tsx#L73-L77
• apps/web/src/components/DiffPanel.tsx#L1032-L1041

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

Checked against the Pierre source and this does not happen. initialExpansion: "open" sets state.defaultExpansion = "open", and isDirectoryExpanded falls through to isDirectoryExpandedByDefault, which returns true for any directory not explicitly collapsed — including ones added later via batch. The only path that marks new directories collapsed on add is collapseNewDirectoriesByDefault, which is set only when initialExpansion is "closed" and every directory was listed in initialExpandedPaths (the approach #6373 used, which is exactly why it needed a reset-and-recompute effect). Verified in the recording: switching the scope to Branch changes swaps in a whole new set of folders and they all arrive open.

[cursor]

Ancestor expand misses unsuffixed folders

Low Severity

The reveal effect expands ancestors only via model.getItem with a trailing slash. The Files tab looks up both the slashed and unsuffixed ids because Pierre can register a flattened directory under either form. If the slashed lookup misses, a collapsed parent stays closed and the selected file is not revealed.

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

FileTreeController.getItem documents that it "accepts both canonical directory paths (src/) and bare directory lookup paths (src)", so the trailing-slash form already resolves flattened directories; the double lookup in FileBrowserPanel is belt-and-braces, not a requirement. Leaving as is.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[cursor]

Flattened folders break expand-all

Medium Severity

DiffFileTree turns on flattenEmptyDirectories and seeds Pierre with file paths only, then treats every ancestor from collectDirectoryPaths as a real item. Flattened single-child chains often have no apps/ or apps/web/ node, so areAllDirectoriesExpanded stays false and the header control keeps offering Expand instead of Collapse. The same lookups drive chat reveal, so collapsed ancestors may never reopen.

Additional Locations (2)

• apps/web/src/components/diffs/diffFileTree.logic.ts#L36-L48
• apps/web/src/components/diffs/DiffFileTree.tsx#L147-L160

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[juliusmarminge]

Tested this against @pierre/trees directly rather than assume: a FileTree with flattenEmptyDirectories: true, initialExpansion: "open", seeded only with apps/mobile/src/a.ts, apps/mobile/src/b.ts, docs/x.md. getItem resolves every ancestor from collectDirectoryPaths (apps/, apps/mobile/, apps/mobile/src/) — flattening is a render-time projection over the canonical path store, the nodes still exist. areAllDirectoriesExpanded is true on load and flips to false after collapsing apps/mobile/src/, so the header control toggles correctly. This is also the same helper and the same flattenEmptyDirectories setting the Files tab has shipped with. The recordings in the description show both the collapse/expand-all toggle and chat-driven reveal working over flattened chains (mobile / src, server / src / environment).

[juliusmarminge]

Problem

Reading a diff with many files means scrolling through all of them to find the one you want. Neither the thread Diff panel nor the pull request Code tab had any way to see the changed files as a structure or jump straight to one.

Fix

One shared DiffFileTree component (apps/web/src/components/diffs/), mounted in both places behind a folder-tree toggle at the end of each toolbar (same spot and icon as the Files tab). The toggle persists per view in localStorage, off by default.

• Pierre file tree of the changed files with git status marks (A/M/D/R), directories open by default, plus an expand/collapse-all-folders control in the tree header.
• Clicking a file expands it if it was folded and scrolls the code view to it.
• The tree diffs the path list into add/remove batch ops instead of rebuilding, so a refresh after an agent edit or a later PR slice keeps whatever folders the reader has opened or closed.
• Thread diff panel: the file selected from the chat's changed-files list is mirrored into the tree (select + reveal).
• PR code tab: a Load more files footer while the diff is still paging (also acts as Retry on failure). The existing scroll sentinel and this button share one loadNextSlice.
• The Files tab's Pierre theme CSS moves to pierre-tree-theme.ts so all three trees share it.

Based on the approach in #6373 by @ShpetimA; that PR predates #9174 (expanded-by-default) and had drifted, so this is a fresh cut with him as co-author. Deliberately not coupling "expand all files" to "expand all folders" — the tree has its own button, matching the Files tab.

Surfaces

• Web + desktop (shared apps/web). Mobile has its own diff UI and is unchanged.
• Docs: docs/user/source-control.md.
• Providers/contracts: untouched.

Verification

vp test run apps/web/src/components/diffs/diffFileTree.logic.test.ts (6 tests), tsgo --noEmit in apps/web, targeted vp lint on the touched files. Manually verified in a real browser against a snapshot of real data.

Thread diff panel

Before	After

Switching scope to Branch changes rebuilds the tree for that scope:

Walkthrough (toggle on, jump to two files, collapse/expand folders, switch scope, jump again, toggle off):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/ec08e7f59a261fe0/diff-panel.mp4

Pull request Code tab (PR #9253, 52 files)

Walkthrough (toggle on, jump, collapse all folders, drill into apps/web/src, collapse all files from the toolbar, then pick a file in the tree so it expands just that one and scrolls to it):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/28416528c557fe77/pr-code-tab.mp4

Not exercised: the Load more files footer, since every open PR I tried fits in GitHub's 100-file page so nextCursor is never set. It drives the same code path as the existing scroll sentinel.

---

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
UI-only navigation and layout in shared web diff views; no auth, API, or data-model changes.

Overview
Adds a folder-tree sidebar to the thread Diff panel and pull request Code tab so reviewers can browse changed files by path and jump to any file without scrolling the full patch.

A shared DiffFileTree (Pierre file tree + git status badges) sits beside the diff viewer when a toolbar Show file tree toggle is on. Visibility is persisted in localStorage per surface (off by default). Picking a file unfolds a collapsed diff and scrolls the code view to it; the thread panel also syncs selection from chat changed-files links into the tree.

Tree paths update incrementally via buildDiffFileTreeUpdates so refreshes and paged PR slices keep folder expand/collapse state. On large PRs, the tree footer exposes Load more files / Retry, sharing the same loadNextSlice path as the scroll sentinel. Pierre tree styling is centralized in pierre-tree-theme.ts (also used by the Files tab). User docs in source-control.md describe the feature.

^{Reviewed by Cursor Bugbot for commit 5ea691d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add file tree toggle and navigation to DiffPanel

• Adds a toolbar toggle in DiffPanel.tsx that shows a side-by-side DiffFileTree listing all changed files
• The toggle state is persisted across sessions
• Selecting a file in the tree reopens its diff if collapsed and scrolls the viewer to it
• Risk: new layout adds a conditional sidebar next to the diff viewer; verify rendering on narrow viewports

^{Macroscope summarized 5ea691d.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.4 KiB	13.4 KiB	+4 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+3 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+1 B (+0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−29 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−9 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−20 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: f5fbb1b · PR result: 5ea691d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new persisted file-tree workflow across two production diff surfaces, including dynamic folder updates, selection synchronization, scrolling, and pull-request paging controls. The supplied unresolved comments identify medium-severity risks in incremental folder expansion and flattened-directory handling, while the new product defaults require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

New folders stay collapsed after updates

Medium Severity

initialExpansion: "open" only applies to the first resetPaths. Later path changes use batch adds and never expand the new directories. A scope switch, agent refresh, or PR slice that introduces a new folder can hide those files behind collapsed rows, even though directories are supposed to start open.

Additional Locations (2)

• apps/web/src/components/diffs/DiffFileTree.tsx#L73-L77
• apps/web/src/components/DiffPanel.tsx#L1032-L1041

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

Checked against the Pierre source and this does not happen. initialExpansion: "open" sets state.defaultExpansion = "open", and isDirectoryExpanded falls through to isDirectoryExpandedByDefault, which returns true for any directory not explicitly collapsed — including ones added later via batch. The only path that marks new directories collapsed on add is collapseNewDirectoriesByDefault, which is set only when initialExpansion is "closed" and every directory was listed in initialExpandedPaths (the approach #6373 used, which is exactly why it needed a reset-and-recompute effect). Verified in the recording: switching the scope to Branch changes swaps in a whole new set of folders and they all arrive open.

[cursor]

Ancestor expand misses unsuffixed folders

Low Severity

The reveal effect expands ancestors only via model.getItem with a trailing slash. The Files tab looks up both the slashed and unsuffixed ids because Pierre can register a flattened directory under either form. If the slashed lookup misses, a collapsed parent stays closed and the selected file is not revealed.

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

FileTreeController.getItem documents that it "accepts both canonical directory paths (src/) and bare directory lookup paths (src)", so the trailing-slash form already resolves flattened directories; the double lookup in FileBrowserPanel is belt-and-braces, not a requirement. Leaving as is.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[cursor]

Flattened folders break expand-all

Medium Severity

DiffFileTree turns on flattenEmptyDirectories and seeds Pierre with file paths only, then treats every ancestor from collectDirectoryPaths as a real item. Flattened single-child chains often have no apps/ or apps/web/ node, so areAllDirectoriesExpanded stays false and the header control keeps offering Expand instead of Collapse. The same lookups drive chat reveal, so collapsed ancestors may never reopen.

Additional Locations (2)

• apps/web/src/components/diffs/diffFileTree.logic.ts#L36-L48
• apps/web/src/components/diffs/DiffFileTree.tsx#L147-L160

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[juliusmarminge]

Tested this against @pierre/trees directly rather than assume: a FileTree with flattenEmptyDirectories: true, initialExpansion: "open", seeded only with apps/mobile/src/a.ts, apps/mobile/src/b.ts, docs/x.md. getItem resolves every ancestor from collectDirectoryPaths (apps/, apps/mobile/, apps/mobile/src/) — flattening is a render-time projection over the canonical path store, the nodes still exist. areAllDirectoriesExpanded is true on load and flips to false after collapsing apps/mobile/src/, so the header control toggles correctly. This is also the same helper and the same flattenEmptyDirectories setting the Files tab has shipped with. The recordings in the description show both the collapse/expand-all toggle and chat-driven reveal working over flattened chains (mobile / src, server / src / environment).

[juliusmarminge]

Problem

Reading a diff with many files means scrolling through all of them to find the one you want. Neither the thread Diff panel nor the pull request Code tab had any way to see the changed files as a structure or jump straight to one.

Fix

One shared DiffFileTree component (apps/web/src/components/diffs/), mounted in both places behind a folder-tree toggle at the end of each toolbar (same spot and icon as the Files tab). The toggle persists per view in localStorage, off by default.

• Pierre file tree of the changed files with git status marks (A/M/D/R), directories open by default, plus an expand/collapse-all-folders control in the tree header.
• Clicking a file expands it if it was folded and scrolls the code view to it.
• The tree diffs the path list into add/remove batch ops instead of rebuilding, so a refresh after an agent edit or a later PR slice keeps whatever folders the reader has opened or closed.
• Thread diff panel: the file selected from the chat's changed-files list is mirrored into the tree (select + reveal).
• PR code tab: a Load more files footer while the diff is still paging (also acts as Retry on failure). The existing scroll sentinel and this button share one loadNextSlice.
• The Files tab's Pierre theme CSS moves to pierre-tree-theme.ts so all three trees share it.

Based on the approach in #6373 by @ShpetimA; that PR predates #9174 (expanded-by-default) and had drifted, so this is a fresh cut with him as co-author. Deliberately not coupling "expand all files" to "expand all folders" — the tree has its own button, matching the Files tab.

Surfaces

• Web + desktop (shared apps/web). Mobile has its own diff UI and is unchanged.
• Docs: docs/user/source-control.md.
• Providers/contracts: untouched.

Verification

vp test run apps/web/src/components/diffs/diffFileTree.logic.test.ts (6 tests), tsgo --noEmit in apps/web, targeted vp lint on the touched files. Manually verified in a real browser against a snapshot of real data.

Thread diff panel

Before	After

Switching scope to Branch changes rebuilds the tree for that scope:

Walkthrough (toggle on, jump to two files, collapse/expand folders, switch scope, jump again, toggle off):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/ec08e7f59a261fe0/diff-panel.mp4

Pull request Code tab (PR #9253, 52 files)

Walkthrough (toggle on, jump, collapse all folders, drill into apps/web/src, collapse all files from the toolbar, then pick a file in the tree so it expands just that one and scrolls to it):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/28416528c557fe77/pr-code-tab.mp4

Not exercised: the Load more files footer, since every open PR I tried fits in GitHub's 100-file page so nextCursor is never set. It drives the same code path as the existing scroll sentinel.

---

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
UI-only navigation and layout in shared web diff views; no auth, API, or data-model changes.

Overview
Adds a folder-tree sidebar to the thread Diff panel and pull request Code tab so reviewers can browse changed files by path and jump to any file without scrolling the full patch.

A shared DiffFileTree (Pierre file tree + git status badges) sits beside the diff viewer when a toolbar Show file tree toggle is on. Visibility is persisted in localStorage per surface (off by default). Picking a file unfolds a collapsed diff and scrolls the code view to it; the thread panel also syncs selection from chat changed-files links into the tree.

Tree paths update incrementally via buildDiffFileTreeUpdates so refreshes and paged PR slices keep folder expand/collapse state. On large PRs, the tree footer exposes Load more files / Retry, sharing the same loadNextSlice path as the scroll sentinel. Pierre tree styling is centralized in pierre-tree-theme.ts (also used by the Files tab). User docs in source-control.md describe the feature.

^{Reviewed by Cursor Bugbot for commit 5ea691d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add file tree toggle and navigation to DiffPanel

• Adds a toolbar toggle in DiffPanel.tsx that shows a side-by-side DiffFileTree listing all changed files
• The toggle state is persisted across sessions
• Selecting a file in the tree reopens its diff if collapsed and scrolls the viewer to it
• Risk: new layout adds a conditional sidebar next to the diff viewer; verify rendering on narrow viewports

^{Macroscope summarized 5ea691d.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.4 KiB	13.4 KiB	+4 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+3 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+1 B (+0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−29 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−9 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−20 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: f5fbb1b · PR result: 5ea691d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new persisted file-tree workflow across two production diff surfaces, including dynamic folder updates, selection synchronization, scrolling, and pull-request paging controls. The supplied unresolved comments identify medium-severity risks in incremental folder expansion and flattened-directory handling, while the new product defaults require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

New folders stay collapsed after updates

Medium Severity

initialExpansion: "open" only applies to the first resetPaths. Later path changes use batch adds and never expand the new directories. A scope switch, agent refresh, or PR slice that introduces a new folder can hide those files behind collapsed rows, even though directories are supposed to start open.

Additional Locations (2)

• apps/web/src/components/diffs/DiffFileTree.tsx#L73-L77
• apps/web/src/components/DiffPanel.tsx#L1032-L1041

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

Checked against the Pierre source and this does not happen. initialExpansion: "open" sets state.defaultExpansion = "open", and isDirectoryExpanded falls through to isDirectoryExpandedByDefault, which returns true for any directory not explicitly collapsed — including ones added later via batch. The only path that marks new directories collapsed on add is collapseNewDirectoriesByDefault, which is set only when initialExpansion is "closed" and every directory was listed in initialExpandedPaths (the approach #6373 used, which is exactly why it needed a reset-and-recompute effect). Verified in the recording: switching the scope to Branch changes swaps in a whole new set of folders and they all arrive open.

[cursor]

Ancestor expand misses unsuffixed folders

Low Severity

The reveal effect expands ancestors only via model.getItem with a trailing slash. The Files tab looks up both the slashed and unsuffixed ids because Pierre can register a flattened directory under either form. If the slashed lookup misses, a collapsed parent stays closed and the selected file is not revealed.

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

FileTreeController.getItem documents that it "accepts both canonical directory paths (src/) and bare directory lookup paths (src)", so the trailing-slash form already resolves flattened directories; the double lookup in FileBrowserPanel is belt-and-braces, not a requirement. Leaving as is.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[cursor]

Flattened folders break expand-all

Medium Severity

DiffFileTree turns on flattenEmptyDirectories and seeds Pierre with file paths only, then treats every ancestor from collectDirectoryPaths as a real item. Flattened single-child chains often have no apps/ or apps/web/ node, so areAllDirectoriesExpanded stays false and the header control keeps offering Expand instead of Collapse. The same lookups drive chat reveal, so collapsed ancestors may never reopen.

Additional Locations (2)

• apps/web/src/components/diffs/diffFileTree.logic.ts#L36-L48
• apps/web/src/components/diffs/DiffFileTree.tsx#L147-L160

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[juliusmarminge]

Tested this against @pierre/trees directly rather than assume: a FileTree with flattenEmptyDirectories: true, initialExpansion: "open", seeded only with apps/mobile/src/a.ts, apps/mobile/src/b.ts, docs/x.md. getItem resolves every ancestor from collectDirectoryPaths (apps/, apps/mobile/, apps/mobile/src/) — flattening is a render-time projection over the canonical path store, the nodes still exist. areAllDirectoriesExpanded is true on load and flips to false after collapsing apps/mobile/src/, so the header control toggles correctly. This is also the same helper and the same flattenEmptyDirectories setting the Files tab has shipped with. The recordings in the description show both the collapse/expand-all toggle and chat-driven reveal working over flattened chains (mobile / src, server / src / environment).

[juliusmarminge]

Problem

Reading a diff with many files means scrolling through all of them to find the one you want. Neither the thread Diff panel nor the pull request Code tab had any way to see the changed files as a structure or jump straight to one.

Fix

One shared DiffFileTree component (apps/web/src/components/diffs/), mounted in both places behind a folder-tree toggle at the end of each toolbar (same spot and icon as the Files tab). The toggle persists per view in localStorage, off by default.

• Pierre file tree of the changed files with git status marks (A/M/D/R), directories open by default, plus an expand/collapse-all-folders control in the tree header.
• Clicking a file expands it if it was folded and scrolls the code view to it.
• The tree diffs the path list into add/remove batch ops instead of rebuilding, so a refresh after an agent edit or a later PR slice keeps whatever folders the reader has opened or closed.
• Thread diff panel: the file selected from the chat's changed-files list is mirrored into the tree (select + reveal).
• PR code tab: a Load more files footer while the diff is still paging (also acts as Retry on failure). The existing scroll sentinel and this button share one loadNextSlice.
• The Files tab's Pierre theme CSS moves to pierre-tree-theme.ts so all three trees share it.

Based on the approach in #6373 by @ShpetimA; that PR predates #9174 (expanded-by-default) and had drifted, so this is a fresh cut with him as co-author. Deliberately not coupling "expand all files" to "expand all folders" — the tree has its own button, matching the Files tab.

Surfaces

• Web + desktop (shared apps/web). Mobile has its own diff UI and is unchanged.
• Docs: docs/user/source-control.md.
• Providers/contracts: untouched.

Verification

vp test run apps/web/src/components/diffs/diffFileTree.logic.test.ts (6 tests), tsgo --noEmit in apps/web, targeted vp lint on the touched files. Manually verified in a real browser against a snapshot of real data.

Thread diff panel

Before	After

Switching scope to Branch changes rebuilds the tree for that scope:

Walkthrough (toggle on, jump to two files, collapse/expand folders, switch scope, jump again, toggle off):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/ec08e7f59a261fe0/diff-panel.mp4

Pull request Code tab (PR #9253, 52 files)

Walkthrough (toggle on, jump, collapse all folders, drill into apps/web/src, collapse all files from the toolbar, then pick a file in the tree so it expands just that one and scrolls to it):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/28416528c557fe77/pr-code-tab.mp4

Not exercised: the Load more files footer, since every open PR I tried fits in GitHub's 100-file page so nextCursor is never set. It drives the same code path as the existing scroll sentinel.

---

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
UI-only navigation and layout in shared web diff views; no auth, API, or data-model changes.

Overview
Adds a folder-tree sidebar to the thread Diff panel and pull request Code tab so reviewers can browse changed files by path and jump to any file without scrolling the full patch.

A shared DiffFileTree (Pierre file tree + git status badges) sits beside the diff viewer when a toolbar Show file tree toggle is on. Visibility is persisted in localStorage per surface (off by default). Picking a file unfolds a collapsed diff and scrolls the code view to it; the thread panel also syncs selection from chat changed-files links into the tree.

Tree paths update incrementally via buildDiffFileTreeUpdates so refreshes and paged PR slices keep folder expand/collapse state. On large PRs, the tree footer exposes Load more files / Retry, sharing the same loadNextSlice path as the scroll sentinel. Pierre tree styling is centralized in pierre-tree-theme.ts (also used by the Files tab). User docs in source-control.md describe the feature.

^{Reviewed by Cursor Bugbot for commit 5ea691d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add file tree toggle and navigation to DiffPanel

• Adds a toolbar toggle in DiffPanel.tsx that shows a side-by-side DiffFileTree listing all changed files
• The toggle state is persisted across sessions
• Selecting a file in the tree reopens its diff if collapsed and scrolls the viewer to it
• Risk: new layout adds a conditional sidebar next to the diff viewer; verify rendering on narrow viewports

^{Macroscope summarized 5ea691d.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.4 KiB	13.4 KiB	+4 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+3 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+1 B (+0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−29 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−9 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−20 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: f5fbb1b · PR result: 5ea691d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new persisted file-tree workflow across two production diff surfaces, including dynamic folder updates, selection synchronization, scrolling, and pull-request paging controls. The supplied unresolved comments identify medium-severity risks in incremental folder expansion and flattened-directory handling, while the new product defaults require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

New folders stay collapsed after updates

Medium Severity

initialExpansion: "open" only applies to the first resetPaths. Later path changes use batch adds and never expand the new directories. A scope switch, agent refresh, or PR slice that introduces a new folder can hide those files behind collapsed rows, even though directories are supposed to start open.

Additional Locations (2)

• apps/web/src/components/diffs/DiffFileTree.tsx#L73-L77
• apps/web/src/components/DiffPanel.tsx#L1032-L1041

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

Checked against the Pierre source and this does not happen. initialExpansion: "open" sets state.defaultExpansion = "open", and isDirectoryExpanded falls through to isDirectoryExpandedByDefault, which returns true for any directory not explicitly collapsed — including ones added later via batch. The only path that marks new directories collapsed on add is collapseNewDirectoriesByDefault, which is set only when initialExpansion is "closed" and every directory was listed in initialExpandedPaths (the approach #6373 used, which is exactly why it needed a reset-and-recompute effect). Verified in the recording: switching the scope to Branch changes swaps in a whole new set of folders and they all arrive open.

[cursor]

Ancestor expand misses unsuffixed folders

Low Severity

The reveal effect expands ancestors only via model.getItem with a trailing slash. The Files tab looks up both the slashed and unsuffixed ids because Pierre can register a flattened directory under either form. If the slashed lookup misses, a collapsed parent stays closed and the selected file is not revealed.

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

FileTreeController.getItem documents that it "accepts both canonical directory paths (src/) and bare directory lookup paths (src)", so the trailing-slash form already resolves flattened directories; the double lookup in FileBrowserPanel is belt-and-braces, not a requirement. Leaving as is.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[cursor]

Flattened folders break expand-all

Medium Severity

DiffFileTree turns on flattenEmptyDirectories and seeds Pierre with file paths only, then treats every ancestor from collectDirectoryPaths as a real item. Flattened single-child chains often have no apps/ or apps/web/ node, so areAllDirectoriesExpanded stays false and the header control keeps offering Expand instead of Collapse. The same lookups drive chat reveal, so collapsed ancestors may never reopen.

Additional Locations (2)

• apps/web/src/components/diffs/diffFileTree.logic.ts#L36-L48
• apps/web/src/components/diffs/DiffFileTree.tsx#L147-L160

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[juliusmarminge]

Tested this against @pierre/trees directly rather than assume: a FileTree with flattenEmptyDirectories: true, initialExpansion: "open", seeded only with apps/mobile/src/a.ts, apps/mobile/src/b.ts, docs/x.md. getItem resolves every ancestor from collectDirectoryPaths (apps/, apps/mobile/, apps/mobile/src/) — flattening is a render-time projection over the canonical path store, the nodes still exist. areAllDirectoriesExpanded is true on load and flips to false after collapsing apps/mobile/src/, so the header control toggles correctly. This is also the same helper and the same flattenEmptyDirectories setting the Files tab has shipped with. The recordings in the description show both the collapse/expand-all toggle and chat-driven reveal working over flattened chains (mobile / src, server / src / environment).

[juliusmarminge]

Problem

Reading a diff with many files means scrolling through all of them to find the one you want. Neither the thread Diff panel nor the pull request Code tab had any way to see the changed files as a structure or jump straight to one.

Fix

One shared DiffFileTree component (apps/web/src/components/diffs/), mounted in both places behind a folder-tree toggle at the end of each toolbar (same spot and icon as the Files tab). The toggle persists per view in localStorage, off by default.

• Pierre file tree of the changed files with git status marks (A/M/D/R), directories open by default, plus an expand/collapse-all-folders control in the tree header.
• Clicking a file expands it if it was folded and scrolls the code view to it.
• The tree diffs the path list into add/remove batch ops instead of rebuilding, so a refresh after an agent edit or a later PR slice keeps whatever folders the reader has opened or closed.
• Thread diff panel: the file selected from the chat's changed-files list is mirrored into the tree (select + reveal).
• PR code tab: a Load more files footer while the diff is still paging (also acts as Retry on failure). The existing scroll sentinel and this button share one loadNextSlice.
• The Files tab's Pierre theme CSS moves to pierre-tree-theme.ts so all three trees share it.

Based on the approach in #6373 by @ShpetimA; that PR predates #9174 (expanded-by-default) and had drifted, so this is a fresh cut with him as co-author. Deliberately not coupling "expand all files" to "expand all folders" — the tree has its own button, matching the Files tab.

Surfaces

• Web + desktop (shared apps/web). Mobile has its own diff UI and is unchanged.
• Docs: docs/user/source-control.md.
• Providers/contracts: untouched.

Verification

vp test run apps/web/src/components/diffs/diffFileTree.logic.test.ts (6 tests), tsgo --noEmit in apps/web, targeted vp lint on the touched files. Manually verified in a real browser against a snapshot of real data.

Thread diff panel

Before	After

Switching scope to Branch changes rebuilds the tree for that scope:

Walkthrough (toggle on, jump to two files, collapse/expand folders, switch scope, jump again, toggle off):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/ec08e7f59a261fe0/diff-panel.mp4

Pull request Code tab (PR #9253, 52 files)

Walkthrough (toggle on, jump, collapse all folders, drill into apps/web/src, collapse all files from the toolbar, then pick a file in the tree so it expands just that one and scrolls to it):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/28416528c557fe77/pr-code-tab.mp4

Not exercised: the Load more files footer, since every open PR I tried fits in GitHub's 100-file page so nextCursor is never set. It drives the same code path as the existing scroll sentinel.

---

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
UI-only navigation and layout in shared web diff views; no auth, API, or data-model changes.

Overview
Adds a folder-tree sidebar to the thread Diff panel and pull request Code tab so reviewers can browse changed files by path and jump to any file without scrolling the full patch.

A shared DiffFileTree (Pierre file tree + git status badges) sits beside the diff viewer when a toolbar Show file tree toggle is on. Visibility is persisted in localStorage per surface (off by default). Picking a file unfolds a collapsed diff and scrolls the code view to it; the thread panel also syncs selection from chat changed-files links into the tree.

Tree paths update incrementally via buildDiffFileTreeUpdates so refreshes and paged PR slices keep folder expand/collapse state. On large PRs, the tree footer exposes Load more files / Retry, sharing the same loadNextSlice path as the scroll sentinel. Pierre tree styling is centralized in pierre-tree-theme.ts (also used by the Files tab). User docs in source-control.md describe the feature.

^{Reviewed by Cursor Bugbot for commit 5ea691d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add file tree toggle and navigation to DiffPanel

• Adds a toolbar toggle in DiffPanel.tsx that shows a side-by-side DiffFileTree listing all changed files
• The toggle state is persisted across sessions
• Selecting a file in the tree reopens its diff if collapsed and scrolls the viewer to it
• Risk: new layout adds a conditional sidebar next to the diff viewer; verify rendering on narrow viewports

^{Macroscope summarized 5ea691d.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.4 KiB	13.4 KiB	+4 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+3 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+1 B (+0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−29 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−9 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−20 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: f5fbb1b · PR result: 5ea691d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new persisted file-tree workflow across two production diff surfaces, including dynamic folder updates, selection synchronization, scrolling, and pull-request paging controls. The supplied unresolved comments identify medium-severity risks in incremental folder expansion and flattened-directory handling, while the new product defaults require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

New folders stay collapsed after updates

Medium Severity

initialExpansion: "open" only applies to the first resetPaths. Later path changes use batch adds and never expand the new directories. A scope switch, agent refresh, or PR slice that introduces a new folder can hide those files behind collapsed rows, even though directories are supposed to start open.

Additional Locations (2)

• apps/web/src/components/diffs/DiffFileTree.tsx#L73-L77
• apps/web/src/components/DiffPanel.tsx#L1032-L1041

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

Checked against the Pierre source and this does not happen. initialExpansion: "open" sets state.defaultExpansion = "open", and isDirectoryExpanded falls through to isDirectoryExpandedByDefault, which returns true for any directory not explicitly collapsed — including ones added later via batch. The only path that marks new directories collapsed on add is collapseNewDirectoriesByDefault, which is set only when initialExpansion is "closed" and every directory was listed in initialExpandedPaths (the approach #6373 used, which is exactly why it needed a reset-and-recompute effect). Verified in the recording: switching the scope to Branch changes swaps in a whole new set of folders and they all arrive open.

[cursor]

Ancestor expand misses unsuffixed folders

Low Severity

The reveal effect expands ancestors only via model.getItem with a trailing slash. The Files tab looks up both the slashed and unsuffixed ids because Pierre can register a flattened directory under either form. If the slashed lookup misses, a collapsed parent stays closed and the selected file is not revealed.

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

FileTreeController.getItem documents that it "accepts both canonical directory paths (src/) and bare directory lookup paths (src)", so the trailing-slash form already resolves flattened directories; the double lookup in FileBrowserPanel is belt-and-braces, not a requirement. Leaving as is.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[cursor]

Flattened folders break expand-all

Medium Severity

DiffFileTree turns on flattenEmptyDirectories and seeds Pierre with file paths only, then treats every ancestor from collectDirectoryPaths as a real item. Flattened single-child chains often have no apps/ or apps/web/ node, so areAllDirectoriesExpanded stays false and the header control keeps offering Expand instead of Collapse. The same lookups drive chat reveal, so collapsed ancestors may never reopen.

Additional Locations (2)

• apps/web/src/components/diffs/diffFileTree.logic.ts#L36-L48
• apps/web/src/components/diffs/DiffFileTree.tsx#L147-L160

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[juliusmarminge]

Tested this against @pierre/trees directly rather than assume: a FileTree with flattenEmptyDirectories: true, initialExpansion: "open", seeded only with apps/mobile/src/a.ts, apps/mobile/src/b.ts, docs/x.md. getItem resolves every ancestor from collectDirectoryPaths (apps/, apps/mobile/, apps/mobile/src/) — flattening is a render-time projection over the canonical path store, the nodes still exist. areAllDirectoriesExpanded is true on load and flips to false after collapsing apps/mobile/src/, so the header control toggles correctly. This is also the same helper and the same flattenEmptyDirectories setting the Files tab has shipped with. The recordings in the description show both the collapse/expand-all toggle and chat-driven reveal working over flattened chains (mobile / src, server / src / environment).

[juliusmarminge]

Problem

Reading a diff with many files means scrolling through all of them to find the one you want. Neither the thread Diff panel nor the pull request Code tab had any way to see the changed files as a structure or jump straight to one.

Fix

One shared DiffFileTree component (apps/web/src/components/diffs/), mounted in both places behind a folder-tree toggle at the end of each toolbar (same spot and icon as the Files tab). The toggle persists per view in localStorage, off by default.

• Pierre file tree of the changed files with git status marks (A/M/D/R), directories open by default, plus an expand/collapse-all-folders control in the tree header.
• Clicking a file expands it if it was folded and scrolls the code view to it.
• The tree diffs the path list into add/remove batch ops instead of rebuilding, so a refresh after an agent edit or a later PR slice keeps whatever folders the reader has opened or closed.
• Thread diff panel: the file selected from the chat's changed-files list is mirrored into the tree (select + reveal).
• PR code tab: a Load more files footer while the diff is still paging (also acts as Retry on failure). The existing scroll sentinel and this button share one loadNextSlice.
• The Files tab's Pierre theme CSS moves to pierre-tree-theme.ts so all three trees share it.

Based on the approach in #6373 by @ShpetimA; that PR predates #9174 (expanded-by-default) and had drifted, so this is a fresh cut with him as co-author. Deliberately not coupling "expand all files" to "expand all folders" — the tree has its own button, matching the Files tab.

Surfaces

• Web + desktop (shared apps/web). Mobile has its own diff UI and is unchanged.
• Docs: docs/user/source-control.md.
• Providers/contracts: untouched.

Verification

vp test run apps/web/src/components/diffs/diffFileTree.logic.test.ts (6 tests), tsgo --noEmit in apps/web, targeted vp lint on the touched files. Manually verified in a real browser against a snapshot of real data.

Thread diff panel

Before	After

Switching scope to Branch changes rebuilds the tree for that scope:

Walkthrough (toggle on, jump to two files, collapse/expand folders, switch scope, jump again, toggle off):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/ec08e7f59a261fe0/diff-panel.mp4

Pull request Code tab (PR #9253, 52 files)

Walkthrough (toggle on, jump, collapse all folders, drill into apps/web/src, collapse all files from the toolbar, then pick a file in the tree so it expands just that one and scrolls to it):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/28416528c557fe77/pr-code-tab.mp4

Not exercised: the Load more files footer, since every open PR I tried fits in GitHub's 100-file page so nextCursor is never set. It drives the same code path as the existing scroll sentinel.

---

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
UI-only navigation and layout in shared web diff views; no auth, API, or data-model changes.

Overview
Adds a folder-tree sidebar to the thread Diff panel and pull request Code tab so reviewers can browse changed files by path and jump to any file without scrolling the full patch.

A shared DiffFileTree (Pierre file tree + git status badges) sits beside the diff viewer when a toolbar Show file tree toggle is on. Visibility is persisted in localStorage per surface (off by default). Picking a file unfolds a collapsed diff and scrolls the code view to it; the thread panel also syncs selection from chat changed-files links into the tree.

Tree paths update incrementally via buildDiffFileTreeUpdates so refreshes and paged PR slices keep folder expand/collapse state. On large PRs, the tree footer exposes Load more files / Retry, sharing the same loadNextSlice path as the scroll sentinel. Pierre tree styling is centralized in pierre-tree-theme.ts (also used by the Files tab). User docs in source-control.md describe the feature.

^{Reviewed by Cursor Bugbot for commit 5ea691d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add file tree toggle and navigation to DiffPanel

• Adds a toolbar toggle in DiffPanel.tsx that shows a side-by-side DiffFileTree listing all changed files
• The toggle state is persisted across sessions
• Selecting a file in the tree reopens its diff if collapsed and scrolls the viewer to it
• Risk: new layout adds a conditional sidebar next to the diff viewer; verify rendering on narrow viewports

^{Macroscope summarized 5ea691d.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.4 KiB	13.4 KiB	+4 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+3 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+1 B (+0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−29 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−9 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−20 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: f5fbb1b · PR result: 5ea691d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new persisted file-tree workflow across two production diff surfaces, including dynamic folder updates, selection synchronization, scrolling, and pull-request paging controls. The supplied unresolved comments identify medium-severity risks in incremental folder expansion and flattened-directory handling, while the new product defaults require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

New folders stay collapsed after updates

Medium Severity

initialExpansion: "open" only applies to the first resetPaths. Later path changes use batch adds and never expand the new directories. A scope switch, agent refresh, or PR slice that introduces a new folder can hide those files behind collapsed rows, even though directories are supposed to start open.

Additional Locations (2)

• apps/web/src/components/diffs/DiffFileTree.tsx#L73-L77
• apps/web/src/components/DiffPanel.tsx#L1032-L1041

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

Checked against the Pierre source and this does not happen. initialExpansion: "open" sets state.defaultExpansion = "open", and isDirectoryExpanded falls through to isDirectoryExpandedByDefault, which returns true for any directory not explicitly collapsed — including ones added later via batch. The only path that marks new directories collapsed on add is collapseNewDirectoriesByDefault, which is set only when initialExpansion is "closed" and every directory was listed in initialExpandedPaths (the approach #6373 used, which is exactly why it needed a reset-and-recompute effect). Verified in the recording: switching the scope to Branch changes swaps in a whole new set of folders and they all arrive open.

[cursor]

Ancestor expand misses unsuffixed folders

Low Severity

The reveal effect expands ancestors only via model.getItem with a trailing slash. The Files tab looks up both the slashed and unsuffixed ids because Pierre can register a flattened directory under either form. If the slashed lookup misses, a collapsed parent stays closed and the selected file is not revealed.

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

FileTreeController.getItem documents that it "accepts both canonical directory paths (src/) and bare directory lookup paths (src)", so the trailing-slash form already resolves flattened directories; the double lookup in FileBrowserPanel is belt-and-braces, not a requirement. Leaving as is.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[cursor]

Flattened folders break expand-all

Medium Severity

DiffFileTree turns on flattenEmptyDirectories and seeds Pierre with file paths only, then treats every ancestor from collectDirectoryPaths as a real item. Flattened single-child chains often have no apps/ or apps/web/ node, so areAllDirectoriesExpanded stays false and the header control keeps offering Expand instead of Collapse. The same lookups drive chat reveal, so collapsed ancestors may never reopen.

Additional Locations (2)

• apps/web/src/components/diffs/diffFileTree.logic.ts#L36-L48
• apps/web/src/components/diffs/DiffFileTree.tsx#L147-L160

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[juliusmarminge]

Tested this against @pierre/trees directly rather than assume: a FileTree with flattenEmptyDirectories: true, initialExpansion: "open", seeded only with apps/mobile/src/a.ts, apps/mobile/src/b.ts, docs/x.md. getItem resolves every ancestor from collectDirectoryPaths (apps/, apps/mobile/, apps/mobile/src/) — flattening is a render-time projection over the canonical path store, the nodes still exist. areAllDirectoriesExpanded is true on load and flips to false after collapsing apps/mobile/src/, so the header control toggles correctly. This is also the same helper and the same flattenEmptyDirectories setting the Files tab has shipped with. The recordings in the description show both the collapse/expand-all toggle and chat-driven reveal working over flattened chains (mobile / src, server / src / environment).

[juliusmarminge]

Problem

Reading a diff with many files means scrolling through all of them to find the one you want. Neither the thread Diff panel nor the pull request Code tab had any way to see the changed files as a structure or jump straight to one.

Fix

One shared DiffFileTree component (apps/web/src/components/diffs/), mounted in both places behind a folder-tree toggle at the end of each toolbar (same spot and icon as the Files tab). The toggle persists per view in localStorage, off by default.

• Pierre file tree of the changed files with git status marks (A/M/D/R), directories open by default, plus an expand/collapse-all-folders control in the tree header.
• Clicking a file expands it if it was folded and scrolls the code view to it.
• The tree diffs the path list into add/remove batch ops instead of rebuilding, so a refresh after an agent edit or a later PR slice keeps whatever folders the reader has opened or closed.
• Thread diff panel: the file selected from the chat's changed-files list is mirrored into the tree (select + reveal).
• PR code tab: a Load more files footer while the diff is still paging (also acts as Retry on failure). The existing scroll sentinel and this button share one loadNextSlice.
• The Files tab's Pierre theme CSS moves to pierre-tree-theme.ts so all three trees share it.

Based on the approach in #6373 by @ShpetimA; that PR predates #9174 (expanded-by-default) and had drifted, so this is a fresh cut with him as co-author. Deliberately not coupling "expand all files" to "expand all folders" — the tree has its own button, matching the Files tab.

Surfaces

• Web + desktop (shared apps/web). Mobile has its own diff UI and is unchanged.
• Docs: docs/user/source-control.md.
• Providers/contracts: untouched.

Verification

vp test run apps/web/src/components/diffs/diffFileTree.logic.test.ts (6 tests), tsgo --noEmit in apps/web, targeted vp lint on the touched files. Manually verified in a real browser against a snapshot of real data.

Thread diff panel

Before	After

Switching scope to Branch changes rebuilds the tree for that scope:

Walkthrough (toggle on, jump to two files, collapse/expand folders, switch scope, jump again, toggle off):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/ec08e7f59a261fe0/diff-panel.mp4

Pull request Code tab (PR #9253, 52 files)

Walkthrough (toggle on, jump, collapse all folders, drill into apps/web/src, collapse all files from the toolbar, then pick a file in the tree so it expands just that one and scrolls to it):

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/28416528c557fe77/pr-code-tab.mp4

Not exercised: the Load more files footer, since every open PR I tried fits in GitHub's 100-file page so nextCursor is never set. It drives the same code path as the existing scroll sentinel.

---

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
UI-only navigation and layout in shared web diff views; no auth, API, or data-model changes.

Overview
Adds a folder-tree sidebar to the thread Diff panel and pull request Code tab so reviewers can browse changed files by path and jump to any file without scrolling the full patch.

A shared DiffFileTree (Pierre file tree + git status badges) sits beside the diff viewer when a toolbar Show file tree toggle is on. Visibility is persisted in localStorage per surface (off by default). Picking a file unfolds a collapsed diff and scrolls the code view to it; the thread panel also syncs selection from chat changed-files links into the tree.

Tree paths update incrementally via buildDiffFileTreeUpdates so refreshes and paged PR slices keep folder expand/collapse state. On large PRs, the tree footer exposes Load more files / Retry, sharing the same loadNextSlice path as the scroll sentinel. Pierre tree styling is centralized in pierre-tree-theme.ts (also used by the Files tab). User docs in source-control.md describe the feature.

^{Reviewed by Cursor Bugbot for commit 5ea691d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add file tree toggle and navigation to DiffPanel

• Adds a toolbar toggle in DiffPanel.tsx that shows a side-by-side DiffFileTree listing all changed files
• The toggle state is persisted across sessions
• Selecting a file in the tree reopens its diff if collapsed and scrolls the viewer to it
• Risk: new layout adds a conditional sidebar next to the diff viewer; verify rendering on narrow viewports

^{Macroscope summarized 5ea691d.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.4 KiB	13.4 KiB	+4 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+3 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+1 B (+0.0%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−29 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−9 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−20 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: f5fbb1b · PR result: 5ea691d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 109.4 KiB
• Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new persisted file-tree workflow across two production diff surfaces, including dynamic folder updates, selection synchronization, scrolling, and pull-request paging controls. The supplied unresolved comments identify medium-severity risks in incremental folder expansion and flattened-directory handling, while the new product defaults require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

New folders stay collapsed after updates

Medium Severity

initialExpansion: "open" only applies to the first resetPaths. Later path changes use batch adds and never expand the new directories. A scope switch, agent refresh, or PR slice that introduces a new folder can hide those files behind collapsed rows, even though directories are supposed to start open.

Additional Locations (2)

• apps/web/src/components/diffs/DiffFileTree.tsx#L73-L77
• apps/web/src/components/DiffPanel.tsx#L1032-L1041

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

Checked against the Pierre source and this does not happen. initialExpansion: "open" sets state.defaultExpansion = "open", and isDirectoryExpanded falls through to isDirectoryExpandedByDefault, which returns true for any directory not explicitly collapsed — including ones added later via batch. The only path that marks new directories collapsed on add is collapseNewDirectoriesByDefault, which is set only when initialExpansion is "closed" and every directory was listed in initialExpandedPaths (the approach #6373 used, which is exactly why it needed a reset-and-recompute effect). Verified in the recording: switching the scope to Branch changes swaps in a whole new set of folders and they all arrive open.

[cursor]

Ancestor expand misses unsuffixed folders

Low Severity

The reveal effect expands ancestors only via model.getItem with a trailing slash. The Files tab looks up both the slashed and unsuffixed ids because Pierre can register a flattened directory under either form. If the slashed lookup misses, a collapsed parent stays closed and the selected file is not revealed.

^{Reviewed by Cursor Bugbot for commit ea55cf8. Configure here.}

[juliusmarminge]

FileTreeController.getItem documents that it "accepts both canonical directory paths (src/) and bare directory lookup paths (src)", so the trailing-slash form already resolves flattened directories; the double lookup in FileBrowserPanel is belt-and-braces, not a requirement. Leaving as is.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[cursor]

Flattened folders break expand-all

Medium Severity

DiffFileTree turns on flattenEmptyDirectories and seeds Pierre with file paths only, then treats every ancestor from collectDirectoryPaths as a real item. Flattened single-child chains often have no apps/ or apps/web/ node, so areAllDirectoriesExpanded stays false and the header control keeps offering Expand instead of Collapse. The same lookups drive chat reveal, so collapsed ancestors may never reopen.

Additional Locations (2)

• apps/web/src/components/diffs/diffFileTree.logic.ts#L36-L48
• apps/web/src/components/diffs/DiffFileTree.tsx#L147-L160

^{Reviewed by Cursor Bugbot for commit 5ea691d. Configure here.}

[juliusmarminge]

Tested this against @pierre/trees directly rather than assume: a FileTree with flattenEmptyDirectories: true, initialExpansion: "open", seeded only with apps/mobile/src/a.ts, apps/mobile/src/b.ts, docs/x.md. getItem resolves every ancestor from collectDirectoryPaths (apps/, apps/mobile/, apps/mobile/src/) — flattening is a render-time projection over the canonical path store, the nodes still exist. areAllDirectoriesExpanded is true on load and flips to false after collapsing apps/mobile/src/, so the header control toggles correctly. This is also the same helper and the same flattenEmptyDirectories setting the Files tab has shipped with. The recordings in the description show both the collapse/expand-all toggle and chat-driven reveal working over flattened chains (mobile / src, server / src / environment).