Uh oh!
There was an error while loading. Please reload this page.
chore(ci): narrow the Effect conventions check-run agent - #9321
Merged
Conversation
The agent included **/*.tsx although no Effect service lives in a .tsx file, so every UI-only PR woke it up to find nothing. It also carried rules from finished work: the domain/Services + domain/Layers consolidation and the provider-session reconciliation design from #7719. Its reporting scope of introduced or retained violations flagged pre-existing FooShape interfaces and catchTag uses in any touched file. Scope include to .ts and exclude tests, drop the stale rules, restrict reporting to changed lines, fold the eight overlapping error bullets into six, and drop the unused git_tools and github_api_read_only tools. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 3, 2026
## What's Changed * chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298 * fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306 * fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294 * feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299 * feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313 * fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314 * refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253 * fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316 * chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300 * chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321 * refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322 * fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324 * fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255 * fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326 * chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331 * chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327 * feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330 * feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315 * fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334 * fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343 * feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339 * fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349 * feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137 * fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347 * fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351 * feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093 ## New Contributors * @tristanmanchester made their first contribution in pingdotgg/t3code#9255 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9297 and #9298, same treatment for the Effect agent. It isn't the cost problem the UI agent was, but it had the same drift in smaller doses plus one scoping mistake.
Runs on PRs it can't act on.
includelisted**/*.tsx, but Effect services (Context.Service,Layer.*,Schema.TaggedErrorClass) live in 258.tsfiles across the repo and zero.tsxfiles. Every UI-only PR woke the agent to read the diff and sayAll clear. Now.tsonly, with**/*.test.tsexcluded since the prompt already carves tests out of the injection rules.Stale, PR-specific rules. Removed the startup-reconciliation rule from #7719 (the design of one feature, not a convention) and the
domain/Services+domain/Layers→domain/Foo.tsmigration section (those directories no longer exist). The general "delete old files, update every consumer, no re-export shims" rule survives as one line.Flagging old code in touched files. Reporting said "introduced or retained in the pull request's changed scope," which had the agent dinging pre-existing
FooShapeinterfaces (40 remain) andEffect.catchTaguses (8 files) in any file a PR touched. Now "introduced by changed lines," matching the UI agent.Repetition. The errors section had eight bullets that each restated some mix of "derive
messagefrom structural fields, nevercause; keepcause; nodetailcopyingcause.message; no raw payloads." Folded into six with every rule preserved.Also dropped
github_api_read_only(unused) andgit_tools(redundant withbrowse_code). Keptclaude-opus-5andeffort: high.The
catchTags-only rule stays as is. Worth knowing that.repos/effect-smol/LLMS.md, which AGENTS.md points agents at before writing Effect code, usesEffect.catchTagin its examples, so agents following the reference will write code this check fails. If that preference isn't deliberate, dropping the ban is a one-line follow-up.Claude Fable 5 via Claude Code
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only change to a CI review agent prompt and triggers; no application runtime or Effect service code is modified.
Overview
Tightens the Effect Service Conventions Macroscope check-run agent so it runs less often, reviews less code, and flags fewer false positives.
Scope and tooling:
includeis.tsonly (drops**/*.tsxbecause Effect services aren’t in TSX) and addsexclude: **/*.test.ts. Removes unusedgithub_api_read_onlyand redundantgit_tools(keepsbrowse_code).Prompt behavior: Review is limited to lines the PR actually changed; legacy patterns in the same file are out of scope—aligned with the UI consistency agent. Reporting shifts from “introduced or retained” to “introduced by changed lines.”
Rule cleanup: Drops obsolete file-layout/migration guidance (merged into a single “no re-export shims” line when services move), removes the startup-reconciliation error rule, and condenses the errors section without dropping the substantive rules. Opening instructions are shortened throughout.
Reviewed by Cursor Bugbot for commit 80527dd. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Narrow Effect service conventions check-run agent scope to changed lines
Updates the check-run agent policy in effect-service-conventions.md to reduce review noise and focus on the diff. The agent now excludes
**/*.test.tsand all TSX files, no longer uses Git or GitHub read-only tools, and reports only violations on changed lines instead of repository-wide call-site cleanup. Guidance is consolidated and shortened across Effect imports, service definitions, dependency acquisition, runtime boundaries, and errors; added a requirement to delete obsolete service files and compatibility shims during service moves. A clean review must return exactlyAll clear.📊 Macroscope summarized 80527dd. 1 file reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted
🗂️ Filtered Issues