refactor(mobile): style plain views with Uniwind classes instead of the theme bridge - #9322

Merged
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge
Sep 3, 2026
Merged

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge#9322
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

Follow-up to #9300. useUniwindTheme is documented as the one palette bridge for native and third-party props that cannot take a className (React Navigation, react-native-screens, SVG, native editors, swipeables). Auditing the 24 allowlisted files found four that also fed it into ordinary View, Pressable, and TextInput styles where the equivalent semantic class already exists and is already used elsewhere in the app.

Fix

  • FontSizeSliderRow — track and fill become bg-secondary-border / bg-primary, the same Animated.View + className + animated style shape LoadingStrip uses. The hook is gone from this file.
  • NewTaskContextPickerScreens — the branch search input already carried text-foreground, and font-sans resolves to the same DMSans-Regular as useFontFamily("regular"), so both style overrides were redundant. Both hooks are gone from this file.
  • thread-list-items / thread-list-v2-items — row hairlines use border-b border-separator (already used in ArchivedThreadsScreen), pressed backgrounds use active:bg-subtle (18 existing uses). The hook stays in both files for ThreadSwipeable, PullRequestIcon, and the themeColorWithAlpha blend on selected rows, which genuinely need raw values.

The two hook-free files come off the allowUniwindTheme override in vite.config.ts, so the lint rule now rejects the hook there.

Left alone: the other 20 allowlisted files, whose every useUniwindTheme read flows into a prop that takes a color string. That matches the intent of #7327.

Verification

  • vp check clean (0 errors, same 22 pre-existing warnings as main); mobile tsc --noEmit clean.
  • Every class introduced already has in-tree precedent, so the Uniwind tokens resolve.
  • Planted a useUniwindTheme import back into FontSizeSliderRow and confirmed the rule reports it.
  • No simulator pass: no T3CodeDev dev client is installed on any local simulator and this is a JS-only change, so I did not do a native rebuild for it. The four surfaces (appearance settings slider, branch picker, thread list rows in both list variants) are worth a glance on device before merge.

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only styling parity using classes that already exist elsewhere; main regression risk is visual (pressed states, separators, slider colors) on the affected screens.

Overview
Follow-up to tightening where useUniwindTheme is allowed: this PR moves ordinaryView / Pressable / TextInput styling off the theme bridge and onto existing Uniwind tokens, while leaving the hook only where APIs need raw color strings.

Appearance & new-task flows: The font-size slider track and fill use bg-secondary-border and bg-primary on animated views instead of backgroundColor from the hook. The Android branch search field drops redundant style overrides in favor of font-sans and existing text-foreground classes.

Thread lists: Compact rows get active:opacity-70, hairlines use border-b border-separator, and sidebar pending rows use active:bg-subtle / bg-drawer instead of pressed-state style callbacks. useUniwindTheme remains in the list files for swipeables, SVG PR icons, and selected-row color blending.

Tooling:FontSizeSliderRow and NewTaskContextPickerScreens are removed from the allowUniwindTheme override list in vite.config.ts, so the lint rule will reject reintroducing the hook there.

Reviewed by Cursor Bugbot for commit 9671c9b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace theme bridge hooks with Uniwind utility classes in mobile list and settings views

  • Moves theme color, font-family, separator, and pressed-state styling from JavaScript hook lookups to Uniwind utility classes across FontSizeSliderRow.tsx, NewTaskContextPickerScreens.tsx, thread-list-items.tsx, and thread-list-v2-items.tsx
  • Removes FontSizeSliderRow.tsx and NewTaskContextPickerScreens.tsx from the formatter ignore list in vite.config.ts
  • Layout dimensions, animation, and placeholder styles are unchanged; only the color and font sourcing mechanism changes
  • Risk: visual appearance depends on Uniwind utility classes resolving the same theme values as the removed hook lookups — verify pressed states and separator colors in compact and non-compact thread rows

Macroscope summarized 9671c9b.

…he theme bridge
useUniwindTheme is the palette bridge for native and third-party props
that cannot take a className. Four files were also feeding it into
ordinary View, Pressable, and TextInput styles where the equivalent
semantic class already exists and is used elsewhere in the app.
- FontSizeSliderRow: track and fill use bg-secondary-border / bg-primary,
the same Animated.View + className shape as LoadingStrip. The hook is
gone from this file.
- NewTaskContextPickerScreens: the branch search input already carried
text-foreground; font-sans resolves to the same DMSans-Regular as
useFontFamily("regular"). Both hooks are gone from this file.
- thread-list-items / thread-list-v2-items: row separators use
border-b border-separator and pressed backgrounds use active:bg-subtle.
The hook stays for ThreadSwipeable, PullRequestIcon, and the alpha
blend on selected rows.
Drop the two hook-free files from the lint allowlist so the rule
enforces them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−218 B (−1.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−219 B (−3.3%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB+3 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 194f838 · PR result: 9671c9b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 3, 2026
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This production mobile styling refactor changes compact thread-row spacing and pressed-state rendering, rather than being purely mechanical. An unresolved comment identifies a concrete rem-scaling mismatch that can misalign compact rows, so the visual impact should receive human review.

You can add or adjust custom eligibility rules. Learn more.

…asses
The compact thread and pending-task rows still carried inline padding, gap,
and pressed-opacity styles after the theme-bridge conversion. Move them to
classes (pl-5 pr-[18px] pt-2.5, gap-[3px] pb-2.5, active:opacity-70) so the
rows are styled the same way as the rest of the mobile app.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 02:54

Dismissing prior approval to re-evaluate 26c0e86

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 26c0e86. Configure here.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
Uniwind's rem base is 14 in this app, so pl-5 and pt-2.5 resolved to
17.5px and 8.75px and the compact rows drifted inward of the home header
and group headers that still use HOME_HORIZONTAL_INSET. Read the left
inset from the shared constant again and use pixel classes for the
vertical padding.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:01
@juliusmarminge
juliusmarminge merged commit 85f2479 into mainSep 3, 2026
27 checks passed
@juliusmarminge
juliusmarminge deleted the mobile/shrink-uniwind-theme-bridge branch September 3, 2026 03:02
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge - #9322

Merged
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge
Sep 3, 2026
Merged

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge#9322
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

Follow-up to #9300. useUniwindTheme is documented as the one palette bridge for native and third-party props that cannot take a className (React Navigation, react-native-screens, SVG, native editors, swipeables). Auditing the 24 allowlisted files found four that also fed it into ordinary View, Pressable, and TextInput styles where the equivalent semantic class already exists and is already used elsewhere in the app.

Fix

  • FontSizeSliderRow — track and fill become bg-secondary-border / bg-primary, the same Animated.View + className + animated style shape LoadingStrip uses. The hook is gone from this file.
  • NewTaskContextPickerScreens — the branch search input already carried text-foreground, and font-sans resolves to the same DMSans-Regular as useFontFamily("regular"), so both style overrides were redundant. Both hooks are gone from this file.
  • thread-list-items / thread-list-v2-items — row hairlines use border-b border-separator (already used in ArchivedThreadsScreen), pressed backgrounds use active:bg-subtle (18 existing uses). The hook stays in both files for ThreadSwipeable, PullRequestIcon, and the themeColorWithAlpha blend on selected rows, which genuinely need raw values.

The two hook-free files come off the allowUniwindTheme override in vite.config.ts, so the lint rule now rejects the hook there.

Left alone: the other 20 allowlisted files, whose every useUniwindTheme read flows into a prop that takes a color string. That matches the intent of #7327.

Verification

  • vp check clean (0 errors, same 22 pre-existing warnings as main); mobile tsc --noEmit clean.
  • Every class introduced already has in-tree precedent, so the Uniwind tokens resolve.
  • Planted a useUniwindTheme import back into FontSizeSliderRow and confirmed the rule reports it.
  • No simulator pass: no T3CodeDev dev client is installed on any local simulator and this is a JS-only change, so I did not do a native rebuild for it. The four surfaces (appearance settings slider, branch picker, thread list rows in both list variants) are worth a glance on device before merge.

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only styling parity using classes that already exist elsewhere; main regression risk is visual (pressed states, separators, slider colors) on the affected screens.

Overview
Follow-up to tightening where useUniwindTheme is allowed: this PR moves ordinaryView / Pressable / TextInput styling off the theme bridge and onto existing Uniwind tokens, while leaving the hook only where APIs need raw color strings.

Appearance & new-task flows: The font-size slider track and fill use bg-secondary-border and bg-primary on animated views instead of backgroundColor from the hook. The Android branch search field drops redundant style overrides in favor of font-sans and existing text-foreground classes.

Thread lists: Compact rows get active:opacity-70, hairlines use border-b border-separator, and sidebar pending rows use active:bg-subtle / bg-drawer instead of pressed-state style callbacks. useUniwindTheme remains in the list files for swipeables, SVG PR icons, and selected-row color blending.

Tooling:FontSizeSliderRow and NewTaskContextPickerScreens are removed from the allowUniwindTheme override list in vite.config.ts, so the lint rule will reject reintroducing the hook there.

Reviewed by Cursor Bugbot for commit 9671c9b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace theme bridge hooks with Uniwind utility classes in mobile list and settings views

  • Moves theme color, font-family, separator, and pressed-state styling from JavaScript hook lookups to Uniwind utility classes across FontSizeSliderRow.tsx, NewTaskContextPickerScreens.tsx, thread-list-items.tsx, and thread-list-v2-items.tsx
  • Removes FontSizeSliderRow.tsx and NewTaskContextPickerScreens.tsx from the formatter ignore list in vite.config.ts
  • Layout dimensions, animation, and placeholder styles are unchanged; only the color and font sourcing mechanism changes
  • Risk: visual appearance depends on Uniwind utility classes resolving the same theme values as the removed hook lookups — verify pressed states and separator colors in compact and non-compact thread rows

Macroscope summarized 9671c9b.

…he theme bridge
useUniwindTheme is the palette bridge for native and third-party props
that cannot take a className. Four files were also feeding it into
ordinary View, Pressable, and TextInput styles where the equivalent
semantic class already exists and is used elsewhere in the app.
- FontSizeSliderRow: track and fill use bg-secondary-border / bg-primary,
the same Animated.View + className shape as LoadingStrip. The hook is
gone from this file.
- NewTaskContextPickerScreens: the branch search input already carried
text-foreground; font-sans resolves to the same DMSans-Regular as
useFontFamily("regular"). Both hooks are gone from this file.
- thread-list-items / thread-list-v2-items: row separators use
border-b border-separator and pressed backgrounds use active:bg-subtle.
The hook stays for ThreadSwipeable, PullRequestIcon, and the alpha
blend on selected rows.
Drop the two hook-free files from the lint allowlist so the rule
enforces them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−218 B (−1.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−219 B (−3.3%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB+3 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 194f838 · PR result: 9671c9b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 3, 2026
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This production mobile styling refactor changes compact thread-row spacing and pressed-state rendering, rather than being purely mechanical. An unresolved comment identifies a concrete rem-scaling mismatch that can misalign compact rows, so the visual impact should receive human review.

You can add or adjust custom eligibility rules. Learn more.

…asses
The compact thread and pending-task rows still carried inline padding, gap,
and pressed-opacity styles after the theme-bridge conversion. Move them to
classes (pl-5 pr-[18px] pt-2.5, gap-[3px] pb-2.5, active:opacity-70) so the
rows are styled the same way as the rest of the mobile app.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 02:54

Dismissing prior approval to re-evaluate 26c0e86

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 26c0e86. Configure here.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
Uniwind's rem base is 14 in this app, so pl-5 and pt-2.5 resolved to
17.5px and 8.75px and the compact rows drifted inward of the home header
and group headers that still use HOME_HORIZONTAL_INSET. Read the left
inset from the shared constant again and use pixel classes for the
vertical padding.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:01
@juliusmarminge
juliusmarminge merged commit 85f2479 into mainSep 3, 2026
27 checks passed
@juliusmarminge
juliusmarminge deleted the mobile/shrink-uniwind-theme-bridge branch September 3, 2026 03:02
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge - #9322

Merged
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge
Sep 3, 2026
Merged

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge#9322
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

Follow-up to #9300. useUniwindTheme is documented as the one palette bridge for native and third-party props that cannot take a className (React Navigation, react-native-screens, SVG, native editors, swipeables). Auditing the 24 allowlisted files found four that also fed it into ordinary View, Pressable, and TextInput styles where the equivalent semantic class already exists and is already used elsewhere in the app.

Fix

  • FontSizeSliderRow — track and fill become bg-secondary-border / bg-primary, the same Animated.View + className + animated style shape LoadingStrip uses. The hook is gone from this file.
  • NewTaskContextPickerScreens — the branch search input already carried text-foreground, and font-sans resolves to the same DMSans-Regular as useFontFamily("regular"), so both style overrides were redundant. Both hooks are gone from this file.
  • thread-list-items / thread-list-v2-items — row hairlines use border-b border-separator (already used in ArchivedThreadsScreen), pressed backgrounds use active:bg-subtle (18 existing uses). The hook stays in both files for ThreadSwipeable, PullRequestIcon, and the themeColorWithAlpha blend on selected rows, which genuinely need raw values.

The two hook-free files come off the allowUniwindTheme override in vite.config.ts, so the lint rule now rejects the hook there.

Left alone: the other 20 allowlisted files, whose every useUniwindTheme read flows into a prop that takes a color string. That matches the intent of #7327.

Verification

  • vp check clean (0 errors, same 22 pre-existing warnings as main); mobile tsc --noEmit clean.
  • Every class introduced already has in-tree precedent, so the Uniwind tokens resolve.
  • Planted a useUniwindTheme import back into FontSizeSliderRow and confirmed the rule reports it.
  • No simulator pass: no T3CodeDev dev client is installed on any local simulator and this is a JS-only change, so I did not do a native rebuild for it. The four surfaces (appearance settings slider, branch picker, thread list rows in both list variants) are worth a glance on device before merge.

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only styling parity using classes that already exist elsewhere; main regression risk is visual (pressed states, separators, slider colors) on the affected screens.

Overview
Follow-up to tightening where useUniwindTheme is allowed: this PR moves ordinaryView / Pressable / TextInput styling off the theme bridge and onto existing Uniwind tokens, while leaving the hook only where APIs need raw color strings.

Appearance & new-task flows: The font-size slider track and fill use bg-secondary-border and bg-primary on animated views instead of backgroundColor from the hook. The Android branch search field drops redundant style overrides in favor of font-sans and existing text-foreground classes.

Thread lists: Compact rows get active:opacity-70, hairlines use border-b border-separator, and sidebar pending rows use active:bg-subtle / bg-drawer instead of pressed-state style callbacks. useUniwindTheme remains in the list files for swipeables, SVG PR icons, and selected-row color blending.

Tooling:FontSizeSliderRow and NewTaskContextPickerScreens are removed from the allowUniwindTheme override list in vite.config.ts, so the lint rule will reject reintroducing the hook there.

Reviewed by Cursor Bugbot for commit 9671c9b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace theme bridge hooks with Uniwind utility classes in mobile list and settings views

  • Moves theme color, font-family, separator, and pressed-state styling from JavaScript hook lookups to Uniwind utility classes across FontSizeSliderRow.tsx, NewTaskContextPickerScreens.tsx, thread-list-items.tsx, and thread-list-v2-items.tsx
  • Removes FontSizeSliderRow.tsx and NewTaskContextPickerScreens.tsx from the formatter ignore list in vite.config.ts
  • Layout dimensions, animation, and placeholder styles are unchanged; only the color and font sourcing mechanism changes
  • Risk: visual appearance depends on Uniwind utility classes resolving the same theme values as the removed hook lookups — verify pressed states and separator colors in compact and non-compact thread rows

Macroscope summarized 9671c9b.

…he theme bridge
useUniwindTheme is the palette bridge for native and third-party props
that cannot take a className. Four files were also feeding it into
ordinary View, Pressable, and TextInput styles where the equivalent
semantic class already exists and is used elsewhere in the app.
- FontSizeSliderRow: track and fill use bg-secondary-border / bg-primary,
the same Animated.View + className shape as LoadingStrip. The hook is
gone from this file.
- NewTaskContextPickerScreens: the branch search input already carried
text-foreground; font-sans resolves to the same DMSans-Regular as
useFontFamily("regular"). Both hooks are gone from this file.
- thread-list-items / thread-list-v2-items: row separators use
border-b border-separator and pressed backgrounds use active:bg-subtle.
The hook stays for ThreadSwipeable, PullRequestIcon, and the alpha
blend on selected rows.
Drop the two hook-free files from the lint allowlist so the rule
enforces them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−218 B (−1.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−219 B (−3.3%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB+3 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 194f838 · PR result: 9671c9b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 3, 2026
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This production mobile styling refactor changes compact thread-row spacing and pressed-state rendering, rather than being purely mechanical. An unresolved comment identifies a concrete rem-scaling mismatch that can misalign compact rows, so the visual impact should receive human review.

You can add or adjust custom eligibility rules. Learn more.

…asses
The compact thread and pending-task rows still carried inline padding, gap,
and pressed-opacity styles after the theme-bridge conversion. Move them to
classes (pl-5 pr-[18px] pt-2.5, gap-[3px] pb-2.5, active:opacity-70) so the
rows are styled the same way as the rest of the mobile app.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 02:54

Dismissing prior approval to re-evaluate 26c0e86

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 26c0e86. Configure here.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
Uniwind's rem base is 14 in this app, so pl-5 and pt-2.5 resolved to
17.5px and 8.75px and the compact rows drifted inward of the home header
and group headers that still use HOME_HORIZONTAL_INSET. Read the left
inset from the shared constant again and use pixel classes for the
vertical padding.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:01
@juliusmarminge
juliusmarminge merged commit 85f2479 into mainSep 3, 2026
27 checks passed
@juliusmarminge
juliusmarminge deleted the mobile/shrink-uniwind-theme-bridge branch September 3, 2026 03:02
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge - #9322

Merged
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge
Sep 3, 2026
Merged

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge#9322
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

Follow-up to #9300. useUniwindTheme is documented as the one palette bridge for native and third-party props that cannot take a className (React Navigation, react-native-screens, SVG, native editors, swipeables). Auditing the 24 allowlisted files found four that also fed it into ordinary View, Pressable, and TextInput styles where the equivalent semantic class already exists and is already used elsewhere in the app.

Fix

  • FontSizeSliderRow — track and fill become bg-secondary-border / bg-primary, the same Animated.View + className + animated style shape LoadingStrip uses. The hook is gone from this file.
  • NewTaskContextPickerScreens — the branch search input already carried text-foreground, and font-sans resolves to the same DMSans-Regular as useFontFamily("regular"), so both style overrides were redundant. Both hooks are gone from this file.
  • thread-list-items / thread-list-v2-items — row hairlines use border-b border-separator (already used in ArchivedThreadsScreen), pressed backgrounds use active:bg-subtle (18 existing uses). The hook stays in both files for ThreadSwipeable, PullRequestIcon, and the themeColorWithAlpha blend on selected rows, which genuinely need raw values.

The two hook-free files come off the allowUniwindTheme override in vite.config.ts, so the lint rule now rejects the hook there.

Left alone: the other 20 allowlisted files, whose every useUniwindTheme read flows into a prop that takes a color string. That matches the intent of #7327.

Verification

  • vp check clean (0 errors, same 22 pre-existing warnings as main); mobile tsc --noEmit clean.
  • Every class introduced already has in-tree precedent, so the Uniwind tokens resolve.
  • Planted a useUniwindTheme import back into FontSizeSliderRow and confirmed the rule reports it.
  • No simulator pass: no T3CodeDev dev client is installed on any local simulator and this is a JS-only change, so I did not do a native rebuild for it. The four surfaces (appearance settings slider, branch picker, thread list rows in both list variants) are worth a glance on device before merge.

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only styling parity using classes that already exist elsewhere; main regression risk is visual (pressed states, separators, slider colors) on the affected screens.

Overview
Follow-up to tightening where useUniwindTheme is allowed: this PR moves ordinaryView / Pressable / TextInput styling off the theme bridge and onto existing Uniwind tokens, while leaving the hook only where APIs need raw color strings.

Appearance & new-task flows: The font-size slider track and fill use bg-secondary-border and bg-primary on animated views instead of backgroundColor from the hook. The Android branch search field drops redundant style overrides in favor of font-sans and existing text-foreground classes.

Thread lists: Compact rows get active:opacity-70, hairlines use border-b border-separator, and sidebar pending rows use active:bg-subtle / bg-drawer instead of pressed-state style callbacks. useUniwindTheme remains in the list files for swipeables, SVG PR icons, and selected-row color blending.

Tooling:FontSizeSliderRow and NewTaskContextPickerScreens are removed from the allowUniwindTheme override list in vite.config.ts, so the lint rule will reject reintroducing the hook there.

Reviewed by Cursor Bugbot for commit 9671c9b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace theme bridge hooks with Uniwind utility classes in mobile list and settings views

  • Moves theme color, font-family, separator, and pressed-state styling from JavaScript hook lookups to Uniwind utility classes across FontSizeSliderRow.tsx, NewTaskContextPickerScreens.tsx, thread-list-items.tsx, and thread-list-v2-items.tsx
  • Removes FontSizeSliderRow.tsx and NewTaskContextPickerScreens.tsx from the formatter ignore list in vite.config.ts
  • Layout dimensions, animation, and placeholder styles are unchanged; only the color and font sourcing mechanism changes
  • Risk: visual appearance depends on Uniwind utility classes resolving the same theme values as the removed hook lookups — verify pressed states and separator colors in compact and non-compact thread rows

Macroscope summarized 9671c9b.

…he theme bridge
useUniwindTheme is the palette bridge for native and third-party props
that cannot take a className. Four files were also feeding it into
ordinary View, Pressable, and TextInput styles where the equivalent
semantic class already exists and is used elsewhere in the app.
- FontSizeSliderRow: track and fill use bg-secondary-border / bg-primary,
the same Animated.View + className shape as LoadingStrip. The hook is
gone from this file.
- NewTaskContextPickerScreens: the branch search input already carried
text-foreground; font-sans resolves to the same DMSans-Regular as
useFontFamily("regular"). Both hooks are gone from this file.
- thread-list-items / thread-list-v2-items: row separators use
border-b border-separator and pressed backgrounds use active:bg-subtle.
The hook stays for ThreadSwipeable, PullRequestIcon, and the alpha
blend on selected rows.
Drop the two hook-free files from the lint allowlist so the rule
enforces them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−218 B (−1.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−219 B (−3.3%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB+3 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 194f838 · PR result: 9671c9b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 3, 2026
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This production mobile styling refactor changes compact thread-row spacing and pressed-state rendering, rather than being purely mechanical. An unresolved comment identifies a concrete rem-scaling mismatch that can misalign compact rows, so the visual impact should receive human review.

You can add or adjust custom eligibility rules. Learn more.

…asses
The compact thread and pending-task rows still carried inline padding, gap,
and pressed-opacity styles after the theme-bridge conversion. Move them to
classes (pl-5 pr-[18px] pt-2.5, gap-[3px] pb-2.5, active:opacity-70) so the
rows are styled the same way as the rest of the mobile app.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 02:54

Dismissing prior approval to re-evaluate 26c0e86

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 26c0e86. Configure here.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
Uniwind's rem base is 14 in this app, so pl-5 and pt-2.5 resolved to
17.5px and 8.75px and the compact rows drifted inward of the home header
and group headers that still use HOME_HORIZONTAL_INSET. Read the left
inset from the shared constant again and use pixel classes for the
vertical padding.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:01
@juliusmarminge
juliusmarminge merged commit 85f2479 into mainSep 3, 2026
27 checks passed
@juliusmarminge
juliusmarminge deleted the mobile/shrink-uniwind-theme-bridge branch September 3, 2026 03:02
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge - #9322

Merged
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge
Sep 3, 2026
Merged

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge#9322
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

Follow-up to #9300. useUniwindTheme is documented as the one palette bridge for native and third-party props that cannot take a className (React Navigation, react-native-screens, SVG, native editors, swipeables). Auditing the 24 allowlisted files found four that also fed it into ordinary View, Pressable, and TextInput styles where the equivalent semantic class already exists and is already used elsewhere in the app.

Fix

  • FontSizeSliderRow — track and fill become bg-secondary-border / bg-primary, the same Animated.View + className + animated style shape LoadingStrip uses. The hook is gone from this file.
  • NewTaskContextPickerScreens — the branch search input already carried text-foreground, and font-sans resolves to the same DMSans-Regular as useFontFamily("regular"), so both style overrides were redundant. Both hooks are gone from this file.
  • thread-list-items / thread-list-v2-items — row hairlines use border-b border-separator (already used in ArchivedThreadsScreen), pressed backgrounds use active:bg-subtle (18 existing uses). The hook stays in both files for ThreadSwipeable, PullRequestIcon, and the themeColorWithAlpha blend on selected rows, which genuinely need raw values.

The two hook-free files come off the allowUniwindTheme override in vite.config.ts, so the lint rule now rejects the hook there.

Left alone: the other 20 allowlisted files, whose every useUniwindTheme read flows into a prop that takes a color string. That matches the intent of #7327.

Verification

  • vp check clean (0 errors, same 22 pre-existing warnings as main); mobile tsc --noEmit clean.
  • Every class introduced already has in-tree precedent, so the Uniwind tokens resolve.
  • Planted a useUniwindTheme import back into FontSizeSliderRow and confirmed the rule reports it.
  • No simulator pass: no T3CodeDev dev client is installed on any local simulator and this is a JS-only change, so I did not do a native rebuild for it. The four surfaces (appearance settings slider, branch picker, thread list rows in both list variants) are worth a glance on device before merge.

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only styling parity using classes that already exist elsewhere; main regression risk is visual (pressed states, separators, slider colors) on the affected screens.

Overview
Follow-up to tightening where useUniwindTheme is allowed: this PR moves ordinaryView / Pressable / TextInput styling off the theme bridge and onto existing Uniwind tokens, while leaving the hook only where APIs need raw color strings.

Appearance & new-task flows: The font-size slider track and fill use bg-secondary-border and bg-primary on animated views instead of backgroundColor from the hook. The Android branch search field drops redundant style overrides in favor of font-sans and existing text-foreground classes.

Thread lists: Compact rows get active:opacity-70, hairlines use border-b border-separator, and sidebar pending rows use active:bg-subtle / bg-drawer instead of pressed-state style callbacks. useUniwindTheme remains in the list files for swipeables, SVG PR icons, and selected-row color blending.

Tooling:FontSizeSliderRow and NewTaskContextPickerScreens are removed from the allowUniwindTheme override list in vite.config.ts, so the lint rule will reject reintroducing the hook there.

Reviewed by Cursor Bugbot for commit 9671c9b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace theme bridge hooks with Uniwind utility classes in mobile list and settings views

  • Moves theme color, font-family, separator, and pressed-state styling from JavaScript hook lookups to Uniwind utility classes across FontSizeSliderRow.tsx, NewTaskContextPickerScreens.tsx, thread-list-items.tsx, and thread-list-v2-items.tsx
  • Removes FontSizeSliderRow.tsx and NewTaskContextPickerScreens.tsx from the formatter ignore list in vite.config.ts
  • Layout dimensions, animation, and placeholder styles are unchanged; only the color and font sourcing mechanism changes
  • Risk: visual appearance depends on Uniwind utility classes resolving the same theme values as the removed hook lookups — verify pressed states and separator colors in compact and non-compact thread rows

Macroscope summarized 9671c9b.

…he theme bridge
useUniwindTheme is the palette bridge for native and third-party props
that cannot take a className. Four files were also feeding it into
ordinary View, Pressable, and TextInput styles where the equivalent
semantic class already exists and is used elsewhere in the app.
- FontSizeSliderRow: track and fill use bg-secondary-border / bg-primary,
the same Animated.View + className shape as LoadingStrip. The hook is
gone from this file.
- NewTaskContextPickerScreens: the branch search input already carried
text-foreground; font-sans resolves to the same DMSans-Regular as
useFontFamily("regular"). Both hooks are gone from this file.
- thread-list-items / thread-list-v2-items: row separators use
border-b border-separator and pressed backgrounds use active:bg-subtle.
The hook stays for ThreadSwipeable, PullRequestIcon, and the alpha
blend on selected rows.
Drop the two hook-free files from the lint allowlist so the rule
enforces them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−218 B (−1.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−219 B (−3.3%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB+3 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 194f838 · PR result: 9671c9b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 3, 2026
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This production mobile styling refactor changes compact thread-row spacing and pressed-state rendering, rather than being purely mechanical. An unresolved comment identifies a concrete rem-scaling mismatch that can misalign compact rows, so the visual impact should receive human review.

You can add or adjust custom eligibility rules. Learn more.

…asses
The compact thread and pending-task rows still carried inline padding, gap,
and pressed-opacity styles after the theme-bridge conversion. Move them to
classes (pl-5 pr-[18px] pt-2.5, gap-[3px] pb-2.5, active:opacity-70) so the
rows are styled the same way as the rest of the mobile app.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 02:54

Dismissing prior approval to re-evaluate 26c0e86

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 26c0e86. Configure here.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
Uniwind's rem base is 14 in this app, so pl-5 and pt-2.5 resolved to
17.5px and 8.75px and the compact rows drifted inward of the home header
and group headers that still use HOME_HORIZONTAL_INSET. Read the left
inset from the shared constant again and use pixel classes for the
vertical padding.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:01
@juliusmarminge
juliusmarminge merged commit 85f2479 into mainSep 3, 2026
27 checks passed
@juliusmarminge
juliusmarminge deleted the mobile/shrink-uniwind-theme-bridge branch September 3, 2026 03:02
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge - #9322

Merged
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge
Sep 3, 2026
Merged

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge#9322
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

Follow-up to #9300. useUniwindTheme is documented as the one palette bridge for native and third-party props that cannot take a className (React Navigation, react-native-screens, SVG, native editors, swipeables). Auditing the 24 allowlisted files found four that also fed it into ordinary View, Pressable, and TextInput styles where the equivalent semantic class already exists and is already used elsewhere in the app.

Fix

  • FontSizeSliderRow — track and fill become bg-secondary-border / bg-primary, the same Animated.View + className + animated style shape LoadingStrip uses. The hook is gone from this file.
  • NewTaskContextPickerScreens — the branch search input already carried text-foreground, and font-sans resolves to the same DMSans-Regular as useFontFamily("regular"), so both style overrides were redundant. Both hooks are gone from this file.
  • thread-list-items / thread-list-v2-items — row hairlines use border-b border-separator (already used in ArchivedThreadsScreen), pressed backgrounds use active:bg-subtle (18 existing uses). The hook stays in both files for ThreadSwipeable, PullRequestIcon, and the themeColorWithAlpha blend on selected rows, which genuinely need raw values.

The two hook-free files come off the allowUniwindTheme override in vite.config.ts, so the lint rule now rejects the hook there.

Left alone: the other 20 allowlisted files, whose every useUniwindTheme read flows into a prop that takes a color string. That matches the intent of #7327.

Verification

  • vp check clean (0 errors, same 22 pre-existing warnings as main); mobile tsc --noEmit clean.
  • Every class introduced already has in-tree precedent, so the Uniwind tokens resolve.
  • Planted a useUniwindTheme import back into FontSizeSliderRow and confirmed the rule reports it.
  • No simulator pass: no T3CodeDev dev client is installed on any local simulator and this is a JS-only change, so I did not do a native rebuild for it. The four surfaces (appearance settings slider, branch picker, thread list rows in both list variants) are worth a glance on device before merge.

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only styling parity using classes that already exist elsewhere; main regression risk is visual (pressed states, separators, slider colors) on the affected screens.

Overview
Follow-up to tightening where useUniwindTheme is allowed: this PR moves ordinaryView / Pressable / TextInput styling off the theme bridge and onto existing Uniwind tokens, while leaving the hook only where APIs need raw color strings.

Appearance & new-task flows: The font-size slider track and fill use bg-secondary-border and bg-primary on animated views instead of backgroundColor from the hook. The Android branch search field drops redundant style overrides in favor of font-sans and existing text-foreground classes.

Thread lists: Compact rows get active:opacity-70, hairlines use border-b border-separator, and sidebar pending rows use active:bg-subtle / bg-drawer instead of pressed-state style callbacks. useUniwindTheme remains in the list files for swipeables, SVG PR icons, and selected-row color blending.

Tooling:FontSizeSliderRow and NewTaskContextPickerScreens are removed from the allowUniwindTheme override list in vite.config.ts, so the lint rule will reject reintroducing the hook there.

Reviewed by Cursor Bugbot for commit 9671c9b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace theme bridge hooks with Uniwind utility classes in mobile list and settings views

  • Moves theme color, font-family, separator, and pressed-state styling from JavaScript hook lookups to Uniwind utility classes across FontSizeSliderRow.tsx, NewTaskContextPickerScreens.tsx, thread-list-items.tsx, and thread-list-v2-items.tsx
  • Removes FontSizeSliderRow.tsx and NewTaskContextPickerScreens.tsx from the formatter ignore list in vite.config.ts
  • Layout dimensions, animation, and placeholder styles are unchanged; only the color and font sourcing mechanism changes
  • Risk: visual appearance depends on Uniwind utility classes resolving the same theme values as the removed hook lookups — verify pressed states and separator colors in compact and non-compact thread rows

Macroscope summarized 9671c9b.

…he theme bridge
useUniwindTheme is the palette bridge for native and third-party props
that cannot take a className. Four files were also feeding it into
ordinary View, Pressable, and TextInput styles where the equivalent
semantic class already exists and is used elsewhere in the app.
- FontSizeSliderRow: track and fill use bg-secondary-border / bg-primary,
the same Animated.View + className shape as LoadingStrip. The hook is
gone from this file.
- NewTaskContextPickerScreens: the branch search input already carried
text-foreground; font-sans resolves to the same DMSans-Regular as
useFontFamily("regular"). Both hooks are gone from this file.
- thread-list-items / thread-list-v2-items: row separators use
border-b border-separator and pressed backgrounds use active:bg-subtle.
The hook stays for ThreadSwipeable, PullRequestIcon, and the alpha
blend on selected rows.
Drop the two hook-free files from the lint allowlist so the rule
enforces them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−218 B (−1.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−219 B (−3.3%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB+3 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 194f838 · PR result: 9671c9b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 3, 2026
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This production mobile styling refactor changes compact thread-row spacing and pressed-state rendering, rather than being purely mechanical. An unresolved comment identifies a concrete rem-scaling mismatch that can misalign compact rows, so the visual impact should receive human review.

You can add or adjust custom eligibility rules. Learn more.

…asses
The compact thread and pending-task rows still carried inline padding, gap,
and pressed-opacity styles after the theme-bridge conversion. Move them to
classes (pl-5 pr-[18px] pt-2.5, gap-[3px] pb-2.5, active:opacity-70) so the
rows are styled the same way as the rest of the mobile app.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 02:54

Dismissing prior approval to re-evaluate 26c0e86

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 26c0e86. Configure here.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
Uniwind's rem base is 14 in this app, so pl-5 and pt-2.5 resolved to
17.5px and 8.75px and the compact rows drifted inward of the home header
and group headers that still use HOME_HORIZONTAL_INSET. Read the left
inset from the shared constant again and use pixel classes for the
vertical padding.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:01
@juliusmarminge
juliusmarminge merged commit 85f2479 into mainSep 3, 2026
27 checks passed
@juliusmarminge
juliusmarminge deleted the mobile/shrink-uniwind-theme-bridge branch September 3, 2026 03:02
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge - #9322

Merged
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge
Sep 3, 2026
Merged

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge#9322
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

Follow-up to #9300. useUniwindTheme is documented as the one palette bridge for native and third-party props that cannot take a className (React Navigation, react-native-screens, SVG, native editors, swipeables). Auditing the 24 allowlisted files found four that also fed it into ordinary View, Pressable, and TextInput styles where the equivalent semantic class already exists and is already used elsewhere in the app.

Fix

  • FontSizeSliderRow — track and fill become bg-secondary-border / bg-primary, the same Animated.View + className + animated style shape LoadingStrip uses. The hook is gone from this file.
  • NewTaskContextPickerScreens — the branch search input already carried text-foreground, and font-sans resolves to the same DMSans-Regular as useFontFamily("regular"), so both style overrides were redundant. Both hooks are gone from this file.
  • thread-list-items / thread-list-v2-items — row hairlines use border-b border-separator (already used in ArchivedThreadsScreen), pressed backgrounds use active:bg-subtle (18 existing uses). The hook stays in both files for ThreadSwipeable, PullRequestIcon, and the themeColorWithAlpha blend on selected rows, which genuinely need raw values.

The two hook-free files come off the allowUniwindTheme override in vite.config.ts, so the lint rule now rejects the hook there.

Left alone: the other 20 allowlisted files, whose every useUniwindTheme read flows into a prop that takes a color string. That matches the intent of #7327.

Verification

  • vp check clean (0 errors, same 22 pre-existing warnings as main); mobile tsc --noEmit clean.
  • Every class introduced already has in-tree precedent, so the Uniwind tokens resolve.
  • Planted a useUniwindTheme import back into FontSizeSliderRow and confirmed the rule reports it.
  • No simulator pass: no T3CodeDev dev client is installed on any local simulator and this is a JS-only change, so I did not do a native rebuild for it. The four surfaces (appearance settings slider, branch picker, thread list rows in both list variants) are worth a glance on device before merge.

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only styling parity using classes that already exist elsewhere; main regression risk is visual (pressed states, separators, slider colors) on the affected screens.

Overview
Follow-up to tightening where useUniwindTheme is allowed: this PR moves ordinaryView / Pressable / TextInput styling off the theme bridge and onto existing Uniwind tokens, while leaving the hook only where APIs need raw color strings.

Appearance & new-task flows: The font-size slider track and fill use bg-secondary-border and bg-primary on animated views instead of backgroundColor from the hook. The Android branch search field drops redundant style overrides in favor of font-sans and existing text-foreground classes.

Thread lists: Compact rows get active:opacity-70, hairlines use border-b border-separator, and sidebar pending rows use active:bg-subtle / bg-drawer instead of pressed-state style callbacks. useUniwindTheme remains in the list files for swipeables, SVG PR icons, and selected-row color blending.

Tooling:FontSizeSliderRow and NewTaskContextPickerScreens are removed from the allowUniwindTheme override list in vite.config.ts, so the lint rule will reject reintroducing the hook there.

Reviewed by Cursor Bugbot for commit 9671c9b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace theme bridge hooks with Uniwind utility classes in mobile list and settings views

  • Moves theme color, font-family, separator, and pressed-state styling from JavaScript hook lookups to Uniwind utility classes across FontSizeSliderRow.tsx, NewTaskContextPickerScreens.tsx, thread-list-items.tsx, and thread-list-v2-items.tsx
  • Removes FontSizeSliderRow.tsx and NewTaskContextPickerScreens.tsx from the formatter ignore list in vite.config.ts
  • Layout dimensions, animation, and placeholder styles are unchanged; only the color and font sourcing mechanism changes
  • Risk: visual appearance depends on Uniwind utility classes resolving the same theme values as the removed hook lookups — verify pressed states and separator colors in compact and non-compact thread rows

Macroscope summarized 9671c9b.

…he theme bridge
useUniwindTheme is the palette bridge for native and third-party props
that cannot take a className. Four files were also feeding it into
ordinary View, Pressable, and TextInput styles where the equivalent
semantic class already exists and is used elsewhere in the app.
- FontSizeSliderRow: track and fill use bg-secondary-border / bg-primary,
the same Animated.View + className shape as LoadingStrip. The hook is
gone from this file.
- NewTaskContextPickerScreens: the branch search input already carried
text-foreground; font-sans resolves to the same DMSans-Regular as
useFontFamily("regular"). Both hooks are gone from this file.
- thread-list-items / thread-list-v2-items: row separators use
border-b border-separator and pressed backgrounds use active:bg-subtle.
The hook stays for ThreadSwipeable, PullRequestIcon, and the alpha
blend on selected rows.
Drop the two hook-free files from the lint allowlist so the rule
enforces them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−218 B (−1.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−219 B (−3.3%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB+3 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 194f838 · PR result: 9671c9b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 3, 2026
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This production mobile styling refactor changes compact thread-row spacing and pressed-state rendering, rather than being purely mechanical. An unresolved comment identifies a concrete rem-scaling mismatch that can misalign compact rows, so the visual impact should receive human review.

You can add or adjust custom eligibility rules. Learn more.

…asses
The compact thread and pending-task rows still carried inline padding, gap,
and pressed-opacity styles after the theme-bridge conversion. Move them to
classes (pl-5 pr-[18px] pt-2.5, gap-[3px] pb-2.5, active:opacity-70) so the
rows are styled the same way as the rest of the mobile app.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 02:54

Dismissing prior approval to re-evaluate 26c0e86

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 26c0e86. Configure here.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
Uniwind's rem base is 14 in this app, so pl-5 and pt-2.5 resolved to
17.5px and 8.75px and the compact rows drifted inward of the home header
and group headers that still use HOME_HORIZONTAL_INSET. Read the left
inset from the shared constant again and use pixel classes for the
vertical padding.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:01
@juliusmarminge
juliusmarminge merged commit 85f2479 into mainSep 3, 2026
27 checks passed
@juliusmarminge
juliusmarminge deleted the mobile/shrink-uniwind-theme-bridge branch September 3, 2026 03:02
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge - #9322

Merged
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge
Sep 3, 2026
Merged

refactor(mobile): style plain views with Uniwind classes instead of the theme bridge#9322
juliusmarminge merged 3 commits into
mainfrom
mobile/shrink-uniwind-theme-bridge

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

Follow-up to #9300. useUniwindTheme is documented as the one palette bridge for native and third-party props that cannot take a className (React Navigation, react-native-screens, SVG, native editors, swipeables). Auditing the 24 allowlisted files found four that also fed it into ordinary View, Pressable, and TextInput styles where the equivalent semantic class already exists and is already used elsewhere in the app.

Fix

  • FontSizeSliderRow — track and fill become bg-secondary-border / bg-primary, the same Animated.View + className + animated style shape LoadingStrip uses. The hook is gone from this file.
  • NewTaskContextPickerScreens — the branch search input already carried text-foreground, and font-sans resolves to the same DMSans-Regular as useFontFamily("regular"), so both style overrides were redundant. Both hooks are gone from this file.
  • thread-list-items / thread-list-v2-items — row hairlines use border-b border-separator (already used in ArchivedThreadsScreen), pressed backgrounds use active:bg-subtle (18 existing uses). The hook stays in both files for ThreadSwipeable, PullRequestIcon, and the themeColorWithAlpha blend on selected rows, which genuinely need raw values.

The two hook-free files come off the allowUniwindTheme override in vite.config.ts, so the lint rule now rejects the hook there.

Left alone: the other 20 allowlisted files, whose every useUniwindTheme read flows into a prop that takes a color string. That matches the intent of #7327.

Verification

  • vp check clean (0 errors, same 22 pre-existing warnings as main); mobile tsc --noEmit clean.
  • Every class introduced already has in-tree precedent, so the Uniwind tokens resolve.
  • Planted a useUniwindTheme import back into FontSizeSliderRow and confirmed the rule reports it.
  • No simulator pass: no T3CodeDev dev client is installed on any local simulator and this is a JS-only change, so I did not do a native rebuild for it. The four surfaces (appearance settings slider, branch picker, thread list rows in both list variants) are worth a glance on device before merge.

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only styling parity using classes that already exist elsewhere; main regression risk is visual (pressed states, separators, slider colors) on the affected screens.

Overview
Follow-up to tightening where useUniwindTheme is allowed: this PR moves ordinaryView / Pressable / TextInput styling off the theme bridge and onto existing Uniwind tokens, while leaving the hook only where APIs need raw color strings.

Appearance & new-task flows: The font-size slider track and fill use bg-secondary-border and bg-primary on animated views instead of backgroundColor from the hook. The Android branch search field drops redundant style overrides in favor of font-sans and existing text-foreground classes.

Thread lists: Compact rows get active:opacity-70, hairlines use border-b border-separator, and sidebar pending rows use active:bg-subtle / bg-drawer instead of pressed-state style callbacks. useUniwindTheme remains in the list files for swipeables, SVG PR icons, and selected-row color blending.

Tooling:FontSizeSliderRow and NewTaskContextPickerScreens are removed from the allowUniwindTheme override list in vite.config.ts, so the lint rule will reject reintroducing the hook there.

Reviewed by Cursor Bugbot for commit 9671c9b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Replace theme bridge hooks with Uniwind utility classes in mobile list and settings views

  • Moves theme color, font-family, separator, and pressed-state styling from JavaScript hook lookups to Uniwind utility classes across FontSizeSliderRow.tsx, NewTaskContextPickerScreens.tsx, thread-list-items.tsx, and thread-list-v2-items.tsx
  • Removes FontSizeSliderRow.tsx and NewTaskContextPickerScreens.tsx from the formatter ignore list in vite.config.ts
  • Layout dimensions, animation, and placeholder styles are unchanged; only the color and font sourcing mechanism changes
  • Risk: visual appearance depends on Uniwind utility classes resolving the same theme values as the removed hook lookups — verify pressed states and separator colors in compact and non-compact thread rows

Macroscope summarized 9671c9b.

…he theme bridge
useUniwindTheme is the palette bridge for native and third-party props
that cannot take a className. Four files were also feeding it into
ordinary View, Pressable, and TextInput styles where the equivalent
semantic class already exists and is used elsewhere in the app.
- FontSizeSliderRow: track and fill use bg-secondary-border / bg-primary,
the same Animated.View + className shape as LoadingStrip. The hook is
gone from this file.
- NewTaskContextPickerScreens: the branch search input already carried
text-foreground; font-sans resolves to the same DMSans-Regular as
useFontFamily("regular"). Both hooks are gone from this file.
- thread-list-items / thread-list-v2-items: row separators use
border-b border-separator and pressed backgrounds use active:bg-subtle.
The hook stays for ThreadSwipeable, PullRequestIcon, and the alpha
blend on selected rows.
Drop the two hook-free files from the lint allowlist so the rule
enforces them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actionsBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−218 B (−1.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.3 KiB−219 B (−3.3%)7.8 KiB
CodexLive turn WebSocket decoded57.0 KiB55.5 KiB−1.5 KiB (−2.6%)66.4 KiB
CodexLive turn messages108−2 (−20.0%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB+3 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB0 B (0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 194f838 · PR result: 9671c9b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 3, 2026
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This production mobile styling refactor changes compact thread-row spacing and pressed-state rendering, rather than being purely mechanical. An unresolved comment identifies a concrete rem-scaling mismatch that can misalign compact rows, so the visual impact should receive human review.

You can add or adjust custom eligibility rules. Learn more.

…asses
The compact thread and pending-task rows still carried inline padding, gap,
and pressed-opacity styles after the theme-bridge conversion. Move them to
classes (pl-5 pr-[18px] pt-2.5, gap-[3px] pb-2.5, active:opacity-70) so the
rows are styled the same way as the rest of the mobile app.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 02:54

Dismissing prior approval to re-evaluate 26c0e86

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 26c0e86. Configure here.

Comment threadapps/mobile/src/features/threads/thread-list-items.tsx Outdated
Uniwind's rem base is 14 in this app, so pl-5 and pt-2.5 resolved to
17.5px and 8.75px and the compact rows drifted inward of the home header
and group headers that still use HOME_HORIZONTAL_INSET. Read the left
inset from the shared constant again and use pixel classes for the
vertical padding.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge enabled auto-merge (squash) September 3, 2026 03:01
@juliusmarminge
juliusmarminge merged commit 85f2479 into mainSep 3, 2026
27 checks passed
@juliusmarminge
juliusmarminge deleted the mobile/shrink-uniwind-theme-bridge branch September 3, 2026 03:02
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* chore(ci): only run check-run agents on vouched contributors by @juliusmarminge in pingdotgg/t3code#9298
* fix(web): stop remounting markdown on every activity delta by @juliusmarminge in pingdotgg/t3code#9306
* fix(pull-requests): keep cached PR chrome on reopen by @maria-rcks in pingdotgg/t3code#9294
* feat(environments): draw each environment as the machine it runs on by @juliusmarminge in pingdotgg/t3code#9299
* feat(web): apply and remove labels from the pull request tab by @juliusmarminge in pingdotgg/t3code#9313
* fix(sidebar): collapse settled and snoozed shelves by default by @maria-rcks in pingdotgg/t3code#9314
* refactor(media): unify file and media previews across clients by @juliusmarminge in pingdotgg/t3code#9253
* fix(chat): keep live tool labels in present tense by @maria-rcks in pingdotgg/t3code#9316
* chore: audit lint directives and move plugin allowlists into config by @juliusmarminge in pingdotgg/t3code#9300
* chore(ci): narrow the Effect conventions check-run agent by @juliusmarminge in pingdotgg/t3code#9321
* refactor(mobile): style plain views with Uniwind classes instead of the theme bridge by @juliusmarminge in pingdotgg/t3code#9322
* fix(dev): share dev servers on the loopback Vite actually binds by @juliusmarminge in pingdotgg/t3code#9324
* fix(web): line up the titlebar wordmark label and version pill by @tristanmanchester in pingdotgg/t3code#9255
* fix(web): make the diff layout toggle a persisted setting by @juliusmarminge in pingdotgg/t3code#9326
* chore: dedupe lightningcss and tailwind node bindings by @juliusmarminge in pingdotgg/t3code#9331
* chore: upgrade vite-plus to 0.3.0 by @juliusmarminge in pingdotgg/t3code#9327
* feat(web): add a file tree to the diff panel and pull request code tab by @juliusmarminge in pingdotgg/t3code#9330
* feat(web): add PageUp/PageDown chat navigation by @Yash-Singh1 in pingdotgg/t3code#9315
* fix(web): collapse PR header actions to icons when narrow by @maria-rcks in pingdotgg/t3code#9334
* fix(web): resolve Vite sourcemap and supports warnings by @juliusmarminge in pingdotgg/t3code#9343
* feat(web): choose whether links open in the default browser or in T3 Code by @juliusmarminge in pingdotgg/t3code#9339
* fix(web): add press feedback to buttons by @maria-rcks in pingdotgg/t3code#9349
* feat(web): add customizable project icons by @saphid in pingdotgg/t3code#9137
* fix(mobile): stop indented code overflowing Android chat bubbles by @Adamulek123 in pingdotgg/t3code#9347
* fix(web): let the pull request list use wide screens by @juliusmarminge in pingdotgg/t3code#9351
* feat: display native app and browser icons in work logs by @Yash-Singh1 in pingdotgg/t3code#9093
## New Contributors
* @tristanmanchester made their first contribution in pingdotgg/t3code#9255
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1262...v0.0.39-nightly.20260903.1265
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1265
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge