abort in core by CAD97 · Pull Request #154604 · rust-lang/rust

CAD97 · 2026-03-30T20:11:30Z

Implements core::process::abort_immediate as a wrapper around intrinsics::abort.

tracking issue: Tracking Issue for abort_immediate (abort in core) #154601

(This PR used to also add core::process::abort, but that's been deferred to a later addition.)

rustbot · 2026-03-30T20:11:34Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-03-30T20:11:37Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, scottmcm

CAD97 · 2026-03-30T20:21:54Z

tests/ui/extern-flag and tests/ui/no_std caught that __rust_abort still wasn't being defined. I think this must be because std is available (and thus lang = "abort_impl" is defined, but #![no_std] means that we aren't linking std. I'm now looking for how to directly gate the shim on if std is getting linked, to avoid adding a new requirement to no_std binaries.

RalfJung · 2026-03-30T20:48:30Z

Cc @bjorn3 who knows a lot about the alloc shims.

bjorn3 · 2026-03-30T21:47:24Z

Imagine the following scenario:

liba depends on libcore and gets linked as dylib
libb depends on liba and libstd

When building liba, we need to already generate the __rust_abort symbol, but would conflict with the one from libstd. This is not a breaking change on most targets as due to what is arguably a bug in rustc, in this scenario rustc will report an error about libcore getting linked twice. If however you remove libstd.so or link for a target for which we don't ship libstd as dylib yet do still support dynamic linking (i don't know if any such target exists. maybe a wasm target?), then this scenario would currently work fine, but break with this PR.

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables. It is probably more of an issue for Bazel.

anforowicz · 2026-03-30T22:14:38Z

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables.

Thank you for the heads-up.

I think it doesn't impact Chromium, because Chromium product builds link everything statically (no dylibs, only rlibs that are at the end linked by non-rustc-driven linker).
OTOH we are currently working on building std into a dylib in developer builds (and later plan to expand this to some other libraries - e.g. the log crate). But this still seems ok, because I think that Chromium doesn't have a library like liba (linked as dylib, but depends on core and not on std).
That said, I don't fully understand the changes in this PR, so I defer to your judgement / I don't really understand if these changes may require a follow-up in Chromium when/if they get absorbed.

/cc @DKLoehr from the Chromium Toolchain team as FYI

CAD97 · 2026-03-30T22:26:14Z

Given core abort is essentially blocked on EIIs being ready, would it make sense to PR abort_immediate separately first?

CAD97 · 2026-03-30T22:58:41Z

I decided to rebase this branch/PR to just include abort_immediate, which is useful on its own. abort can be added later once EII can be utilized to do so properly.

jyn514 · 2026-03-30T23:26:53Z

+/// # Platform-specific behavior
+///
+/// `abort_immediate` lowers to a trap instruction on *most* architectures; on
+/// some architectures it simply lowers to call the unmangled `abort` function.


"unmangled" you mean libc::abort?

I adapted this wording from the panic-abort crate docs.
extern "C" { #[no_mangle] fn abort() -> !; } will be libc::abort in most cases, yes, but I'm not personally aware of what platforms have what behavior here.

gotcha. cc @japaric, this PR is heavily based on your panic-abort crate.

I don't think "unmangled abort" is very clear. Maybe refer to is as "the C abort function" or so.

Also, on which targets does this call libc::abort?

scottmcm · 2026-04-16T00:22:29Z

Sure, as just an unstable library API this seems fine

@bors r+ rollup

rust-bors · 2026-04-16T00:22:32Z

📌 Commit fb99fbe has been approved by scottmcm

It is now in the queue for this repository.

abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: rust-lang#154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

RalfJung · 2026-04-16T06:01:27Z

There's an unresolved comment further up. It's not blocking but @CAD97 please make sure to take care of it post-landing.

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #154604 - CAD97:abort-immediate, r=scottmcm abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: #154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

CAD97 · 2026-03-30T20:11:30Z

View all comments

Implements core::process::abort_immediate as a wrapper around intrinsics::abort.

tracking issue: Tracking Issue for abort_immediate (abort in core) #154601

(This PR used to also add core::process::abort, but that's been deferred to a later addition.)

rustbot · 2026-03-30T20:11:34Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-03-30T20:11:37Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, scottmcm

CAD97 · 2026-03-30T20:21:54Z

tests/ui/extern-flag and tests/ui/no_std caught that __rust_abort still wasn't being defined. I think this must be because std is available (and thus lang = "abort_impl" is defined, but #![no_std] means that we aren't linking std. I'm now looking for how to directly gate the shim on if std is getting linked, to avoid adding a new requirement to no_std binaries.

RalfJung · 2026-03-30T20:48:30Z

Cc @bjorn3 who knows a lot about the alloc shims.

bjorn3 · 2026-03-30T21:47:24Z

Imagine the following scenario:

liba depends on libcore and gets linked as dylib
libb depends on liba and libstd

When building liba, we need to already generate the __rust_abort symbol, but would conflict with the one from libstd. This is not a breaking change on most targets as due to what is arguably a bug in rustc, in this scenario rustc will report an error about libcore getting linked twice. If however you remove libstd.so or link for a target for which we don't ship libstd as dylib yet do still support dynamic linking (i don't know if any such target exists. maybe a wasm target?), then this scenario would currently work fine, but break with this PR.

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables. It is probably more of an issue for Bazel.

anforowicz · 2026-03-30T22:14:38Z

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables.

Thank you for the heads-up.

I think it doesn't impact Chromium, because Chromium product builds link everything statically (no dylibs, only rlibs that are at the end linked by non-rustc-driven linker).
OTOH we are currently working on building std into a dylib in developer builds (and later plan to expand this to some other libraries - e.g. the log crate). But this still seems ok, because I think that Chromium doesn't have a library like liba (linked as dylib, but depends on core and not on std).
That said, I don't fully understand the changes in this PR, so I defer to your judgement / I don't really understand if these changes may require a follow-up in Chromium when/if they get absorbed.

/cc @DKLoehr from the Chromium Toolchain team as FYI

CAD97 · 2026-03-30T22:26:14Z

Given core abort is essentially blocked on EIIs being ready, would it make sense to PR abort_immediate separately first?

CAD97 · 2026-03-30T22:58:41Z

I decided to rebase this branch/PR to just include abort_immediate, which is useful on its own. abort can be added later once EII can be utilized to do so properly.

jyn514 · 2026-03-30T23:26:53Z

+/// # Platform-specific behavior
+///
+/// `abort_immediate` lowers to a trap instruction on *most* architectures; on
+/// some architectures it simply lowers to call the unmangled `abort` function.


"unmangled" you mean libc::abort?

I adapted this wording from the panic-abort crate docs.
extern "C" { #[no_mangle] fn abort() -> !; } will be libc::abort in most cases, yes, but I'm not personally aware of what platforms have what behavior here.

gotcha. cc @japaric, this PR is heavily based on your panic-abort crate.

I don't think "unmangled abort" is very clear. Maybe refer to is as "the C abort function" or so.

Also, on which targets does this call libc::abort?

scottmcm · 2026-04-16T00:22:29Z

Sure, as just an unstable library API this seems fine

@bors r+ rollup

rust-bors · 2026-04-16T00:22:32Z

📌 Commit fb99fbe has been approved by scottmcm

It is now in the queue for this repository.

abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: rust-lang#154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

RalfJung · 2026-04-16T06:01:27Z

There's an unresolved comment further up. It's not blocking but @CAD97 please make sure to take care of it post-landing.

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #154604 - CAD97:abort-immediate, r=scottmcm abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: #154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

CAD97 · 2026-03-30T20:11:30Z

View all comments

Implements core::process::abort_immediate as a wrapper around intrinsics::abort.

tracking issue: Tracking Issue for abort_immediate (abort in core) #154601

(This PR used to also add core::process::abort, but that's been deferred to a later addition.)

rustbot · 2026-03-30T20:11:34Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-03-30T20:11:37Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, scottmcm

CAD97 · 2026-03-30T20:21:54Z

tests/ui/extern-flag and tests/ui/no_std caught that __rust_abort still wasn't being defined. I think this must be because std is available (and thus lang = "abort_impl" is defined, but #![no_std] means that we aren't linking std. I'm now looking for how to directly gate the shim on if std is getting linked, to avoid adding a new requirement to no_std binaries.

RalfJung · 2026-03-30T20:48:30Z

Cc @bjorn3 who knows a lot about the alloc shims.

bjorn3 · 2026-03-30T21:47:24Z

Imagine the following scenario:

liba depends on libcore and gets linked as dylib
libb depends on liba and libstd

When building liba, we need to already generate the __rust_abort symbol, but would conflict with the one from libstd. This is not a breaking change on most targets as due to what is arguably a bug in rustc, in this scenario rustc will report an error about libcore getting linked twice. If however you remove libstd.so or link for a target for which we don't ship libstd as dylib yet do still support dynamic linking (i don't know if any such target exists. maybe a wasm target?), then this scenario would currently work fine, but break with this PR.

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables. It is probably more of an issue for Bazel.

anforowicz · 2026-03-30T22:14:38Z

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables.

Thank you for the heads-up.

I think it doesn't impact Chromium, because Chromium product builds link everything statically (no dylibs, only rlibs that are at the end linked by non-rustc-driven linker).
OTOH we are currently working on building std into a dylib in developer builds (and later plan to expand this to some other libraries - e.g. the log crate). But this still seems ok, because I think that Chromium doesn't have a library like liba (linked as dylib, but depends on core and not on std).
That said, I don't fully understand the changes in this PR, so I defer to your judgement / I don't really understand if these changes may require a follow-up in Chromium when/if they get absorbed.

/cc @DKLoehr from the Chromium Toolchain team as FYI

CAD97 · 2026-03-30T22:26:14Z

Given core abort is essentially blocked on EIIs being ready, would it make sense to PR abort_immediate separately first?

CAD97 · 2026-03-30T22:58:41Z

I decided to rebase this branch/PR to just include abort_immediate, which is useful on its own. abort can be added later once EII can be utilized to do so properly.

jyn514 · 2026-03-30T23:26:53Z

+/// # Platform-specific behavior
+///
+/// `abort_immediate` lowers to a trap instruction on *most* architectures; on
+/// some architectures it simply lowers to call the unmangled `abort` function.


"unmangled" you mean libc::abort?

I adapted this wording from the panic-abort crate docs.
extern "C" { #[no_mangle] fn abort() -> !; } will be libc::abort in most cases, yes, but I'm not personally aware of what platforms have what behavior here.

gotcha. cc @japaric, this PR is heavily based on your panic-abort crate.

I don't think "unmangled abort" is very clear. Maybe refer to is as "the C abort function" or so.

Also, on which targets does this call libc::abort?

scottmcm · 2026-04-16T00:22:29Z

Sure, as just an unstable library API this seems fine

@bors r+ rollup

rust-bors · 2026-04-16T00:22:32Z

📌 Commit fb99fbe has been approved by scottmcm

It is now in the queue for this repository.

abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: rust-lang#154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

RalfJung · 2026-04-16T06:01:27Z

There's an unresolved comment further up. It's not blocking but @CAD97 please make sure to take care of it post-landing.

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #154604 - CAD97:abort-immediate, r=scottmcm abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: #154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

CAD97 · 2026-03-30T20:11:30Z

View all comments

Implements core::process::abort_immediate as a wrapper around intrinsics::abort.

tracking issue: Tracking Issue for abort_immediate (abort in core) #154601

(This PR used to also add core::process::abort, but that's been deferred to a later addition.)

rustbot · 2026-03-30T20:11:34Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-03-30T20:11:37Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, scottmcm

CAD97 · 2026-03-30T20:21:54Z

tests/ui/extern-flag and tests/ui/no_std caught that __rust_abort still wasn't being defined. I think this must be because std is available (and thus lang = "abort_impl" is defined, but #![no_std] means that we aren't linking std. I'm now looking for how to directly gate the shim on if std is getting linked, to avoid adding a new requirement to no_std binaries.

RalfJung · 2026-03-30T20:48:30Z

Cc @bjorn3 who knows a lot about the alloc shims.

bjorn3 · 2026-03-30T21:47:24Z

Imagine the following scenario:

liba depends on libcore and gets linked as dylib
libb depends on liba and libstd

When building liba, we need to already generate the __rust_abort symbol, but would conflict with the one from libstd. This is not a breaking change on most targets as due to what is arguably a bug in rustc, in this scenario rustc will report an error about libcore getting linked twice. If however you remove libstd.so or link for a target for which we don't ship libstd as dylib yet do still support dynamic linking (i don't know if any such target exists. maybe a wasm target?), then this scenario would currently work fine, but break with this PR.

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables. It is probably more of an issue for Bazel.

anforowicz · 2026-03-30T22:14:38Z

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables.

Thank you for the heads-up.

I think it doesn't impact Chromium, because Chromium product builds link everything statically (no dylibs, only rlibs that are at the end linked by non-rustc-driven linker).
OTOH we are currently working on building std into a dylib in developer builds (and later plan to expand this to some other libraries - e.g. the log crate). But this still seems ok, because I think that Chromium doesn't have a library like liba (linked as dylib, but depends on core and not on std).
That said, I don't fully understand the changes in this PR, so I defer to your judgement / I don't really understand if these changes may require a follow-up in Chromium when/if they get absorbed.

/cc @DKLoehr from the Chromium Toolchain team as FYI

CAD97 · 2026-03-30T22:26:14Z

Given core abort is essentially blocked on EIIs being ready, would it make sense to PR abort_immediate separately first?

CAD97 · 2026-03-30T22:58:41Z

I decided to rebase this branch/PR to just include abort_immediate, which is useful on its own. abort can be added later once EII can be utilized to do so properly.

jyn514 · 2026-03-30T23:26:53Z

+/// # Platform-specific behavior
+///
+/// `abort_immediate` lowers to a trap instruction on *most* architectures; on
+/// some architectures it simply lowers to call the unmangled `abort` function.


"unmangled" you mean libc::abort?

I adapted this wording from the panic-abort crate docs.
extern "C" { #[no_mangle] fn abort() -> !; } will be libc::abort in most cases, yes, but I'm not personally aware of what platforms have what behavior here.

gotcha. cc @japaric, this PR is heavily based on your panic-abort crate.

I don't think "unmangled abort" is very clear. Maybe refer to is as "the C abort function" or so.

Also, on which targets does this call libc::abort?

scottmcm · 2026-04-16T00:22:29Z

Sure, as just an unstable library API this seems fine

@bors r+ rollup

rust-bors · 2026-04-16T00:22:32Z

📌 Commit fb99fbe has been approved by scottmcm

It is now in the queue for this repository.

abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: rust-lang#154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

RalfJung · 2026-04-16T06:01:27Z

There's an unresolved comment further up. It's not blocking but @CAD97 please make sure to take care of it post-landing.

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #154604 - CAD97:abort-immediate, r=scottmcm abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: #154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

CAD97 · 2026-03-30T20:11:30Z

View all comments

Implements core::process::abort_immediate as a wrapper around intrinsics::abort.

tracking issue: Tracking Issue for abort_immediate (abort in core) #154601

(This PR used to also add core::process::abort, but that's been deferred to a later addition.)

rustbot · 2026-03-30T20:11:34Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-03-30T20:11:37Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, scottmcm

CAD97 · 2026-03-30T20:21:54Z

tests/ui/extern-flag and tests/ui/no_std caught that __rust_abort still wasn't being defined. I think this must be because std is available (and thus lang = "abort_impl" is defined, but #![no_std] means that we aren't linking std. I'm now looking for how to directly gate the shim on if std is getting linked, to avoid adding a new requirement to no_std binaries.

RalfJung · 2026-03-30T20:48:30Z

Cc @bjorn3 who knows a lot about the alloc shims.

bjorn3 · 2026-03-30T21:47:24Z

Imagine the following scenario:

liba depends on libcore and gets linked as dylib
libb depends on liba and libstd

When building liba, we need to already generate the __rust_abort symbol, but would conflict with the one from libstd. This is not a breaking change on most targets as due to what is arguably a bug in rustc, in this scenario rustc will report an error about libcore getting linked twice. If however you remove libstd.so or link for a target for which we don't ship libstd as dylib yet do still support dynamic linking (i don't know if any such target exists. maybe a wasm target?), then this scenario would currently work fine, but break with this PR.

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables. It is probably more of an issue for Bazel.

anforowicz · 2026-03-30T22:14:38Z

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables.

Thank you for the heads-up.

I think it doesn't impact Chromium, because Chromium product builds link everything statically (no dylibs, only rlibs that are at the end linked by non-rustc-driven linker).
OTOH we are currently working on building std into a dylib in developer builds (and later plan to expand this to some other libraries - e.g. the log crate). But this still seems ok, because I think that Chromium doesn't have a library like liba (linked as dylib, but depends on core and not on std).
That said, I don't fully understand the changes in this PR, so I defer to your judgement / I don't really understand if these changes may require a follow-up in Chromium when/if they get absorbed.

/cc @DKLoehr from the Chromium Toolchain team as FYI

CAD97 · 2026-03-30T22:26:14Z

Given core abort is essentially blocked on EIIs being ready, would it make sense to PR abort_immediate separately first?

CAD97 · 2026-03-30T22:58:41Z

I decided to rebase this branch/PR to just include abort_immediate, which is useful on its own. abort can be added later once EII can be utilized to do so properly.

jyn514 · 2026-03-30T23:26:53Z

+/// # Platform-specific behavior
+///
+/// `abort_immediate` lowers to a trap instruction on *most* architectures; on
+/// some architectures it simply lowers to call the unmangled `abort` function.


"unmangled" you mean libc::abort?

I adapted this wording from the panic-abort crate docs.
extern "C" { #[no_mangle] fn abort() -> !; } will be libc::abort in most cases, yes, but I'm not personally aware of what platforms have what behavior here.

gotcha. cc @japaric, this PR is heavily based on your panic-abort crate.

I don't think "unmangled abort" is very clear. Maybe refer to is as "the C abort function" or so.

Also, on which targets does this call libc::abort?

scottmcm · 2026-04-16T00:22:29Z

Sure, as just an unstable library API this seems fine

@bors r+ rollup

rust-bors · 2026-04-16T00:22:32Z

📌 Commit fb99fbe has been approved by scottmcm

It is now in the queue for this repository.

abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: rust-lang#154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

RalfJung · 2026-04-16T06:01:27Z

There's an unresolved comment further up. It's not blocking but @CAD97 please make sure to take care of it post-landing.

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #154604 - CAD97:abort-immediate, r=scottmcm abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: #154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

CAD97 · 2026-03-30T20:11:30Z

View all comments

Implements core::process::abort_immediate as a wrapper around intrinsics::abort.

tracking issue: Tracking Issue for abort_immediate (abort in core) #154601

(This PR used to also add core::process::abort, but that's been deferred to a later addition.)

rustbot · 2026-03-30T20:11:34Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-03-30T20:11:37Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, scottmcm

CAD97 · 2026-03-30T20:21:54Z

tests/ui/extern-flag and tests/ui/no_std caught that __rust_abort still wasn't being defined. I think this must be because std is available (and thus lang = "abort_impl" is defined, but #![no_std] means that we aren't linking std. I'm now looking for how to directly gate the shim on if std is getting linked, to avoid adding a new requirement to no_std binaries.

RalfJung · 2026-03-30T20:48:30Z

Cc @bjorn3 who knows a lot about the alloc shims.

bjorn3 · 2026-03-30T21:47:24Z

Imagine the following scenario:

liba depends on libcore and gets linked as dylib
libb depends on liba and libstd

When building liba, we need to already generate the __rust_abort symbol, but would conflict with the one from libstd. This is not a breaking change on most targets as due to what is arguably a bug in rustc, in this scenario rustc will report an error about libcore getting linked twice. If however you remove libstd.so or link for a target for which we don't ship libstd as dylib yet do still support dynamic linking (i don't know if any such target exists. maybe a wasm target?), then this scenario would currently work fine, but break with this PR.

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables. It is probably more of an issue for Bazel.

anforowicz · 2026-03-30T22:14:38Z

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables.

Thank you for the heads-up.

I think it doesn't impact Chromium, because Chromium product builds link everything statically (no dylibs, only rlibs that are at the end linked by non-rustc-driven linker).
OTOH we are currently working on building std into a dylib in developer builds (and later plan to expand this to some other libraries - e.g. the log crate). But this still seems ok, because I think that Chromium doesn't have a library like liba (linked as dylib, but depends on core and not on std).
That said, I don't fully understand the changes in this PR, so I defer to your judgement / I don't really understand if these changes may require a follow-up in Chromium when/if they get absorbed.

/cc @DKLoehr from the Chromium Toolchain team as FYI

CAD97 · 2026-03-30T22:26:14Z

Given core abort is essentially blocked on EIIs being ready, would it make sense to PR abort_immediate separately first?

CAD97 · 2026-03-30T22:58:41Z

I decided to rebase this branch/PR to just include abort_immediate, which is useful on its own. abort can be added later once EII can be utilized to do so properly.

jyn514 · 2026-03-30T23:26:53Z

+/// # Platform-specific behavior
+///
+/// `abort_immediate` lowers to a trap instruction on *most* architectures; on
+/// some architectures it simply lowers to call the unmangled `abort` function.


"unmangled" you mean libc::abort?

I adapted this wording from the panic-abort crate docs.
extern "C" { #[no_mangle] fn abort() -> !; } will be libc::abort in most cases, yes, but I'm not personally aware of what platforms have what behavior here.

gotcha. cc @japaric, this PR is heavily based on your panic-abort crate.

I don't think "unmangled abort" is very clear. Maybe refer to is as "the C abort function" or so.

Also, on which targets does this call libc::abort?

scottmcm · 2026-04-16T00:22:29Z

Sure, as just an unstable library API this seems fine

@bors r+ rollup

rust-bors · 2026-04-16T00:22:32Z

📌 Commit fb99fbe has been approved by scottmcm

It is now in the queue for this repository.

abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: rust-lang#154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

RalfJung · 2026-04-16T06:01:27Z

There's an unresolved comment further up. It's not blocking but @CAD97 please make sure to take care of it post-landing.

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #154604 - CAD97:abort-immediate, r=scottmcm abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: #154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

CAD97 · 2026-03-30T20:11:30Z

View all comments

Implements core::process::abort_immediate as a wrapper around intrinsics::abort.

tracking issue: Tracking Issue for abort_immediate (abort in core) #154601

(This PR used to also add core::process::abort, but that's been deferred to a later addition.)

rustbot · 2026-03-30T20:11:34Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-03-30T20:11:37Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, scottmcm

CAD97 · 2026-03-30T20:21:54Z

tests/ui/extern-flag and tests/ui/no_std caught that __rust_abort still wasn't being defined. I think this must be because std is available (and thus lang = "abort_impl" is defined, but #![no_std] means that we aren't linking std. I'm now looking for how to directly gate the shim on if std is getting linked, to avoid adding a new requirement to no_std binaries.

RalfJung · 2026-03-30T20:48:30Z

Cc @bjorn3 who knows a lot about the alloc shims.

bjorn3 · 2026-03-30T21:47:24Z

Imagine the following scenario:

liba depends on libcore and gets linked as dylib
libb depends on liba and libstd

When building liba, we need to already generate the __rust_abort symbol, but would conflict with the one from libstd. This is not a breaking change on most targets as due to what is arguably a bug in rustc, in this scenario rustc will report an error about libcore getting linked twice. If however you remove libstd.so or link for a target for which we don't ship libstd as dylib yet do still support dynamic linking (i don't know if any such target exists. maybe a wasm target?), then this scenario would currently work fine, but break with this PR.

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables. It is probably more of an issue for Bazel.

anforowicz · 2026-03-30T22:14:38Z

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables.

Thank you for the heads-up.

I think it doesn't impact Chromium, because Chromium product builds link everything statically (no dylibs, only rlibs that are at the end linked by non-rustc-driven linker).
OTOH we are currently working on building std into a dylib in developer builds (and later plan to expand this to some other libraries - e.g. the log crate). But this still seems ok, because I think that Chromium doesn't have a library like liba (linked as dylib, but depends on core and not on std).
That said, I don't fully understand the changes in this PR, so I defer to your judgement / I don't really understand if these changes may require a follow-up in Chromium when/if they get absorbed.

/cc @DKLoehr from the Chromium Toolchain team as FYI

CAD97 · 2026-03-30T22:26:14Z

Given core abort is essentially blocked on EIIs being ready, would it make sense to PR abort_immediate separately first?

CAD97 · 2026-03-30T22:58:41Z

I decided to rebase this branch/PR to just include abort_immediate, which is useful on its own. abort can be added later once EII can be utilized to do so properly.

jyn514 · 2026-03-30T23:26:53Z

+/// # Platform-specific behavior
+///
+/// `abort_immediate` lowers to a trap instruction on *most* architectures; on
+/// some architectures it simply lowers to call the unmangled `abort` function.


"unmangled" you mean libc::abort?

I adapted this wording from the panic-abort crate docs.
extern "C" { #[no_mangle] fn abort() -> !; } will be libc::abort in most cases, yes, but I'm not personally aware of what platforms have what behavior here.

gotcha. cc @japaric, this PR is heavily based on your panic-abort crate.

I don't think "unmangled abort" is very clear. Maybe refer to is as "the C abort function" or so.

Also, on which targets does this call libc::abort?

scottmcm · 2026-04-16T00:22:29Z

Sure, as just an unstable library API this seems fine

@bors r+ rollup

rust-bors · 2026-04-16T00:22:32Z

📌 Commit fb99fbe has been approved by scottmcm

It is now in the queue for this repository.

abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: rust-lang#154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

RalfJung · 2026-04-16T06:01:27Z

There's an unresolved comment further up. It's not blocking but @CAD97 please make sure to take care of it post-landing.

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #154604 - CAD97:abort-immediate, r=scottmcm abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: #154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

CAD97 · 2026-03-30T20:11:30Z

View all comments

Implements core::process::abort_immediate as a wrapper around intrinsics::abort.

tracking issue: Tracking Issue for abort_immediate (abort in core) #154601

(This PR used to also add core::process::abort, but that's been deferred to a later addition.)

rustbot · 2026-03-30T20:11:34Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustbot · 2026-03-30T20:11:37Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @scottmcm, libs
@scottmcm, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, scottmcm

CAD97 · 2026-03-30T20:21:54Z

tests/ui/extern-flag and tests/ui/no_std caught that __rust_abort still wasn't being defined. I think this must be because std is available (and thus lang = "abort_impl" is defined, but #![no_std] means that we aren't linking std. I'm now looking for how to directly gate the shim on if std is getting linked, to avoid adding a new requirement to no_std binaries.

RalfJung · 2026-03-30T20:48:30Z

Cc @bjorn3 who knows a lot about the alloc shims.

bjorn3 · 2026-03-30T21:47:24Z

Imagine the following scenario:

liba depends on libcore and gets linked as dylib
libb depends on liba and libstd

When building liba, we need to already generate the __rust_abort symbol, but would conflict with the one from libstd. This is not a breaking change on most targets as due to what is arguably a bug in rustc, in this scenario rustc will report an error about libcore getting linked twice. If however you remove libstd.so or link for a target for which we don't ship libstd as dylib yet do still support dynamic linking (i don't know if any such target exists. maybe a wasm target?), then this scenario would currently work fine, but break with this PR.

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables. It is probably more of an issue for Bazel.

anforowicz · 2026-03-30T22:14:38Z

Also cc @anforowicz for Chromium which bypasses the allocator shim. I think it will be fine for you as you include libstd, but I'm not sure if you don't have any no_std executables.

Thank you for the heads-up.

I think it doesn't impact Chromium, because Chromium product builds link everything statically (no dylibs, only rlibs that are at the end linked by non-rustc-driven linker).
OTOH we are currently working on building std into a dylib in developer builds (and later plan to expand this to some other libraries - e.g. the log crate). But this still seems ok, because I think that Chromium doesn't have a library like liba (linked as dylib, but depends on core and not on std).
That said, I don't fully understand the changes in this PR, so I defer to your judgement / I don't really understand if these changes may require a follow-up in Chromium when/if they get absorbed.

/cc @DKLoehr from the Chromium Toolchain team as FYI

CAD97 · 2026-03-30T22:26:14Z

Given core abort is essentially blocked on EIIs being ready, would it make sense to PR abort_immediate separately first?

CAD97 · 2026-03-30T22:58:41Z

I decided to rebase this branch/PR to just include abort_immediate, which is useful on its own. abort can be added later once EII can be utilized to do so properly.

jyn514 · 2026-03-30T23:26:53Z

+/// # Platform-specific behavior
+///
+/// `abort_immediate` lowers to a trap instruction on *most* architectures; on
+/// some architectures it simply lowers to call the unmangled `abort` function.


"unmangled" you mean libc::abort?

I adapted this wording from the panic-abort crate docs.
extern "C" { #[no_mangle] fn abort() -> !; } will be libc::abort in most cases, yes, but I'm not personally aware of what platforms have what behavior here.

gotcha. cc @japaric, this PR is heavily based on your panic-abort crate.

I don't think "unmangled abort" is very clear. Maybe refer to is as "the C abort function" or so.

Also, on which targets does this call libc::abort?

scottmcm · 2026-04-16T00:22:29Z

Sure, as just an unstable library API this seems fine

@bors r+ rollup

rust-bors · 2026-04-16T00:22:32Z

📌 Commit fb99fbe has been approved by scottmcm

It is now in the queue for this repository.

abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: rust-lang#154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

RalfJung · 2026-04-16T06:01:27Z

There's an unresolved comment further up. It's not blocking but @CAD97 please make sure to take care of it post-landing.

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #154604 - CAD97:abort-immediate, r=scottmcm abort in core Implements `core::process::abort_immediate` as a wrapper around `intrinsics::abort`. - tracking issue: #154601 (This PR used to also add `core::process::abort`, but that's been deferred to a later addition.)

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned scottmcm Mar 30, 2026

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

This comment has been minimized.
Sign in to view

bjorn3 reviewed Mar 30, 2026
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/base.rs Outdated

add abort_immediate
3a311ed

CAD97 force-pushed the abort-immediate branch from 807cd4e to 3a311edCompare March 30, 2026 22:56

CAD97 mentioned this pull request Mar 30, 2026
Tracking Issue for abort_immediate (abort in core) #154601
Open
4 tasks

This comment has been minimized.
Sign in to view

add missing core::process module docs
fb99fbe

jyn514 reviewed Mar 30, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 2beaa60 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

CAD97 deleted the abort-immediate branch June 23, 2026 02:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned scottmcm Mar 30, 2026

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

This comment has been minimized.
Sign in to view

bjorn3 reviewed Mar 30, 2026
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/base.rs Outdated

add abort_immediate
3a311ed

CAD97 force-pushed the abort-immediate branch from 807cd4e to 3a311edCompare March 30, 2026 22:56

CAD97 mentioned this pull request Mar 30, 2026
Tracking Issue for abort_immediate (abort in core) #154601
Open
4 tasks

This comment has been minimized.
Sign in to view

add missing core::process module docs
fb99fbe

jyn514 reviewed Mar 30, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 2beaa60 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

CAD97 deleted the abort-immediate branch June 23, 2026 02:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned scottmcm Mar 30, 2026

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

This comment has been minimized.
Sign in to view

bjorn3 reviewed Mar 30, 2026
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/base.rs Outdated

add abort_immediate
3a311ed

CAD97 force-pushed the abort-immediate branch from 807cd4e to 3a311edCompare March 30, 2026 22:56

CAD97 mentioned this pull request Mar 30, 2026
Tracking Issue for abort_immediate (abort in core) #154601
Open
4 tasks

This comment has been minimized.
Sign in to view

add missing core::process module docs
fb99fbe

jyn514 reviewed Mar 30, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 2beaa60 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

CAD97 deleted the abort-immediate branch June 23, 2026 02:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned scottmcm Mar 30, 2026

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

This comment has been minimized.
Sign in to view

bjorn3 reviewed Mar 30, 2026
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/base.rs Outdated

add abort_immediate
3a311ed

CAD97 force-pushed the abort-immediate branch from 807cd4e to 3a311edCompare March 30, 2026 22:56

CAD97 mentioned this pull request Mar 30, 2026
Tracking Issue for abort_immediate (abort in core) #154601
Open
4 tasks

This comment has been minimized.
Sign in to view

add missing core::process module docs
fb99fbe

jyn514 reviewed Mar 30, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 2beaa60 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

CAD97 deleted the abort-immediate branch June 23, 2026 02:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned scottmcm Mar 30, 2026

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

This comment has been minimized.
Sign in to view

bjorn3 reviewed Mar 30, 2026
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/base.rs Outdated

add abort_immediate
3a311ed

CAD97 force-pushed the abort-immediate branch from 807cd4e to 3a311edCompare March 30, 2026 22:56

CAD97 mentioned this pull request Mar 30, 2026
Tracking Issue for abort_immediate (abort in core) #154601
Open
4 tasks

This comment has been minimized.
Sign in to view

add missing core::process module docs
fb99fbe

jyn514 reviewed Mar 30, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 2beaa60 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

CAD97 deleted the abort-immediate branch June 23, 2026 02:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned scottmcm Mar 30, 2026

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

This comment has been minimized.
Sign in to view

bjorn3 reviewed Mar 30, 2026
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/base.rs Outdated

add abort_immediate
3a311ed

CAD97 force-pushed the abort-immediate branch from 807cd4e to 3a311edCompare March 30, 2026 22:56

CAD97 mentioned this pull request Mar 30, 2026
Tracking Issue for abort_immediate (abort in core) #154601
Open
4 tasks

This comment has been minimized.
Sign in to view

add missing core::process module docs
fb99fbe

jyn514 reviewed Mar 30, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 2beaa60 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

CAD97 deleted the abort-immediate branch June 23, 2026 02:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned scottmcm Mar 30, 2026

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

This comment has been minimized.
Sign in to view

bjorn3 reviewed Mar 30, 2026
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/base.rs Outdated

add abort_immediate
3a311ed

CAD97 force-pushed the abort-immediate branch from 807cd4e to 3a311edCompare March 30, 2026 22:56

CAD97 mentioned this pull request Mar 30, 2026
Tracking Issue for abort_immediate (abort in core) #154601
Open
4 tasks

This comment has been minimized.
Sign in to view

add missing core::process module docs
fb99fbe

jyn514 reviewed Mar 30, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 2beaa60 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

CAD97 deleted the abort-immediate branch June 23, 2026 02:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 30, 2026

rustbot assigned scottmcm Mar 30, 2026

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

RalfJung reviewed Mar 30, 2026
View reviewed changes

Comment threadlibrary/core/src/process.rs Outdated

This comment has been minimized.
Sign in to view

bjorn3 reviewed Mar 30, 2026
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/base.rs Outdated

add abort_immediate
3a311ed

CAD97 force-pushed the abort-immediate branch from 807cd4e to 3a311edCompare March 30, 2026 22:56

CAD97 mentioned this pull request Mar 30, 2026
Tracking Issue for abort_immediate (abort in core) #154601
Open
4 tasks

This comment has been minimized.
Sign in to view

add missing core::process module docs
fb99fbe

jyn514 reviewed Mar 30, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 2beaa60 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

CAD97 deleted the abort-immediate branch June 23, 2026 02:56

Uh oh!

Uh oh!

Conversation

CAD97 commented Mar 30, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

CAD97 commented Mar 30, 2026

Uh oh!

RalfJung commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

bjorn3 commented Mar 30, 2026

Uh oh!

anforowicz commented Mar 30, 2026

Uh oh!

CAD97 commented Mar 30, 2026

Uh oh!

CAD97 commented Mar 30, 2026

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scottmcm commented Apr 16, 2026

Uh oh!

rust-borsBot commented Apr 16, 2026

Uh oh!

RalfJung commented Apr 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

CAD97 commented Mar 30, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

rustbot commented Mar 30, 2026

Uh oh!

CAD97 commented Mar 30, 2026

Uh oh!

RalfJung commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

bjorn3 commented Mar 30, 2026

Uh oh!

anforowicz commented Mar 30, 2026

Uh oh!

CAD97 commented Mar 30, 2026

Uh oh!

CAD97 commented Mar 30, 2026

Uh oh!

This comment has been minimized.

CAD97 commented Mar 30, 2026•
edited by rustbot
Loading

RalfJung commented Apr 16, 2026•
edited
Loading

CAD97 commented Mar 30, 2026•
edited by rustbot
Loading

RalfJung commented Apr 16, 2026•
edited
Loading

CAD97 commented Mar 30, 2026•
edited by rustbot
Loading