remove calls to AliasTyKind::def_id - #155356

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
WilliamTakeshi:remove_calls_to_def_id
Apr 16, 2026
Merged

remove calls to AliasTyKind::def_id#155356
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
WilliamTakeshi:remove_calls_to_def_id

Conversation

@WilliamTakeshi

@WilliamTakeshiWilliamTakeshi commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

ref #154941

I asked the LSP where AliasTyKind::def_id and then checked where the AliasTyKind::def_id was trivial to change. Could only find 2 places, and I am not sure about the opaque_types.rs (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as AliasTyKind::def_id

This is the list checked:

  • compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
  • compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
  • compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
  • compiler/rustc_hir_analysis/src/check/mod.rs — 1
  • compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
  • compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
  • compiler/rustc_infer/src/infer/outlives/verify.rs — 3
  • compiler/rustc_middle/src/ty/print/pretty.rs — 1
  • compiler/rustc_middle/src/ty/sty.rs — 1
  • compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
  • compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
  • compiler/rustc_pattern_analysis/src/rustc.rs — 1
  • compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
  • compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
  • compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
  • compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
  • compiler/rustc_trait_selection/src/traits/effects.rs — 1
  • compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
  • compiler/rustc_ty_utils/src/opaque_types.rs — 7
  • compiler/rustc_ty_utils/src/ty.rs — 1
  • compiler/rustc_type_ir/src/outlives.rs — 1
  • compiler/rustc_type_ir/src/predicate.rs — 1
  • compiler/rustc_type_ir/src/relate.rs — 5
  • compiler/rustc_type_ir/src/ty_kind.rs — 2

r? @WaffleLapkin

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026
@rustbot

rustbot commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

WaffleLapkin is not on the review rotation at the moment.
They may take a while to respond.

WaffleLapkin
WaffleLapkin approved these changes Apr 15, 2026
View reviewed changes

@WaffleLapkinWaffleLapkin left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd refactor all of the other cases as well, but this is a small improvement so looks good to me :)

View changes since this review

@WaffleLapkin

WaffleLapkin commented Apr 15, 2026

Copy link
Copy Markdown
Member

r=me with green CI
@bors delegate

@rust-bors

rust-borsBot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

✌️ @WilliamTakeshi, you can now approve this pull request!

If @WaffleLapkin told you to "r=me" after making some further change, then please make that change and post @bors r=WaffleLapkin.

@Kivooeo

Kivooeo commented Apr 15, 2026

Copy link
Copy Markdown
Member

@bors r=WaffleLapkin rollup

@rust-bors

rust-borsBot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit dbb83b6 has been approved by WaffleLapkin

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 16, 2026
@jhpratt
Rollup merge ofrust-lang#155356- WilliamTakeshi:remove_calls_to_def…
8dfe975
…_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref rust-lang#154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@jhprattjhpratt mentioned this pull request Apr 16, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Apr 16, 2026
@bors
Auto merge of#155373- jhpratt:rollup-qjxAt4R, r=jhpratt
63faf88
Rollup of 18 pull requests
Successful merges:
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@jhprattjhpratt mentioned this pull request Apr 16, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Apr 16, 2026
@bors
Auto merge of#155380- jhpratt:rollup-j1e7DVL, r=jhpratt
7af3402
Rollup of 18 pull requests
Successful merges:
- #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@rust-bors
rust-borsBot merged commit 94d946e into rust-lang:mainApr 16, 2026
11 checks passed
@rustbotrustbot added this to the 1.97.0 milestone Apr 16, 2026
rust-timer added a commit that referenced this pull request Apr 16, 2026
@rust-timer
Unrolled build for#155356
1b26279
Rollup merge of #155356 - WilliamTakeshi:remove_calls_to_def_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref #154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@WilliamTakeshi
WilliamTakeshi deleted the remove_calls_to_def_id branch April 17, 2026 11:01
zihan0822 pushed a commit to zihan0822/rust-clippy that referenced this pull request Apr 30, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
8bc1aa3
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
a502b0f
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WaffleLapkinWaffleLapkinWaffleLapkin approved these changes

Assignees

@WaffleLapkinWaffleLapkin

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@WilliamTakeshi@rustbot@WaffleLapkin@Kivooeo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
remove calls to AliasTyKind::def_id - #155356
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Apr 16, 2026
Merged
remove calls to AliasTyKind::def_id#155356
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Conversation
@WilliamTakeshi
@WilliamTakeshiWilliamTakeshi
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
ref #154941
I asked the LSP where AliasTyKind::def_id and then checked where the AliasTyKind::def_id was trivial to change. Could only find 2 places, and I am not sure about the opaque_types.rs (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as AliasTyKind::def_id
This is the list checked:
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
  •  compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
  •  compiler/rustc_hir_analysis/src/check/mod.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
  •  compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/verify.rs — 3
  •  compiler/rustc_middle/src/ty/print/pretty.rs — 1
  •  compiler/rustc_middle/src/ty/sty.rs — 1
  •  compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
  •  compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
  •  compiler/rustc_pattern_analysis/src/rustc.rs — 1
  •  compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
  •  compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
  •  compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
  •  compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
  •  compiler/rustc_trait_selection/src/traits/effects.rs — 1
  •  compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
  •  compiler/rustc_ty_utils/src/opaque_types.rs — 7
  •  compiler/rustc_ty_utils/src/ty.rs — 1
  •  compiler/rustc_type_ir/src/outlives.rs — 1
  •  compiler/rustc_type_ir/src/predicate.rs — 1
  •  compiler/rustc_type_ir/src/relate.rs — 5
  •  compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Apr 15, 2026
@rustbot
rustbot
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
WaffleLapkin is not on the review rotation at the moment.

They may take a while to respond.
WaffleLapkin
WaffleLapkin
approved these changes
Apr 15, 2026
View reviewed changes
@WaffleLapkinWaffleLapkin
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd refactor all of the other cases as well, but this is a small improvement so looks good to me :)
View changes since this review
@WaffleLapkin
WaffleLapkin
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
r=me with green CI
@bors delegate
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
✌️ @WilliamTakeshi, you can now approve this pull request!
If @WaffleLapkin told you to "r=me" after making some further change, then please make that change and post @bors r=WaffleLapkin.
@Kivooeo
Kivooeo
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
@bors r=WaffleLapkin rollup
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit dbb83b6 has been approved by WaffleLapkin
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 15, 2026
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
@jhpratt
Rollup merge ofrust-lang#155356- WilliamTakeshi:remove_calls_to_def…
8dfe975
…_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref rust-lang#154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155373- jhpratt:rollup-qjxAt4R, r=jhpratt
63faf88
Rollup of 18 pull requests
Successful merges:
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155380- jhpratt:rollup-j1e7DVL, r=jhpratt
7af3402
Rollup of 18 pull requests
Successful merges:
- #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@rust-bors
rust-borsBot
merged commit 94d946e
into
rust-lang:mainApr 16, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 16, 2026
rust-timer added a commit
that referenced
this pull request
Apr 16, 2026
@rust-timer
Unrolled build for#155356
1b26279
Rollup merge of #155356 - WilliamTakeshi:remove_calls_to_def_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref #154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@WilliamTakeshi
WilliamTakeshi
deleted the

remove_calls_to_def_id

branch
April 17, 2026 11:01
zihan0822 pushed a commit
to zihan0822/rust-clippy
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
8bc1aa3
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
a502b0f
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@WaffleLapkinWaffleLapkinWaffleLapkin approved these changes

Assignees

@WaffleLapkinWaffleLapkin

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@WilliamTakeshi@rustbot@WaffleLapkin@Kivooeo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
remove calls to AliasTyKind::def_id - #155356
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Apr 16, 2026
Merged
remove calls to AliasTyKind::def_id#155356
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Conversation
@WilliamTakeshi
@WilliamTakeshiWilliamTakeshi
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
ref #154941
I asked the LSP where AliasTyKind::def_id and then checked where the AliasTyKind::def_id was trivial to change. Could only find 2 places, and I am not sure about the opaque_types.rs (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as AliasTyKind::def_id
This is the list checked:
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
  •  compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
  •  compiler/rustc_hir_analysis/src/check/mod.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
  •  compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/verify.rs — 3
  •  compiler/rustc_middle/src/ty/print/pretty.rs — 1
  •  compiler/rustc_middle/src/ty/sty.rs — 1
  •  compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
  •  compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
  •  compiler/rustc_pattern_analysis/src/rustc.rs — 1
  •  compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
  •  compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
  •  compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
  •  compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
  •  compiler/rustc_trait_selection/src/traits/effects.rs — 1
  •  compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
  •  compiler/rustc_ty_utils/src/opaque_types.rs — 7
  •  compiler/rustc_ty_utils/src/ty.rs — 1
  •  compiler/rustc_type_ir/src/outlives.rs — 1
  •  compiler/rustc_type_ir/src/predicate.rs — 1
  •  compiler/rustc_type_ir/src/relate.rs — 5
  •  compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Apr 15, 2026
@rustbot
rustbot
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
WaffleLapkin is not on the review rotation at the moment.

They may take a while to respond.
WaffleLapkin
WaffleLapkin
approved these changes
Apr 15, 2026
View reviewed changes
@WaffleLapkinWaffleLapkin
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd refactor all of the other cases as well, but this is a small improvement so looks good to me :)
View changes since this review
@WaffleLapkin
WaffleLapkin
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
r=me with green CI
@bors delegate
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
✌️ @WilliamTakeshi, you can now approve this pull request!
If @WaffleLapkin told you to "r=me" after making some further change, then please make that change and post @bors r=WaffleLapkin.
@Kivooeo
Kivooeo
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
@bors r=WaffleLapkin rollup
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit dbb83b6 has been approved by WaffleLapkin
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 15, 2026
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
@jhpratt
Rollup merge ofrust-lang#155356- WilliamTakeshi:remove_calls_to_def…
8dfe975
…_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref rust-lang#154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155373- jhpratt:rollup-qjxAt4R, r=jhpratt
63faf88
Rollup of 18 pull requests
Successful merges:
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155380- jhpratt:rollup-j1e7DVL, r=jhpratt
7af3402
Rollup of 18 pull requests
Successful merges:
- #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@rust-bors
rust-borsBot
merged commit 94d946e
into
rust-lang:mainApr 16, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 16, 2026
rust-timer added a commit
that referenced
this pull request
Apr 16, 2026
@rust-timer
Unrolled build for#155356
1b26279
Rollup merge of #155356 - WilliamTakeshi:remove_calls_to_def_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref #154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@WilliamTakeshi
WilliamTakeshi
deleted the

remove_calls_to_def_id

branch
April 17, 2026 11:01
zihan0822 pushed a commit
to zihan0822/rust-clippy
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
8bc1aa3
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
a502b0f
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@WaffleLapkinWaffleLapkinWaffleLapkin approved these changes

Assignees

@WaffleLapkinWaffleLapkin

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@WilliamTakeshi@rustbot@WaffleLapkin@Kivooeo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
remove calls to AliasTyKind::def_id - #155356
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Apr 16, 2026
Merged
remove calls to AliasTyKind::def_id#155356
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Conversation
@WilliamTakeshi
@WilliamTakeshiWilliamTakeshi
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
ref #154941
I asked the LSP where AliasTyKind::def_id and then checked where the AliasTyKind::def_id was trivial to change. Could only find 2 places, and I am not sure about the opaque_types.rs (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as AliasTyKind::def_id
This is the list checked:
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
  •  compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
  •  compiler/rustc_hir_analysis/src/check/mod.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
  •  compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/verify.rs — 3
  •  compiler/rustc_middle/src/ty/print/pretty.rs — 1
  •  compiler/rustc_middle/src/ty/sty.rs — 1
  •  compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
  •  compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
  •  compiler/rustc_pattern_analysis/src/rustc.rs — 1
  •  compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
  •  compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
  •  compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
  •  compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
  •  compiler/rustc_trait_selection/src/traits/effects.rs — 1
  •  compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
  •  compiler/rustc_ty_utils/src/opaque_types.rs — 7
  •  compiler/rustc_ty_utils/src/ty.rs — 1
  •  compiler/rustc_type_ir/src/outlives.rs — 1
  •  compiler/rustc_type_ir/src/predicate.rs — 1
  •  compiler/rustc_type_ir/src/relate.rs — 5
  •  compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Apr 15, 2026
@rustbot
rustbot
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
WaffleLapkin is not on the review rotation at the moment.

They may take a while to respond.
WaffleLapkin
WaffleLapkin
approved these changes
Apr 15, 2026
View reviewed changes
@WaffleLapkinWaffleLapkin
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd refactor all of the other cases as well, but this is a small improvement so looks good to me :)
View changes since this review
@WaffleLapkin
WaffleLapkin
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
r=me with green CI
@bors delegate
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
✌️ @WilliamTakeshi, you can now approve this pull request!
If @WaffleLapkin told you to "r=me" after making some further change, then please make that change and post @bors r=WaffleLapkin.
@Kivooeo
Kivooeo
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
@bors r=WaffleLapkin rollup
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit dbb83b6 has been approved by WaffleLapkin
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 15, 2026
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
@jhpratt
Rollup merge ofrust-lang#155356- WilliamTakeshi:remove_calls_to_def…
8dfe975
…_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref rust-lang#154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155373- jhpratt:rollup-qjxAt4R, r=jhpratt
63faf88
Rollup of 18 pull requests
Successful merges:
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155380- jhpratt:rollup-j1e7DVL, r=jhpratt
7af3402
Rollup of 18 pull requests
Successful merges:
- #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@rust-bors
rust-borsBot
merged commit 94d946e
into
rust-lang:mainApr 16, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 16, 2026
rust-timer added a commit
that referenced
this pull request
Apr 16, 2026
@rust-timer
Unrolled build for#155356
1b26279
Rollup merge of #155356 - WilliamTakeshi:remove_calls_to_def_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref #154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@WilliamTakeshi
WilliamTakeshi
deleted the

remove_calls_to_def_id

branch
April 17, 2026 11:01
zihan0822 pushed a commit
to zihan0822/rust-clippy
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
8bc1aa3
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
a502b0f
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@WaffleLapkinWaffleLapkinWaffleLapkin approved these changes

Assignees

@WaffleLapkinWaffleLapkin

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@WilliamTakeshi@rustbot@WaffleLapkin@Kivooeo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
remove calls to AliasTyKind::def_id - #155356
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Apr 16, 2026
Merged
remove calls to AliasTyKind::def_id#155356
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Conversation
@WilliamTakeshi
@WilliamTakeshiWilliamTakeshi
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
ref #154941
I asked the LSP where AliasTyKind::def_id and then checked where the AliasTyKind::def_id was trivial to change. Could only find 2 places, and I am not sure about the opaque_types.rs (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as AliasTyKind::def_id
This is the list checked:
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
  •  compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
  •  compiler/rustc_hir_analysis/src/check/mod.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
  •  compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/verify.rs — 3
  •  compiler/rustc_middle/src/ty/print/pretty.rs — 1
  •  compiler/rustc_middle/src/ty/sty.rs — 1
  •  compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
  •  compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
  •  compiler/rustc_pattern_analysis/src/rustc.rs — 1
  •  compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
  •  compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
  •  compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
  •  compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
  •  compiler/rustc_trait_selection/src/traits/effects.rs — 1
  •  compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
  •  compiler/rustc_ty_utils/src/opaque_types.rs — 7
  •  compiler/rustc_ty_utils/src/ty.rs — 1
  •  compiler/rustc_type_ir/src/outlives.rs — 1
  •  compiler/rustc_type_ir/src/predicate.rs — 1
  •  compiler/rustc_type_ir/src/relate.rs — 5
  •  compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Apr 15, 2026
@rustbot
rustbot
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
WaffleLapkin is not on the review rotation at the moment.

They may take a while to respond.
WaffleLapkin
WaffleLapkin
approved these changes
Apr 15, 2026
View reviewed changes
@WaffleLapkinWaffleLapkin
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd refactor all of the other cases as well, but this is a small improvement so looks good to me :)
View changes since this review
@WaffleLapkin
WaffleLapkin
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
r=me with green CI
@bors delegate
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
✌️ @WilliamTakeshi, you can now approve this pull request!
If @WaffleLapkin told you to "r=me" after making some further change, then please make that change and post @bors r=WaffleLapkin.
@Kivooeo
Kivooeo
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
@bors r=WaffleLapkin rollup
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit dbb83b6 has been approved by WaffleLapkin
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 15, 2026
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
@jhpratt
Rollup merge ofrust-lang#155356- WilliamTakeshi:remove_calls_to_def…
8dfe975
…_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref rust-lang#154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155373- jhpratt:rollup-qjxAt4R, r=jhpratt
63faf88
Rollup of 18 pull requests
Successful merges:
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155380- jhpratt:rollup-j1e7DVL, r=jhpratt
7af3402
Rollup of 18 pull requests
Successful merges:
- #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@rust-bors
rust-borsBot
merged commit 94d946e
into
rust-lang:mainApr 16, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 16, 2026
rust-timer added a commit
that referenced
this pull request
Apr 16, 2026
@rust-timer
Unrolled build for#155356
1b26279
Rollup merge of #155356 - WilliamTakeshi:remove_calls_to_def_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref #154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@WilliamTakeshi
WilliamTakeshi
deleted the

remove_calls_to_def_id

branch
April 17, 2026 11:01
zihan0822 pushed a commit
to zihan0822/rust-clippy
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
8bc1aa3
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
a502b0f
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@WaffleLapkinWaffleLapkinWaffleLapkin approved these changes

Assignees

@WaffleLapkinWaffleLapkin

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@WilliamTakeshi@rustbot@WaffleLapkin@Kivooeo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
remove calls to AliasTyKind::def_id - #155356
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Apr 16, 2026
Merged
remove calls to AliasTyKind::def_id#155356
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Conversation
@WilliamTakeshi
@WilliamTakeshiWilliamTakeshi
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
ref #154941
I asked the LSP where AliasTyKind::def_id and then checked where the AliasTyKind::def_id was trivial to change. Could only find 2 places, and I am not sure about the opaque_types.rs (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as AliasTyKind::def_id
This is the list checked:
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
  •  compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
  •  compiler/rustc_hir_analysis/src/check/mod.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
  •  compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/verify.rs — 3
  •  compiler/rustc_middle/src/ty/print/pretty.rs — 1
  •  compiler/rustc_middle/src/ty/sty.rs — 1
  •  compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
  •  compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
  •  compiler/rustc_pattern_analysis/src/rustc.rs — 1
  •  compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
  •  compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
  •  compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
  •  compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
  •  compiler/rustc_trait_selection/src/traits/effects.rs — 1
  •  compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
  •  compiler/rustc_ty_utils/src/opaque_types.rs — 7
  •  compiler/rustc_ty_utils/src/ty.rs — 1
  •  compiler/rustc_type_ir/src/outlives.rs — 1
  •  compiler/rustc_type_ir/src/predicate.rs — 1
  •  compiler/rustc_type_ir/src/relate.rs — 5
  •  compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Apr 15, 2026
@rustbot
rustbot
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
WaffleLapkin is not on the review rotation at the moment.

They may take a while to respond.
WaffleLapkin
WaffleLapkin
approved these changes
Apr 15, 2026
View reviewed changes
@WaffleLapkinWaffleLapkin
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd refactor all of the other cases as well, but this is a small improvement so looks good to me :)
View changes since this review
@WaffleLapkin
WaffleLapkin
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
r=me with green CI
@bors delegate
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
✌️ @WilliamTakeshi, you can now approve this pull request!
If @WaffleLapkin told you to "r=me" after making some further change, then please make that change and post @bors r=WaffleLapkin.
@Kivooeo
Kivooeo
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
@bors r=WaffleLapkin rollup
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit dbb83b6 has been approved by WaffleLapkin
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 15, 2026
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
@jhpratt
Rollup merge ofrust-lang#155356- WilliamTakeshi:remove_calls_to_def…
8dfe975
…_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref rust-lang#154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155373- jhpratt:rollup-qjxAt4R, r=jhpratt
63faf88
Rollup of 18 pull requests
Successful merges:
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155380- jhpratt:rollup-j1e7DVL, r=jhpratt
7af3402
Rollup of 18 pull requests
Successful merges:
- #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@rust-bors
rust-borsBot
merged commit 94d946e
into
rust-lang:mainApr 16, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 16, 2026
rust-timer added a commit
that referenced
this pull request
Apr 16, 2026
@rust-timer
Unrolled build for#155356
1b26279
Rollup merge of #155356 - WilliamTakeshi:remove_calls_to_def_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref #154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@WilliamTakeshi
WilliamTakeshi
deleted the

remove_calls_to_def_id

branch
April 17, 2026 11:01
zihan0822 pushed a commit
to zihan0822/rust-clippy
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
8bc1aa3
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
a502b0f
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@WaffleLapkinWaffleLapkinWaffleLapkin approved these changes

Assignees

@WaffleLapkinWaffleLapkin

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@WilliamTakeshi@rustbot@WaffleLapkin@Kivooeo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
remove calls to AliasTyKind::def_id - #155356
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Apr 16, 2026
Merged
remove calls to AliasTyKind::def_id#155356
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Conversation
@WilliamTakeshi
@WilliamTakeshiWilliamTakeshi
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
ref #154941
I asked the LSP where AliasTyKind::def_id and then checked where the AliasTyKind::def_id was trivial to change. Could only find 2 places, and I am not sure about the opaque_types.rs (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as AliasTyKind::def_id
This is the list checked:
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
  •  compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
  •  compiler/rustc_hir_analysis/src/check/mod.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
  •  compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/verify.rs — 3
  •  compiler/rustc_middle/src/ty/print/pretty.rs — 1
  •  compiler/rustc_middle/src/ty/sty.rs — 1
  •  compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
  •  compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
  •  compiler/rustc_pattern_analysis/src/rustc.rs — 1
  •  compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
  •  compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
  •  compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
  •  compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
  •  compiler/rustc_trait_selection/src/traits/effects.rs — 1
  •  compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
  •  compiler/rustc_ty_utils/src/opaque_types.rs — 7
  •  compiler/rustc_ty_utils/src/ty.rs — 1
  •  compiler/rustc_type_ir/src/outlives.rs — 1
  •  compiler/rustc_type_ir/src/predicate.rs — 1
  •  compiler/rustc_type_ir/src/relate.rs — 5
  •  compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Apr 15, 2026
@rustbot
rustbot
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
WaffleLapkin is not on the review rotation at the moment.

They may take a while to respond.
WaffleLapkin
WaffleLapkin
approved these changes
Apr 15, 2026
View reviewed changes
@WaffleLapkinWaffleLapkin
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd refactor all of the other cases as well, but this is a small improvement so looks good to me :)
View changes since this review
@WaffleLapkin
WaffleLapkin
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
r=me with green CI
@bors delegate
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
✌️ @WilliamTakeshi, you can now approve this pull request!
If @WaffleLapkin told you to "r=me" after making some further change, then please make that change and post @bors r=WaffleLapkin.
@Kivooeo
Kivooeo
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
@bors r=WaffleLapkin rollup
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit dbb83b6 has been approved by WaffleLapkin
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 15, 2026
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
@jhpratt
Rollup merge ofrust-lang#155356- WilliamTakeshi:remove_calls_to_def…
8dfe975
…_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref rust-lang#154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155373- jhpratt:rollup-qjxAt4R, r=jhpratt
63faf88
Rollup of 18 pull requests
Successful merges:
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155380- jhpratt:rollup-j1e7DVL, r=jhpratt
7af3402
Rollup of 18 pull requests
Successful merges:
- #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@rust-bors
rust-borsBot
merged commit 94d946e
into
rust-lang:mainApr 16, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 16, 2026
rust-timer added a commit
that referenced
this pull request
Apr 16, 2026
@rust-timer
Unrolled build for#155356
1b26279
Rollup merge of #155356 - WilliamTakeshi:remove_calls_to_def_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref #154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@WilliamTakeshi
WilliamTakeshi
deleted the

remove_calls_to_def_id

branch
April 17, 2026 11:01
zihan0822 pushed a commit
to zihan0822/rust-clippy
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
8bc1aa3
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
a502b0f
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@WaffleLapkinWaffleLapkinWaffleLapkin approved these changes

Assignees

@WaffleLapkinWaffleLapkin

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@WilliamTakeshi@rustbot@WaffleLapkin@Kivooeo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
remove calls to AliasTyKind::def_id - #155356
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Apr 16, 2026
Merged
remove calls to AliasTyKind::def_id#155356
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
WilliamTakeshi:remove_calls_to_def_id
Conversation
@WilliamTakeshi
@WilliamTakeshiWilliamTakeshi
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
ref #154941
I asked the LSP where AliasTyKind::def_id and then checked where the AliasTyKind::def_id was trivial to change. Could only find 2 places, and I am not sure about the opaque_types.rs (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as AliasTyKind::def_id
This is the list checked:
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
  •  compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
  •  compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
  •  compiler/rustc_hir_analysis/src/check/mod.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
  •  compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
  •  compiler/rustc_infer/src/infer/outlives/verify.rs — 3
  •  compiler/rustc_middle/src/ty/print/pretty.rs — 1
  •  compiler/rustc_middle/src/ty/sty.rs — 1
  •  compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
  •  compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
  •  compiler/rustc_pattern_analysis/src/rustc.rs — 1
  •  compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
  •  compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
  •  compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
  •  compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
  •  compiler/rustc_trait_selection/src/traits/effects.rs — 1
  •  compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
  •  compiler/rustc_ty_utils/src/opaque_types.rs — 7
  •  compiler/rustc_ty_utils/src/ty.rs — 1
  •  compiler/rustc_type_ir/src/outlives.rs — 1
  •  compiler/rustc_type_ir/src/predicate.rs — 1
  •  compiler/rustc_type_ir/src/relate.rs — 5
  •  compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Apr 15, 2026
@rustbot
rustbot
commented
Apr 15, 2026

Copy link


Copy Markdown

Collaborator
WaffleLapkin is not on the review rotation at the moment.

They may take a while to respond.
WaffleLapkin
WaffleLapkin
approved these changes
Apr 15, 2026
View reviewed changes
@WaffleLapkinWaffleLapkin
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd refactor all of the other cases as well, but this is a small improvement so looks good to me :)
View changes since this review
@WaffleLapkin
WaffleLapkin
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
r=me with green CI
@bors delegate
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
✌️ @WilliamTakeshi, you can now approve this pull request!
If @WaffleLapkin told you to "r=me" after making some further change, then please make that change and post @bors r=WaffleLapkin.
@Kivooeo
Kivooeo
commented
Apr 15, 2026

Copy link


Copy Markdown

Member
@bors r=WaffleLapkin rollup
@rust-bors
rust-borsBot
commented
Apr 15, 2026

Copy link


Copy Markdown

Contributor
📌 Commit dbb83b6 has been approved by WaffleLapkin
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 15, 2026
jhpratt added a commit
to jhpratt/rust
that referenced
this pull request
Apr 16, 2026
@jhpratt
Rollup merge ofrust-lang#155356- WilliamTakeshi:remove_calls_to_def…
8dfe975
…_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref rust-lang#154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Closed

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155373- jhpratt:rollup-qjxAt4R, r=jhpratt
63faf88
Rollup of 18 pull requests
Successful merges:
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@jhprattjhpratt
mentioned this pull request
Apr 16, 2026
 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
@bors
Auto merge of#155380- jhpratt:rollup-j1e7DVL, r=jhpratt
7af3402
Rollup of 18 pull requests
Successful merges:
- #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- #154595 (Emit fatal on invalid const args with nested defs)
- #154599 (report the `varargs_without_pattern` lint in deps)
- #154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- #155357 (Add `--remap-path-scope` as unstable in rustdoc)
- #150649 (clippy fix: non_canonical_clone_impl)
- #154604 (abort in core)
- #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- #155266 (Adjust release notes for post-merge feedback)
- #155326 (Disallow ZST allocations with `TypedArena`.)
- #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- #155340 (Handle nonnull pattern types in size skeleton)
- #155347 (Add push_mut and new Layout methods to release notes)
- #155356 (remove calls to AliasTyKind::def_id)
- #155364 (Reduce diagnostic type visibilities.)
@rust-bors
rust-borsBot
merged commit 94d946e
into
rust-lang:mainApr 16, 2026

11 checks passed

@rustbotrustbot
added this to the 1.97.0 milestone
Apr 16, 2026
rust-timer added a commit
that referenced
this pull request
Apr 16, 2026
@rust-timer
Unrolled build for#155356
1b26279
Rollup merge of #155356 - WilliamTakeshi:remove_calls_to_def_id, r=WaffleLapkin
remove calls to AliasTyKind::def_id
ref #154941
I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id`
This is the list checked:
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1
- [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1
- [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5
- [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2
- [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1
- [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3
- [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1
- [X] compiler/rustc_middle/src/ty/sty.rs — 1
- [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3
- [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3
- [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1
- [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2
- [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4
- [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2
- [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1
- [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1
- [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7
- [X] compiler/rustc_ty_utils/src/ty.rs — 1
- [X] compiler/rustc_type_ir/src/outlives.rs — 1
- [X] compiler/rustc_type_ir/src/predicate.rs — 1
- [X] compiler/rustc_type_ir/src/relate.rs — 5
- [X] compiler/rustc_type_ir/src/ty_kind.rs — 2
r? @WaffleLapkin
@WilliamTakeshi
WilliamTakeshi
deleted the

remove_calls_to_def_id

branch
April 17, 2026 11:01
zihan0822 pushed a commit
to zihan0822/rust-clippy
that referenced
this pull request
Apr 30, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
8bc1aa3
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #155380 - jhpratt:rollup-j1e7DVL, r=jhpratt
a502b0f
Rollup of 18 pull requests
Successful merges:
- rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait)
- rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs)
- rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps)
- rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`)
- rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field)
- rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc)
- rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl)
- rust-lang/rust#154604 (abort in core)
- rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output)
- rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting)
- rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions)
- rust-lang/rust#155266 (Adjust release notes for post-merge feedback)
- rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.)
- rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests)
- rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton)
- rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes)
- rust-lang/rust#155356 (remove calls to AliasTyKind::def_id)
- rust-lang/rust#155364 (Reduce diagnostic type visibilities.)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@WaffleLapkinWaffleLapkinWaffleLapkin approved these changes

Assignees

@WaffleLapkinWaffleLapkin

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@WilliamTakeshi@rustbot@WaffleLapkin@Kivooeo