Uh oh!
There was an error while loading. Please reload this page.
Rollup of 18 pull requests - #155373
Closed
jhpratt wants to merge 56 commits into
Closed
Conversation
Shaves off 368 bytes from the total size of all Unicode data tables.
When a type alias is locally re-exported from a private module (an implicit inline), rustdoc drops its `cfg` attributes because it treats it like a standard un-inlined re-export. Since type aliases have no inner fields to carry the `cfg` badge (unlike structs or enums), the portability info is lost entirely. This patch explicitly preserves the target's `cfg` metadata when the generated item is a `TypeAliasItem`, ensuring the portability badge renders correctly without breaking standard cross-crate re-export behavior.
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.
This allows warnings to be annotated, and verifies that no unexpected warnings occur.
* Adds musl CVE fix to compiler section * Removes Cargo section per feedback in the PR
`DroplessArena::alloc` already disallows ZST allocation. `TypedArena::alloc` allows it but: - (a) it's never used, and - (b) writing to `NonNull::dangling()` seems dubious, even if the write is zero-sized. This commit just changes it to panic on a ZST. This eliminates an untested code path, and we shouldn't be allocating ZSTs anyway. It also eliminates an unused ZST code path in `clear_last_chunk`. Tests are also updated accordingly.
Co-authored-by: Josh Stone <cuviper@gmail.com>
This adds a `--quiet` flag to x.py and bootstrap to suppress some of the output when compiling Rust. It conflicts with `--verbose`, matching the behavior of `cargo` which does not allow `--verbose` and `--quiet`. It works by passing quiet flags down to the underlying cargo, or LLVM build processes. Note that for LLVM, we only can suppress logs when we explicitly configure it with ninja. Otherwise we won't know what flag to pass along to whichever build system cmake decides to use. This can be helpful with AI workloads in the Rust codebase to help shrink down the output to reduce token usage, which can help prevent context pollution and lower costs. This patch was partially generated with Gemini, but I've reviewed the changes it made.
…_id, r=WaffleLapkin remove calls to AliasTyKind::def_id ref rust-lang#154941 I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id` This is the list checked: - [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1 - [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1 - [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5 - [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1 - [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2 - [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1 - [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3 - [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1 - [X] compiler/rustc_middle/src/ty/sty.rs — 1 - [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3 - [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3 - [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1 - [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1 - [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2 - [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4 - [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2 - [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1 - [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1 - [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7 - [X] compiler/rustc_ty_utils/src/ty.rs — 1 - [X] compiler/rustc_type_ir/src/outlives.rs — 1 - [X] compiler/rustc_type_ir/src/predicate.rs — 1 - [X] compiler/rustc_type_ir/src/relate.rs — 5 - [X] compiler/rustc_type_ir/src/ty_kind.rs — 2 r? @WaffleLapkin
…bilities, r=Kivooeo Reduce diagnostic type visibilities. Most diagnostic types are only used within their own crate, and so have a `pub(crate)` visibility. We have some diagnostic types that are unnecessarily `pub`. This is bad because (a) information hiding, and (b) if a `pub(crate)` type becomes unused the compiler will warn but it won't warn for a `pub` type. This commit eliminates unnecessary `pub` visibilities for some diagnostic types, and also some related things due to knock-on effects. (I found these types with some ad hoc use of `grep`.) r? @Kivooeo
jhpratt
commented
Apr 16, 2026
MemberAuthor
@bors r+ rollup=never p=5 |
Contributor
This comment has been minimized.
This comment has been minimized.
rust-borsBot
pushed a commit
that referenced
this pull request
Apr 16, 2026
Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)
rust-log-analyzer
commented
Apr 16, 2026
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
💔 Test for 63faf88 failed: CI. Failed job:
|
Contributor
PR #154970, which is a member of this rollup, was unapproved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
varargs_without_patternlint in deps #154599 (report thevarargs_without_patternlint in deps)core::unicode: ReplaceCasedtable withLt#154699 (core::unicode: ReplaceCasedtable withLt)inaccessible_ctor_reexportresolver field #155353 (resolve: Removeinaccessible_ctor_reexportresolver field)--remap-path-scopeas unstable in rustdoc #155357 (Add--remap-path-scopeas unstable in rustdoc)--quietflag to x.py and bootstrap to suppress output #154616 (Add--quietflag to x.py and bootstrap to suppress output)doc(cfg)on locally re-exported type aliases #154970 (rustdoc: preservedoc(cfg)on locally re-exported type aliases)AttributeLintKindand refactor diagnostic attribute linting #155215 (Clean upAttributeLintKindand refactor diagnostic attribute linting)cpassandrpassrevisions #155228 (Check diagnostic output in incrementalcpassandrpassrevisions)TypedArena. #155326 (Disallow ZST allocations withTypedArena.)0b1instead ofNonZero::MINinNonZero::bit_widthdoctests #155334 (docs: Use0b1instead ofNonZero::MINinNonZero::bit_widthdoctests)r? @ghost
Create a similar rollup