resolve: Remove `inaccessible_ctor_reexport` resolver field by petrochenkov · Pull Request #155353 · rust-lang/rust

petrochenkov · 2026-04-15T19:00:29Z

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra.

Also cleanup the related diagnostic code for struct constructors in general, see the individual commits.

This mitigates most of the harm brought by #133477.

Use imports instead

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot · 2026-04-15T19:00:35Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 16 candidates

petrochenkov · 2026-04-15T19:01:51Z

Let's try it
r? @mu001999

rustbot · 2026-04-15T19:01:54Z

Failed to set assignee to mu001999: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

petrochenkov · 2026-04-15T19:02:48Z

Ah, not yet, rust-lang/team#2417 is probably not deployed yet.

mu001999 · 2026-04-15T23:46:30Z

r? me

mu001999 · 2026-04-16T01:00:26Z

LGTM!

Just have a question about the interaction with inherent assoc types.
But I believe this does not block the current change.

So @bors r+

rust-bors · 2026-04-16T01:00:29Z

📌 Commit 19c7df6 has been approved by mu001999

It is now in the queue for this repository.

resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155353 - petrochenkov:globdedup, r=mu001999 resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by #133477.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

petrochenkov · 2026-04-15T19:00:29Z

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra.

Also cleanup the related diagnostic code for struct constructors in general, see the individual commits.

This mitigates most of the harm brought by #133477.

Use imports instead

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot · 2026-04-15T19:00:35Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 16 candidates

petrochenkov · 2026-04-15T19:01:51Z

Let's try it
r? @mu001999

rustbot · 2026-04-15T19:01:54Z

Failed to set assignee to mu001999: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

petrochenkov · 2026-04-15T19:02:48Z

Ah, not yet, rust-lang/team#2417 is probably not deployed yet.

mu001999 · 2026-04-15T23:46:30Z

r? me

mu001999 · 2026-04-16T01:00:26Z

LGTM!

Just have a question about the interaction with inherent assoc types.
But I believe this does not block the current change.

So @bors r+

rust-bors · 2026-04-16T01:00:29Z

📌 Commit 19c7df6 has been approved by mu001999

It is now in the queue for this repository.

resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155353 - petrochenkov:globdedup, r=mu001999 resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by #133477.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

petrochenkov · 2026-04-15T19:00:29Z

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra.

Also cleanup the related diagnostic code for struct constructors in general, see the individual commits.

This mitigates most of the harm brought by #133477.

Use imports instead

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot · 2026-04-15T19:00:35Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 16 candidates

petrochenkov · 2026-04-15T19:01:51Z

Let's try it
r? @mu001999

rustbot · 2026-04-15T19:01:54Z

Failed to set assignee to mu001999: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

petrochenkov · 2026-04-15T19:02:48Z

Ah, not yet, rust-lang/team#2417 is probably not deployed yet.

mu001999 · 2026-04-15T23:46:30Z

r? me

mu001999 · 2026-04-16T01:00:26Z

LGTM!

Just have a question about the interaction with inherent assoc types.
But I believe this does not block the current change.

So @bors r+

rust-bors · 2026-04-16T01:00:29Z

📌 Commit 19c7df6 has been approved by mu001999

It is now in the queue for this repository.

resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155353 - petrochenkov:globdedup, r=mu001999 resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by #133477.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

petrochenkov · 2026-04-15T19:00:29Z

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra.

Also cleanup the related diagnostic code for struct constructors in general, see the individual commits.

This mitigates most of the harm brought by #133477.

Use imports instead

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot · 2026-04-15T19:00:35Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 16 candidates

petrochenkov · 2026-04-15T19:01:51Z

Let's try it
r? @mu001999

rustbot · 2026-04-15T19:01:54Z

Failed to set assignee to mu001999: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

petrochenkov · 2026-04-15T19:02:48Z

Ah, not yet, rust-lang/team#2417 is probably not deployed yet.

mu001999 · 2026-04-15T23:46:30Z

r? me

mu001999 · 2026-04-16T01:00:26Z

LGTM!

Just have a question about the interaction with inherent assoc types.
But I believe this does not block the current change.

So @bors r+

rust-bors · 2026-04-16T01:00:29Z

📌 Commit 19c7df6 has been approved by mu001999

It is now in the queue for this repository.

resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155353 - petrochenkov:globdedup, r=mu001999 resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by #133477.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

petrochenkov · 2026-04-15T19:00:29Z

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra.

Also cleanup the related diagnostic code for struct constructors in general, see the individual commits.

This mitigates most of the harm brought by #133477.

Use imports instead

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot · 2026-04-15T19:00:35Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 16 candidates

petrochenkov · 2026-04-15T19:01:51Z

Let's try it
r? @mu001999

rustbot · 2026-04-15T19:01:54Z

Failed to set assignee to mu001999: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

petrochenkov · 2026-04-15T19:02:48Z

Ah, not yet, rust-lang/team#2417 is probably not deployed yet.

mu001999 · 2026-04-15T23:46:30Z

r? me

mu001999 · 2026-04-16T01:00:26Z

LGTM!

Just have a question about the interaction with inherent assoc types.
But I believe this does not block the current change.

So @bors r+

rust-bors · 2026-04-16T01:00:29Z

📌 Commit 19c7df6 has been approved by mu001999

It is now in the queue for this repository.

resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155353 - petrochenkov:globdedup, r=mu001999 resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by #133477.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

petrochenkov · 2026-04-15T19:00:29Z

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra.

Also cleanup the related diagnostic code for struct constructors in general, see the individual commits.

This mitigates most of the harm brought by #133477.

Use imports instead

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot · 2026-04-15T19:00:35Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 16 candidates

petrochenkov · 2026-04-15T19:01:51Z

Let's try it
r? @mu001999

rustbot · 2026-04-15T19:01:54Z

Failed to set assignee to mu001999: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

petrochenkov · 2026-04-15T19:02:48Z

Ah, not yet, rust-lang/team#2417 is probably not deployed yet.

mu001999 · 2026-04-15T23:46:30Z

r? me

mu001999 · 2026-04-16T01:00:26Z

LGTM!

Just have a question about the interaction with inherent assoc types.
But I believe this does not block the current change.

So @bors r+

rust-bors · 2026-04-16T01:00:29Z

📌 Commit 19c7df6 has been approved by mu001999

It is now in the queue for this repository.

resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155353 - petrochenkov:globdedup, r=mu001999 resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by #133477.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

petrochenkov · 2026-04-15T19:00:29Z

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra.

Also cleanup the related diagnostic code for struct constructors in general, see the individual commits.

This mitigates most of the harm brought by #133477.

Use imports instead

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot · 2026-04-15T19:00:35Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 16 candidates

petrochenkov · 2026-04-15T19:01:51Z

Let's try it
r? @mu001999

rustbot · 2026-04-15T19:01:54Z

Failed to set assignee to mu001999: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

petrochenkov · 2026-04-15T19:02:48Z

Ah, not yet, rust-lang/team#2417 is probably not deployed yet.

mu001999 · 2026-04-15T23:46:30Z

r? me

mu001999 · 2026-04-16T01:00:26Z

LGTM!

Just have a question about the interaction with inherent assoc types.
But I believe this does not block the current change.

So @bors r+

rust-bors · 2026-04-16T01:00:29Z

📌 Commit 19c7df6 has been approved by mu001999

It is now in the queue for this repository.

resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155353 - petrochenkov:globdedup, r=mu001999 resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by #133477.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

petrochenkov · 2026-04-15T19:00:29Z

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra.

Also cleanup the related diagnostic code for struct constructors in general, see the individual commits.

This mitigates most of the harm brought by #133477.

Use imports instead

Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot · 2026-04-15T19:00:35Z

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 16 candidates

petrochenkov · 2026-04-15T19:01:51Z

Let's try it
r? @mu001999

rustbot · 2026-04-15T19:01:54Z

Failed to set assignee to mu001999: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

petrochenkov · 2026-04-15T19:02:48Z

Ah, not yet, rust-lang/team#2417 is probably not deployed yet.

mu001999 · 2026-04-15T23:46:30Z

r? me

mu001999 · 2026-04-16T01:00:26Z

LGTM!

Just have a question about the interaction with inherent assoc types.
But I believe this does not block the current change.

So @bors r+

rust-bors · 2026-04-16T01:00:29Z

📌 Commit 19c7df6 has been approved by mu001999

It is now in the queue for this repository.

resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by rust-lang#133477.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155353 - petrochenkov:globdedup, r=mu001999 resolve: Remove `inaccessible_ctor_reexport` resolver field Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra. Also cleanup the related diagnostic code for struct constructors in general, see the individual commits. This mitigates most of the harm brought by #133477.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

petrochenkov added 3 commits April 15, 2026 21:49

resolve: Cleanup diagnostic code for struct constructors
3238112

resolve: Remove type Res aliases except the one in the crate root
9c2e424
Use imports instead

resolve: Remove inaccessible_ctor_reexport resolver field
19c7df6
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot assigned jackh726 Apr 15, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026

rustbot assigned mu001999 and unassigned jackh726 Apr 15, 2026

mu001999 reviewed Apr 16, 2026
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 700f2a7 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

petrochenkov deleted the globdedup branch June 17, 2026 14:56

petrochenkov added 3 commits April 15, 2026 21:49

resolve: Cleanup diagnostic code for struct constructors
3238112

resolve: Remove type Res aliases except the one in the crate root
9c2e424
Use imports instead

resolve: Remove inaccessible_ctor_reexport resolver field
19c7df6
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot assigned jackh726 Apr 15, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026

rustbot assigned mu001999 and unassigned jackh726 Apr 15, 2026

mu001999 reviewed Apr 16, 2026
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 700f2a7 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

petrochenkov deleted the globdedup branch June 17, 2026 14:56

petrochenkov added 3 commits April 15, 2026 21:49

resolve: Cleanup diagnostic code for struct constructors
3238112

resolve: Remove type Res aliases except the one in the crate root
9c2e424
Use imports instead

resolve: Remove inaccessible_ctor_reexport resolver field
19c7df6
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot assigned jackh726 Apr 15, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026

rustbot assigned mu001999 and unassigned jackh726 Apr 15, 2026

mu001999 reviewed Apr 16, 2026
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 700f2a7 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

petrochenkov deleted the globdedup branch June 17, 2026 14:56

petrochenkov added 3 commits April 15, 2026 21:49

resolve: Cleanup diagnostic code for struct constructors
3238112

resolve: Remove type Res aliases except the one in the crate root
9c2e424
Use imports instead

resolve: Remove inaccessible_ctor_reexport resolver field
19c7df6
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot assigned jackh726 Apr 15, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026

rustbot assigned mu001999 and unassigned jackh726 Apr 15, 2026

mu001999 reviewed Apr 16, 2026
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 700f2a7 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

petrochenkov deleted the globdedup branch June 17, 2026 14:56

petrochenkov added 3 commits April 15, 2026 21:49

resolve: Cleanup diagnostic code for struct constructors
3238112

resolve: Remove type Res aliases except the one in the crate root
9c2e424
Use imports instead

resolve: Remove inaccessible_ctor_reexport resolver field
19c7df6
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot assigned jackh726 Apr 15, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026

rustbot assigned mu001999 and unassigned jackh726 Apr 15, 2026

mu001999 reviewed Apr 16, 2026
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 700f2a7 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

petrochenkov deleted the globdedup branch June 17, 2026 14:56

petrochenkov added 3 commits April 15, 2026 21:49

resolve: Cleanup diagnostic code for struct constructors
3238112

resolve: Remove type Res aliases except the one in the crate root
9c2e424
Use imports instead

resolve: Remove inaccessible_ctor_reexport resolver field
19c7df6
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot assigned jackh726 Apr 15, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026

rustbot assigned mu001999 and unassigned jackh726 Apr 15, 2026

mu001999 reviewed Apr 16, 2026
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 700f2a7 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

petrochenkov deleted the globdedup branch June 17, 2026 14:56

petrochenkov added 3 commits April 15, 2026 21:49

resolve: Cleanup diagnostic code for struct constructors
3238112

resolve: Remove type Res aliases except the one in the crate root
9c2e424
Use imports instead

resolve: Remove inaccessible_ctor_reexport resolver field
19c7df6
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot assigned jackh726 Apr 15, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026

rustbot assigned mu001999 and unassigned jackh726 Apr 15, 2026

mu001999 reviewed Apr 16, 2026
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 700f2a7 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

petrochenkov deleted the globdedup branch June 17, 2026 14:56

petrochenkov added 3 commits April 15, 2026 21:49

resolve: Cleanup diagnostic code for struct constructors
3238112

resolve: Remove type Res aliases except the one in the crate root
9c2e424
Use imports instead

resolve: Remove inaccessible_ctor_reexport resolver field
19c7df6
Collect the necessary information during error reporting instead of doing it on a good path from the core name resolution infra

rustbot assigned jackh726 Apr 15, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2026

rustbot assigned mu001999 and unassigned jackh726 Apr 15, 2026

mu001999 reviewed Apr 16, 2026
View reviewed changes

Comment threadcompiler/rustc_resolve/src/late/diagnostics.rs

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 700f2a7 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

petrochenkov deleted the globdedup branch June 17, 2026 14:56

Uh oh!

Uh oh!

Conversation

petrochenkov commented Apr 15, 2026

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

petrochenkov commented Apr 15, 2026

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

petrochenkov commented Apr 15, 2026

Uh oh!

mu001999 commented Apr 15, 2026

Uh oh!

Uh oh!

mu001999 commented Apr 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-borsBot commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

petrochenkov commented Apr 15, 2026

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

petrochenkov commented Apr 15, 2026

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

petrochenkov commented Apr 15, 2026

Uh oh!

mu001999 commented Apr 15, 2026

Uh oh!

Uh oh!

mu001999 commented Apr 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-borsBot commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

petrochenkov commented Apr 15, 2026

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

petrochenkov commented Apr 15, 2026

Uh oh!

rustbot commented Apr 15, 2026

Uh oh!

petrochenkov commented Apr 15, 2026

Uh oh!

mu001999 commented Apr 15, 2026

Uh oh!

Uh oh!

mu001999 commented Apr 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-borsBot commented Apr 16, 2026

mu001999 commented Apr 16, 2026•
edited
Loading

mu001999 commented Apr 16, 2026•
edited
Loading

mu001999 commented Apr 16, 2026•
edited
Loading

mu001999 commented Apr 16, 2026•
edited
Loading