Check diagnostic output in incremental `cpass` and `rpass` revisions by Zalathar · Pull Request #155228 · rust-lang/rust

Zalathar · 2026-04-13T07:45:08Z

This allows compiler warnings to be annotated in cpass and rpass revisions, and verifies that no unexpected warnings occur.

My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of cfail revisions with //@ build-pass directives, and replace them with a more straightforward cpass revision that also checks diagnostic output. That migration is not part of this PR.

rustbot · 2026-04-13T07:45:11Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-04-13T07:45:14Z

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu · 2026-04-13T07:48:49Z

r? me

Zalathar · 2026-04-13T09:42:47Z

Ugh, a Linux-only test emitting warnings.

~~I might just slap a //@ dont-require-annotations: WARN on it, and leave a FIXME for someone to potentially investigate later.~~

EDIT: The warnings appear to be GCC-only, so I applied an //@ ignore-backends: gcc instead, as there are already several of those in the incremental suite.

Zalathar · 2026-04-13T10:20:48Z

@bors try jobs=x86_64-gnu

Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

rust-bors · 2026-04-13T12:42:37Z

☀️ Try build successful (CI)
Build commit: e7053b8 (e7053b858097a5db7be019c4aa896b1f68a24843, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

jieyouxu

Thanks
r? me @bors r+ rollup

View changes since this review

rust-bors · 2026-04-16T01:44:50Z

📌 Commit 316fcbd has been approved by jieyouxu

It is now in the queue for this repository.

Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155228 - Zalathar:incr-test-diag, r=jieyouxu Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

Zalathar · 2026-04-13T07:45:08Z

This allows compiler warnings to be annotated in cpass and rpass revisions, and verifies that no unexpected warnings occur.

My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of cfail revisions with //@ build-pass directives, and replace them with a more straightforward cpass revision that also checks diagnostic output. That migration is not part of this PR.

rustbot · 2026-04-13T07:45:11Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-04-13T07:45:14Z

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu · 2026-04-13T07:48:49Z

r? me

Zalathar · 2026-04-13T09:42:47Z

Ugh, a Linux-only test emitting warnings.

~~I might just slap a //@ dont-require-annotations: WARN on it, and leave a FIXME for someone to potentially investigate later.~~

EDIT: The warnings appear to be GCC-only, so I applied an //@ ignore-backends: gcc instead, as there are already several of those in the incremental suite.

Zalathar · 2026-04-13T10:20:48Z

@bors try jobs=x86_64-gnu

Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

rust-bors · 2026-04-13T12:42:37Z

☀️ Try build successful (CI)
Build commit: e7053b8 (e7053b858097a5db7be019c4aa896b1f68a24843, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

jieyouxu

Thanks
r? me @bors r+ rollup

View changes since this review

rust-bors · 2026-04-16T01:44:50Z

📌 Commit 316fcbd has been approved by jieyouxu

It is now in the queue for this repository.

Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155228 - Zalathar:incr-test-diag, r=jieyouxu Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

Zalathar · 2026-04-13T07:45:08Z

This allows compiler warnings to be annotated in cpass and rpass revisions, and verifies that no unexpected warnings occur.

My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of cfail revisions with //@ build-pass directives, and replace them with a more straightforward cpass revision that also checks diagnostic output. That migration is not part of this PR.

rustbot · 2026-04-13T07:45:11Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-04-13T07:45:14Z

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu · 2026-04-13T07:48:49Z

r? me

Zalathar · 2026-04-13T09:42:47Z

Ugh, a Linux-only test emitting warnings.

~~I might just slap a //@ dont-require-annotations: WARN on it, and leave a FIXME for someone to potentially investigate later.~~

EDIT: The warnings appear to be GCC-only, so I applied an //@ ignore-backends: gcc instead, as there are already several of those in the incremental suite.

Zalathar · 2026-04-13T10:20:48Z

@bors try jobs=x86_64-gnu

Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

rust-bors · 2026-04-13T12:42:37Z

☀️ Try build successful (CI)
Build commit: e7053b8 (e7053b858097a5db7be019c4aa896b1f68a24843, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

jieyouxu

Thanks
r? me @bors r+ rollup

View changes since this review

rust-bors · 2026-04-16T01:44:50Z

📌 Commit 316fcbd has been approved by jieyouxu

It is now in the queue for this repository.

Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155228 - Zalathar:incr-test-diag, r=jieyouxu Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

Zalathar · 2026-04-13T07:45:08Z

This allows compiler warnings to be annotated in cpass and rpass revisions, and verifies that no unexpected warnings occur.

My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of cfail revisions with //@ build-pass directives, and replace them with a more straightforward cpass revision that also checks diagnostic output. That migration is not part of this PR.

rustbot · 2026-04-13T07:45:11Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-04-13T07:45:14Z

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu · 2026-04-13T07:48:49Z

r? me

Zalathar · 2026-04-13T09:42:47Z

Ugh, a Linux-only test emitting warnings.

~~I might just slap a //@ dont-require-annotations: WARN on it, and leave a FIXME for someone to potentially investigate later.~~

EDIT: The warnings appear to be GCC-only, so I applied an //@ ignore-backends: gcc instead, as there are already several of those in the incremental suite.

Zalathar · 2026-04-13T10:20:48Z

@bors try jobs=x86_64-gnu

Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

rust-bors · 2026-04-13T12:42:37Z

☀️ Try build successful (CI)
Build commit: e7053b8 (e7053b858097a5db7be019c4aa896b1f68a24843, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

jieyouxu

Thanks
r? me @bors r+ rollup

View changes since this review

rust-bors · 2026-04-16T01:44:50Z

📌 Commit 316fcbd has been approved by jieyouxu

It is now in the queue for this repository.

Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155228 - Zalathar:incr-test-diag, r=jieyouxu Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

Zalathar · 2026-04-13T07:45:08Z

This allows compiler warnings to be annotated in cpass and rpass revisions, and verifies that no unexpected warnings occur.

My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of cfail revisions with //@ build-pass directives, and replace them with a more straightforward cpass revision that also checks diagnostic output. That migration is not part of this PR.

rustbot · 2026-04-13T07:45:11Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-04-13T07:45:14Z

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu · 2026-04-13T07:48:49Z

r? me

Zalathar · 2026-04-13T09:42:47Z

Ugh, a Linux-only test emitting warnings.

~~I might just slap a //@ dont-require-annotations: WARN on it, and leave a FIXME for someone to potentially investigate later.~~

EDIT: The warnings appear to be GCC-only, so I applied an //@ ignore-backends: gcc instead, as there are already several of those in the incremental suite.

Zalathar · 2026-04-13T10:20:48Z

@bors try jobs=x86_64-gnu

Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

rust-bors · 2026-04-13T12:42:37Z

☀️ Try build successful (CI)
Build commit: e7053b8 (e7053b858097a5db7be019c4aa896b1f68a24843, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

jieyouxu

Thanks
r? me @bors r+ rollup

View changes since this review

rust-bors · 2026-04-16T01:44:50Z

📌 Commit 316fcbd has been approved by jieyouxu

It is now in the queue for this repository.

Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155228 - Zalathar:incr-test-diag, r=jieyouxu Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

Zalathar · 2026-04-13T07:45:08Z

This allows compiler warnings to be annotated in cpass and rpass revisions, and verifies that no unexpected warnings occur.

My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of cfail revisions with //@ build-pass directives, and replace them with a more straightforward cpass revision that also checks diagnostic output. That migration is not part of this PR.

rustbot · 2026-04-13T07:45:11Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-04-13T07:45:14Z

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu · 2026-04-13T07:48:49Z

r? me

Zalathar · 2026-04-13T09:42:47Z

Ugh, a Linux-only test emitting warnings.

~~I might just slap a //@ dont-require-annotations: WARN on it, and leave a FIXME for someone to potentially investigate later.~~

EDIT: The warnings appear to be GCC-only, so I applied an //@ ignore-backends: gcc instead, as there are already several of those in the incremental suite.

Zalathar · 2026-04-13T10:20:48Z

@bors try jobs=x86_64-gnu

Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

rust-bors · 2026-04-13T12:42:37Z

☀️ Try build successful (CI)
Build commit: e7053b8 (e7053b858097a5db7be019c4aa896b1f68a24843, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

jieyouxu

Thanks
r? me @bors r+ rollup

View changes since this review

rust-bors · 2026-04-16T01:44:50Z

📌 Commit 316fcbd has been approved by jieyouxu

It is now in the queue for this repository.

Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155228 - Zalathar:incr-test-diag, r=jieyouxu Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

Zalathar · 2026-04-13T07:45:08Z

This allows compiler warnings to be annotated in cpass and rpass revisions, and verifies that no unexpected warnings occur.

My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of cfail revisions with //@ build-pass directives, and replace them with a more straightforward cpass revision that also checks diagnostic output. That migration is not part of this PR.

rustbot · 2026-04-13T07:45:11Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-04-13T07:45:14Z

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu · 2026-04-13T07:48:49Z

r? me

Zalathar · 2026-04-13T09:42:47Z

Ugh, a Linux-only test emitting warnings.

~~I might just slap a //@ dont-require-annotations: WARN on it, and leave a FIXME for someone to potentially investigate later.~~

EDIT: The warnings appear to be GCC-only, so I applied an //@ ignore-backends: gcc instead, as there are already several of those in the incremental suite.

Zalathar · 2026-04-13T10:20:48Z

@bors try jobs=x86_64-gnu

Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

rust-bors · 2026-04-13T12:42:37Z

☀️ Try build successful (CI)
Build commit: e7053b8 (e7053b858097a5db7be019c4aa896b1f68a24843, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

jieyouxu

Thanks
r? me @bors r+ rollup

View changes since this review

rust-bors · 2026-04-16T01:44:50Z

📌 Commit 316fcbd has been approved by jieyouxu

It is now in the queue for this repository.

Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155228 - Zalathar:incr-test-diag, r=jieyouxu Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

Zalathar · 2026-04-13T07:45:08Z

This allows compiler warnings to be annotated in cpass and rpass revisions, and verifies that no unexpected warnings occur.

My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of cfail revisions with //@ build-pass directives, and replace them with a more straightforward cpass revision that also checks diagnostic output. That migration is not part of this PR.

rustbot · 2026-04-13T07:45:11Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-04-13T07:45:14Z

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
@jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
Random selection from Mark-Simulacrum, clubby789, jieyouxu

jieyouxu · 2026-04-13T07:48:49Z

r? me

Zalathar · 2026-04-13T09:42:47Z

Ugh, a Linux-only test emitting warnings.

~~I might just slap a //@ dont-require-annotations: WARN on it, and leave a FIXME for someone to potentially investigate later.~~

EDIT: The warnings appear to be GCC-only, so I applied an //@ ignore-backends: gcc instead, as there are already several of those in the incremental suite.

Zalathar · 2026-04-13T10:20:48Z

@bors try jobs=x86_64-gnu

Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

rust-bors · 2026-04-13T12:42:37Z

☀️ Try build successful (CI)
Build commit: e7053b8 (e7053b858097a5db7be019c4aa896b1f68a24843, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

jieyouxu

Thanks
r? me @bors r+ rollup

View changes since this review

rust-bors · 2026-04-16T01:44:50Z

📌 Commit 316fcbd has been approved by jieyouxu

It is now in the queue for this repository.

Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup merge of #155228 - Zalathar:incr-test-diag, r=jieyouxu Check diagnostic output in incremental `cpass` and `rpass` revisions This allows compiler warnings to be annotated in `cpass` and `rpass` revisions, and verifies that no unexpected warnings occur. --- My underlying motivation is that I want to be able to reduce or eliminate the confusing combination of `cfail` revisions with `//@ build-pass` directives, and replace them with a more straightforward `cpass` revision that also checks diagnostic output. That migration is not part of this PR.

Rollup of 18 pull requests Successful merges: - rust-lang/rust#154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - rust-lang/rust#154595 (Emit fatal on invalid const args with nested defs) - rust-lang/rust#154599 (report the `varargs_without_pattern` lint in deps) - rust-lang/rust#154699 (`core::unicode`: Replace `Cased` table with `Lt`) - rust-lang/rust#155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - rust-lang/rust#155357 (Add `--remap-path-scope` as unstable in rustdoc) - rust-lang/rust#150649 (clippy fix: non_canonical_clone_impl) - rust-lang/rust#154604 (abort in core) - rust-lang/rust#154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - rust-lang/rust#155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - rust-lang/rust#155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - rust-lang/rust#155266 (Adjust release notes for post-merge feedback) - rust-lang/rust#155326 (Disallow ZST allocations with `TypedArena`.) - rust-lang/rust#155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - rust-lang/rust#155340 (Handle nonnull pattern types in size skeleton) - rust-lang/rust#155347 (Add push_mut and new Layout methods to release notes) - rust-lang/rust#155356 (remove calls to AliasTyKind::def_id) - rust-lang/rust#155364 (Reduce diagnostic type visibilities.)

rustbot assigned clubby789 Apr 13, 2026

rustbot assigned jieyouxu and unassigned clubby789 Apr 13, 2026

This comment has been minimized.
Sign in to view

This comment was marked as duplicate.
Sign in to view

This comment was marked as outdated.
Sign in to view

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
Auto merge of#155228- Zalathar:incr-test-diag, r=<try>
e7053b8
Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

Zalathar added 3 commits April 13, 2026 20:48

Fix some irrelevant warnings in tests/incremental
c79fcfc
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

Extract check_compiler_output_for_incr
8565c4a

Check diagnostic output in incremental cpass and rpass revisions
316fcbd
This allows warnings to be annotated, and verifies that no unexpected warnings occur.

Zalathar force-pushed the incr-test-diag branch from e8fae41 to 316fcbdCompare April 13, 2026 10:48

jieyouxu approved these changes Apr 16, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 74bf795 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Zalathar deleted the incr-test-diag branch April 17, 2026 00:58

rustbot assigned clubby789 Apr 13, 2026

rustbot assigned jieyouxu and unassigned clubby789 Apr 13, 2026

This comment has been minimized.
Sign in to view

This comment was marked as duplicate.
Sign in to view

This comment was marked as outdated.
Sign in to view

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
Auto merge of#155228- Zalathar:incr-test-diag, r=<try>
e7053b8
Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

Zalathar added 3 commits April 13, 2026 20:48

Fix some irrelevant warnings in tests/incremental
c79fcfc
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

Extract check_compiler_output_for_incr
8565c4a

Check diagnostic output in incremental cpass and rpass revisions
316fcbd
This allows warnings to be annotated, and verifies that no unexpected warnings occur.

Zalathar force-pushed the incr-test-diag branch from e8fae41 to 316fcbdCompare April 13, 2026 10:48

jieyouxu approved these changes Apr 16, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 74bf795 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Zalathar deleted the incr-test-diag branch April 17, 2026 00:58

rustbot assigned clubby789 Apr 13, 2026

rustbot assigned jieyouxu and unassigned clubby789 Apr 13, 2026

This comment has been minimized.
Sign in to view

This comment was marked as duplicate.
Sign in to view

This comment was marked as outdated.
Sign in to view

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
Auto merge of#155228- Zalathar:incr-test-diag, r=<try>
e7053b8
Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

Zalathar added 3 commits April 13, 2026 20:48

Fix some irrelevant warnings in tests/incremental
c79fcfc
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

Extract check_compiler_output_for_incr
8565c4a

Check diagnostic output in incremental cpass and rpass revisions
316fcbd
This allows warnings to be annotated, and verifies that no unexpected warnings occur.

Zalathar force-pushed the incr-test-diag branch from e8fae41 to 316fcbdCompare April 13, 2026 10:48

jieyouxu approved these changes Apr 16, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 74bf795 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Zalathar deleted the incr-test-diag branch April 17, 2026 00:58

rustbot assigned clubby789 Apr 13, 2026

rustbot assigned jieyouxu and unassigned clubby789 Apr 13, 2026

This comment has been minimized.
Sign in to view

This comment was marked as duplicate.
Sign in to view

This comment was marked as outdated.
Sign in to view

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
Auto merge of#155228- Zalathar:incr-test-diag, r=<try>
e7053b8
Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

Zalathar added 3 commits April 13, 2026 20:48

Fix some irrelevant warnings in tests/incremental
c79fcfc
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

Extract check_compiler_output_for_incr
8565c4a

Check diagnostic output in incremental cpass and rpass revisions
316fcbd
This allows warnings to be annotated, and verifies that no unexpected warnings occur.

Zalathar force-pushed the incr-test-diag branch from e8fae41 to 316fcbdCompare April 13, 2026 10:48

jieyouxu approved these changes Apr 16, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 74bf795 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Zalathar deleted the incr-test-diag branch April 17, 2026 00:58

rustbot assigned clubby789 Apr 13, 2026

rustbot assigned jieyouxu and unassigned clubby789 Apr 13, 2026

This comment has been minimized.
Sign in to view

This comment was marked as duplicate.
Sign in to view

This comment was marked as outdated.
Sign in to view

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
Auto merge of#155228- Zalathar:incr-test-diag, r=<try>
e7053b8
Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

Zalathar added 3 commits April 13, 2026 20:48

Fix some irrelevant warnings in tests/incremental
c79fcfc
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

Extract check_compiler_output_for_incr
8565c4a

Check diagnostic output in incremental cpass and rpass revisions
316fcbd
This allows warnings to be annotated, and verifies that no unexpected warnings occur.

Zalathar force-pushed the incr-test-diag branch from e8fae41 to 316fcbdCompare April 13, 2026 10:48

jieyouxu approved these changes Apr 16, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 74bf795 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Zalathar deleted the incr-test-diag branch April 17, 2026 00:58

rustbot assigned clubby789 Apr 13, 2026

rustbot assigned jieyouxu and unassigned clubby789 Apr 13, 2026

This comment has been minimized.
Sign in to view

This comment was marked as duplicate.
Sign in to view

This comment was marked as outdated.
Sign in to view

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
Auto merge of#155228- Zalathar:incr-test-diag, r=<try>
e7053b8
Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

Zalathar added 3 commits April 13, 2026 20:48

Fix some irrelevant warnings in tests/incremental
c79fcfc
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

Extract check_compiler_output_for_incr
8565c4a

Check diagnostic output in incremental cpass and rpass revisions
316fcbd
This allows warnings to be annotated, and verifies that no unexpected warnings occur.

Zalathar force-pushed the incr-test-diag branch from e8fae41 to 316fcbdCompare April 13, 2026 10:48

jieyouxu approved these changes Apr 16, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 74bf795 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Zalathar deleted the incr-test-diag branch April 17, 2026 00:58

rustbot assigned clubby789 Apr 13, 2026

rustbot assigned jieyouxu and unassigned clubby789 Apr 13, 2026

This comment has been minimized.
Sign in to view

This comment was marked as duplicate.
Sign in to view

This comment was marked as outdated.
Sign in to view

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
Auto merge of#155228- Zalathar:incr-test-diag, r=<try>
e7053b8
Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

Zalathar added 3 commits April 13, 2026 20:48

Fix some irrelevant warnings in tests/incremental
c79fcfc
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

Extract check_compiler_output_for_incr
8565c4a

Check diagnostic output in incremental cpass and rpass revisions
316fcbd
This allows warnings to be annotated, and verifies that no unexpected warnings occur.

Zalathar force-pushed the incr-test-diag branch from e8fae41 to 316fcbdCompare April 13, 2026 10:48

jieyouxu approved these changes Apr 16, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 74bf795 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Zalathar deleted the incr-test-diag branch April 17, 2026 00:58

rustbot assigned clubby789 Apr 13, 2026

rustbot assigned jieyouxu and unassigned clubby789 Apr 13, 2026

This comment has been minimized.
Sign in to view

This comment was marked as duplicate.
Sign in to view

This comment was marked as outdated.
Sign in to view

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 13, 2026
Auto merge of#155228- Zalathar:incr-test-diag, r=<try>
e7053b8
Check diagnostic output in incremental `cpass` and `rpass` revisions try-job: x86_64-gnu

Zalathar added 3 commits April 13, 2026 20:48

Fix some irrelevant warnings in tests/incremental
c79fcfc
This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

Extract check_compiler_output_for_incr
8565c4a

Check diagnostic output in incremental cpass and rpass revisions
316fcbd
This allows warnings to be annotated, and verifies that no unexpected warnings occur.

Zalathar force-pushed the incr-test-diag branch from e8fae41 to 316fcbdCompare April 13, 2026 10:48

jieyouxu approved these changes Apr 16, 2026
View reviewed changes

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155373
Closed

jhpratt mentioned this pull request Apr 16, 2026
Rollup of 18 pull requests #155380
Merged

rust-borsBot merged commit 74bf795 into rust-lang:mainApr 16, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Zalathar deleted the incr-test-diag branch April 17, 2026 00:58

Uh oh!

Uh oh!

Conversation

Zalathar commented Apr 13, 2026

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

jieyouxu commented Apr 13, 2026

Uh oh!

This comment has been minimized.

Zalathar commented Apr 13, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as duplicate.

This comment was marked as outdated.

Zalathar commented Apr 13, 2026

Uh oh!

This comment has been minimized.

rust-borsBot commented Apr 13, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-borsBot commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Apr 13, 2026

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

jieyouxu commented Apr 13, 2026

Uh oh!

This comment has been minimized.

Zalathar commented Apr 13, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as duplicate.

This comment was marked as outdated.

Zalathar commented Apr 13, 2026

Uh oh!

This comment has been minimized.

rust-borsBot commented Apr 13, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-borsBot commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Apr 13, 2026

Uh oh!

rustbot commented Apr 13, 2026

Zalathar commented Apr 13, 2026•
edited
Loading

jieyouxu left a comment •
edited by rustbot
Loading

Zalathar commented Apr 13, 2026•
edited
Loading

jieyouxu left a comment •
edited by rustbot
Loading

Zalathar commented Apr 13, 2026•
edited
Loading

jieyouxu left a comment •
edited by rustbot
Loading

Zalathar commented Apr 13, 2026•
edited
Loading