Rollup of PRs in the queue; Wednesday by Manishearth · Pull Request #22796 · rust-lang/rust

Manishearth · 2015-02-25T06:42:06Z

No description provided.

Rather than stabilize on the current API, we're going to punt this concern to crates.io, to allow for faster iteration. If you need this functionality, you might look at https://github.com/carllerche/syncbox [breaking-change]

This commit removes many unnecessary `unsafe impl` blocks as well as pushing the needed implementations to the lowest level possible. I noticed that the bounds for `RwLock` are a little off when reviewing rust-lang#22574 and wanted to ensure that we had our story straight on these implementations.

Fixesrust-lang#22382.

This affects the `set_non_blocking` function which cannot fail for Unix or Windows, given correct parameters. Additionally, the short UDP write error case has been removed as there is no such thing as "short UDP writes", instead, the operating system will error out if the application tries to send a packet larger than the MTU of the network path.

If the filename for a path is `None` then we know that the creation of the parent directory created the whole path so there's no need to retry the call to `create_dir`. Closesrust-lang#22737

Currently we have a `set_mode` mutator, so this just adds the pairing of a `mode` accessor to read the value. Closesrust-lang#22738

…utes

…roid aarch64

Fixesrust-lang#22342

Tests often use `vec![1, 2, 3]` instead of shorter and faster `[1, 2, 3]`. This patch removes a lot of unnecessary `vec!`s. Hopefully, the tests will compile and run a bit faster.

This affects the `set_non_blocking` function which cannot fail for Unix or Windows, given correct parameters. Additionally, the short UDP write error case has been removed as there is no such thing as \"short UDP writes\", instead, the operating system will error out if the application tries to send a packet larger than the MTU of the network path.

…hton Makes Rust less amusing by fixing [rust-lang#22745](rust-lang#22745)

…hton This allows selectively disabling the lint for individual methods or traits.

@alexcrichton

…excrichton This commit has already been merged in rust-lang#21774, but i think it has been accidently overriden by rust-lang#22584 and rust-lang#22480. r? @alexcrichton

"body": null,

…r=alexcrichton Fixesrust-lang#22342

I tried to follow [the style guide][1] as much as possible. This is just from some random readings of the code, so no guarantees on completeness, even in the edited files. [1]: http://aturon.github.io/style/README.html

@eddyb

Apply borrowck to fns that appear in const declarations. Fixesrust-lang#22382. r? @eddyb

…crichton

Specifically, the following actions were taken: * The `copy_memory` and `copy_nonoverlapping_memory` functions to drop the `_memory` suffix (as it's implied by the functionality). Both functions are now marked as `#[stable]`. * The `set_memory` function was renamed to `write_bytes` and is now stable. * The `zero_memory` function is now deprecated in favor of `write_bytes` directly. * The `Unique` pointer type is now behind its own feature gate called `unique` to facilitate future stabilization. * All type parameters now are `T: ?Sized` wherever possible and new clauses were added to the `offset` functions to require that the type is sized. [breaking-change]

bors · 2015-02-25T16:25:08Z

⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-win-32-nopt-t, auto-win-32-opt...

bors · 2015-02-25T16:27:46Z

💔 Test failed - auto-win-32-nopt-t

Manishearth · 2015-02-25T16:28:04Z

@bors: retry

Manishearth · 2015-02-25T16:28:44Z

@bors: force

Manishearth · 2015-02-25T16:34:00Z

@bors: force

bors · 2015-02-25T16:34:04Z

⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-win-32-nopt-t, auto-win-32-opt...

bors · 2015-02-25T16:36:52Z

💔 Test failed - auto-win-32-nopt-t

Manishearth · 2015-02-25T16:37:47Z

@bors retry

Manishearth · 2015-02-25T16:37:51Z

@bors: force

Manishearth · 2015-02-25T16:41:03Z

@bors: force clean

bors · 2015-02-25T16:41:08Z

⌛ Testing commit 357b41b with merge f7d562c...

bors · 2015-02-25T18:07:53Z

💔 Test failed - auto-mac-64-opt

alexcrichton · 2015-02-25T18:25:56Z

@bors: retry force

bors · 2015-02-25T18:26:00Z

⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

bors · 2015-02-25T18:28:47Z

💔 Test failed - auto-win-32-opt

alexcrichton · 2015-02-25T18:32:40Z

@bors: retry force clean

bors · 2015-02-25T18:34:57Z

⌛ Testing commit 357b41b with merge 72a5ee4...

bors · 2015-02-25T20:31:31Z

💔 Test failed - auto-mac-32-opt

Manishearth · 2015-02-25T20:32:55Z

@bors retry force clean

bors · 2015-02-25T20:32:59Z

⌛ Testing commit 357b41b with merge 4db0b32...

bors · 2015-02-25T23:08:51Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

aturonand others added 30 commits February 16, 2015 16:42

Deprecate std::sync::TaskPool
efd2a17
Rather than stabilize on the current API, we're going to punt this concern to crates.io, to allow for faster iteration. If you need this functionality, you might look at https://github.com/carllerche/syncbox [breaking-change]

Apply borrowck to fns that appear in const declarations.
d443f98
Fixesrust-lang#22382.

std: Handle a trailing slash in create_dir_all
79bf783
If the filename for a path is `None` then we know that the creation of the parent directory created the whole path so there's no need to retry the call to `create_dir`. Closesrust-lang#22737

std: Expose a mode accessor for Permissions on unix
537d694
Currently we have a `set_mode` mutator, so this just adds the pairing of a `mode` accessor to read the value. Closesrust-lang#22738

Stop parsing "-" as integer,fixesrust-lang#22745
948a17e

Properly reimplement unsafe-code lint to honor changing lint attrib…
fcf7023
…utes

std::io::BufReader: remove leftover lifetime parameter on get_ref()
23f5a8f

Add missing fn
a9f6f4b

Replace deprecated getdtablesize() with sysconf(_SC_OPEN_MAX) for and…
0afebe6
…roid aarch64

style nitpicks
0bea550

iOS: Sync/Send fallout
01385a2

Revert a wrong replace of "fail" to "panic"
54b1106

Improve readability of an error check in set_non_blocking
0fc1a7d

Mention try macro in error chapter
f31ea22
Fixesrust-lang#22342

Use arrays instead of vectors in tests
2807a1c

Fix broken tests
c11807d

Rollup merge ofrust-lang#22623- petrochenkov:optest, r=alexcrichton
0e36a27
Tests often use `vec![1, 2, 3]` instead of shorter and faster `[1, 2, 3]`. This patch removes a lot of unnecessary `vec!`s. Hopefully, the tests will compile and run a bit faster.

Rollup merge ofrust-lang#22747- krdln:fix-parsing-minus, r=alexcric…
ad73cb0
…hton Makes Rust less amusing by fixing [rust-lang#22745](rust-lang#22745)

Rollup merge ofrust-lang#22752- ipetkov:unsafe-lint-fix, r=alexcric…
4ff8b8a
…hton This allows selectively disabling the lint for individual methods or traits.

Rollup merge ofrust-lang#22758- ejjeong:aarch64-linux-android, r=al…
1913e79
…excrichton This commit has already been merged in rust-lang#21774, but i think it has been accidently overriden by rust-lang#22584 and rust-lang#22480. r? @alexcrichton

Rollup merge ofrust-lang#22770- vhbit:ios-rand-send, r=alexcrichton
216be12
"body": null,

Rollup merge ofrust-lang#22772- tbu-:pr_panic_fail, r=alexcrichton
80ac3a8

Rollup merge ofrust-lang#22458- steveklabnik:try_in_error_chapter, …
a429bf6
…r=alexcrichton Fixesrust-lang#22342

Rollup merge ofrust-lang#22539- oli-obk:style_nitpicks, r=Manishearth
c51c377
I tried to follow [the style guide][1] as much as possible. This is just from some random readings of the code, so no guarantees on completeness, even in the edited files. [1]: http://aturon.github.io/style/README.html

Rollup merge ofrust-lang#22736- nikomatsakis:issue-22382, r=eddyb
2408698
Apply borrowck to fns that appear in const declarations. Fixesrust-lang#22382. r? @eddyb

Rollup merge ofrust-lang#22778- mzabaluev:leftover-lifetime, r=alex…
b711b6a
…crichton

bors added a commit that referenced this pull request Feb 25, 2015
Auto merge of#22796- Manishearth:rollup, r=Manishearth
4db0b32

bors merged commit 357b41b into rust-lang:masterFeb 25, 2015

bors mentioned this pull request Feb 25, 2015
[Pending RFC] Const functions and inherent methods. #22816
Closed

Manishearth deleted the rollup branch February 25, 2015 23:11

bors mentioned this pull request Feb 25, 2015
Separate most of rustc::lint::builtin into a separate crate. #22801
Merged

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Centril unassigned brson Oct 2, 2019

Uh oh!

Uh oh!

Conversation

Manishearth commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

Manishearth commented Feb 25, 2015

Uh oh!

Manishearth commented Feb 25, 2015

Uh oh!

Manishearth commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

Manishearth commented Feb 25, 2015

Uh oh!

Manishearth commented Feb 25, 2015

Uh oh!

Manishearth commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

alexcrichton commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

alexcrichton commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

Manishearth commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

bors commented Feb 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants