Skip to content

Extract nomicon to its own repo - #40222

Merged
bors merged 2 commits into
rust-lang:masterfrom
steveklabnik:extract-nomicon
Mar 9, 2017
Merged

Extract nomicon to its own repo#40222
bors merged 2 commits into
rust-lang:masterfrom
steveklabnik:extract-nomicon

Conversation

@steveklabnik

Copy link
Copy Markdown
Contributor

part of #39588

same as #40213 but for the nomicon

r? @alexcrichton

Comment thread.gitmodules Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this book was official part of the rust-lang, why "downgrade" it to rust-lang-nursery instead of keeping a repo in rust-lang ?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of us felt super strongly, but @brson said, with regards to the reference, that it needs a lot of work. The same is true for the nomicon; it still has the huge header at the top, for example.

Given that, the nursery feels appropriate, though I can see putting it in rust-lang too!

@bors

bors commented Mar 4, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #39917) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton rebased to fix the merge conflict

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 6, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4369aee has been approved by alexcrichton

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2017
…xcrichton
Extract nomicon to its own repo
part of rust-lang#39588
same as rust-lang#40213 but for the nomicon
r? @alexcrichton
@steveklabnik

Copy link
Copy Markdown
ContributorAuthor

@bors: rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Mar 7, 2017
…xcrichton
Extract nomicon to its own repo
part of rust-lang#39588
same as rust-lang#40213 but for the nomicon
r? @alexcrichton
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
…xcrichton
Extract nomicon to its own repo
part of rust-lang#39588
same as rust-lang#40213 but for the nomicon
r? @alexcrichton
@frewsxcvfrewsxcv mentioned this pull request Mar 8, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
…xcrichton
Extract nomicon to its own repo
part of rust-lang#39588
same as rust-lang#40213 but for the nomicon
r? @alexcrichton
@frewsxcvfrewsxcv mentioned this pull request Mar 8, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 8, 2017
…xcrichton
Extract nomicon to its own repo
part of rust-lang#39588
same as rust-lang#40213 but for the nomicon
r? @alexcrichton
@arielb1arielb1 mentioned this pull request Mar 8, 2017
bors added a commit that referenced this pull request Mar 9, 2017
@bors
bors merged commit 4369aee into rust-lang:masterMar 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@steveklabnik@bors@alexcrichton@JordiPolo