Uh oh!
There was an error while loading. Please reload this page.
Rollup of 20 pull requests - #40368
Merged
Merged
Conversation
Exposes a boolean flag in RawTable and use it instead of a bool field in HashMap. Fixes: rust-lang#40042
compiler_builtins may not have any unwinding within it to link correctly. This is notoriously finicky, and this small piece of change removes yet another case where personality function happens to get introduced. Side note: I do remember solving the exact same thing before. I wonder why it has reappered...
Test copied from src/test/codegen/extern-functions.rs. Refs: rust-lang#39059
Test copied from src/test/run-pass/thread-local-extern-static.rs. Refs: rust-lang#39059
No longer necessary now that the whitelist is empty. Fixes: rust-lang#39059
The args() and args_os() docs include a line about how the first element is usually the program name. Include that line in the struct docs too.
Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856)
…frewsxcv add unstable book to the bookshelf r? @frewsxcv@GuillaumeGomez
…xcrichton Extract nomicon to its own repo part of rust-lang#39588 same as rust-lang#40213 but for the nomicon r? @alexcrichton
Issue rust-lang#39688 - Help people find String::as_bytes() for UTF-8 Added in links for the inverse functions so people will know that as_bytes() is the inverse of from_utf8() and vice versa. ?r @steveklabnik
Reduce size overhead of adaptative hashmap Exposes a boolean flag in RawTable and use it instead of a bool field in HashMap. Taking a bit from capacity or length would make overflow handling tricky. Fixes: rust-lang#40042
added 16 commits
March 8, 2017 20:53
…=alexcrichton Fix personality_fn within the compiler_builtins compiler_builtins may not have any unwinding within it to link correctly. This is notoriously finicky, and this small piece of change removes yet another case where personality function happens to get introduced. Side note: I do remember solving the exact same thing before. I wonder why it has reappered... @cuviper, could you please try building beta with this patch applied? It should apply cleanly. If it works, I’ll nominate to land this into beta. Fixes(?) rust-lang#40251
Fix description of closure coercion feature Thanks to @whitequark for pointing this out.
…umeGomez Improve the style of the sidebar in rustdoc output Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856) Sample screenshots:   
…wup, r=arielb1 Fix normalization error Follows rust-lang#40163. I don't know whether this is good, but seems logical. [This block of code](https://github.com/rust-lang/rust/blob/ba07bd5d23aced6d4baa5696213b11ca832c1a5d/src/librustc_typeck/check/mod.rs#L2110-L2138) doesn't contain a call to `normalize_associated_types_in`, while [this](https://github.com/rust-lang/rust/blob/master/src/librustc_typeck/check/mod.rs#L2027-L2028) block does, and is nearly identical. Ideally these two blocks should be unified into one, but since the change doesn't seem trivial and I'm unsure if this patch will be accepted it hasn't been done yet. r? @arielb1
Add compile-fail tests for remaining items in whitelist and remove it Add compile-fail tests for `cfg_target_thread_local` and `unwind_attributes`, and remove the whitelist. Let me know if I should clean up the tests (or if I've done anything else wrong, this is my first contribution to rust). cc/ @est31
clarify docs for Args and ArgsOs The args() and args_os() docs include a line about how the first element is usually the program name. Include that line in the struct docs too.
Fix text formatting in README There was a missing backtick in the README.
Remove extra space in test description (of a mod test)
…excrichton Add tests for issues with the 'E-needtest' label. This PR adds tests for the following issues:
Fix a typo in the docs
…turon README formatting in configure/make section Tiny change to render the `config.mk` correctly
Added remove_from to vec.rs (rust-lang#38143) Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞. @madseagames I'm really sorry about that 😭
…chton Update link to COMPILER_TESTS.md in CONTRIBUTING.md Link to compiler test documentation was broken after the file was moved by rust-lang#40086. This updates the link to the new location of the file.
Add missing urls in some macros doc r? @frewsxcv
Clarify handling of `src` in `ptr::write` Fixesrust-lang#39733.
…eklabnik
Document why `str.to_{lower,upper}case` return `String`
Fixesrust-lang#39201.arielb1
commented
Mar 8, 2017
ContributorAuthor
@bors r+ p=1 |
rust-highfive
commented
Mar 8, 2017
Contributor
Some changes occurred in HTML/CSS. |
bors
commented
Mar 8, 2017
Collaborator
📌 Commit f2886e8 has been approved by |
rust-highfive
commented
Mar 8, 2017
Contributor
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
Mar 9, 2017
Collaborator
bors added a commit
that referenced
this pull request
Mar 9, 2017
bors
commented
Mar 9, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
srcinptr::write#40333, Document whystr.to_{lower,upper}casereturnString#40335