Improve the style of the sidebar in rustdoc output by wesleywiser · Pull Request #40265 · rust-lang/rust

wesleywiser · 2017-03-04T18:59:09Z

Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently.

All visual design credit goes to @johnwhelchel (#37856)

Sample screenshots:

rust-highfive · 2017-03-04T18:59:14Z

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik · 2017-03-05T00:09:14Z

@bors: r+ rollup

thanks!

bors · 2017-03-05T00:09:15Z

📌 Commit 5bc2687 has been approved by steveklabnik

bors · 2017-03-05T00:09:20Z

🔒 Merge conflict

wesleywiser · 2017-03-05T01:46:32Z

@steveklabnik rebased

frewsxcv · 2017-03-05T04:20:30Z

As far as I can tell, the build orchestration tool (powering bors) is currently broken, which is causing everything to be incorrectly errored as a merge conflict. We'll need to wait for that to get fixed before approving it again.

wesleywiser · 2017-03-05T04:22:57Z

Thanks! I was a little confused why my local repo didn't report a merge conflict.

…

On Sat, Mar 4, 2017, 11:20 PM Corey Farwell ***@***.***> wrote: As far as I can tell, the build orchestration tool (powering bors) is currently broken, which is causing everything to be incorrectly errored as a merge conflict. We'll need to wait for that to get fixed before approving it again. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#40265 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAyu2LlKvHJRE0C0ZockUxaXwp9YsLg7ks5rijgdgaJpZM4MTLZI> .

GuillaumeGomez · 2017-03-05T12:46:33Z

color changes shouldn't be in this file but in src/librustdoc/html/static/styles/main.css.

GuillaumeGomez · 2017-03-05T12:46:41Z

Same for this one.

GuillaumeGomez · 2017-03-05T12:46:50Z

Same for this one.

GuillaumeGomez · 2017-03-05T12:47:06Z

wesleywiser · 2017-03-06T02:00:29Z

@GuillaumeGomez Fixed

GuillaumeGomez

Just one last change and it's good!

GuillaumeGomez · 2017-03-06T11:28:49Z

Could be just:
border:1px solid;
Instead of:
border-width:1px; border-style: solid;

Thanks! I didn't even know you could do that.

@johnwhelchel

Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856)

wesleywiser · 2017-03-06T23:24:07Z

@GuillaumeGomez Fixed

GuillaumeGomez · 2017-03-07T15:09:21Z

Thanks!

@bors: r+ rollup

bors · 2017-03-07T15:09:22Z

📌 Commit 2bb2a29 has been approved by GuillaumeGomez

@johnwhelchel

…umeGomez Improve the style of the sidebar in rustdoc output Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856) Sample screenshots: ![screen shot 2017-03-04 at 12 29 48 pm](https://cloud.githubusercontent.com/assets/831192/23580829/db6c26c2-00d6-11e7-8d89-822e25ba79f0.png) ![screen shot 2017-03-04 at 12 30 10 pm](https://cloud.githubusercontent.com/assets/831192/23580828/db69eeca-00d6-11e7-9f89-1e06fd3bf098.png) ![screen shot 2017-03-04 at 12 30 31 pm](https://cloud.githubusercontent.com/assets/831192/23580830/db6d00ce-00d6-11e7-89ca-cd03e148a121.png)

@johnwhelchel

…umeGomez Improve the style of the sidebar in rustdoc output Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856) Sample screenshots: ![screen shot 2017-03-04 at 12 29 48 pm](https://cloud.githubusercontent.com/assets/831192/23580829/db6c26c2-00d6-11e7-8d89-822e25ba79f0.png) ![screen shot 2017-03-04 at 12 30 10 pm](https://cloud.githubusercontent.com/assets/831192/23580828/db69eeca-00d6-11e7-9f89-1e06fd3bf098.png) ![screen shot 2017-03-04 at 12 30 31 pm](https://cloud.githubusercontent.com/assets/831192/23580830/db6d00ce-00d6-11e7-89ca-cd03e148a121.png)

@johnwhelchel

…umeGomez Improve the style of the sidebar in rustdoc output Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856) Sample screenshots: ![screen shot 2017-03-04 at 12 29 48 pm](https://cloud.githubusercontent.com/assets/831192/23580829/db6c26c2-00d6-11e7-8d89-822e25ba79f0.png) ![screen shot 2017-03-04 at 12 30 10 pm](https://cloud.githubusercontent.com/assets/831192/23580828/db69eeca-00d6-11e7-9f89-1e06fd3bf098.png) ![screen shot 2017-03-04 at 12 30 31 pm](https://cloud.githubusercontent.com/assets/831192/23580830/db6d00ce-00d6-11e7-89ca-cd03e148a121.png)

Rollup of 20 pull requests - Successful merges: #40154, #40222, #40226, #40237, #40254, #40258, #40265, #40268, #40279, #40283, #40292, #40293, #40296, #40316, #40321, #40325, #40326, #40327, #40333, #40335 - Failed merges:

rust-highfive assigned steveklabnik Mar 4, 2017

frewsxcv added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-tools labels Mar 4, 2017

wesleywiser force-pushed the rustdoc_style branch from 5bc2687 to 7509f4fCompare March 5, 2017 01:46

GuillaumeGomez requested changes Mar 5, 2017
View reviewed changes

wesleywiser force-pushed the rustdoc_style branch from 7509f4f to 6ae283aCompare March 6, 2017 02:00

GuillaumeGomez requested changes Mar 6, 2017
View reviewed changes

Improve the style of the sidebar in rustdoc output
2bb2a29
Makes the sidebar a light grey and highlights the currently viewed item in the sidebar more prominently. All visual design credit goes to @johnwhelchel (rust-lang#37856)

wesleywiser force-pushed the rustdoc_style branch from 6ae283a to 2bb2a29Compare March 6, 2017 23:23

frewsxcv assigned GuillaumeGomez and unassigned steveklabnik Mar 7, 2017

GuillaumeGomez approved these changes Mar 7, 2017
View reviewed changes

frewsxcv mentioned this pull request Mar 8, 2017
Rollup of 19 pull requests #40357
Closed

frewsxcv mentioned this pull request Mar 8, 2017
Rollup of 18 pull requests #40361
Closed

arielb1 mentioned this pull request Mar 8, 2017
Rollup of 20 pull requests #40368
Merged

bors merged commit 2bb2a29 into rust-lang:masterMar 9, 2017

This was referenced Mar 9, 2017
Clean up rustdoc css #40278
Merged
rustdoc sidebar styling doesn't extend to bottom of page if content is taller than sidebar #40459
Closed

est31 mentioned this pull request Mar 23, 2017
Rustdoc sidebar style improvements #40679
Closed

Uh oh!

Uh oh!

Conversation

wesleywiser commented Mar 4, 2017

Uh oh!

rust-highfive commented Mar 4, 2017

Uh oh!

steveklabnik commented Mar 5, 2017

Uh oh!

bors commented Mar 5, 2017

Uh oh!

bors commented Mar 5, 2017

Uh oh!

wesleywiser commented Mar 5, 2017

Uh oh!

frewsxcv commented Mar 5, 2017

Uh oh!

wesleywiser commented Mar 5, 2017 via email

Uh oh!

GuillaumeGomezMar 5, 2017

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMar 5, 2017

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMar 5, 2017

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMar 5, 2017

Choose a reason for hiding this comment

Uh oh!

wesleywiser commented Mar 6, 2017

Uh oh!

GuillaumeGomez left a comment

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomezMar 6, 2017

Choose a reason for hiding this comment

Uh oh!

wesleywiserMar 6, 2017

Choose a reason for hiding this comment

Uh oh!

wesleywiser commented Mar 6, 2017

Uh oh!

GuillaumeGomez commented Mar 7, 2017

Uh oh!

bors commented Mar 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants