Uh oh!
There was an error while loading. Please reload this page.
Added remove_item to vec.rs (#38143) - #40325
Merged
Merged
Conversation
rust-highfive
commented
Mar 7, 2017
Contributor
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
Mar 7, 2017
ContributorAuthor
@bors r=alexcrichton |
bors
commented
Mar 7, 2017
Collaborator
📌 Commit df61719 has been approved by |
madseagames
commented
Mar 7, 2017
Contributor
So... Now what? Is my commit gonna be in the compiler now? In the beta or nightly? |
eddyb
commented
Mar 7, 2017
ContributorAuthor
@madseagames It first has to go through the merge queue, where the PR is tested in a few dozen configurations, and if successful, it will be in the first nightly after that. |
madseagames
commented
Mar 7, 2017
Contributor
@eddyb that's awesome! Thanks for the help Eddy! |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 8, 2017
Added remove_from to vec.rs (rust-lang#38143) Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞. @madseagames I'm really sorry about that 😭
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 8, 2017
Added remove_from to vec.rs (rust-lang#38143) Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞. @madseagames I'm really sorry about that 😭
arielb1 pushed a commit
to arielb1/rust
that referenced
this pull request
Mar 8, 2017
Added remove_from to vec.rs (rust-lang#38143) Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞. @madseagames I'm really sorry about that 😭
bors added a commit
that referenced
this pull request
Mar 9, 2017
bors
commented
Mar 9, 2017
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that if you push to someone's PR branch and cause the PR to close, you lose delegation 😞.
@madseagames I'm really sorry about that 😭