Skip to content

Document why str.to_{lower,upper}case return String - #40335

Merged
bors merged 1 commit into
rust-lang:masterfrom
tbu-:pr_doc_str_to_somecase
Mar 9, 2017
Merged

Document why str.to_{lower,upper}case return String#40335
bors merged 1 commit into
rust-lang:masterfrom
tbu-:pr_doc_str_to_somecase

Conversation

@tbu-

@tbu-tbu- commented Mar 7, 2017

Copy link
Copy Markdown
Contributor

Fixes#39201.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@tbu-

tbu- commented Mar 7, 2017

Copy link
Copy Markdown
ContributorAuthor

CC @Havvy

@sfackler

Copy link
Copy Markdown
Member

r? @steveklabnik

Comment threadsrc/libcollections/str.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "multiple characters" instead of "multiple".

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Comment threadsrc/libcollections/str.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise here.

@tbu-
tbu-force-pushed the pr_doc_str_to_somecase branch from 45cf255 to f3a2f90CompareMarch 7, 2017 23:06
@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

thanks!

@bors

bors commented Mar 8, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit f3a2f90 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
…eklabnik
Document why `str.to_{lower,upper}case` return `String`
Fixesrust-lang#39201.
@frewsxcvfrewsxcv mentioned this pull request Mar 8, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 8, 2017
…eklabnik
Document why `str.to_{lower,upper}case` return `String`
Fixesrust-lang#39201.
@frewsxcvfrewsxcv mentioned this pull request Mar 8, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 8, 2017
…eklabnik
Document why `str.to_{lower,upper}case` return `String`
Fixesrust-lang#39201.
@arielb1arielb1 mentioned this pull request Mar 8, 2017
bors added a commit that referenced this pull request Mar 9, 2017
@bors
bors merged commit f3a2f90 into rust-lang:masterMar 9, 2017
@bors

bors commented Mar 9, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f3a2f90 with merge 3087a1f...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tbu-@rust-highfive@sfackler@steveklabnik@bors@Havvy