Skip to content

derive PartialEq and Eq for ParseCharError - #47790

Merged
bors merged 1 commit into
rust-lang:masterfrom
tinaun:patch-1
Feb 10, 2018
Merged

derive PartialEq and Eq for ParseCharError#47790
bors merged 1 commit into
rust-lang:masterfrom
tinaun:patch-1

Conversation

@tinaun

@tinauntinaun commented Jan 26, 2018

Copy link
Copy Markdown
Contributor

unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason

@tinaun
derive PartialEq and Eq for ParseCharError
838ddbf
unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
@rust-highfive

rust-highfive commented Jan 26, 2018

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytmkennytm added T-libs-api [DEPRECATED; DO NOT USE] S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2018
@kennytm

kennytm commented Jan 31, 2018

Copy link
Copy Markdown
Member

Review ping @sfackler!

@emilyalbini

emilyalbini commented Feb 5, 2018

Copy link
Copy Markdown
Member

@sfackler this PR awaits your review :)

@sfackler

sfackler commented Feb 9, 2018

Copy link
Copy Markdown
Member

Oops, sorry about the delay!

@bors r+

@bors

bors commented Feb 9, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 838ddbf has been approved by sfackler

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2018
@kennytm

kennytm commented Feb 9, 2018

Copy link
Copy Markdown
Member

@bors rollup

@kennytmkennytm mentioned this pull request Feb 9, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018
@kennytm
Rollup merge ofrust-lang#47790- tinaun:patch-1, r=sfackler
2e28f98
derive PartialEq and Eq for `ParseCharError`
unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of#48077- kennytm:rollup, r=kennytm
68df9d6
Rollup of 12 pull requests
- Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064, #47790, #48059, #48078, #48080, #48085
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018
@kennytm
Rollup merge ofrust-lang#47790- tinaun:patch-1, r=sfackler
270e6aa
derive PartialEq and Eq for `ParseCharError`
unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
@kennytmkennytm mentioned this pull request Feb 9, 2018
Closed
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of#48104- kennytm:rollup, r=kennytm
394ccaf
Rollup of 17 pull requests
- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48085, #48086, #48090, #48093, #48098, #48101
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 10, 2018
@kennytm
Rollup merge ofrust-lang#47790- tinaun:patch-1, r=sfackler
6bbee8d
derive PartialEq and Eq for `ParseCharError`
unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
@kennytmkennytm mentioned this pull request Feb 10, 2018
Merged
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of#48113- kennytm:rollup, r=kennytm
d5e3164
Rollup of 16 pull requests
- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100
- Failed merges:
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of#48113- kennytm:rollup, r=kennytm
45fba43
Rollup of 20 pull requests
- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100, #48085, #48120, #48124, #47547
- Failed merges:
@bors
bors merged commit 838ddbf into rust-lang:masterFeb 10, 2018
@tinaun
tinaun deleted the patch-1 branch February 10, 2018 23:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sfacklersfackler

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tinaun@rust-highfive@kennytm@emilyalbini@sfackler@bors