Skip to content

Hide theme button under menu in mobile mode and fix top margin issue … - #48080

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:mobile-docs-fixes
Feb 10, 2018
Merged

Hide theme button under menu in mobile mode and fix top margin issue …#48080
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:mobile-docs-fixes

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Feb 8, 2018

Copy link
Copy Markdown
Member

@QuietMisdreavus

QuietMisdreavus commented Feb 9, 2018

Copy link
Copy Markdown
Contributor

@bors r+ rollup

The "darker margin on the header" thing may be some kind of artifact of using a desktop browser? The screenshot on the issue was taken in Chrome in Windows 7. A similar effect happens in Firefox on Windows 10:

big screenshot

screen shot 2018-02-08 at 21 28 42

However, when testing on my iPhone 7 Plus in mobile Safari, i see no such artifact:

big screenshot

photo-2018-02-08-21-33-40_0390

In addition, @GuillaumeGomez was unable to recreate the issue at all. I'm willing to write it off at this point. I wonder if it has something to do with the scroll bar indicator, and it's just the way it looks when it overlaps the bar? That would explain why it's narrower on the Firefox screenshot. It does not explain why the coloring changes when the menu is open, but the finer points of that are beyond me.

@bors

bors commented Feb 9, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit e9bcb4e has been approved by QuietMisdreavus

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 9, 2018
@GuillaumeGomez

GuillaumeGomez commented Feb 9, 2018

Copy link
Copy Markdown
MemberAuthor

I'll try to recreate the bug. You said firefox? Then on firefox I'll check. :)

@kennytmkennytm mentioned this pull request Feb 9, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018
@kennytm
Rollup merge ofrust-lang#48080- GuillaumeGomez:mobile-docs-fixes, r…
434865d
…=QuietMisdreavus Hide theme button under menu in mobile mode and fix top margin issue … Fixesrust-lang#48060.
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of#48077- kennytm:rollup, r=kennytm
68df9d6
Rollup of 12 pull requests
- Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064, #47790, #48059, #48078, #48080, #48085
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018
@kennytm
Rollup merge ofrust-lang#48080- GuillaumeGomez:mobile-docs-fixes, r…
cbc3b8c
…=QuietMisdreavus
Hide theme button under menu in mobile mode and fix top margin issue …
Fixesrust-lang#48060.
r? @QuietMisdreavus
@kennytmkennytm mentioned this pull request Feb 9, 2018
Closed
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of#48104- kennytm:rollup, r=kennytm
394ccaf
Rollup of 17 pull requests
- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48085, #48086, #48090, #48093, #48098, #48101
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 10, 2018
@kennytm
Rollup merge ofrust-lang#48080- GuillaumeGomez:mobile-docs-fixes, r…
a580eef
…=QuietMisdreavus
Hide theme button under menu in mobile mode and fix top margin issue …
Fixesrust-lang#48060.
r? @QuietMisdreavus
@kennytmkennytm mentioned this pull request Feb 10, 2018
Merged
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of#48113- kennytm:rollup, r=kennytm
d5e3164
Rollup of 16 pull requests
- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100
- Failed merges:
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of#48113- kennytm:rollup, r=kennytm
45fba43
Rollup of 20 pull requests
- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100, #48085, #48120, #48124, #47547
- Failed merges:
@bors
bors merged commit e9bcb4e into rust-lang:masterFeb 10, 2018
@GuillaumeGomez
GuillaumeGomez deleted the mobile-docs-fixes branch February 12, 2018 08:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@QuietMisdreavusQuietMisdreavus

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez@QuietMisdreavus@bors