Uh oh!
There was an error while loading. Please reload this page.
Forcibly disable optimizations in backtrace-debuginfo - #48090
Closed
alexcrichton wants to merge 1 commit into
Closed
Forcibly disable optimizations in backtrace-debuginfo#48090alexcrichton wants to merge 1 commit into
alexcrichton wants to merge 1 commit into
Conversation
Various versions of LLVM do various things with debuginfo but we're most curious that our own code is working so let's just disable optimizations in this test to ensure we have as much pristine debuginfo as possible.
rust-highfive
commented
Feb 9, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
commented
Feb 9, 2018
Contributor
@bors r+ |
bors
commented
Feb 9, 2018
Collaborator
📌 Commit b521c77 has been approved by |
alexcrichton
commented
Feb 9, 2018
MemberAuthor
@bors: rollup |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Feb 9, 2018
…komatsakis Forcibly disable optimizations in backtrace-debuginfo Various versions of LLVM do various things with debuginfo but we're most curious that our own code is working so let's just disable optimizations in this test to ensure we have as much pristine debuginfo as possible. This is currently extracted from rust-lang#47828 to land standalone
bors added a commit
that referenced
this pull request
Feb 9, 2018
kennytm
commented
Feb 10, 2018
Member
#47828 (which includes this change) has been merged, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various versions of LLVM do various things with debuginfo but we're most curious
that our own code is working so let's just disable optimizations in this test to
ensure we have as much pristine debuginfo as possible.
This is currently extracted from #47828 to land standalone