Uh oh!
There was an error while loading. Please reload this page.
Don't cross-compile Emscripten's LLVM - #48093
Conversation
Eventually the LLVM version of Emscripten and the main LLVM will diverge, and we can't cross-compile an older version of LLVM using a newer version of LLVM's `llvm-config`.
rust-highfive
commented
Feb 9, 2018
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Feb 9, 2018
Mark-Simulacrum
commented
Feb 9, 2018
So just to make sure this basically means that we'll be building emscripten LLVM completely (i.e., bootstrapping it) instead of cross compiling from an existing pre-built LLVM? |
alexcrichton
commented
Feb 9, 2018
Nah it's actually a bit better than that! LLVM needs to be told that it's being cross compiled for situations like i686 -> ARM (dunno why). We were informing Emscripten that it was being cross compiled on the i686 builder when we were building from x86_64 -> i686, but this wasn't necessary. Fuctionally this PR actually changes nothing, we still build LLVM the same number of times (aka Emscripten only once). It just means that when we upgrade LLVM away from Emscripten it'll actually work :) |
Mark-Simulacrum
commented
Feb 9, 2018
Sounds good, thanks! @bors r+ |
bors
commented
Feb 9, 2018
📌 Commit 866d13a has been approved by |
alexcrichton
commented
Feb 9, 2018
@bors: rollup |
… r=Mark-Simulacrum Don't cross-compile Emscripten's LLVM Eventually the LLVM version of Emscripten and the main LLVM will diverge, and we can't cross-compile an older version of LLVM using a newer version of LLVM's `llvm-config`. This is extracted from rust-lang#47828
bors
commented
Feb 10, 2018
☔ The latest upstream changes (presumably #47828) made this pull request unmergeable. Please resolve the merge conflicts. |
kennytm
commented
Feb 10, 2018
#47828 (which includes this change) has been merged, closing. |
Eventually the LLVM version of Emscripten and the main LLVM will diverge, and we
can't cross-compile an older version of LLVM using a newer version of LLVM's
llvm-config.This is extracted from #47828