Customizable extended tools by o01eg · Pull Request #48015 · rust-lang/rust

o01eg · 2018-02-05T16:52:59Z

This PR adds build.tools option to manage installation of extended rust tools.

By default it doesn't change installation. All tools are built and rls and rustfmt allowed to fail installation.

If some set of tools chosen only those tools are built and installed without any fails allowed.

It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498

rust-highfive · 2018-02-05T16:53:11Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

nikomatsakis · 2018-02-05T17:57:27Z

r? @Mark-Simulacrum -- code seems fine to me, but I don't feel like the 'owner' of this code

Mark-Simulacrum · 2018-02-06T03:56:58Z

r? @alexcrichton

Seems fine to me too, though looks somewhat odd... I'd like @alexcrichton to have a look though since this is dist-related.

alexcrichton · 2018-02-07T15:34:10Z

Thanks @o01eg! Mind adding a helper method to do the extended + is a member check? Other than that looks good to go!

o01eg · 2018-02-07T18:10:53Z

@alexcrichton Added commit with refactoring. I'm waiting installat step to see if something broken. Also I'm not sure about #[allow(dead_code)] but I have no other idea.

alexcrichton · 2018-02-07T18:33:56Z

@bors: r+

Looks fine by me!

bors · 2018-02-07T18:33:57Z

📌 Commit 78a0b7f has been approved by alexcrichton

bors · 2018-02-07T22:44:24Z

⌛ Testing commit 78a0b7f with merge 4a984fd...

Customizable extended tools This PR adds `build.tools` option to manage installation of extended rust tools. By default it doesn't change installation. All tools are built and `rls` and `rustfmt` allowed to fail installation. If some set of tools chosen only those tools are built and installed without any fails allowed. It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498

bors · 2018-02-08T01:46:57Z

💔 Test failed - status-appveyor

kennytm · 2018-02-08T06:39:45Z

@bors retry

…lexcrichton Customizable extended tools This PR adds `build.tools` option to manage installation of extended rust tools. By default it doesn't change installation. All tools are built and `rls` and `rustfmt` allowed to fail installation. If some set of tools chosen only those tools are built and installed without any fails allowed. It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498

Rollup of 7 pull requests - Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064 - Failed merges:

Rollup of 12 pull requests - Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064, #47790, #48059, #48078, #48080, #48085 - Failed merges:

…lexcrichton Customizable extended tools This PR adds `build.tools` option to manage installation of extended rust tools. By default it doesn't change installation. All tools are built and `rls` and `rustfmt` allowed to fail installation. If some set of tools chosen only those tools are built and installed without any fails allowed. It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498

Rollup of 17 pull requests - Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48085, #48086, #48090, #48093, #48098, #48101 - Failed merges:

…lexcrichton Customizable extended tools This PR adds `build.tools` option to manage installation of extended rust tools. By default it doesn't change installation. All tools are built and `rls` and `rustfmt` allowed to fail installation. If some set of tools chosen only those tools are built and installed without any fails allowed. It solves some slotting issues with extended build enabled: https://bugs.gentoo.org/show_bug.cgi?id=645498

Rollup of 16 pull requests - Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100 - Failed merges:

Rollup of 20 pull requests - Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100, #48085, #48120, #48124, #47547 - Failed merges:

rust-highfive assigned nikomatsakis Feb 5, 2018

emilyalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2018

Add build.tools option to manage installation of extended rust tools.
7be8e2f

rust-highfive assigned Mark-Simulacrum and unassigned nikomatsakis Feb 5, 2018

rust-highfive assigned alexcrichton and unassigned Mark-Simulacrum Feb 6, 2018

Refactor checks on list of extended tools.
78a0b7f

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2018

kennytm mentioned this pull request Feb 8, 2018
Rollup of 12 pull requests #48077
Closed

bors added a commit that referenced this pull request Feb 8, 2018
Auto merge of#48077- kennytm:rollup, r=kennytm
4b3e620
Rollup of 7 pull requests - Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064 - Failed merges:

bors added a commit that referenced this pull request Feb 9, 2018
Auto merge of#48077- kennytm:rollup, r=kennytm
b29141d
Rollup of 7 pull requests - Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064 - Failed merges:

bors added a commit that referenced this pull request Feb 9, 2018
Auto merge of#48077- kennytm:rollup, r=kennytm
68df9d6
Rollup of 12 pull requests - Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064, #47790, #48059, #48078, #48080, #48085 - Failed merges:

kennytm mentioned this pull request Feb 9, 2018
Rollup of 17 pull requests #48104
Closed

kennytm mentioned this pull request Feb 10, 2018
Rollup of 20 pull requests #48113
Merged

bors merged commit 78a0b7f into rust-lang:masterFeb 10, 2018

o01eg deleted the disableable-installation branch February 11, 2018 09:55

o01eg mentioned this pull request Feb 11, 2018
Cargo file coliision gentoo/gentoo-rust#319
Closed

o01eg mentioned this pull request Jan 10, 2019
[experimental] ci: bootstrap from beta instead of nightly rust-lang/rust-clippy#3650
Closed

Navigation Menu

Uh oh!

Uh oh!

Customizable extended tools - #48015

Customizable extended tools#48015
bors merged 2 commits into
rust-lang:masterfrom
o01eg:disableable-installation

o01eg commented Feb 5, 2018

Uh oh!

rust-highfive commented Feb 5, 2018

Uh oh!

nikomatsakis commented Feb 5, 2018

Uh oh!

Mark-Simulacrum commented Feb 6, 2018

Uh oh!

alexcrichton commented Feb 7, 2018

Uh oh!

o01eg commented Feb 7, 2018

Uh oh!

alexcrichton commented Feb 7, 2018

Uh oh!

bors commented Feb 7, 2018

Uh oh!

bors commented Feb 7, 2018

Uh oh!

bors commented Feb 8, 2018

Uh oh!

kennytm commented Feb 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

o01eg commented Feb 5, 2018

Uh oh!

rust-highfive commented Feb 5, 2018

Uh oh!

nikomatsakis commented Feb 5, 2018

Uh oh!

Mark-Simulacrum commented Feb 6, 2018

Uh oh!

alexcrichton commented Feb 7, 2018

Uh oh!

o01eg commented Feb 7, 2018

Uh oh!

alexcrichton commented Feb 7, 2018

Uh oh!

bors commented Feb 7, 2018

Uh oh!

bors commented Feb 7, 2018

Uh oh!

bors commented Feb 8, 2018

Uh oh!

kennytm commented Feb 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants