Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #48774
Closed
GuillaumeGomez wants to merge 27 commits into
Closed
Conversation
Also: - apply some rustfmt love - fix output of one example
Ideally I'd like to soon enable sccache for rustbuild itself and some of the stage0 tools, but for that to work we'll need some better Rust support than the pretty old version we were previously using!
Also fix a spelling mistake.
This Python script converts documentation comments from the `#[doc = "..."]` attribute to the `///` syntax. It was added six years ago, presumably to help with the transition when `///` was implemented and hasn't really been touched since. I don't think there's much value in keeping it around at this point.
Fix spelling s/casted/cast/ r? @GuillaumeGomez
Suggest type for overflowing bin/hex-literals Fixesrust-lang#48073 For hexadecimal and binary literals, which overflow, it gives an additional note to the warning message, like in this [comment](rust-lang#48073 (comment)). Additionally it will suggest a type (`X < Y`): - `iX`: if literal fits in `uX` => `uX`, else => `iY` - `-iX` => `iY` - `uX` => `uY` Exceptions: `isize`, `usize`. I don't think you can make a good suggestion here. The programmer has to figure it out on it's own in this case. r? @oli-obk
…fix, r=QuietMisdreavus Add resource-suffix option for rustdoc Alternative version of rust-lang#48442. cc @onur r? @QuietMisdreavus
…e, r=estebank Raw string error note Fixesrust-lang#48395. I think this note should be helpful enough to solve the issue.
doc: no need for the reference Also, we are well within line length limit
Update sccache to its master branch Ideally I'd like to soon enable sccache for rustbuild itself and some of the stage0 tools, but for that to work we'll need some better Rust support than the pretty old version we were previously using!
…h, r=rkruppe Refactor contrived match.
…hton Remove useless powerpc64 entry from ARCH_TABLE Hope, I understood the scope of the fix correctly. closesrust-lang#47737
Remove a couple of `isize` references from hashmap docs Also fix a spelling mistake.
…s, r=rkruppe while let all the things
…crichton Remove seemingly unused sugarise-doc-comments Python script. This Python script converts documentation comments from the `#[doc = "..."]` attribute to the `///` syntax. It was added six years ago, presumably to help with the transition when `///` was implemented and hasn't really been touched since. I don't think there's much value in keeping it around at this point.
rust-highfive
commented
Mar 6, 2018
Contributor
Some changes occurred in HTML/CSS. |
rust-highfive
commented
Mar 6, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
commented
Mar 6, 2018
MemberAuthor
@bors: r+ p=11 |
bors
commented
Mar 6, 2018
Collaborator
📌 Commit 93be89a has been approved by |
GuillaumeGomez
commented
Mar 6, 2018
MemberAuthor
Apparently there is another PR on the go so I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isizereferences from hashmap docs #48753, while let all the things #48754, Remove seemingly unused sugarise-doc-comments Python script. #48761