Uh oh!
There was an error while loading. Please reload this page.
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings - #2415
Merged
Conversation
getWorkflowRunEvents applied resolveData only client-side: it always downloaded the resolved payload bytes for every event, then discarded them when resolveData was 'none'. The v4 list endpoints accept remoteRefBehavior (resolve|lazy, default resolve), so map resolveData 'none' → lazy and send it on the runId and correlationId list queries — the backend then emits empty-body frames and skips the per-event blob read. Safe against a backend that predates the flag: it ignores the param and streams full bodies, and buildEventFromV4 still strips them for resolveData 'none', so this is a pure bandwidth optimization either way. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
🦋 Changeset detectedLatest commit: e6d0f6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
karthikscale3
approved these changes
Jun 17, 2026
karthikscale3
left a comment
Contributor
There was a problem hiding this comment.
ai: Approving. Reviewed for blockers/regressions — none found. Small, well-scoped bandwidth optimization; 11/11 tests pass and typecheck is clean. Verification notes posted inline.
| cursor: pagination?.cursor ?? undefined, | ||
| limit: pagination?.limit, | ||
| sortOrder: pagination?.sortOrder, | ||
| remoteRefBehavior: (resolveData === 'none' ? 'lazy' : 'resolve') as |
Contributor
There was a problem hiding this comment.
ai: Verified this mapping is exhaustive — ResolveData is typed 'none' | 'all' (packages/world/src/shared.ts:48), so the binary 'none' ? 'lazy' : 'resolve' covers every case with no silent fallthrough. The as 'lazy' | 'resolve' cast is harmless. Note: default ('all') listings now always send remoteRefBehavior=resolve where they previously sent no param — a behavioral no-op since resolve is the backend default.
| // full bodies regardless; buildEventFromV4 still strips them when | ||
| // resolveData is 'none', so this is purely a bandwidth optimization and is | ||
| // safe against an older backend. | ||
| const wirePagination = { |
Contributor
There was a problem hiding this comment.
ai: Verified backward-compatibility with an older backend. buildEventFromV4 (line 438) still strips eventData whenever resolveData === 'none', regardless of whether the body arrived — so correctness holds even if the backend ignores lazy and streams full bodies. The new test deliberately simulates this (sends lazy AND asserts a still-present body is stripped).
| * Shared by the runId and correlationId list query builders so both send | ||
| * `remoteRefBehavior` identically. | ||
| */ | ||
| function appendListParams(sp: URLSearchParams, params: ListEventsV4Params) { |
Contributor
There was a problem hiding this comment.
ai: Verified both list paths send the param identically — appendListParams is now called by both paginationToQuery (runId path) and getEventsByCorrelationIdV4. This refactor also removes the pre-existing duplication of cursor/limit/sortOrder in the correlationId builder, eliminating drift. remoteRefBehavior is optional and only set by getWorkflowRunEvents, so no other V4 callers are affected.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Contributor
No backport to This commit modifies the v4 event-listing wire path ( To override, re-run the Backport to stable workflow manually via |
pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
…-hydration * origin/main: perf(core): lazy inline step start (save one world round-trip per step) (#2478) perf(core): skip per-step events.list via inline event-log delta (#2475) Version Packages (beta) (#2491) [world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486) Version Packages (beta) (#2451) Fix Next workflow module specifier root (#2455) [world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415) [swc-plugin] Fix eager discovery for object property steps (#2484) fix(web-shared): align attributes panel styling (#2483) [web-shared] Auto-scroll trace viewer on J/K span navigation (#2366) fix(web): render restarted step segment as solid gray, not running stripes (#2480) fix(web-shared): use solid gray for queued trace segment (#2474) Add trace viewer span markers for hooks and attributes (#2452) test: support Vercel protection bypass secret in e2e headers (#2458) fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> # Conflicts: # packages/core/src/runtime.ts
6 tasks
VaguelySerious added a commit
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
getWorkflowRunEventsappliedresolveDataonly client-side: on the v4 wire it always downloaded the resolved payload bytes for every event (step inputs/outputs, run input/output, hook payloads, errors), then discarded them inbuildEventFromV4whenresolveDatawas'none'. Pure wasted bandwidth for metadata-only consumers — and v4 has no per-event/refspath to opt out of.The v4 list endpoints already accept
remoteRefBehavior(resolve|lazy, defaultresolve). This mapsresolveData: 'none'→remoteRefBehavior: 'lazy'and sends it on both the runId and correlationId list queries, so the backend emits empty-body frames and skips the per-event blob read entirely.resolveData: 'all'sendsresolve(the default), unchanged.This is the SDK half of the metadata-only-listing optimization; it pairs with the backend change that honors
remoteRefBehavior=lazyon the v4 list/stream.Why it's safe
remoteRefBehaviorparam — the same one v2/v3 use, whichresolveDatahas always mapped to.buildEventFromV4still strips them forresolveData: 'none'. So correctness holds regardless of backend version — it's purely a bandwidth optimization that kicks in once the backend supports it.Test plan
getWorkflowRunEvents({ resolveData: 'none' })sends?remoteRefBehavior=lazyand strips any body the backend still returns (events.test.ts)resolveData: 'all') sends?remoteRefBehavior=resolveand splices the body bytes intoeventDataappendListParams)