Uh oh!
There was an error while loading. Please reload this page.
Fix Next workflow module specifier root - #2455
Merged
Merged
Conversation
Contributor
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
workflow with 1 step💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
ijjk
approved these changes
Jun 16, 2026
🦋 Changeset detectedLatest commit: 0a522d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TooTallNate
enabled auto-merge (squash)
June 17, 2026 03:23
karthikscale3
approved these changes
Jun 17, 2026
karthikscale3
left a comment
Contributor
There was a problem hiding this comment.
Approved. I left one non-blocking test coverage suggestion inline.
| expect(builderConfigs).toHaveLength(1); | ||
| expect(builderConfigs[0]).toMatchObject({ | ||
| projectRoot: '/repo', | ||
| moduleSpecifierRoot: process.cwd(), |
Contributor
There was a problem hiding this comment.
Non-blocking: this verifies the config plumbing, but it would be stronger to add an end-to-end fixture where outputFileTracingRoot is the monorepo root, the Next app imports a workspace-package workflow, and the generated manifest/registry is asserted to use the package-form workflow ID. That would catch this split-brain ID regression if the plumbing changes again.
Contributor
Backport to This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details. Once the underlying issue is fixed, re-run the Backport to stable workflow manually via |
github-actionsBot
added a commit
that referenced
this pull request
Jun 17, 2026
Signed-off-by: Nathan Rajlich <n@n8.io>
Contributor
Backport PR opened against |
pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
…-hydration * origin/main: perf(core): lazy inline step start (save one world round-trip per step) (#2478) perf(core): skip per-step events.list via inline event-log delta (#2475) Version Packages (beta) (#2491) [world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486) Version Packages (beta) (#2451) Fix Next workflow module specifier root (#2455) [world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415) [swc-plugin] Fix eager discovery for object property steps (#2484) fix(web-shared): align attributes panel styling (#2483) [web-shared] Auto-scroll trace viewer on J/K span navigation (#2366) fix(web): render restarted step segment as solid gray, not running stripes (#2480) fix(web-shared): use solid gray for queued trace segment (#2474) Add trace viewer span markers for hooks and attributes (#2452) test: support Vercel protection bypass secret in e2e headers (#2458) fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> # Conflicts: # packages/core/src/runtime.ts
VaguelySerious pushed a commit
that referenced
this pull request
Jun 18, 2026
This was referenced Jun 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moduleSpecifierRootoption.outputFileTracingRootpoints at the monorepo root.Testing
pnpm vitest run packages/builders/src/swc-esbuild-plugin.test.ts packages/next/src/index.test.ts packages/next/src/builder-deferred.test.tspnpm --filter @workflow/builders build && pnpm --filter @workflow/next buildpnpm biome check packages/builders/src/apply-swc-transform.ts packages/builders/src/base-builder.ts packages/builders/src/swc-esbuild-plugin.test.ts packages/builders/src/swc-esbuild-plugin.ts packages/builders/src/types.ts packages/next/src/builder-deferred.ts packages/next/src/index.test.ts packages/next/src/index.ts(passes with existing complexity/style warnings)