Skip to content

Add trace viewer span markers for hooks and attributes - #2452

Merged
mitul-s merged 5 commits into
mainfrom
ms/trace-span-markers
Jun 17, 2026
Merged

Add trace viewer span markers for hooks and attributes #2452
mitul-s merged 5 commits into
mainfrom
ms/trace-span-markers

Conversation

@mitul-s

@mitul-smitul-s commented Jun 16, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Test by visiting a Workflow with a hook, and a workflow with attributes being set.

CleanShot.2026-06-16.at.12.06.25.mp4

mitul-sand others added 2 commits June 16, 2026 12:03
@mitul-s@claude
feat(web-shared): add event markers to the trace timeline
1bb1201
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mitul-s
Update span-markers.tsx
720363e
@mitul-s
mitul-s requested a review from a team as a code ownerJune 16, 2026 16:07
@vercel

vercelBot commented Jun 16, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-astro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-express-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-fastify-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-hono-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nitro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nuxt-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-vite-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-swc-playgroundErrorErrorJun 17, 2026 3:33pm
workflow-tarballsReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-webReadyReadyPreview, CommentJun 17, 2026 3:33pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 17, 2026 3:33pm

@changeset-bot

changeset-botBot commented Jun 16, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 316741e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedMinor
@workflow/webMinor
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

karthikscale3
karthikscale3 approved these changes Jun 16, 2026
View reviewed changes

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this is directionally good and the focused marker/segment tests pass, but please address the two inline UI regressions before merging: tiny-span attr_set markers can disappear, and marker tooltips/labels no longer identify the event kind.

Comment threadpackages/web-shared/src/components/new-trace-viewer/components/timeline.tsx
const baseMarkers = useMemo(() => computeSpanMarkers(span), [span]);
const markers = useMemo(
() =>
geometry.mode.kind === 'full'

@karthikscale3karthikscale3Jun 16, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI regression risk: because markers are only projected/rendered when geometry.mode.kind is full, any attr_set marker on a short/tiny span disappears. The old AttrSetMarkers path projected by viewport time and still showed those diamonds even when the bar collapsed to tiny/arrow. Can we keep a visible marker/indicator for tiny spans too?

Comment threadpackages/web-shared/src/components/new-trace-viewer/components/span-markers.tsx
className="pointer-events-auto absolute top-0 bottom-0 z-10 flex w-8 -translate-x-1/2 items-center justify-center"
style={{ left: `clamp(8px, ${m.leftPct}%, calc(100% - 8px))` }}
>
<TimestampTooltip date={m.timeMs}>

@karthikscale3karthikscale3Jun 16, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve the marker kind and include it in the tooltip/aria label? Right now SpanMarker only carries timeMs, so hook_received and attr_set both render as the same timestamp-only tick. That regresses the previous Attributes set affordance and makes hook resumptions vs attribute writes indistinguishable.

@mitul-smitul-sJun 17, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to follow up on this in a different PR

@vercel
vercelBottemporarily deployed to Preview – workflow-docs June 17, 2026 15:31 Inactive
@mitul-s
mitul-s merged commit 2acf13c into mainJun 17, 2026
58 of 59 checks passed
@mitul-s
mitul-s deleted the ms/trace-span-markers branch June 17, 2026 16:34
@github-actions

github-actionsBot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No backport to stable for 2acf13c (AI decision).

Every change in this commit is confined to packages/web-shared/src/components/new-trace-viewer/, which does not exist on stable (verified via git ls-tree origin/stable — only the older trace-viewer/ directory is present there). The new trace viewer is a main-only feature, so these span-marker additions have nothing to apply against on stable.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

2acf13cc72f4d78ac3671dddb7041dd96340c18e

@github-actionsgithub-actionsBot mentioned this pull request Jun 17, 2026
Merged
@pranaygppranaygp mentioned this pull request Jun 17, 2026
Merged
This was referenced Jun 17, 2026
Open
Closed
pranaygp added a commit that referenced this pull request Jun 18, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into pgp/perf-memoize-step…
3ca022f
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
@mitul-s
mitul-s restored the ms/trace-span-markers branch June 18, 2026 21:44
@github-actionsgithub-actionsBot mentioned this pull request Jun 19, 2026
Closed
@cursorcursorBot mentioned this pull request Jun 23, 2026
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add trace viewer span markers for hooks and attributes by mitul-s · Pull Request #2452 · vercel/workflow · GitHub
Skip to content
Add trace viewer span markers for hooks and attributes  - #2452
Merged
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Jun 17, 2026
Merged
Add trace viewer span markers for hooks and attributes #2452
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Conversation
@mitul-s
@mitul-smitul-s
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Test by visiting a Workflow with a hook, and a workflow with attributes being set.
CleanShot.2026-06-16.at.12.06.25.mp4
mitul-sand others
added 2 commits
June 16, 2026 12:03
@mitul-s@claude
feat(web-shared): add event markers to the trace timeline
1bb1201
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mitul-s
Update span-markers.tsx
720363e
@mitul-s
mitul-s
requested a review
from a team
as a code ownerJune 16, 2026 16:07
@vercel
vercelBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-astro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-express-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-fastify-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-hono-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nitro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nuxt-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-vite-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-swc-playgroundErrorErrorJun 17, 2026 3:33pm
workflow-tarballsReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-webReadyReadyPreview, CommentJun 17, 2026 3:33pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 17, 2026 3:33pm
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 316741e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedMinor
@workflow/webMinor
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
karthikscale3
karthikscale3
approved these changes
Jun 16, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this is directionally good and the focused marker/segment tests pass, but please address the two inline UI regressions before merging: tiny-span attr_set markers can disappear, and marker tooltips/labels no longer identify the event kind.
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/timeline.tsx
 const baseMarkers = useMemo(() => computeSpanMarkers(span), [span]);
 const markers = useMemo(
 () =>
 geometry.mode.kind === 'full'
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI regression risk: because markers are only projected/rendered when geometry.mode.kind is full, any attr_set marker on a short/tiny span disappears. The old AttrSetMarkers path projected by viewport time and still showed those diamonds even when the bar collapsed to tiny/arrow. Can we keep a visible marker/indicator for tiny spans too?
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/span-markers.tsx
 className="pointer-events-auto absolute top-0 bottom-0 z-10 flex w-8 -translate-x-1/2 items-center justify-center"
 style={{ left: `clamp(8px, ${m.leftPct}%, calc(100% - 8px))` }}
 >
 <TimestampTooltip date={m.timeMs}>
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve the marker kind and include it in the tooltip/aria label? Right now SpanMarker only carries timeMs, so hook_received and attr_set both render as the same timestamp-only tick. That regresses the previous Attributes set affordance and makes hook resumptions vs attribute writes indistinguishable.
@mitul-smitul-sJun 17, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to follow up on this in a different PR
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 17, 2026 15:31
Inactive

@mitul-s
mitul-s
merged commit 2acf13c
into
mainJun 17, 2026

58 of 59 checks passed

@mitul-s
mitul-s
deleted the

ms/trace-span-markers

branch
June 17, 2026 16:34
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 2acf13c (AI decision).
Every change in this commit is confined to packages/web-shared/src/components/new-trace-viewer/, which does not exist on stable (verified via git ls-tree origin/stable — only the older trace-viewer/ directory is present there). The new trace viewer is a main-only feature, so these span-marker additions have nothing to apply against on stable.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
2acf13cc72f4d78ac3671dddb7041dd96340c18e

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jun 17, 2026
 Merged


This was referenced Jun 17, 2026
 Open

 Closed

pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into pgp/perf-memoize-step…
3ca022f
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
@mitul-s
mitul-s
restored the

ms/trace-span-markers

branch
June 18, 2026 21:44
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 19, 2026
 Closed

@cursorcursorBot
mentioned this pull request
Jun 23, 2026
 Closed

3 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add trace viewer span markers for hooks and attributes by mitul-s · Pull Request #2452 · vercel/workflow · GitHub
Skip to content
Add trace viewer span markers for hooks and attributes  - #2452
Merged
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Jun 17, 2026
Merged
Add trace viewer span markers for hooks and attributes #2452
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Conversation
@mitul-s
@mitul-smitul-s
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Test by visiting a Workflow with a hook, and a workflow with attributes being set.
CleanShot.2026-06-16.at.12.06.25.mp4
mitul-sand others
added 2 commits
June 16, 2026 12:03
@mitul-s@claude
feat(web-shared): add event markers to the trace timeline
1bb1201
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mitul-s
Update span-markers.tsx
720363e
@mitul-s
mitul-s
requested a review
from a team
as a code ownerJune 16, 2026 16:07
@vercel
vercelBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-astro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-express-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-fastify-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-hono-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nitro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nuxt-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-vite-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-swc-playgroundErrorErrorJun 17, 2026 3:33pm
workflow-tarballsReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-webReadyReadyPreview, CommentJun 17, 2026 3:33pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 17, 2026 3:33pm
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 316741e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedMinor
@workflow/webMinor
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
karthikscale3
karthikscale3
approved these changes
Jun 16, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this is directionally good and the focused marker/segment tests pass, but please address the two inline UI regressions before merging: tiny-span attr_set markers can disappear, and marker tooltips/labels no longer identify the event kind.
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/timeline.tsx
 const baseMarkers = useMemo(() => computeSpanMarkers(span), [span]);
 const markers = useMemo(
 () =>
 geometry.mode.kind === 'full'
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI regression risk: because markers are only projected/rendered when geometry.mode.kind is full, any attr_set marker on a short/tiny span disappears. The old AttrSetMarkers path projected by viewport time and still showed those diamonds even when the bar collapsed to tiny/arrow. Can we keep a visible marker/indicator for tiny spans too?
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/span-markers.tsx
 className="pointer-events-auto absolute top-0 bottom-0 z-10 flex w-8 -translate-x-1/2 items-center justify-center"
 style={{ left: `clamp(8px, ${m.leftPct}%, calc(100% - 8px))` }}
 >
 <TimestampTooltip date={m.timeMs}>
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve the marker kind and include it in the tooltip/aria label? Right now SpanMarker only carries timeMs, so hook_received and attr_set both render as the same timestamp-only tick. That regresses the previous Attributes set affordance and makes hook resumptions vs attribute writes indistinguishable.
@mitul-smitul-sJun 17, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to follow up on this in a different PR
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 17, 2026 15:31
Inactive

@mitul-s
mitul-s
merged commit 2acf13c
into
mainJun 17, 2026

58 of 59 checks passed

@mitul-s
mitul-s
deleted the

ms/trace-span-markers

branch
June 17, 2026 16:34
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 2acf13c (AI decision).
Every change in this commit is confined to packages/web-shared/src/components/new-trace-viewer/, which does not exist on stable (verified via git ls-tree origin/stable — only the older trace-viewer/ directory is present there). The new trace viewer is a main-only feature, so these span-marker additions have nothing to apply against on stable.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
2acf13cc72f4d78ac3671dddb7041dd96340c18e

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jun 17, 2026
 Merged


This was referenced Jun 17, 2026
 Open

 Closed

pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into pgp/perf-memoize-step…
3ca022f
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
@mitul-s
mitul-s
restored the

ms/trace-span-markers

branch
June 18, 2026 21:44
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 19, 2026
 Closed

@cursorcursorBot
mentioned this pull request
Jun 23, 2026
 Closed

3 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add trace viewer span markers for hooks and attributes by mitul-s · Pull Request #2452 · vercel/workflow · GitHub
Skip to content
Add trace viewer span markers for hooks and attributes  - #2452
Merged
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Jun 17, 2026
Merged
Add trace viewer span markers for hooks and attributes #2452
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Conversation
@mitul-s
@mitul-smitul-s
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Test by visiting a Workflow with a hook, and a workflow with attributes being set.
CleanShot.2026-06-16.at.12.06.25.mp4
mitul-sand others
added 2 commits
June 16, 2026 12:03
@mitul-s@claude
feat(web-shared): add event markers to the trace timeline
1bb1201
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mitul-s
Update span-markers.tsx
720363e
@mitul-s
mitul-s
requested a review
from a team
as a code ownerJune 16, 2026 16:07
@vercel
vercelBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-astro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-express-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-fastify-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-hono-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nitro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nuxt-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-vite-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-swc-playgroundErrorErrorJun 17, 2026 3:33pm
workflow-tarballsReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-webReadyReadyPreview, CommentJun 17, 2026 3:33pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 17, 2026 3:33pm
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 316741e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedMinor
@workflow/webMinor
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
karthikscale3
karthikscale3
approved these changes
Jun 16, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this is directionally good and the focused marker/segment tests pass, but please address the two inline UI regressions before merging: tiny-span attr_set markers can disappear, and marker tooltips/labels no longer identify the event kind.
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/timeline.tsx
 const baseMarkers = useMemo(() => computeSpanMarkers(span), [span]);
 const markers = useMemo(
 () =>
 geometry.mode.kind === 'full'
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI regression risk: because markers are only projected/rendered when geometry.mode.kind is full, any attr_set marker on a short/tiny span disappears. The old AttrSetMarkers path projected by viewport time and still showed those diamonds even when the bar collapsed to tiny/arrow. Can we keep a visible marker/indicator for tiny spans too?
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/span-markers.tsx
 className="pointer-events-auto absolute top-0 bottom-0 z-10 flex w-8 -translate-x-1/2 items-center justify-center"
 style={{ left: `clamp(8px, ${m.leftPct}%, calc(100% - 8px))` }}
 >
 <TimestampTooltip date={m.timeMs}>
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve the marker kind and include it in the tooltip/aria label? Right now SpanMarker only carries timeMs, so hook_received and attr_set both render as the same timestamp-only tick. That regresses the previous Attributes set affordance and makes hook resumptions vs attribute writes indistinguishable.
@mitul-smitul-sJun 17, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to follow up on this in a different PR
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 17, 2026 15:31
Inactive

@mitul-s
mitul-s
merged commit 2acf13c
into
mainJun 17, 2026

58 of 59 checks passed

@mitul-s
mitul-s
deleted the

ms/trace-span-markers

branch
June 17, 2026 16:34
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 2acf13c (AI decision).
Every change in this commit is confined to packages/web-shared/src/components/new-trace-viewer/, which does not exist on stable (verified via git ls-tree origin/stable — only the older trace-viewer/ directory is present there). The new trace viewer is a main-only feature, so these span-marker additions have nothing to apply against on stable.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
2acf13cc72f4d78ac3671dddb7041dd96340c18e

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jun 17, 2026
 Merged


This was referenced Jun 17, 2026
 Open

 Closed

pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into pgp/perf-memoize-step…
3ca022f
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
@mitul-s
mitul-s
restored the

ms/trace-span-markers

branch
June 18, 2026 21:44
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 19, 2026
 Closed

@cursorcursorBot
mentioned this pull request
Jun 23, 2026
 Closed

3 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add trace viewer span markers for hooks and attributes by mitul-s · Pull Request #2452 · vercel/workflow · GitHub
Skip to content
Add trace viewer span markers for hooks and attributes  - #2452
Merged
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Jun 17, 2026
Merged
Add trace viewer span markers for hooks and attributes #2452
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Conversation
@mitul-s
@mitul-smitul-s
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Test by visiting a Workflow with a hook, and a workflow with attributes being set.
CleanShot.2026-06-16.at.12.06.25.mp4
mitul-sand others
added 2 commits
June 16, 2026 12:03
@mitul-s@claude
feat(web-shared): add event markers to the trace timeline
1bb1201
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mitul-s
Update span-markers.tsx
720363e
@mitul-s
mitul-s
requested a review
from a team
as a code ownerJune 16, 2026 16:07
@vercel
vercelBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-astro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-express-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-fastify-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-hono-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nitro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nuxt-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-vite-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-swc-playgroundErrorErrorJun 17, 2026 3:33pm
workflow-tarballsReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-webReadyReadyPreview, CommentJun 17, 2026 3:33pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 17, 2026 3:33pm
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 316741e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedMinor
@workflow/webMinor
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
karthikscale3
karthikscale3
approved these changes
Jun 16, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this is directionally good and the focused marker/segment tests pass, but please address the two inline UI regressions before merging: tiny-span attr_set markers can disappear, and marker tooltips/labels no longer identify the event kind.
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/timeline.tsx
 const baseMarkers = useMemo(() => computeSpanMarkers(span), [span]);
 const markers = useMemo(
 () =>
 geometry.mode.kind === 'full'
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI regression risk: because markers are only projected/rendered when geometry.mode.kind is full, any attr_set marker on a short/tiny span disappears. The old AttrSetMarkers path projected by viewport time and still showed those diamonds even when the bar collapsed to tiny/arrow. Can we keep a visible marker/indicator for tiny spans too?
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/span-markers.tsx
 className="pointer-events-auto absolute top-0 bottom-0 z-10 flex w-8 -translate-x-1/2 items-center justify-center"
 style={{ left: `clamp(8px, ${m.leftPct}%, calc(100% - 8px))` }}
 >
 <TimestampTooltip date={m.timeMs}>
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve the marker kind and include it in the tooltip/aria label? Right now SpanMarker only carries timeMs, so hook_received and attr_set both render as the same timestamp-only tick. That regresses the previous Attributes set affordance and makes hook resumptions vs attribute writes indistinguishable.
@mitul-smitul-sJun 17, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to follow up on this in a different PR
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 17, 2026 15:31
Inactive

@mitul-s
mitul-s
merged commit 2acf13c
into
mainJun 17, 2026

58 of 59 checks passed

@mitul-s
mitul-s
deleted the

ms/trace-span-markers

branch
June 17, 2026 16:34
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 2acf13c (AI decision).
Every change in this commit is confined to packages/web-shared/src/components/new-trace-viewer/, which does not exist on stable (verified via git ls-tree origin/stable — only the older trace-viewer/ directory is present there). The new trace viewer is a main-only feature, so these span-marker additions have nothing to apply against on stable.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
2acf13cc72f4d78ac3671dddb7041dd96340c18e

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jun 17, 2026
 Merged


This was referenced Jun 17, 2026
 Open

 Closed

pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into pgp/perf-memoize-step…
3ca022f
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
@mitul-s
mitul-s
restored the

ms/trace-span-markers

branch
June 18, 2026 21:44
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 19, 2026
 Closed

@cursorcursorBot
mentioned this pull request
Jun 23, 2026
 Closed

3 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add trace viewer span markers for hooks and attributes by mitul-s · Pull Request #2452 · vercel/workflow · GitHub
Skip to content
Add trace viewer span markers for hooks and attributes  - #2452
Merged
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Jun 17, 2026
Merged
Add trace viewer span markers for hooks and attributes #2452
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Conversation
@mitul-s
@mitul-smitul-s
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Test by visiting a Workflow with a hook, and a workflow with attributes being set.
CleanShot.2026-06-16.at.12.06.25.mp4
mitul-sand others
added 2 commits
June 16, 2026 12:03
@mitul-s@claude
feat(web-shared): add event markers to the trace timeline
1bb1201
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mitul-s
Update span-markers.tsx
720363e
@mitul-s
mitul-s
requested a review
from a team
as a code ownerJune 16, 2026 16:07
@vercel
vercelBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-astro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-express-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-fastify-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-hono-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nitro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nuxt-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-vite-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-swc-playgroundErrorErrorJun 17, 2026 3:33pm
workflow-tarballsReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-webReadyReadyPreview, CommentJun 17, 2026 3:33pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 17, 2026 3:33pm
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 316741e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedMinor
@workflow/webMinor
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
karthikscale3
karthikscale3
approved these changes
Jun 16, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this is directionally good and the focused marker/segment tests pass, but please address the two inline UI regressions before merging: tiny-span attr_set markers can disappear, and marker tooltips/labels no longer identify the event kind.
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/timeline.tsx
 const baseMarkers = useMemo(() => computeSpanMarkers(span), [span]);
 const markers = useMemo(
 () =>
 geometry.mode.kind === 'full'
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI regression risk: because markers are only projected/rendered when geometry.mode.kind is full, any attr_set marker on a short/tiny span disappears. The old AttrSetMarkers path projected by viewport time and still showed those diamonds even when the bar collapsed to tiny/arrow. Can we keep a visible marker/indicator for tiny spans too?
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/span-markers.tsx
 className="pointer-events-auto absolute top-0 bottom-0 z-10 flex w-8 -translate-x-1/2 items-center justify-center"
 style={{ left: `clamp(8px, ${m.leftPct}%, calc(100% - 8px))` }}
 >
 <TimestampTooltip date={m.timeMs}>
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve the marker kind and include it in the tooltip/aria label? Right now SpanMarker only carries timeMs, so hook_received and attr_set both render as the same timestamp-only tick. That regresses the previous Attributes set affordance and makes hook resumptions vs attribute writes indistinguishable.
@mitul-smitul-sJun 17, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to follow up on this in a different PR
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 17, 2026 15:31
Inactive

@mitul-s
mitul-s
merged commit 2acf13c
into
mainJun 17, 2026

58 of 59 checks passed

@mitul-s
mitul-s
deleted the

ms/trace-span-markers

branch
June 17, 2026 16:34
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 2acf13c (AI decision).
Every change in this commit is confined to packages/web-shared/src/components/new-trace-viewer/, which does not exist on stable (verified via git ls-tree origin/stable — only the older trace-viewer/ directory is present there). The new trace viewer is a main-only feature, so these span-marker additions have nothing to apply against on stable.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
2acf13cc72f4d78ac3671dddb7041dd96340c18e

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jun 17, 2026
 Merged


This was referenced Jun 17, 2026
 Open

 Closed

pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into pgp/perf-memoize-step…
3ca022f
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
@mitul-s
mitul-s
restored the

ms/trace-span-markers

branch
June 18, 2026 21:44
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 19, 2026
 Closed

@cursorcursorBot
mentioned this pull request
Jun 23, 2026
 Closed

3 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add trace viewer span markers for hooks and attributes by mitul-s · Pull Request #2452 · vercel/workflow · GitHub
Skip to content
Add trace viewer span markers for hooks and attributes  - #2452
Merged
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Jun 17, 2026
Merged
Add trace viewer span markers for hooks and attributes #2452
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Conversation
@mitul-s
@mitul-smitul-s
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Test by visiting a Workflow with a hook, and a workflow with attributes being set.
CleanShot.2026-06-16.at.12.06.25.mp4
mitul-sand others
added 2 commits
June 16, 2026 12:03
@mitul-s@claude
feat(web-shared): add event markers to the trace timeline
1bb1201
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mitul-s
Update span-markers.tsx
720363e
@mitul-s
mitul-s
requested a review
from a team
as a code ownerJune 16, 2026 16:07
@vercel
vercelBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-astro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-express-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-fastify-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-hono-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nitro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nuxt-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-vite-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-swc-playgroundErrorErrorJun 17, 2026 3:33pm
workflow-tarballsReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-webReadyReadyPreview, CommentJun 17, 2026 3:33pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 17, 2026 3:33pm
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 316741e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedMinor
@workflow/webMinor
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
karthikscale3
karthikscale3
approved these changes
Jun 16, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this is directionally good and the focused marker/segment tests pass, but please address the two inline UI regressions before merging: tiny-span attr_set markers can disappear, and marker tooltips/labels no longer identify the event kind.
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/timeline.tsx
 const baseMarkers = useMemo(() => computeSpanMarkers(span), [span]);
 const markers = useMemo(
 () =>
 geometry.mode.kind === 'full'
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI regression risk: because markers are only projected/rendered when geometry.mode.kind is full, any attr_set marker on a short/tiny span disappears. The old AttrSetMarkers path projected by viewport time and still showed those diamonds even when the bar collapsed to tiny/arrow. Can we keep a visible marker/indicator for tiny spans too?
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/span-markers.tsx
 className="pointer-events-auto absolute top-0 bottom-0 z-10 flex w-8 -translate-x-1/2 items-center justify-center"
 style={{ left: `clamp(8px, ${m.leftPct}%, calc(100% - 8px))` }}
 >
 <TimestampTooltip date={m.timeMs}>
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve the marker kind and include it in the tooltip/aria label? Right now SpanMarker only carries timeMs, so hook_received and attr_set both render as the same timestamp-only tick. That regresses the previous Attributes set affordance and makes hook resumptions vs attribute writes indistinguishable.
@mitul-smitul-sJun 17, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to follow up on this in a different PR
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 17, 2026 15:31
Inactive

@mitul-s
mitul-s
merged commit 2acf13c
into
mainJun 17, 2026

58 of 59 checks passed

@mitul-s
mitul-s
deleted the

ms/trace-span-markers

branch
June 17, 2026 16:34
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 2acf13c (AI decision).
Every change in this commit is confined to packages/web-shared/src/components/new-trace-viewer/, which does not exist on stable (verified via git ls-tree origin/stable — only the older trace-viewer/ directory is present there). The new trace viewer is a main-only feature, so these span-marker additions have nothing to apply against on stable.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
2acf13cc72f4d78ac3671dddb7041dd96340c18e

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jun 17, 2026
 Merged


This was referenced Jun 17, 2026
 Open

 Closed

pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into pgp/perf-memoize-step…
3ca022f
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
@mitul-s
mitul-s
restored the

ms/trace-span-markers

branch
June 18, 2026 21:44
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 19, 2026
 Closed

@cursorcursorBot
mentioned this pull request
Jun 23, 2026
 Closed

3 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add trace viewer span markers for hooks and attributes by mitul-s · Pull Request #2452 · vercel/workflow · GitHub
Skip to content
Add trace viewer span markers for hooks and attributes  - #2452
Merged
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Jun 17, 2026
Merged
Add trace viewer span markers for hooks and attributes #2452
mitul-s merged 5 commits into
mainfrom 
ms/trace-span-markers
Conversation
@mitul-s
@mitul-smitul-s
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Test by visiting a Workflow with a hook, and a workflow with attributes being set.
CleanShot.2026-06-16.at.12.06.25.mp4
mitul-sand others
added 2 commits
June 16, 2026 12:03
@mitul-s@claude
feat(web-shared): add event markers to the trace timeline
1bb1201
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mitul-s
Update span-markers.tsx
720363e
@mitul-s
mitul-s
requested a review
from a team
as a code ownerJune 16, 2026 16:07
@vercel
vercelBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 17, 2026 3:33pm
example-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-astro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-express-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-fastify-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-hono-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nitro-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-nuxt-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workbench-vite-workflowReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-swc-playgroundErrorErrorJun 17, 2026 3:33pm
workflow-tarballsReadyReadyPreview, CommentJun 17, 2026 3:33pm
workflow-webReadyReadyPreview, CommentJun 17, 2026 3:33pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 17, 2026 3:33pm
@changeset-bot
changeset-botBot
commented
Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 316741e
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedMinor
@workflow/webMinor
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
karthikscale3
karthikscale3
approved these changes
Jun 16, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this is directionally good and the focused marker/segment tests pass, but please address the two inline UI regressions before merging: tiny-span attr_set markers can disappear, and marker tooltips/labels no longer identify the event kind.
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/timeline.tsx
 const baseMarkers = useMemo(() => computeSpanMarkers(span), [span]);
 const markers = useMemo(
 () =>
 geometry.mode.kind === 'full'
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small UI regression risk: because markers are only projected/rendered when geometry.mode.kind is full, any attr_set marker on a short/tiny span disappears. The old AttrSetMarkers path projected by viewport time and still showed those diamonds even when the bar collapsed to tiny/arrow. Can we keep a visible marker/indicator for tiny spans too?
Comment threadpackages/web-shared/src/components/new-trace-viewer/components/span-markers.tsx
 className="pointer-events-auto absolute top-0 bottom-0 z-10 flex w-8 -translate-x-1/2 items-center justify-center"
 style={{ left: `clamp(8px, ${m.leftPct}%, calc(100% - 8px))` }}
 >
 <TimestampTooltip date={m.timeMs}>
@karthikscale3karthikscale3Jun 16, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve the marker kind and include it in the tooltip/aria label? Right now SpanMarker only carries timeMs, so hook_received and attr_set both render as the same timestamp-only tick. That regresses the previous Attributes set affordance and makes hook resumptions vs attribute writes indistinguishable.
@mitul-smitul-sJun 17, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to follow up on this in a different PR
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 17, 2026 15:31
Inactive

@mitul-s
mitul-s
merged commit 2acf13c
into
mainJun 17, 2026

58 of 59 checks passed

@mitul-s
mitul-s
deleted the

ms/trace-span-markers

branch
June 17, 2026 16:34
@github-actions
github-actionsBot
commented
Jun 17, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 2acf13c (AI decision).
Every change in this commit is confined to packages/web-shared/src/components/new-trace-viewer/, which does not exist on stable (verified via git ls-tree origin/stable — only the older trace-viewer/ directory is present there). The new trace viewer is a main-only feature, so these span-marker additions have nothing to apply against on stable.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
2acf13cc72f4d78ac3671dddb7041dd96340c18e

@github-actionsgithub-actionsBot
mentioned this pull request
Jun 17, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jun 17, 2026
 Merged


This was referenced Jun 17, 2026
 Open

 Closed

pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into pgp/perf-memoize-step…
3ca022f
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
@mitul-s
mitul-s
restored the

ms/trace-span-markers

branch
June 18, 2026 21:44
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 19, 2026
 Closed

@cursorcursorBot
mentioned this pull request
Jun 23, 2026
 Closed

3 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3