Skip to content

fix(web): render restarted step segment as solid gray, not running stripes - #2480

Merged
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653
Jun 17, 2026
Merged

fix(web): render restarted step segment as solid gray, not running stripes#2480
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

In the trace timeline (new-trace-viewer), each step bar is split into status segments. The animated blue diagonal "running" stripes are only drawn for segments whose status is running (or received).

When a step emits step_started twice in a row — a re-start with no step_retrying/step_failed/step_completed in between — the interval between the two starts fell into the else branch and was labeled running, so it rendered as the animated blue stripes. That implied active progress for what is really a superseded/abandoned attempt.

This changes that single case to retrying, which renders as a solid gray segment (no stripes). The other next-mark types are unaffected (step_retrying/step_failedfailed, step_completedsucceeded), so this only touches the started-twice case.

Test plan

  • Open a run whose step was started, then started again (with no retry/fail/complete in between) and confirm the interval between the two starts renders solid gray instead of animated blue stripes.
  • Confirm normal steps (created → started → completed) still render green, and failed/retried steps are unchanged.

Made with Cursor

…ripes
When a step emits `step_started` twice in a row (a re-start with no
retrying/failed/completed in between), the interval between the two starts
was shown with the animated blue "running" stripes, implying active
progress. Treat that segment as gray ('retrying') instead.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerJune 17, 2026 17:42
@vercel

vercelBot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22db8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mitul-s
mitul-s enabled auto-merge (squash) June 17, 2026 17:42
@mitul-s
mitul-s merged commit 9eb5b9f into mainJun 17, 2026
59 checks passed
@mitul-s
mitul-s deleted the c-ms/90f76653 branch June 17, 2026 18:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 9eb5b9f (AI decision).

The fix is confined to packages/web-shared/src/components/new-trace-viewer/utils.ts, and the entire new-trace-viewer directory (along with the computeStepSegmentsFromSpan function) does not exist on stable — only the older trace-viewer component is present there. Since this main-only component has no counterpart on stable, there is nothing to backport.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

9eb5b9f54d8d87b1866a83a7e9341b8d8b2bb08d

pranaygp added a commit that referenced this pull request Jun 18, 2026
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(web): render restarted step segment as solid gray, not running stripes by mitul-s · Pull Request #2480 · vercel/workflow · GitHub
Skip to content

fix(web): render restarted step segment as solid gray, not running stripes - #2480

Merged
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653
Jun 17, 2026
Merged

fix(web): render restarted step segment as solid gray, not running stripes#2480
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

In the trace timeline (new-trace-viewer), each step bar is split into status segments. The animated blue diagonal "running" stripes are only drawn for segments whose status is running (or received).

When a step emits step_started twice in a row — a re-start with no step_retrying/step_failed/step_completed in between — the interval between the two starts fell into the else branch and was labeled running, so it rendered as the animated blue stripes. That implied active progress for what is really a superseded/abandoned attempt.

This changes that single case to retrying, which renders as a solid gray segment (no stripes). The other next-mark types are unaffected (step_retrying/step_failedfailed, step_completedsucceeded), so this only touches the started-twice case.

Test plan

  • Open a run whose step was started, then started again (with no retry/fail/complete in between) and confirm the interval between the two starts renders solid gray instead of animated blue stripes.
  • Confirm normal steps (created → started → completed) still render green, and failed/retried steps are unchanged.

Made with Cursor

…ripes
When a step emits `step_started` twice in a row (a re-start with no
retrying/failed/completed in between), the interval between the two starts
was shown with the animated blue "running" stripes, implying active
progress. Treat that segment as gray ('retrying') instead.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerJune 17, 2026 17:42
@vercel

vercelBot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22db8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mitul-s
mitul-s enabled auto-merge (squash) June 17, 2026 17:42
@mitul-s
mitul-s merged commit 9eb5b9f into mainJun 17, 2026
59 checks passed
@mitul-s
mitul-s deleted the c-ms/90f76653 branch June 17, 2026 18:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 9eb5b9f (AI decision).

The fix is confined to packages/web-shared/src/components/new-trace-viewer/utils.ts, and the entire new-trace-viewer directory (along with the computeStepSegmentsFromSpan function) does not exist on stable — only the older trace-viewer component is present there. Since this main-only component has no counterpart on stable, there is nothing to backport.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

9eb5b9f54d8d87b1866a83a7e9341b8d8b2bb08d

pranaygp added a commit that referenced this pull request Jun 18, 2026
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(web): render restarted step segment as solid gray, not running stripes by mitul-s · Pull Request #2480 · vercel/workflow · GitHub
Skip to content

fix(web): render restarted step segment as solid gray, not running stripes - #2480

Merged
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653
Jun 17, 2026
Merged

fix(web): render restarted step segment as solid gray, not running stripes#2480
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

In the trace timeline (new-trace-viewer), each step bar is split into status segments. The animated blue diagonal "running" stripes are only drawn for segments whose status is running (or received).

When a step emits step_started twice in a row — a re-start with no step_retrying/step_failed/step_completed in between — the interval between the two starts fell into the else branch and was labeled running, so it rendered as the animated blue stripes. That implied active progress for what is really a superseded/abandoned attempt.

This changes that single case to retrying, which renders as a solid gray segment (no stripes). The other next-mark types are unaffected (step_retrying/step_failedfailed, step_completedsucceeded), so this only touches the started-twice case.

Test plan

  • Open a run whose step was started, then started again (with no retry/fail/complete in between) and confirm the interval between the two starts renders solid gray instead of animated blue stripes.
  • Confirm normal steps (created → started → completed) still render green, and failed/retried steps are unchanged.

Made with Cursor

…ripes
When a step emits `step_started` twice in a row (a re-start with no
retrying/failed/completed in between), the interval between the two starts
was shown with the animated blue "running" stripes, implying active
progress. Treat that segment as gray ('retrying') instead.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerJune 17, 2026 17:42
@vercel

vercelBot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22db8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mitul-s
mitul-s enabled auto-merge (squash) June 17, 2026 17:42
@mitul-s
mitul-s merged commit 9eb5b9f into mainJun 17, 2026
59 checks passed
@mitul-s
mitul-s deleted the c-ms/90f76653 branch June 17, 2026 18:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 9eb5b9f (AI decision).

The fix is confined to packages/web-shared/src/components/new-trace-viewer/utils.ts, and the entire new-trace-viewer directory (along with the computeStepSegmentsFromSpan function) does not exist on stable — only the older trace-viewer component is present there. Since this main-only component has no counterpart on stable, there is nothing to backport.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

9eb5b9f54d8d87b1866a83a7e9341b8d8b2bb08d

pranaygp added a commit that referenced this pull request Jun 18, 2026
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(web): render restarted step segment as solid gray, not running stripes by mitul-s · Pull Request #2480 · vercel/workflow · GitHub
Skip to content

fix(web): render restarted step segment as solid gray, not running stripes - #2480

Merged
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653
Jun 17, 2026
Merged

fix(web): render restarted step segment as solid gray, not running stripes#2480
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

In the trace timeline (new-trace-viewer), each step bar is split into status segments. The animated blue diagonal "running" stripes are only drawn for segments whose status is running (or received).

When a step emits step_started twice in a row — a re-start with no step_retrying/step_failed/step_completed in between — the interval between the two starts fell into the else branch and was labeled running, so it rendered as the animated blue stripes. That implied active progress for what is really a superseded/abandoned attempt.

This changes that single case to retrying, which renders as a solid gray segment (no stripes). The other next-mark types are unaffected (step_retrying/step_failedfailed, step_completedsucceeded), so this only touches the started-twice case.

Test plan

  • Open a run whose step was started, then started again (with no retry/fail/complete in between) and confirm the interval between the two starts renders solid gray instead of animated blue stripes.
  • Confirm normal steps (created → started → completed) still render green, and failed/retried steps are unchanged.

Made with Cursor

…ripes
When a step emits `step_started` twice in a row (a re-start with no
retrying/failed/completed in between), the interval between the two starts
was shown with the animated blue "running" stripes, implying active
progress. Treat that segment as gray ('retrying') instead.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerJune 17, 2026 17:42
@vercel

vercelBot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22db8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mitul-s
mitul-s enabled auto-merge (squash) June 17, 2026 17:42
@mitul-s
mitul-s merged commit 9eb5b9f into mainJun 17, 2026
59 checks passed
@mitul-s
mitul-s deleted the c-ms/90f76653 branch June 17, 2026 18:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 9eb5b9f (AI decision).

The fix is confined to packages/web-shared/src/components/new-trace-viewer/utils.ts, and the entire new-trace-viewer directory (along with the computeStepSegmentsFromSpan function) does not exist on stable — only the older trace-viewer component is present there. Since this main-only component has no counterpart on stable, there is nothing to backport.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

9eb5b9f54d8d87b1866a83a7e9341b8d8b2bb08d

pranaygp added a commit that referenced this pull request Jun 18, 2026
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(web): render restarted step segment as solid gray, not running stripes by mitul-s · Pull Request #2480 · vercel/workflow · GitHub
Skip to content

fix(web): render restarted step segment as solid gray, not running stripes - #2480

Merged
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653
Jun 17, 2026
Merged

fix(web): render restarted step segment as solid gray, not running stripes#2480
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

In the trace timeline (new-trace-viewer), each step bar is split into status segments. The animated blue diagonal "running" stripes are only drawn for segments whose status is running (or received).

When a step emits step_started twice in a row — a re-start with no step_retrying/step_failed/step_completed in between — the interval between the two starts fell into the else branch and was labeled running, so it rendered as the animated blue stripes. That implied active progress for what is really a superseded/abandoned attempt.

This changes that single case to retrying, which renders as a solid gray segment (no stripes). The other next-mark types are unaffected (step_retrying/step_failedfailed, step_completedsucceeded), so this only touches the started-twice case.

Test plan

  • Open a run whose step was started, then started again (with no retry/fail/complete in between) and confirm the interval between the two starts renders solid gray instead of animated blue stripes.
  • Confirm normal steps (created → started → completed) still render green, and failed/retried steps are unchanged.

Made with Cursor

…ripes
When a step emits `step_started` twice in a row (a re-start with no
retrying/failed/completed in between), the interval between the two starts
was shown with the animated blue "running" stripes, implying active
progress. Treat that segment as gray ('retrying') instead.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerJune 17, 2026 17:42
@vercel

vercelBot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22db8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mitul-s
mitul-s enabled auto-merge (squash) June 17, 2026 17:42
@mitul-s
mitul-s merged commit 9eb5b9f into mainJun 17, 2026
59 checks passed
@mitul-s
mitul-s deleted the c-ms/90f76653 branch June 17, 2026 18:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 9eb5b9f (AI decision).

The fix is confined to packages/web-shared/src/components/new-trace-viewer/utils.ts, and the entire new-trace-viewer directory (along with the computeStepSegmentsFromSpan function) does not exist on stable — only the older trace-viewer component is present there. Since this main-only component has no counterpart on stable, there is nothing to backport.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

9eb5b9f54d8d87b1866a83a7e9341b8d8b2bb08d

pranaygp added a commit that referenced this pull request Jun 18, 2026
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(web): render restarted step segment as solid gray, not running stripes by mitul-s · Pull Request #2480 · vercel/workflow · GitHub
Skip to content

fix(web): render restarted step segment as solid gray, not running stripes - #2480

Merged
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653
Jun 17, 2026
Merged

fix(web): render restarted step segment as solid gray, not running stripes#2480
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

In the trace timeline (new-trace-viewer), each step bar is split into status segments. The animated blue diagonal "running" stripes are only drawn for segments whose status is running (or received).

When a step emits step_started twice in a row — a re-start with no step_retrying/step_failed/step_completed in between — the interval between the two starts fell into the else branch and was labeled running, so it rendered as the animated blue stripes. That implied active progress for what is really a superseded/abandoned attempt.

This changes that single case to retrying, which renders as a solid gray segment (no stripes). The other next-mark types are unaffected (step_retrying/step_failedfailed, step_completedsucceeded), so this only touches the started-twice case.

Test plan

  • Open a run whose step was started, then started again (with no retry/fail/complete in between) and confirm the interval between the two starts renders solid gray instead of animated blue stripes.
  • Confirm normal steps (created → started → completed) still render green, and failed/retried steps are unchanged.

Made with Cursor

…ripes
When a step emits `step_started` twice in a row (a re-start with no
retrying/failed/completed in between), the interval between the two starts
was shown with the animated blue "running" stripes, implying active
progress. Treat that segment as gray ('retrying') instead.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerJune 17, 2026 17:42
@vercel

vercelBot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22db8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mitul-s
mitul-s enabled auto-merge (squash) June 17, 2026 17:42
@mitul-s
mitul-s merged commit 9eb5b9f into mainJun 17, 2026
59 checks passed
@mitul-s
mitul-s deleted the c-ms/90f76653 branch June 17, 2026 18:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 9eb5b9f (AI decision).

The fix is confined to packages/web-shared/src/components/new-trace-viewer/utils.ts, and the entire new-trace-viewer directory (along with the computeStepSegmentsFromSpan function) does not exist on stable — only the older trace-viewer component is present there. Since this main-only component has no counterpart on stable, there is nothing to backport.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

9eb5b9f54d8d87b1866a83a7e9341b8d8b2bb08d

pranaygp added a commit that referenced this pull request Jun 18, 2026
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(web): render restarted step segment as solid gray, not running stripes by mitul-s · Pull Request #2480 · vercel/workflow · GitHub
Skip to content

fix(web): render restarted step segment as solid gray, not running stripes - #2480

Merged
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653
Jun 17, 2026
Merged

fix(web): render restarted step segment as solid gray, not running stripes#2480
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

In the trace timeline (new-trace-viewer), each step bar is split into status segments. The animated blue diagonal "running" stripes are only drawn for segments whose status is running (or received).

When a step emits step_started twice in a row — a re-start with no step_retrying/step_failed/step_completed in between — the interval between the two starts fell into the else branch and was labeled running, so it rendered as the animated blue stripes. That implied active progress for what is really a superseded/abandoned attempt.

This changes that single case to retrying, which renders as a solid gray segment (no stripes). The other next-mark types are unaffected (step_retrying/step_failedfailed, step_completedsucceeded), so this only touches the started-twice case.

Test plan

  • Open a run whose step was started, then started again (with no retry/fail/complete in between) and confirm the interval between the two starts renders solid gray instead of animated blue stripes.
  • Confirm normal steps (created → started → completed) still render green, and failed/retried steps are unchanged.

Made with Cursor

…ripes
When a step emits `step_started` twice in a row (a re-start with no
retrying/failed/completed in between), the interval between the two starts
was shown with the animated blue "running" stripes, implying active
progress. Treat that segment as gray ('retrying') instead.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerJune 17, 2026 17:42
@vercel

vercelBot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22db8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mitul-s
mitul-s enabled auto-merge (squash) June 17, 2026 17:42
@mitul-s
mitul-s merged commit 9eb5b9f into mainJun 17, 2026
59 checks passed
@mitul-s
mitul-s deleted the c-ms/90f76653 branch June 17, 2026 18:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 9eb5b9f (AI decision).

The fix is confined to packages/web-shared/src/components/new-trace-viewer/utils.ts, and the entire new-trace-viewer directory (along with the computeStepSegmentsFromSpan function) does not exist on stable — only the older trace-viewer component is present there. Since this main-only component has no counterpart on stable, there is nothing to backport.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

9eb5b9f54d8d87b1866a83a7e9341b8d8b2bb08d

pranaygp added a commit that referenced this pull request Jun 18, 2026
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(web): render restarted step segment as solid gray, not running stripes by mitul-s · Pull Request #2480 · vercel/workflow · GitHub
Skip to content

fix(web): render restarted step segment as solid gray, not running stripes - #2480

Merged
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653
Jun 17, 2026
Merged

fix(web): render restarted step segment as solid gray, not running stripes#2480
mitul-s merged 1 commit into
mainfrom
c-ms/90f76653

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

In the trace timeline (new-trace-viewer), each step bar is split into status segments. The animated blue diagonal "running" stripes are only drawn for segments whose status is running (or received).

When a step emits step_started twice in a row — a re-start with no step_retrying/step_failed/step_completed in between — the interval between the two starts fell into the else branch and was labeled running, so it rendered as the animated blue stripes. That implied active progress for what is really a superseded/abandoned attempt.

This changes that single case to retrying, which renders as a solid gray segment (no stripes). The other next-mark types are unaffected (step_retrying/step_failedfailed, step_completedsucceeded), so this only touches the started-twice case.

Test plan

  • Open a run whose step was started, then started again (with no retry/fail/complete in between) and confirm the interval between the two starts renders solid gray instead of animated blue stripes.
  • Confirm normal steps (created → started → completed) still render green, and failed/retried steps are unchanged.

Made with Cursor

…ripes
When a step emits `step_started` twice in a row (a re-start with no
retrying/failed/completed in between), the interval between the two starts
was shown with the animated blue "running" stripes, implying active
progress. Treat that segment as gray ('retrying') instead.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerJune 17, 2026 17:42
@vercel

vercelBot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22db8d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mitul-s
mitul-s enabled auto-merge (squash) June 17, 2026 17:42
@mitul-s
mitul-s merged commit 9eb5b9f into mainJun 17, 2026
59 checks passed
@mitul-s
mitul-s deleted the c-ms/90f76653 branch June 17, 2026 18:02
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 9eb5b9f (AI decision).

The fix is confined to packages/web-shared/src/components/new-trace-viewer/utils.ts, and the entire new-trace-viewer directory (along with the computeStepSegmentsFromSpan function) does not exist on stable — only the older trace-viewer component is present there. Since this main-only component has no counterpart on stable, there is nothing to backport.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

9eb5b9f54d8d87b1866a83a7e9341b8d8b2bb08d

pranaygp added a commit that referenced this pull request Jun 18, 2026
…-hydration
* origin/main:
perf(core): lazy inline step start (save one world round-trip per step) (#2478)
perf(core): skip per-step events.list via inline event-log delta (#2475)
Version Packages (beta) (#2491)
[world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486)
Version Packages (beta) (#2451)
Fix Next workflow module specifier root (#2455)
[world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415)
[swc-plugin] Fix eager discovery for object property steps (#2484)
fix(web-shared): align attributes panel styling (#2483)
[web-shared] Auto-scroll trace viewer on J/K span navigation (#2366)
fix(web): render restarted step segment as solid gray, not running stripes (#2480)
fix(web-shared): use solid gray for queued trace segment (#2474)
Add trace viewer span markers for hooks and attributes (#2452)
test: support Vercel protection bypass secret in e2e headers (#2458)
fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts:
#	packages/core/src/runtime.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mitul-s@karthikscale3