Uh oh!
There was an error while loading. Please reload this page.
[swc-plugin] Fix eager discovery for object property steps - #2484
Merged
karthikscale3 merged 2 commits intoJun 17, 2026
Conversation
🦋 Changeset detectedLatest commit: 8777bd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
karthikscale3
marked this pull request as ready for review
June 17, 2026 19:04
ijjk
approved these changes
Jun 17, 2026
Contributor
Backport to To resolve manually, push a backport branch and open a PR against git fetch origin stable
git checkout -b backport/pr-2484-to-stable origin/stable
git cherry-pick -S da373493d211c09056f745332b18f55ef801da2b # -S signs the commit# Fix conflicts, then:
git add -A
git cherry-pick --continue
git push -u origin backport/pr-2484-to-stable
gh pr create --base stable --head backport/pr-2484-to-stable \
--title "Backport #2484: <original PR title>" \
--body "Manual backport of #2484 (cherry-pick da373493d211) to \`stable\`." |
This was referenced Jun 17, 2026
pranaygp added a commit
that referenced
this pull request
Jun 18, 2026
…-hydration * origin/main: perf(core): lazy inline step start (save one world round-trip per step) (#2478) perf(core): skip per-step events.list via inline event-log delta (#2475) Version Packages (beta) (#2491) [world-vercel] Honor hasMore flag from v4 list pagination endpoint (#2486) Version Packages (beta) (#2451) Fix Next workflow module specifier root (#2455) [world-vercel] Send remoteRefBehavior=lazy on v4 metadata-only event listings (#2415) [swc-plugin] Fix eager discovery for object property steps (#2484) fix(web-shared): align attributes panel styling (#2483) [web-shared] Auto-scroll trace viewer on J/K span navigation (#2366) fix(web): render restarted step segment as solid gray, not running stripes (#2480) fix(web-shared): use solid gray for queued trace segment (#2474) Add trace viewer span markers for hooks and attributes (#2452) test: support Vercel protection bypass secret in e2e headers (#2458) fix(core): bump payload-compression cutoff to 5.0.0-beta.18 (#2470) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> # Conflicts: # packages/core/src/runtime.ts
Contributor
Backport to To resolve manually, push a backport branch and open a PR against git fetch origin stable
git checkout -b backport/pr-2484-to-stable origin/stable
git cherry-pick -S da373493d211c09056f745332b18f55ef801da2b # -S signs the commit# Fix conflicts, then:
git add -A
git cherry-pick --continue
git push -u origin backport/pr-2484-to-stable
gh pr create --base stable --head backport/pr-2484-to-stable \
--title "Backport #2484: <original PR title>" \
--body "Manual backport of #2484 (cherry-pick da373493d211) to \`stable\`." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Eager discovery relies on SWC detect mode to decide which files belong in the step registration bundle. Object-property handlers like
tool({ execute: async () => { 'use step' } })were supported by step/workflow transforms, but detect mode emitted no step manifest entry, so eager builds skipped those files.Validation
cargo test -p swc_workflow