Uh oh!
There was an error while loading. Please reload this page.
CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin… - #540
CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin…#540likitha wants to merge 1 commit into
Conversation
…d partial unusable disks and VM snapshots in secondary storage. Enhance storage garbage collector to delete corresponding partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot.
asfbot
commented
Jun 30, 2015
cloudstack-pull-requests #673 SUCCESS |
wilderrodrigues
commented
Jul 16, 2015
LGTM 👍 |
There was a problem hiding this comment.
Is this really only true for vmware? It seems that adding a uuid to the path is a rather universal action in the ssvm, no?
There was a problem hiding this comment.
It seems like it should be applied to any hypervisor.
Is that another one we can take in and fix?
DaanHoogland
commented
Jul 16, 2015
This seems to me to be a solution for vmware for a more generic problem. in the generic code conditions for hypervisortype == vmware are set while the problem is generic over hypervisor typos. |
There was a problem hiding this comment.
I would also call concat twice: 1 for the "/"; and the 2nd time for the UUID.randomUUID().toString().
There was a problem hiding this comment.
auto spell typo? contact == concat
remibergsma
commented
Aug 8, 2015
@likitha Any updates? |
remibergsma
commented
Aug 9, 2015
Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-). |
This closesapache#577 This closesapache#566 This closesapache#562 This closesapache#561 This closesapache#556 This closesapache#555 This closesapache#554 This closesapache#548 This closesapache#544 This closesapache#540 This closesapache#508 This closesapache#384 This closesapache#372
This closesapache#577 This closesapache#566 This closesapache#562 This closesapache#561 This closesapache#556 This closesapache#555 This closesapache#554 This closesapache#548 This closesapache#544 This closesapache#540 This closesapache#384 This closesapache#372
This closesapache#577 This closesapache#566 This closesapache#562 This closesapache#561 This closesapache#556 This closesapache#555 This closesapache#554 This closesapache#548 This closesapache#544 This closesapache#540 This closesapache#384 This closesapache#372
yadvr
commented
May 2, 2016
tag:vmware-pickup |
jburwell
commented
Aug 4, 2016
@likitha is this PR still pertinent? |
yadvr
commented
Aug 5, 2016
@jburwell Likitha has moved on, unlikely we'll hear from her or see further development activity |
DaanHoogland
commented
Apr 17, 2017
This is open to long with no progress |
yadvr
commented
Apr 19, 2017
@DaanHoogland while this is open with no progress, can you check if the issue has been fixed or there exists a PR that works towards fixing the same. Let's not close old PRs that might still be useful. |
sureshanaparti
commented
May 9, 2017
Continued with the code changes here in a new PR #2090. |
…sl certs (#540) Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Fixesapache#540 Using a simple hyphen as a delimiter for config cache key can lead to ambiguity if the “name” field itself contains hyphens. To address this, a Ternary object of configkey name, scope and scope ID is used as the config cache keys. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
…d partial unusable disks and VM snapshots in secondary storage.
Enhance storage garbage collector to delete corresponding partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot.