Uh oh!
There was an error while loading. Please reload this page.
CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 … - #554
Closed
likitha wants to merge 1 commit into
Closed
CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 …#554likitha wants to merge 1 commit into
likitha wants to merge 1 commit into
Conversation
…instance. During disk attach, while trying to obtain the controller key for SCSI controller, look for device with the generic SCSI controller type i.e. VirtualSCSIController.
sateesh-chodapuneedi
commented
Jul 17, 2015
Member
LGTM. |
sureshanaparti
commented
Jul 24, 2015
Contributor
Looks good to me. |
sateesh-chodapuneedi
commented
Jul 24, 2015
Member
Looks like all checks are good and there are 2 LGTM too. |
DaanHoogland
commented
Jul 25, 2015
Contributor
please add (unit) tests |
wilderrodrigues
commented
Jul 27, 2015
Contributor
+1 for @DaanHoogland's comments: please add unit tests to cover the changes. |
remibergsma
commented
Aug 9, 2015
Contributor
Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-). |
remibergsma added a commit
to remibergsma/cloudstack
that referenced
this pull request
Aug 17, 2015
This closesapache#577 This closesapache#566 This closesapache#562 This closesapache#561 This closesapache#556 This closesapache#555 This closesapache#554 This closesapache#548 This closesapache#544 This closesapache#540 This closesapache#508 This closesapache#384 This closesapache#372
remibergsma added a commit
to remibergsma/cloudstack
that referenced
this pull request
Aug 17, 2015
This closesapache#577 This closesapache#566 This closesapache#562 This closesapache#561 This closesapache#556 This closesapache#555 This closesapache#554 This closesapache#548 This closesapache#544 This closesapache#540 This closesapache#384 This closesapache#372
remibergsma added a commit
to remibergsma/cloudstack
that referenced
this pull request
Aug 17, 2015
This closesapache#577 This closesapache#566 This closesapache#562 This closesapache#561 This closesapache#556 This closesapache#555 This closesapache#554 This closesapache#548 This closesapache#544 This closesapache#540 This closesapache#384 This closesapache#372
yadvr
commented
Aug 26, 2015
Member
LGTM, merging. Someone needs to add the unit test, later. I'm trying to build my skills around vmware related codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…instance.
During disk attach, while trying to obtain the controller key for SCSI controller, look for device with the generic SCSI controller type i.e. VirtualSCSIController.
While trying to obtain the SCSI id to attach a disk to, CS should ignore the reserved SCSI id 7. But this is not being honored in case of VMs with SCSI controller of type 'VirtualLsiLogicSASController'. And so in case of Windows 2012 R2 VMs, CS chooses to attach the 7th disk on the reserved SCSI id and this fails on vCenter.