Cloudstack 8612

[likitha]

To ensure that setting a high timeout value for snapshot backup operation will not affect vCenter connections made for any other operations besides volume snapshot, split the existing vCenter session timeout configuration into two configurations,

1. To tune timeout value for CS's session vCenter during snapshot backup operation - 'vmware.snapshot.backup.session.timeout' (new; default: 20 minutes)
2. For all other operations - 'vmware.vcenter.session.timeout' (existing; default: 20 minutes)

Additional change -
Users could potentially run into a timeout issue while trying to snapshot large VMs. There is a timeout for async-jobs that ensures that any job that has been in process for too long is cancelled by CS MS. This timeout is configurable using a global configuration ‘job.cancel.threshold.minutes’ and it defaults to 1 hour.
Now for large volumes even though users configure other snapshot timeout values (‘vmware.snapshot.backup.session.timeout’ and ‘backup.snapshot.wait‘) to a very high value, the snapshot operation will still fail because the job will be cancelled in 1 hour.
Hence proposing a configuration that will allow admins to separate out the job cancellation timeout for ‘volume snapshot’ jobs from other vm work jobs - 'volume.snapshot.job.cancel.threshold'.

[asfbot]

cloudstack-pull-requests #690 SUCCESS
This pull request looks good

[DaanHoogland]

please use try-with-resource

[DaanHoogland]

Can you add unit- and/or integration tests?

[remibergsma]

Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-).

[yadvr]

tag:vmware-pickup

[bvbharatk]

ACS CI BVT Run

Sumarry:
Build Number 136
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

[sureshanaparti]

Continuing with the code changes here in a new PR #2099.

[DaanHoogland]

closing as @sureshanaparti handles this in #2099